Re: [ovs-dev] [PATCH v6 09/15] netdev-offload-tc: Conntrack ALGs are not supported with tc.

2023-01-23 Thread Roi Dayan via dev
On 13/12/2022 17:35, Eelco Chaudron wrote: > tc does not support conntrack ALGs. Even worse, with tc enabled, they > should not be used/configured at all. This is because even though TC > will ignore the rules with ALG configured, i.e., they will flow through > the kernel module, return traffic

Re: [ovs-dev] [PATCH v2 ovn] Add IPv6 support for lb health-check

2023-01-23 Thread Mark Michelson
Thanks for adding this Lorenzo, Acked-by: Mark Michelson On 12/16/22 12:05, Lorenzo Bianconi wrote: Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health check support. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094 Signed-off-by: Lorenzo Bianconi ---

Re: [ovs-dev] [PATCH] netdev-dpdk: config tx queue number to be the minimum between device and ovs request

2023-01-23 Thread Ilya Maximets
On 1/22/23 19:34, clevia...@marvell.com wrote: > From: Chava Leviatan Hi. Thanks for the patch. See some comments below. > > Tx queue are set each time port is added/removed or the cmask changes by > reconfigure_datapath. The amount of TX queues is set according to PMD > thread and does not

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Set PMD load based sleep start/inc to 1 us.

2023-01-23 Thread Ilya Maximets
On 1/23/23 08:59, David Marchand wrote: > On Wed, Jan 18, 2023 at 5:24 PM Kevin Traynor wrote: >> >> Now that the timer slack for the PMD threads is reduced we can also >> reduce the start/increment for PMD load based sleeping to match it. >> >> This will further reduce initial sleep times making

[ovs-dev] [PATCH] netdev-dpdk: config tx queue number to be the minimum between device and ovs request

2023-01-23 Thread cleviatan
From: Chava Leviatan Tx queue are set each time port is added/removed or the cmask changes by reconfigure_datapath. The amount of TX queues is set according to PMD thread and does not take into consideration the device capabilities . As a result , when transmitting packet from OVS to device

Re: [ovs-dev] [PATCH ovn 2/2] Add fake multinode system tests.

2023-01-23 Thread Ales Musil
Hi Numan, On Thu, Dec 1, 2022 at 8:13 PM wrote: > From: Numan Siddique > > This patch adds a simple system test using ovn-fake-multinode > setup. The tests can be run as - 'make check-multinode' > > Before running these tests, user should deploy fake_multinode setup > by running

Re: [ovs-dev] [PATCH ovn] ovn-trace: Use the original ovnact for execute_load

2023-01-23 Thread Mark Michelson
Thanks Ales and Dumitru, I merged this to main and all branches back to 21.12. On 1/17/23 11:10, Dumitru Ceara wrote: On 12/15/22 10:13, Ales Musil wrote: Compiling with GCC and -fsanitize=undefined throws a warning [0]. To avoid that, use the original ovnact pointer with the inner size

Re: [ovs-dev] [PATCH ovn 1/2] CI: Add a couple of jobs using ovn-fake-multinode.

2023-01-23 Thread Ales Musil
Hi Numan, On Thu, Dec 1, 2022 at 8:26 PM wrote: > From: Numan Siddique > > This patch adds a couple of jobs using ovn-fake-multinode. > It first builds 2 ovn-fake-multinode container images > - one with OVN 22.03 > - one with present main. > > The first job deploys ovn-fake-multinode with

Re: [ovs-dev] [PATCH ovn 1/2] CI: Add a couple of jobs using ovn-fake-multinode.

2023-01-23 Thread Dumitru Ceara
On 12/1/22 20:24, num...@ovn.org wrote: > From: Numan Siddique > > This patch adds a couple of jobs using ovn-fake-multinode. > It first builds 2 ovn-fake-multinode container images > - one with OVN 22.03 > - one with present main. > > The first job deploys ovn-fake-multinode with the main

Re: [ovs-dev] [PATCH] [ovs-dev v5] dpctl: Add support to count upcall packets

2023-01-23 Thread Eelco Chaudron
On 19 Jan 2023, at 2:31, wangchuanlei wrote: > Add support to count upall packets, when kmod of openvswitch upcall to > count the number of packets for upcall succeed and failed, which is a > better way to see how many packets upcalled on every interfaces. > > Signed-off-by: wangchuanlei >

Re: [ovs-dev] [RFC] mcast-snopping: do not learn from well defined multicast IPv6 groups

2023-01-23 Thread Lorenzo Bianconi
> On Mon, 2023-01-23 at 10:01 +0100, Lorenzo Bianconi wrote: > > Avoid learning Link-Local reserved multicast addresses if advertised in > > a MLD reports since this interferes with Slaac IPv6 address resolution > > implemented in OVN. > > > > Reported-at:

Re: [ovs-dev] [RFC] mcast-snopping: do not learn from well defined multicast IPv6 groups

2023-01-23 Thread Dan Williams
On Mon, 2023-01-23 at 10:01 +0100, Lorenzo Bianconi wrote: > Avoid learning Link-Local reserved multicast addresses if advertised in > a MLD reports since this interferes with Slaac IPv6 address resolution > implemented in OVN. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2154930

Re: [ovs-dev] [PATCH ovn v2 1/2] northd: make traffic routed to vtep lport distributed

2023-01-23 Thread Vladislav Odintsov
Thanks Dumitru! Regards, Vladislav Odintsov > On 23 Jan 2023, at 17:58, Dumitru Ceara wrote: > > On 1/23/23 10:15, Simon Horman wrote: >> On Sat, Jan 21, 2023 at 07:46:07PM +0300, Vladislav Odintsov wrote: >>> There were two issues prior to this patch: >>> 1. It was unable to have connectivity

Re: [ovs-dev] [PATCH ovn v2] doc: Point to the ovn.org LTS release page.

2023-01-23 Thread Dumitru Ceara
On 1/20/23 07:54, Ales Musil wrote: > On Thu, Jan 19, 2023 at 10:35 AM Dumitru Ceara wrote: > >> Like that we have a single place where the current (and previous) LTS >> versions are mentioned. >> >> Signed-off-by: Dumitru Ceara >> --- >> V2: Changed patch to point to ovn.org page as suggested

Re: [ovs-dev] [PATCH ovn v3 0/4] Add support for OVSDB Relay in OVN SB DB

2023-01-23 Thread Vladislav Odintsov
Thanks Dumitru! Regards, Vladislav Odintsov > On 23 Jan 2023, at 17:59, Dumitru Ceara wrote: > > On 1/21/23 15:54, Vladislav Odintsov wrote: >> v2->v3: >> - Address Dumitru's comment regarding wrong %systemd_postun rpm macro >> usage. >> - Rebase on current main branch. >> >> v1->v2: >> -

Re: [ovs-dev] [PATCH ovn branch-21.12 5/5] northd: Add flag for CT related

2023-01-23 Thread Dumitru Ceara
On 1/23/23 10:17, Ales Musil wrote: > On Fri, Jan 20, 2023 at 11:55 AM Ales Musil wrote: > >> >> >> On Thu, Jan 19, 2023 at 8:43 PM Mark Michelson >> wrote: >> >>> Hi Ales, >>> >> >> Hi Mark, >> >>> >>> I haven't done a thorough look at all of your backports yet, but I did >>> just a cursory

Re: [ovs-dev] [PATCH ovn v2] northd: Add logical flows to allow rpl/rel traffic in acl_after_lb stage.

2023-01-23 Thread Dumitru Ceara
On 1/20/23 08:23, Ales Musil wrote: > On Wed, Jan 18, 2023 at 8:32 PM Mark Michelson wrote: > >> Thanks Dumitru, it looks good to me. >> >> Acked-by: Mark Michelson >> >> On 1/18/23 07:48, Dumitru Ceara wrote: >>> Otherwise we cannot correctly implement "allow-related" semantics when >>>

Re: [ovs-dev] [PATCH ovn v3 0/4] Add support for OVSDB Relay in OVN SB DB

2023-01-23 Thread Dumitru Ceara
On 1/21/23 15:54, Vladislav Odintsov wrote: > v2->v3: > - Address Dumitru's comment regarding wrong %systemd_postun rpm macro > usage. > - Rebase on current main branch. > > v1->v2: > - Added post/preun/postun scripts to manage systemd-related logic around > new service unit. > > This patch

Re: [ovs-dev] [PATCH ovn v2 1/2] northd: make traffic routed to vtep lport distributed

2023-01-23 Thread Dumitru Ceara
On 1/23/23 10:15, Simon Horman wrote: > On Sat, Jan 21, 2023 at 07:46:07PM +0300, Vladislav Odintsov wrote: >> There were two issues prior to this patch: >> 1. It was unable to have connectivity to networks over a router in >>physical network connected through VTEP (ramp) gateway. >>

Re: [ovs-dev] [PATCH ovn v5] northd: Refactor build_lrouter_nat_flows_for_lb function

2023-01-23 Thread Dumitru Ceara
On 1/23/23 08:59, Ales Musil wrote: > To make it easier to add flows to this stage, refactor the function. > This also has the benefit that we should see fewer allocations due to > rearranging how we create flows and how we manipulate the match string. > > Signed-off-by: Ales Musil > --- Hi

Re: [ovs-dev] [PATCH] system-traffic.at: Skip the 'ICMP6 Related' test if nc is missing.

2023-01-23 Thread Simon Horman
On Mon, Jan 23, 2023 at 03:29:50PM +0100, David Marchand wrote: > On Mon, Jan 23, 2023 at 3:05 PM Ilya Maximets wrote: > > > > Test fails is 'nc' is not available, it should be skipped instead. > > > > Probably not important, but: > Fixes: b020a416e24c ("System Tests: Enhance NAT tests.") > >

Re: [ovs-dev] [PATCH] system-traffic.at: Skip the 'ICMP6 Related' test if nc is missing.

2023-01-23 Thread David Marchand
On Mon, Jan 23, 2023 at 3:05 PM Ilya Maximets wrote: > > Test fails is 'nc' is not available, it should be skipped instead. > Probably not important, but: Fixes: b020a416e24c ("System Tests: Enhance NAT tests.") > Signed-off-by: Ilya Maximets Reviewed-by: David Marchand Some notes: - in

[ovs-dev] [PATCH] system-traffic.at: Skip the 'ICMP6 Related' test if nc is missing.

2023-01-23 Thread Ilya Maximets
Test fails is 'nc' is not available, it should be skipped instead. Signed-off-by: Ilya Maximets --- tests/system-traffic.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 503455cc6..fa605d16d 100644 --- a/tests/system-traffic.at +++

Re: [ovs-dev] [PATCH] tests/mfex: Silence Blowfish/CAST5 deprecation warnings.

2023-01-23 Thread Eelco Chaudron
On 23 Jan 2023, at 11:57, David Marchand wrote: > From: Robin Jarry > > On Fedora 37 (at least), MFEX unit tests are failing because of > deprecation warnings: > $ python3 tests/mfex_fuzzy.py test_traffic.pcap 2000 > /usr/lib/python3.11/site-packages/scapy/layers/ipsec.py:471: >

Re: [ovs-dev] [PATCH v8] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-23 Thread Simon Horman
On Mon, Jan 23, 2023 at 12:03:29PM +0100, Eelco Chaudron wrote: > This patch adds a Python script that can be used to analyze the > revalidator runs by providing statistics (including some real time > graphs). > > The USDT events can also be captured to a file and used for > later offline

[ovs-dev] [PATCH 3/3] ci: Run DPDK tests in GitHub Actions.

2023-01-23 Thread David Marchand
Let's enhance our coverage in the CI and run DPDK system tests. A few DPDK drivers are enabled in DPDK compilation. Put DPDK build in $PATH for dpdk-testpmd to be available. sudo drops PATH= updates and -E does not seem to preserve this variable. Pass PATH=$PATH when running the tests, as a

[ovs-dev] [PATCH 2/3] system-dpdk: Don't require hugetlbfs.

2023-01-23 Thread David Marchand
dpdk-testpmd does not need hugetlbfs backing as we don't require multiprocess support in OVS unit tests. Plus, there is no need for explicitly reserving more memory than what testpmd would actually need at runtime. Switch to --in-memory, use dynamic allocations and remove the then unneeded check

[ovs-dev] [PATCH 1/3] system-dpdk: Introduce helpers for testpmd.

2023-01-23 Thread David Marchand
Rather than copy/paste everywhere, introduce helpers to control testpmd runs. Rely on --stats-period (which outputs port stats every n seconds) so that testpmd keeps running without expecting any user input. Signed-off-by: David Marchand --- tests/system-dpdk-macros.at | 34

Re: [ovs-dev] [PATCH] tests/mfex: Silence Blowfish/CAST5 deprecation warnings.

2023-01-23 Thread 0-day Robot
Bleep bloop. Greetings David Marchand, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-23 Thread Eelco Chaudron
On 23 Jan 2023, at 11:32, Simon Horman wrote: > On Mon, Jan 23, 2023 at 11:28:45AM +0100, Eelco Chaudron wrote: >> >> >> On 19 Jan 2023, at 11:38, Simon Horman wrote: >> >>> On Tue, Jan 17, 2023 at 10:19:23AM +0100, Eelco Chaudron wrote: This patch adds a Python script that can be used to

[ovs-dev] [PATCH v8] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-23 Thread Eelco Chaudron
This patch adds a Python script that can be used to analyze the revalidator runs by providing statistics (including some real time graphs). The USDT events can also be captured to a file and used for later offline analysis. The following blog explains the Open vSwitch revalidator implementation

[ovs-dev] [PATCH] tests/mfex: Silence Blowfish/CAST5 deprecation warnings.

2023-01-23 Thread David Marchand
From: Robin Jarry On Fedora 37 (at least), MFEX unit tests are failing because of deprecation warnings: $ python3 tests/mfex_fuzzy.py test_traffic.pcap 2000 /usr/lib/python3.11/site-packages/scapy/layers/ipsec.py:471: CryptographyDeprecationWarning: Blowfish has been deprecated

Re: [ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-23 Thread Eelco Chaudron
On 19 Jan 2023, at 11:38, Simon Horman wrote: > On Tue, Jan 17, 2023 at 10:19:23AM +0100, Eelco Chaudron wrote: >> This patch adds a Python script that can be used to analyze the >> revalidator runs by providing statistics (including some real time >> graphs). >> >> The USDT events can also be

Re: [ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

2023-01-23 Thread Simon Horman
On Mon, Jan 23, 2023 at 11:28:45AM +0100, Eelco Chaudron wrote: > > > On 19 Jan 2023, at 11:38, Simon Horman wrote: > > > On Tue, Jan 17, 2023 at 10:19:23AM +0100, Eelco Chaudron wrote: > >> This patch adds a Python script that can be used to analyze the > >> revalidator runs by providing

Re: [ovs-dev] [PATCH 1/1] daemon-unix: Support OVS-DPDK HW offloads for non-root user

2023-01-23 Thread Eelco Chaudron
On 22 Mar 2021, at 15:21, David Marchand wrote: > Hello Gaƫtan, > > On Fri, Mar 19, 2021 at 5:59 PM Gaetan Rivet wrote: >> Our rte_flow implementation uses ICM mappings to program our hardware, >> which requires super privileged access. We are looking into ways to avoid it. > > Ok, thanks for

Re: [ovs-dev] [PATCH ovn branch-21.12 5/5] northd: Add flag for CT related

2023-01-23 Thread Ales Musil
On Fri, Jan 20, 2023 at 11:55 AM Ales Musil wrote: > > > On Thu, Jan 19, 2023 at 8:43 PM Mark Michelson > wrote: > >> Hi Ales, >> > > Hi Mark, > >> >> I haven't done a thorough look at all of your backports yet, but I did >> just a cursory comparison to try to figure out which patches were >>

Re: [ovs-dev] [RFC] mcast-snopping: do not learn from well defined multicast IPv6 groups

2023-01-23 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 86 characters long (recommended limit is 79) #152 FILE:

Re: [ovs-dev] [PATCH ovn v2 1/2] northd: make traffic routed to vtep lport distributed

2023-01-23 Thread Simon Horman
On Sat, Jan 21, 2023 at 07:46:07PM +0300, Vladislav Odintsov wrote: > There were two issues prior to this patch: > 1. It was unable to have connectivity to networks over a router in >physical network connected through VTEP (ramp) gateway. >Consider next topology: > > ovn-nbctl lr-add

Re: [ovs-dev] [PATCH ovn 1/2] northd: make traffic routed to vtep lport distributed

2023-01-23 Thread Simon Horman
On Sat, Jan 21, 2023 at 07:49:11PM +0300, Vladislav Odintsov wrote: > Please check out the v2: > https://patchwork.ozlabs.org/project/ovn/patch/20230121164609.3625347-1-odiv...@gmail.com/ Thanks, done :) ___ dev mailing list d...@openvswitch.org

[ovs-dev] [RFC] mcast-snopping: do not learn from well defined multicast IPv6 groups

2023-01-23 Thread Lorenzo Bianconi
Avoid learning Link-Local reserved multicast addresses if advertised in a MLD reports since this interferes with Slaac IPv6 address resolution implemented in OVN. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2154930 Tested-by: Eduardo Olivares Signed-off-by: Lorenzo Bianconi ---

[ovs-dev] [PATCH ovn v5] northd: Refactor build_lrouter_nat_flows_for_lb function

2023-01-23 Thread Ales Musil
To make it easier to add flows to this stage, refactor the function. This also has the benefit that we should see fewer allocations due to rearranging how we create flows and how we manipulate the match string. Signed-off-by: Ales Musil --- v5: Rebase on top of current main. Add missing ");"

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Set PMD load based sleep start/inc to 1 us.

2023-01-23 Thread David Marchand
On Wed, Jan 18, 2023 at 5:24 PM Kevin Traynor wrote: > > Now that the timer slack for the PMD threads is reduced we can also > reduce the start/increment for PMD load based sleeping to match it. > > This will further reduce initial sleep times making it more resilient > to interfaces that might