The device may be deleted and added with ifindex changed.
The tc rules on the device will be deleted if the device is deleted.
The func tc_del_filter will fail when flow del. The mapping of
ufid to tc will not be deleted.
The traffic will trigger the same flow(with same ufid) to put to tc
on the ne
>From 113256c92259876ab1ffe71481949b049761c28a Mon Sep 17 00:00:00 2001
From: Faicker Mo
Date: Tue, 31 Jan 2023 12:05:54 +0800
Subject: [PATCH v3] netdev-offload-tc: del ufid mapping if device not exist.
The device may be deleted and added with ifindex changed.
The tc rules on the device will be
>From b8ec4ac672e7ef3370d52bae66db7eef7b8d9da6 Mon Sep 17 00:00:00 2001
From: Faicker Mo
Date: Thu, 12 Jan 2023 11:55:37 +0800
Subject: [PATCH v2] netdev-offload-tc: del ufid mapping if device not exist.
The device may be deleted and added with ifindex changed.
The tc rules on the device will be
Hi everyone,
This coming Friday, 3 February 2023, is the soft freeze date for OVN
23.03.0. As a reminder, this is the date where any new features to be
considered for inclusion in 23.03.0 need to be submitted to the mailing
list. Two weeks later on 17 February we will create branch-23.03 and
On Mon, Jan 30, 2023 at 05:51:57PM +0100, Ilya Maximets wrote:
> On 1/30/23 16:13, Cheng Li wrote:
> > On Mon, Jan 30, 2023 at 01:38:45PM +0100, Ilya Maximets wrote:
> >> On 1/29/23 02:33, Cheng Li wrote:
> >>> On Fri, Jan 27, 2023 at 04:04:55PM +0100, Ilya Maximets wrote:
> On 1/24/23 16:52,
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v2:
- Fixed compi
UB Sanitizer report:
lib/dp-packet.h:587:22: runtime error: member access within misaligned
address 0x01ecde10 for type 'struct dp_packet', which requires 64
byte alignment
#0 in dp_packet_set_base lib/dp-packet.h:587
#1 in dp_packet_use__ lib/dp-packet.c:46
#2 in dp_packet_use lib
UB Sanitizer report:
lib/netdev-dummy.c:197:15: runtime error: member access within
misaligned address 0x0217a7f0 for type 'struct
dummy_packet_stream', which requires 64 byte alignment
^
#0 dummy_packet_stream_init lib/netdev-dummy.c:197
#1 dummy_packet_stream_create lib
On 1/29/23 09:18, Roi Dayan wrote:
>
>
> On 27/01/2023 13:16, Eelco Chaudron wrote:
>> A long long time ago, an effort was made to make tc flower
>> rtnl_lock() free. However, on the OVS part we forgot to add
>> the TCA_KIND "flower" attribute, which tell the kernel to skip
>> the lock. This patc
UB Sanitizer report:
lib/dp-packet.h:587:22: runtime error: member access within misaligned
address 0x01ecde10 for type 'struct dp_packet', which requires 64
byte alignment
#0 in dp_packet_set_base lib/dp-packet.h:587
#1 in dp_packet_use__ lib/dp-packet.c:46
#2 in dp_packet_use lib
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v2:
- Fixed compi
UB Sanitizer report:
lib/netdev-dummy.c:197:15: runtime error: member access within
misaligned address 0x0217a7f0 for type 'struct
dummy_packet_stream', which requires 64 byte alignment
^
#0 dummy_packet_stream_init lib/netdev-dummy.c:197
#1 dummy_packet_stream_create lib
On Mon, Jan 30, 2023 at 2:03 PM Ilya Maximets wrote:
>
> On 1/30/23 17:03, Mike Pattrick wrote:
> > UB Sanitizer report:
> >
> > lib/netdev-dummy.c:197:15: runtime error: member access within
> > misaligned address 0x0217a7f0 for type 'struct
> > dummy_packet_stream', which requires 64 byte al
On 1/30/23 17:03, Mike Pattrick wrote:
> UB Sanitizer report:
>
> lib/netdev-dummy.c:197:15: runtime error: member access within
> misaligned address 0x0217a7f0 for type 'struct
> dummy_packet_stream', which requires 64 byte alignment
> ^
> #0 dummy_packet_stream_init lib/net
References: <20230130164256.764534-4-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
References: <20230130164256.764534-3-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
References: <20230130164256.764534-2-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-of
On 1/30/23 16:13, Cheng Li wrote:
> On Mon, Jan 30, 2023 at 01:38:45PM +0100, Ilya Maximets wrote:
>> On 1/29/23 02:33, Cheng Li wrote:
>>> On Fri, Jan 27, 2023 at 04:04:55PM +0100, Ilya Maximets wrote:
On 1/24/23 16:52, Kevin Traynor wrote:
> On 08/01/2023 03:55, Cheng Li wrote:
>> In
From: Tianyu Yuan
Add helper function to add id_node in hmap directly and
expose this function for external use.
Signed-off-by: Tianyu Yuan
Signed-off-by: Simon Horman
---
lib/id-pool.c | 12 ++--
lib/id-pool.h | 1 +
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/li
From: Tianyu Yuan
Allow revalidator to continuously delete police in kernel
tc datapath until it is deleted.
In current implementation, polices in tc datapath will not
deleted when they are being used and these remaining polices
will be cleared when the openvswitch restarts.
This patch supports
From: Tianyu Yuan
Expose id_node structure for external use. F.e., the
hash_node could be directly accessed by this structure.
Signed-off-by: Tianyu Yuan
Signed-off-by: Simon Horman
---
lib/id-pool.c | 7 ---
lib/id-pool.h | 7 +++
2 files changed, 7 insertions(+), 7 deletions(-)
dif
This series provides a mechanism to allow the revalidator to retry
deletion of tc police action instances. Without such a technique
action instances created independent of flows, for metering, may be left
dangling if deletion fails when they are still used by flows.
Change since v2:
* Only apply m
On 26 Jan 2023, at 22:29, Ilya Maximets wrote:
> On 1/24/23 13:56, Eelco Chaudron wrote:
>> The revalidator/purge commands in the system test cases sometimes
>> get called immediately after a partial test is completed. This
>> could cause the revalidator thread to log an error that it can
>> not
On 26 Jan 2023, at 21:50, Ilya Maximets wrote:
> On 1/24/23 13:57, Eelco Chaudron wrote:
>> Flush datapath flows as TC flows take some more time to be flushed out.
>> The flush speeds this up.
>>
>> Signed-off-by: Eelco Chaudron
>> Acked-by: Roi Dayan
>> ---
>> tests/system-offloads.at |
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v2:
- Fixed compi
UB Sanitizer report:
lib/dp-packet.h:587:22: runtime error: member access within misaligned
address 0x01ecde10 for type 'struct dp_packet', which requires 64
byte alignment
#0 in dp_packet_set_base lib/dp-packet.h:587
#1 in dp_packet_use__ lib/dp-packet.c:46
#2 in dp_packet_use lib
On 26 Jan 2023, at 21:47, Ilya Maximets wrote:
> On 1/24/23 13:57, Eelco Chaudron wrote:
>> This change fixes the "conntrack - floating" test for the TC
>> offload case. In this scenario, the connection might move to
>> CLOSE_WAIT, which would fail the test as it only accepts
>> TIME_WAIT. Howe
Corey Anderson +1(660)522-0283
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Corey Anderson +1(660)522-0283
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
I never authorized this use of my personal account and it was done without my
knowledge this whole time going back to 2009 in August. Please stop processing
my personal data at once and return my data in your system. Please report this
information to law enforcement agencies including the United
UB Sanitizer report:
lib/netdev-dummy.c:197:15: runtime error: member access within
misaligned address 0x0217a7f0 for type 'struct
dummy_packet_stream', which requires 64 byte alignment
^
#0 dummy_packet_stream_init lib/netdev-dummy.c:197
#1 dummy_packet_stream_create lib
On 26 Jan 2023, at 21:42, Ilya Maximets wrote:
> On 1/24/23 13:56, Eelco Chaudron wrote:
>> This patch adds a delay before dumping the conntrack table because with
>> tc it takes a bit longer before it gets synced.
>>
>> Signed-off-by: Eelco Chaudron
>> Acked-by: Roi Dayan
>> ---
>> tests/sy
On 26 Jan 2023, at 21:40, Ilya Maximets wrote:
> On 1/24/23 13:56, Eelco Chaudron wrote:
>> tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced
>> commit was requested. This patch will fix this.
>>
>> Signed-off-by: Eelco Chaudron
>> Acked-by: Roi Dayan
>> ---
>
> Should this h
On 26 Jan 2023, at 21:15, Ilya Maximets wrote:
> On 1/24/23 13:47, Eelco Chaudron wrote:
>> TC flower does not allow the push of the implicit null labels (RFC3032).
>> Avoid the use of such labels in the MPLS test cases.
>
> Do they cause test failures or OVS just falls back to the kernel datap
On 26 Jan 2023, at 21:10, Ilya Maximets wrote:
> On 1/24/23 13:45, Eelco Chaudron wrote:
>> Include and run the system-traffic.at tests as part of the system offload
>> testsuite. Exclude all the tests that will not run without any special
>> modifications.
>>
>> Signed-off-by: Eelco Chaudron
On Mon, Jan 30, 2023 at 01:38:45PM +0100, Ilya Maximets wrote:
> On 1/29/23 02:33, Cheng Li wrote:
> > On Fri, Jan 27, 2023 at 04:04:55PM +0100, Ilya Maximets wrote:
> >> On 1/24/23 16:52, Kevin Traynor wrote:
> >>> On 08/01/2023 03:55, Cheng Li wrote:
> In my test, if one logical core is pinn
On Fri, Jan 27, 2023 at 06:05:57PM +0100, Ilya Maximets wrote:
> On 1/27/23 14:34, Simon Horman wrote:
> > This series addresses an unnecessary and missing dependency on 'nc' in
> > system tests.
> >
> > Patch 1/2: Remove unnecessary dependency on nc
> > Patch 2/2: Add necessary dependency on nc
>
On Fri, Jan 27, 2023 at 2:34 PM Simon Horman wrote:
>
> The following tests use the nc command and should be skipped if
> nc is not present.
>
> - "offloads - check interface meter offloading - offloads disabled"
> - "offloads - check interface meter offloading - offloads enabled"
>
> Fixes: 566
On Fri, Jan 27, 2023 at 2:34 PM Simon Horman wrote:
>
> The conntrack - ICMP related to original direction" test does not
> use nc and therefore does not need to be skipped if nc is not present.
>
> Fixes: d0e4206230b3 ("tests: ICMP related to original direction test.")
> Reported-by: David Marcha
On Sun, Jan 29, 2023 at 11:34 AM Simon Horman wrote:
> > Probably not important, but:
> > Fixes: b020a416e24c ("System Tests: Enhance NAT tests.")
> > > Signed-off-by: Ilya Maximets
> >
> > Reviewed-by: David Marchand
> > >>>
> > >>> FWIIW,
> > >>>
> > >>> Reviewed-by: Si
On 1/30/23 13:55, Chava Leviatan wrote:
> Inline
>
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, January 30, 2023 2:20 PM
> To: Chava Leviatan ; d...@openvswitch.org
> Cc: i.maxim...@ovn.org; Liron Himi ; David Marchand
>
> Subject: Re: [EXT] Re: [ovs-dev] [PATCH] netdev-
Inline
-Original Message-
From: Ilya Maximets
Sent: Monday, January 30, 2023 2:20 PM
To: Chava Leviatan ; d...@openvswitch.org
Cc: i.maxim...@ovn.org; Liron Himi ; David Marchand
Subject: Re: [EXT] Re: [ovs-dev] [PATCH] netdev-dpdk: config tx queue number to
be the minimum between de
On 1/30/23 13:55, Chava Leviatan wrote:
> Inline
>
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, January 30, 2023 2:20 PM
> To: Chava Leviatan ; d...@openvswitch.org
> Cc: i.maxim...@ovn.org; Liron Himi ; David Marchand
>
> Subject: Re: [EXT] Re: [ovs-dev] [PATCH] netdev-
On 1/29/23 02:33, Cheng Li wrote:
> On Fri, Jan 27, 2023 at 04:04:55PM +0100, Ilya Maximets wrote:
>> On 1/24/23 16:52, Kevin Traynor wrote:
>>> On 08/01/2023 03:55, Cheng Li wrote:
In my test, if one logical core is pinned to PMD thread while the
other logical(of the same physical core)
On 1/30/23 09:31, Chava Leviatan wrote:
> Hello Ilya,
>
> I apologize for the late reply .
>
> When removed our patch , I was able to re-create the crash .
>
> The scenario that led us for the patch comprises of dynamically setting up
> and down ports on exist bridge ( many repeats of that act
On 30 Jan 2023, at 9:29, Faicker Mo wrote:
> From b8ec4ac672e7ef3370d52bae66db7eef7b8d9da6 Mon Sep 17 00:00:00 2001From:
> Faicker Mo
> Date: Thu, 12 Jan 2023 11:55:37 +0800
> Subject: [PATCH] netdev-offload-tc: del ufid mapping if device not exist.
>
>
> The device may be deleted and added wi
Hello Ilya,
I apologize for the late reply .
When removed our patch , I was able to re-create the crash .
The scenario that led us for the patch comprises of dynamically setting up and
down ports on exist bridge ( many repeats of that action )
The device that is added and removed , vf_rep1 ,
>From b8ec4ac672e7ef3370d52bae66db7eef7b8d9da6 Mon Sep 17 00:00:00 2001From:
>Faicker Mo
Date: Thu, 12 Jan 2023 11:55:37 +0800
Subject: [PATCH] netdev-offload-tc: del ufid mapping if device not exist.
The device may be deleted and added with ifindex changed.
The tc rules on the device will be d
48 matches
Mail list logo
