Re: [ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-02-20 Thread 0-day Robot
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #50 FILE: lib/netdev-dpdk.c:1208:

Re: [ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-02-20 Thread 0-day Robot
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #28 FILE: lib/netdev-offload-dpdk.c:743: if

Re: [ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-02-20 Thread 0-day Robot
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #50 FILE: lib/netdev-dpdk.c:1208:

Re: [ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-02-20 Thread 0-day Robot
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #28 FILE: lib/netdev-offload-dpdk.c:743: if

[ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-02-20 Thread Ivan Malov via dev
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 88 +++ lib/netdev-dpdk.h | 4 +-

[ovs-dev] [PATCH v4 0/3] DPDK: align flow offloads with 22.11

2023-02-20 Thread Ivan Malov via dev
Address three problems using three corresponding features in DPDK, which have been around for a year and are now stable: 1) The need to make sure that metadata generated by flow rule execution be delivered from NIC to application; 2) Replacing PORT_ID action with REPRESENTED_PORT; 3) Potentia

[ovs-dev] [PATCH v4 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-02-20 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 40 1 file changed, 40 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index fb0dd43f7..2cebc3cca 100644 --- a/lib/netdev-dpdk.c ++

[ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-02-20 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- lib/netdev-offload-dpdk.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index b3421c099..7

[ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-02-20 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- lib/netdev-offload-dpdk.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index b3421c099..7

[ovs-dev] [PATCH v4 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-02-20 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 40 1 file changed, 40 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index fb0dd43f7..2cebc3cca 100644 --- a/lib/netdev-dpdk.c ++

[ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-02-20 Thread Ivan Malov via dev
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 88 +++ lib/netdev-dpdk.h | 4 +-

[ovs-dev] [PATCH v4 0/3] DPDK: align flow offloads with 22.11

2023-02-20 Thread Ivan Malov via dev
Address three problems using three corresponding features in DPDK, which have been around for a year and are now stable: 1) The need to make sure that metadata generated by flow rule execution be delivered from NIC to application; 2) Replacing PORT_ID action with REPRESENTED_PORT; 3) Potentia

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status

2023-02-20 Thread 0-day Robot
Bleep bloop. Greetings Russell Bryant, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fa

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status

2023-02-20 Thread 0-day Robot
Bleep bloop. Greetings Russell Bryant, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fa

[ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status

2023-02-20 Thread Russell Bryant
From: Russell Bryant I have not been involved in OVN development long enough that I should transition to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 0d19bd622.

[ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status

2023-02-20 Thread Russell Bryant
From: Russell Bryant I have not been involved in OVN development long enough that I should transition to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 0d19bd622.

[ovs-dev] [PATCH] MAINTAINERS: Move myself to emeritus status

2023-02-20 Thread Russell Bryant
I have not been active in OVS development in long enough that I should move to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 1dc406170..5df9aab78 100644 --- a/MAIN

[ovs-dev] [PATCH] MAINTAINERS: Move myself to emeritus status

2023-02-20 Thread Russell Bryant
From: Russell Bryant I have not been active in OVS development in long enough that I should move to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 1dc406170..5df9

Re: [ovs-dev] [PATCH v2] id-pool: Refactor to use a bitmap.

2023-02-20 Thread Ilya Maximets
On 1/31/23 17:21, Mark Michelson wrote: > Using a bitmap makes the id-pool use less memory and be more > cache-friendly. It theoretically should be faster since hashes do not > have to be computed. > > This takes the approach of expanding the bitmap when necessary rather > than allocating the enti

Re: [ovs-dev] [PATCH v3] utilities: add support to set umask in ovs-ctl

2023-02-20 Thread Vladislav Odintsov
Thanks, Ilya! > On 20 Feb 2023, at 22:21, Ilya Maximets wrote: > > On 2/15/23 22:20, Vladislav Odintsov wrote: >> Hi Ilya, >> >> Thats my bad - they were the initial names of options, which I renamed later >> and missed this place before sending a patch. >> I’m absolutely fine with proposed ch

Re: [ovs-dev] [PATCH v3] utilities: add support to set umask in ovs-ctl

2023-02-20 Thread Ilya Maximets
On 2/15/23 22:20, Vladislav Odintsov wrote: > Hi Ilya, > > Thats my bad - they were the initial names of options, which I renamed later > and missed this place before sending a patch. > I’m absolutely fine with proposed change. Please fold it while applying the > patch. Thanks, Vladislav and Ee

Re: [ovs-dev] [PATCH] conntrack:fix conntrack_clean may access the same exp_list each time be called

2023-02-20 Thread Paolo Valerio
Paolo Valerio writes: > Hello Liang, > > Liang Mancang writes: > >> when a exp_list contains more than the clean_end's number of nodes, >> and these nodes will not expire immediately. Then, every times we >> call conntrack_clean, it use the same next_sweep to get exp_list. >> > > Yes, in general

Re: [ovs-dev] [PATCH] conntrack:fix conntrack_clean may access the same exp_list each time be called

2023-02-20 Thread Paolo Valerio
Hello Liang, Liang Mancang writes: > when a exp_list contains more than the clean_end's number of nodes, > and these nodes will not expire immediately. Then, every times we > call conntrack_clean, it use the same next_sweep to get exp_list. > Yes, in general, if the previous count exceeds the c

Re: [ovs-dev] [PATCH v3 2/2] ipfix: make template and stats interval configurable

2023-02-20 Thread Ilya Maximets
On 2/10/23 17:03, Adrián Moreno wrote: > From: Adrian Moreno > > Add options to the IPFIX table configure the interval to send statistics > and template information. > > Signed-off-by: Adrian Moreno > > --- > - v3: >- Removed unit tests which generate errors in Intel CI. Will submit in >

Re: [ovs-dev] [PATCH v3 3/3] route-table: Retrieving the preferred source address from Netlink.

2023-02-20 Thread Simon Horman
On Tue, Feb 14, 2023 at 12:39:06PM +0900, Nobuhiro MIKI wrote: > We can use the "ip route add ... src ..." command to set the preferred > source address for each entry in the kernel FIB. OVS has a mechanism to > cache the FIB, but the preferred source address is ignored and > calculated with its ow

Re: [ovs-dev] [PATCH v3 2/3] ovs-router: Introduce src option in ovs/route/add command.

2023-02-20 Thread Simon Horman
On Tue, Feb 14, 2023 at 12:39:05PM +0900, Nobuhiro MIKI wrote: > When adding a route with ovs/route/add command, the source address > in "ovs_router_entry" structure is always the FIRST address that the > interface has. See "ovs_router_get_netdev_source_address" > function for more information. >

Re: [ovs-dev] [PATCH v3 1/3] netdev-dummy: Support multiple IP addresses

2023-02-20 Thread Simon Horman
On Tue, Feb 14, 2023 at 12:39:04PM +0900, Nobuhiro MIKI wrote: > This is useful in test cases where multiple IPv4/IPv6 addresses > are assigned together. > > Signed-off-by: Nobuhiro MIKI > --- > lib/netdev-dummy.c | 66 +- > 1 file changed, 42 insertio

Re: [ovs-dev] [PATCH v3 2/2] ipfix: make template and stats interval configurable

2023-02-20 Thread Simon Horman
On Fri, Feb 10, 2023 at 05:03:14PM +0100, Adrián Moreno wrote: > From: Adrian Moreno > > Add options to the IPFIX table configure the interval to send statistics > and template information. > > Signed-off-by: Adrian Moreno > > --- > - v3: >- Removed unit tests which generate errors in Inte

Re: [ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-20 Thread Simon Horman
On Fri, Feb 10, 2023 at 05:03:13PM +0100, Adrián Moreno wrote: > From: Adrian Moreno > > IPFIX templates have to be sent for each Observation Domain ID. > Currently, a timer is kept at each dpif_ipfix_exporter to send them. > This works fine for per-bridge sampling where there is only one > Obser

Re: [ovs-dev] [ovs-build] |fail| pw1743629 [ovs-dev, branch-3.1, 1/2] Set release date for 3.1.0.

2023-02-20 Thread Ilya Maximets
On 2/20/23 12:01, Phelan, Michael wrote: > Hi Ilya, > Sorry I was OOO Thursday and Friday of last week so I'm only seeing your mail > now. > > I've updated the CI so it should build with DPDK 22.11 for branch-3.1 from > now on. No problem. Thanks for the update! Best regards, Ilya Maximets.

[ovs-dev] [PATCH ovn] controller: Fix hairpin SNAT flow explosion for the same SNAT IPs case.

2023-02-20 Thread Ilya Maximets
It's common to have 'hairpin_snat_ip' to be configured exactly the same for each and every Load Balancer in a setup. For example, ovn-kubernetes does that, setting '169.254.169.5 fd69::5' value unconditionally for every LB: https://github.com/ovn-org/ovn-kubernetes/blob/cd78ae1af4657d38bdc41003

Re: [ovs-dev] [ovs-build] |fail| pw1743629 [ovs-dev, branch-3.1, 1/2] Set release date for 3.1.0.

2023-02-20 Thread Phelan, Michael
Hi Ilya, Sorry I was OOO Thursday and Friday of last week so I'm only seeing your mail now. I've updated the CI so it should build with DPDK 22.11 for branch-3.1 from now on. Thanks, Michael. > -Original Message- > From: Ilya Maximets > Sent: Thursday 16 February 2023 13:17 > To: ovs_

Re: [ovs-dev] [PATCH net-next v1 1/1] net: openvswitch: ovs_packet_cmd_execute put sw_flow mainbody in stack

2023-02-20 Thread Simon Horman
On Mon, Feb 20, 2023 at 03:11:17PM +0800, Eddy Tao wrote: > Hi, Simon: > > >     About your concern for the stack size, it leads to more room for > improvement. > > I will file a new version which will have smaller stack occupation and > better performance > > > The new revision is invoked by

Re: [ovs-dev] [PATCH v4] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-20 Thread 0-day Robot
Bleep bloop. Greetings Han Ding, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #32 FILE: lib/flow.h:1136: if

[ovs-dev] [PATCH v4] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-20 Thread Han Ding
Function is_gratuitous_arp() and function is_garp() are all used to judge whether the flow is gratuitous arp. It is not necessary to use two functions to do the same thing and just keep one. Gratuitous ARP message is a generally link-level broadcast messages and carry the same IP in sender and t