Re: [ovs-dev] [PATCH v9] netdev-offload-tc: del ufid mapping if device not exist

On Thu, Mar 30, 2023 at 11:13:32AM +0800, Faicker Mo wrote: > Thanks for your testing. > Add the ignore msg "failed to offload flow" to OVS_TRAFFIC_VSWITCHD_STOP can > pass the fail test. > I'll post an update later. Thanks. I'll look out for it. > From: Simon Horman > Date: 2023-03-29 23:22:17

Re: [ovs-dev] [PATCH v9] netdev-offload-tc: del ufid mapping if device not exist

Thanks for your testing. Add the ignore msg "failed to offload flow" to OVS_TRAFFIC_VSWITCHD_STOP can pass the fail test. I'll post an update later. From: Simon Horman Date: 2023-03-29 23:22:17 To: Faicker Mo Cc: d...@openvswitch.org,Eelco Chaudron ,Ilya Maximets Subject: Re: [ovs-dev] [PAT

Re: [ovs-dev] [PATCH] learning-switch: Fix coredump of OpenFlow15 learning-switch

I'll add a test later. You are right. Zeroing out the po can fix the problem. From: Ilya Maximets Date: 2023-03-30 03:36:48 To: Faicker Mo Cc: d...@openvswitch.org,i.maxim...@ovn.org Subject: Re: [ovs-dev] [PATCH] learning-switch: Fix coredump of OpenFlow15 learning-switch>On 3/29/23 08:34

Re: [ovs-dev] [PATCH v12 0/5] userspace: Add SRv6 tunnel support.

On 2023/03/30 6:17, Ilya Maximets wrote: > On 3/29/23 07:51, Nobuhiro MIKI wrote: >> v12: >> * Fix nw_proto after encap. >> * Fix to check nw_proto in system-traffic.at. >> * Remove OVS_UNUSED annotation. >> v11: >> * Fix comments. >> * Clean up conditional statements. >> ("!rt_hdr || rt_hdr->typ

[ovs-dev] [PATCH] util: fix an issue that thread name cannot be set

To: d...@openvswitch.org, i.maxim...@ovn.org The name of the current thread consists of a name with a maximum length of 16 bytes and a thread ID. The final name may be longer than 16 bytes. If the name is longer than 16 bytes, the thread name will fail to be set Signed-off-by: Songtao Zhan

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Fix misaligned 8 byte read.

On 3/29/23 11:16, Eelco Chaudron wrote: > > > On 28 Mar 2023, at 17:21, Mike Pattrick wrote: > >> UB Sanitizer report: >> >> lib/netdev-offload-tc.c:1276:19: runtime error: load of misaligned >> address 0x7f74e801976c for type 'union ovs_u128', which requires 8 byte >> alignment >> >> #0 in

Re: [ovs-dev] [PATCH v2] ovs-dpctl: Add new command dpctl/ct-sweep-next-run.

On 2/27/23 13:30, Paolo Valerio wrote: > Since 3d9c1b855a5f ("conntrack: Replace timeout based expiration lists > with rculists.") the sweep interval changed as well as the constraints > related to the sweeper. > Being able to change the default reschedule time may be convenient in > some condition

Re: [ovs-dev] [RFC ovn 0/3] rework OVN QoS implementation

> Hi Lorenzo et al. Hi Ihar, thx for reviewing the series. > > I took a look at the series and have a number of concerns. Note that I > looked at the series in context of OpenStack and the way Neutron uses > qos_ options. Some points below are not directly relevant to the > series but I think t

Re: [ovs-dev] [PATCH v12 0/5] userspace: Add SRv6 tunnel support.

On 3/29/23 07:51, Nobuhiro MIKI wrote: > v12: > * Fix nw_proto after encap. > * Fix to check nw_proto in system-traffic.at. > * Remove OVS_UNUSED annotation. > v11: > * Fix comments. > * Clean up conditional statements. > ("!rt_hdr || rt_hdr->type != IPV6_SRCRT_TYPE_4"). > * Remove variables from

Re: [ovs-dev] [PATCH v4] db-ctl-base: Partially revert b8bf410a5

Bleep bloop. Greetings Daniel Alvarez Sanchez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: "Fixes" tag is malformed. Use the following format: git log -1 --pretty=form

[ovs-dev] [PATCH v4] db-ctl-base: Partially revert b8bf410a5

From: Daniel Alvarez Sanchez The commit b8bf410a5 [0] broke the `ovs-vsctl add` command which now overwrites the value if it existed already. This patch reverts the code around the `cmd_add` function to restore the previous behavior. It also adds testing coverage for this functionality. [0] ht

Re: [ovs-dev] [PATCH v3] db-ctl-base: Partially revert b8bf410a5

Bleep bloop. Greetings Daniel Alvarez Sanchez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 119 error: could not build fake ancestor hint: Use 'git am -

[ovs-dev] [PATCH v3] db-ctl-base: Partially revert b8bf410a5

The commit b8bf410a5 [0] broke the `ovs-vsctl add` command which now overwrites the value if it existed already. This patch reverts the code around the `cmd_add` function to restore the previous behavior. It also adds testing coverage for this functionality. [0] https://github.com/openvswitch/ovs

Re: [ovs-dev] [PATCH] learning-switch: Fix coredump of OpenFlow15 learning-switch

On 3/29/23 08:34, Faicker Mo wrote: > The OpenFlow15 Packet-Out message contains the whole match instead of the > in_port. > The match has no assignment but used in oxm_put_match. > > The coredump gdb backtrace is: > #0 memcpy_from_metadata (dst=dst@entry=0x7ffcfac2f060, > src=src@entry=0x7ffc

Re: [ovs-dev] [PATCH v2] db-ctl-base: Partially revert b8bf410a5

Bleep bloop. Greetings Daniel Alvarez Sanchez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 118 error: could not build fake ancestor hint: Use 'git am -

[ovs-dev] [PATCH v2] db-ctl-base: Partially revert b8bf410a5

The commit b8bf410a5 [0] broke the `ovs-vsctl add` command which now overwrites the value if it existed already. This patch reverts the code around the `cmd_add` function to restore the previous behavior. It also adds testing coverage for this functionality. [0] https://github.com/openvswitch/ovs

Re: [ovs-dev] [PATCH] db-ctl-base: Partially revert b8bf410a5

On 3/29/23 18:19, Daniel Alvarez Sanchez wrote: > The commit b8bf410a5 [0] broke the `ovs-vsctl add` command > which now overwrites the value if it existed already. > > This patch reverts the code around the `cmd_add` function > to restore the previous behavior. It also adds testing coverage > for

[ovs-dev] [PATCH] db-ctl-base: Partially revert b8bf410a5

The commit b8bf410a5 [0] broke the `ovs-vsctl add` command which now overwrites the value if it existed already. This patch reverts the code around the `cmd_add` function to restore the previous behavior. It also adds testing coverage for this functionality. [0] https://github.com/openvswitch/ovs

Re: [ovs-dev] [PATCH ovn v2 0/3] expr: Optimize OR expressions.

On 3/25/23 23:41, Han Zhou wrote: > > > On Fri, Mar 24, 2023 at 2:57 PM Han Zhou > wrote: >> >> >> >> On Fri, Mar 24, 2023 at 7:22 AM Ilya Maximets > > wrote: >> > >> > On 3/24/23 14:33, Ilya Maximets wrote: >> > > On 3/21/23 13:24, Ilya Maximets

[ovs-dev] [PATCH ovn v3 2/2] expr: Avoid crash if all sub-expressions crushed down to 'true'.

expr_sort() can potentially return NULL if all sub-expressions got crushed into 'true'. This didn't happen before, but can happen with more aggressive optimizations in crush_or() in the future. Signed-off-by: Ilya Maximets --- lib/expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[ovs-dev] [PATCH ovn v3 1/2] expr: Remove supersets from OR expressions.

While crushing OR expressions, OVN removes exact replicas of sub expressions. However, there could be many CMP expressions that are supersets of each other. These are most likely to be created as a result of cross-product while expanding brackets in the AND expression in crush_and_numeric(), i.e.

[ovs-dev] [PATCH ovn v3 0/2] expr: Optimize OR expressions.

This patch set covers removal of expressions which are subsets of other wider expressions and aggregation of a few granular expressions into wider expressions that cover all of them at once. This allows to avoid flow explosion in case of negative matches and reduce the total number of flows requir

Re: [ovs-dev] [PATCH v5] utilities/ofctl: add-meters for save and restore

On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie > > --- > v5: > merge oneline to verbosity h

Re: [ovs-dev] Reliability of system-offload test #50 [Was: Re: [PATCH v3 2/2] ci: Run tc offload tests in GitHub] Actions.

On Tue, Mar 28, 2023 at 01:45:22PM +0200, Eelco Chaudron wrote: > > > On 10 Mar 2023, at 17:20, Simon Horman wrote: > > > On Fri, Mar 10, 2023 at 10:15:44AM +0100, Simon Horman wrote: > >> On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote: > >>> > >>> > >>> On 9 Mar 2023, at 15:42,

Re: [ovs-dev] [PATCH v2] ovs-dpctl: Add new command dpctl/ct-sweep-next-run.

On Mon, Feb 27, 2023 at 01:30:15PM +0100, Paolo Valerio wrote: > Since 3d9c1b855a5f ("conntrack: Replace timeout based expiration lists > with rculists.") the sweep interval changed as well as the constraints > related to the sweeper. > Being able to change the default reschedule time may be conven

Re: [ovs-dev] [PATCH v3] OpenFlow: Add extn to set conntrack entries limit per zone.

On Thu, Mar 16, 2023 at 06:19:44AM +, Naveen Yerramneni wrote: The following text seems to have gone missing since v2: Add OpenFlow extn to set conntrack entries limit per zone. I think it would be nice to expand on why this change is being made. But it is not a hard requirement from me.

Re: [ovs-dev] [PATCH v9] netdev-offload-tc: del ufid mapping if device not exist

On Wed, Mar 15, 2023 at 11:26:55AM +0800, Faicker Mo wrote: > The device may be deleted and added with ifindex changed. > The tc rules on the device will be deleted if the device is deleted. > The func tc_del_filter will fail when flow del. The mapping of > ufid to tc will not be deleted. > The tra

Re: [ovs-dev] [PATCH ovn v6] northd: Make the use of common zone in NAT configurable

On Wed, Mar 29, 2023 at 6:15 AM Dumitru Ceara wrote: > > On 3/29/23 11:20, Ales Musil wrote: > > There are essentially three problems with the current > > combination of DGP + SNAT + LB: > > > > 1) The first packet is being SNATed in common zone due > > to a problem with pinctrl not preserving ct_

Re: [ovs-dev] [PATCH ovn v3 2/2] Add fake multinode system tests.

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #101 FILE: .github/workflows/ov

Re: [ovs-dev] [PATCH ovn v3 1/2] CI: Add a couple of periodic jobs using ovn-fake-multinode.

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 88 characters long (recommended limit is 79) #47 FILE: .github/workflows/ovn

[ovs-dev] [PATCH ovn v3 2/2] Add fake multinode system tests.

From: Numan Siddique This patch adds a simple system test using ovn-fake-multinode setup. The tests can be run as - 'make check-multinode' Before running these tests, user should deploy fake_multinode setup by running 'ovn_cluster.sh start'. This test suite is also triggered for the newly adde

[ovs-dev] [PATCH ovn v3 1/2] CI: Add a couple of periodic jobs using ovn-fake-multinode.

From: Numan Siddique This patch adds a couple of jobs using ovn-fake-multinode. It first builds 2 ovn-fake-multinode container images - one with OVN 22.03 - one with present main. The first job deploys ovn-fake-multinode with the main OVN and runs simple tests provided by ovn-fake-multinode

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

On 3/29/2023 7:49 PM, Eelco Chaudron wrote: On 29 Mar 2023, at 13:41, Chris Mi wrote: On 3/29/2023 6:03 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: On 23 Mar 2023, at 12:24, Chris Mi wrote: I ran it 100 times. All passed. Visually inspecting this, it looks

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

On 29 Mar 2023, at 13:41, Chris Mi wrote: > On 3/29/2023 6:03 PM, Eelco Chaudron wrote: >> >> On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: >> >>> On 23 Mar 2023, at 12:24, Chris Mi wrote: >> >> >> I ran it 100 times. All passed. > Visually inspecting this, it looks fine, however, is

[ovs-dev] [PATCH v26 8/8] system-offloads-traffic.at: Add sFlow offload test cases

Add three sFlow offload test cases: 3: offloads - sflow with sampling=1 - offloads enabled ok 4: offloads - sflow with sampling=2 - offloads enabled ok 5: offloads - ping over vxlan tunnel with sflow - offloads enabled ok Signed-off-by: Chris Mi Reviewed-by: Roi Dayan Acked-by: Eelco Chau

[ovs-dev] [PATCH v26 7/8] netdev-offload-tc: Add offload support for sFlow

Create a unique group ID to map the sFlow info when offloading sample action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/netdev-offload-tc.c | 277 +

[ovs-dev] [PATCH v26 4/8] netdev-offload-tc: Add sample offload API for TC

Initialize psample socket. Add sample recv API to receive sampled packets from psample socket. Add sample recv wait API to add psample socket fd to poll list. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/dpif.h| 6 +- lib/netdev-offload-provider.h | 17 +++ lib/

[ovs-dev] [PATCH v26 6/8] dpif-netlink: Add netdev offload recv in normal recv upcalls

In thread handler 0, add netdev offload recv in normal recv upcalls. To avoid starvation, introduce a flag to alternate the order of receiving normal upcalls and offload upcalls based on that flag. Add similar change for recv_wait. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/dpif-ne

[ovs-dev] [PATCH v26 5/8] netdev-offload: Add netdev offload recv and recv_wait APIs

Iterate each registered offload API. It's not a problem for today since we only have one implementation. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/netdev-offload.c | 35 +++ lib/netdev-offload.h | 5 + 2 files changed, 40 insertions(+) diff --g

[ovs-dev] [PATCH v26 3/8] netdev-offload-tc: Introduce group ID management API

When offloading sample action to TC, userspace creates a unique ID to map sample action and tunnel info and passes this ID to kernel instead of the sample info. Kernel will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sample info and send sampled packet to t

[ovs-dev] [PATCH v26 1/8] compat: Add psample and tc sample action defines for older kernels

Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan Acked-by: Eelco Chaudron --- include/linux/automake.mk| 10 +++--- include/linux/psample.h | 62 include/linux/tc_act/tc_sample.h | 2

[ovs-dev] [PATCH v26 2/8] ovs-kmod-ctl: Load kernel module psample

Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan Acked-by: Eelco Chaudron --- utilities/ovs-kmod-ctl.in | 14 ++ 1 file changed, 14 insertions(+) diff --git

[ovs-dev] [PATCH v26 0/8] Add offload support for sFlow

This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to k

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

On 3/29/2023 6:03 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: On 23 Mar 2023, at 12:24, Chris Mi wrote: I ran it 100 times. All passed. Visually inspecting this, it looks fine, however, is this failing without passing the actions parts? Yes. Only the first

Re: [ovs-dev] [RFC PATCH ovn v2 8/9] ci: Use container to run the tests

On 3/15/23 07:29, Ales Musil wrote: > Move the ci.sh script into .ci folder > and remove the linux-prepare.sh as it > is no longer needed with all the requirements > installed in container. > > Signed-off-by: Ales Musil > --- > {utilities/containers => .ci}/ci.sh | 0 > .ci/linux-prepare.sh

Re: [ovs-dev] [PATCH ovn v2 1/9] ci: Add missing packages to the container

On 3/29/23 12:36, Dumitru Ceara wrote: > On 3/29/23 12:32, Ales Musil wrote: >> On Wed, Mar 29, 2023 at 9:55 AM Dumitru Ceara wrote: >> >>> On 3/29/23 09:43, Dumitru Ceara wrote: On 3/29/23 07:29, Ales Musil wrote: > On Tue, Mar 28, 2023 at 4:48 PM Dumitru Ceara >>> wrote: > >> O

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

On 3/29/23 12:00, Abhiram Sangana wrote: @@ -896,6 +904,26 @@ put_local_common_flows(uint32_t dp_key, pb->header_.uuid.parts[0], &match, ofpacts_p, &pb->header_.uuid); +if (zone_ids->drop) { +/* Table 39, Priority 1.

Re: [ovs-dev] [PATCH ovn v2 1/9] ci: Add missing packages to the container

On 3/29/23 12:32, Ales Musil wrote: > On Wed, Mar 29, 2023 at 9:55 AM Dumitru Ceara wrote: > >> On 3/29/23 09:43, Dumitru Ceara wrote: >>> On 3/29/23 07:29, Ales Musil wrote: On Tue, Mar 28, 2023 at 4:48 PM Dumitru Ceara >> wrote: > On 3/15/23 07:29, Ales Musil wrote: >> Add mi

Re: [ovs-dev] [PATCH ovn v2 1/9] ci: Add missing packages to the container

On Wed, Mar 29, 2023 at 9:55 AM Dumitru Ceara wrote: > On 3/29/23 09:43, Dumitru Ceara wrote: > > On 3/29/23 07:29, Ales Musil wrote: > >> On Tue, Mar 28, 2023 at 4:48 PM Dumitru Ceara > wrote: > >> > >>> On 3/15/23 07:29, Ales Musil wrote: > Add missing jemalloc, kmod and scapy packages. >

Re: [ovs-dev] [PATCH ovn v6] northd: Make the use of common zone in NAT configurable

On 3/29/23 11:20, Ales Musil wrote: > There are essentially three problems with the current > combination of DGP + SNAT + LB: > > 1) The first packet is being SNATed in common zone due > to a problem with pinctrl not preserving ct_mark/ct_label. > The commit would create a SNAT entry within the sa

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: > On 23 Mar 2023, at 12:24, Chris Mi wrote: I ran it 100 times. All passed. >>> Visually inspecting this, it looks fine, however, is this failing without >>> passing the actions parts? >> Yes. Only the first sampled packet has tunnel heade

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

Hi Dumitru, Thanks for reviewing the patch. > On 23 Mar 2023, at 20:59, Dumitru Ceara wrote: > > On 3/17/23 20:34, Numan Siddique wrote: >> On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana >> wrote: >>> >>> This patch adds support to commit connections dropped/rejected by >>> ACLs to the con

Re: [ovs-dev] [PATCH ovn v5] northd: Make the use of common zone in NAT configurable

On Tue, Mar 28, 2023 at 8:36 PM Numan Siddique wrote: > On Tue, Mar 28, 2023 at 1:11 AM Ales Musil wrote: > > > > On Mon, Mar 27, 2023 at 10:01 PM Numan Siddique wrote: > > > > > " > > > > > > On Mon, Mar 27, 2023 at 2:34 AM Ales Musil wrote: > > > > > > > > There are essentially three problem

[ovs-dev] [PATCH ovn v6] northd: Make the use of common zone in NAT configurable

There are essentially three problems with the current combination of DGP + SNAT + LB: 1) The first packet is being SNATed in common zone due to a problem with pinctrl not preserving ct_mark/ct_label. The commit would create a SNAT entry within the same with DNAT entry. 2) The unSNAT for reply alw

Re: [ovs-dev] [PATCH ovn branch-22.12] lb: Allow IPv6 template LBs to use explicit backends.

On Tue, Mar 28, 2023 at 4:31 PM Dumitru Ceara wrote: > This was working fine for IPv4 but partially by accident because IPv4 > addresses don't contain ':'. Fix it for the general case by trying to > parse explicit backends if parsing templates fails. > > Also add unit and system tests for all su

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: Fix misaligned 8 byte read.

On 28 Mar 2023, at 17:21, Mike Pattrick wrote: > UB Sanitizer report: > > lib/netdev-offload-tc.c:1276:19: runtime error: load of misaligned > address 0x7f74e801976c for type 'union ovs_u128', which requires 8 byte > alignment > > #0 in netdev_tc_flow_dump_next lib/netdev-offload-tc.c:1276

Re: [ovs-dev] [RFC PATCH ovn v2 8/9] ci: Use container to run the tests

On 3/29/23 07:32, Ales Musil wrote: > On Tue, Mar 28, 2023 at 5:31 PM Dumitru Ceara wrote: > >> On 3/15/23 07:29, Ales Musil wrote: >>> Move the ci.sh script into .ci folder >>> and remove the linux-prepare.sh as it >>> is no longer needed with all the requirements >>> installed in container. >>

Re: [ovs-dev] [PATCH ovn v2 1/9] ci: Add missing packages to the container

On 3/29/23 09:43, Dumitru Ceara wrote: > On 3/29/23 07:29, Ales Musil wrote: >> On Tue, Mar 28, 2023 at 4:48 PM Dumitru Ceara wrote: >> >>> On 3/15/23 07:29, Ales Musil wrote: Add missing jemalloc, kmod and scapy packages. Install scapy through pip, because the python3-scapy package

Re: [ovs-dev] [PATCH ovn v2 1/9] ci: Add missing packages to the container

On Wed, Mar 29, 2023 at 9:43 AM Dumitru Ceara wrote: > On 3/29/23 07:29, Ales Musil wrote: > > On Tue, Mar 28, 2023 at 4:48 PM Dumitru Ceara wrote: > > > >> On 3/15/23 07:29, Ales Musil wrote: > >>> Add missing jemalloc, kmod and scapy packages. > >>> Install scapy through pip, because the > >>>

Re: [ovs-dev] [PATCH ovn v2 1/9] ci: Add missing packages to the container

On 3/29/23 07:29, Ales Musil wrote: > On Tue, Mar 28, 2023 at 4:48 PM Dumitru Ceara wrote: > >> On 3/15/23 07:29, Ales Musil wrote: >>> Add missing jemalloc, kmod and scapy packages. >>> Install scapy through pip, because the >>> python3-scapy package has a lot of dependencies >>> that would incr

[ovs-dev] [PATCH v25 8/8] system-offloads-traffic.at: Add sFlow offload test cases

Add three sFlow offload test cases: 3: offloads - sflow with sampling=1 - offloads enabled ok 4: offloads - sflow with sampling=2 - offloads enabled ok 5: offloads - ping over vxlan tunnel with sflow - offloads enabled ok Signed-off-by: Chris Mi Reviewed-by: Roi Dayan Acked-by: Eelco Chau

[ovs-dev] [PATCH v25 7/8] netdev-offload-tc: Add offload support for sFlow

Create a unique group ID to map the sFlow info when offloading sample action to TC. When showing the offloaded datapath flows, translate the group ID from TC sample action to sFlow info using the mapping. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/netdev-offload-tc.c | 276 +

[ovs-dev] [PATCH v25 6/8] dpif-netlink: Add netdev offload recv in normal recv upcalls

In thread handler 0, add netdev offload recv in normal recv upcalls. To avoid starvation, introduce a flag to alternate the order of receiving normal upcalls and offload upcalls based on that flag. Add similar change for recv_wait. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/dpif-ne

[ovs-dev] [PATCH v25 4/8] netdev-offload-tc: Add sample offload API for TC

Initialize psample socket. Add sample recv API to receive sampled packets from psample socket. Add sample recv wait API to add psample socket fd to poll list. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/dpif.h| 6 +- lib/netdev-offload-provider.h | 17 +++ lib/

[ovs-dev] [PATCH v25 5/8] netdev-offload: Add netdev offload recv and recv_wait APIs

Iterate each registered offload API. It's not a problem for today since we only have one implementation. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan --- lib/netdev-offload.c | 35 +++ lib/netdev-offload.h | 5 + 2 files changed, 40 insertions(+) diff --g

[ovs-dev] [PATCH v25 3/8] netdev-offload-tc: Introduce group ID management API

When offloading sample action to TC, userspace creates a unique ID to map sample action and tunnel info and passes this ID to kernel instead of the sample info. Kernel will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sample info and send sampled packet to t

[ovs-dev] [PATCH v25 1/8] compat: Add psample and tc sample action defines for older kernels

Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan Acked-by: Eelco Chaudron --- include/linux/automake.mk| 10 +++--- include/linux/psample.h | 62 include/linux/tc_act/tc_sample.h | 2

[ovs-dev] [PATCH v25 2/8] ovs-kmod-ctl: Load kernel module psample

Load kernel module psample to receive sampled packets from TC. Before removing kernel module psample, remove act_sample first. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan Acked-by: Eelco Chaudron --- utilities/ovs-kmod-ctl.in | 14 ++ 1 file changed, 14 insertions(+) diff --git

[ovs-dev] [PATCH v25 0/8] Add offload support for sFlow

This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to k