Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#551 FILE: utilities/ovn-nbctl.c:276:
mirror-add NA
Today the mirror feature in OVN supports only tunnel to a remote
destinations. This patch adds the support for mirroring to a local OVS
port. It is particularly useful for monitoring traffic that is offloaded
thus not possible to be intercepted by regular tools such as tcpdump.
With this feature, t
It is more convenient to support "both" as a keyword to indicate both
directions instead of having to create two mirror objects to mirror both
directions.
Signed-off-by: Han Zhou
---
NEWS | 3 ++-
controller/mirror.c | 14 ++
ovn-nb.ovsschema | 7
On Mon, May 1, 2023 at 9:37 PM Mark Michelson wrote:
> Thanks Xavier.
>
> Acked-by: Mark Michelson
>
> On 4/28/23 08:01, Xavier Simonart wrote:
> > Tests was sometimes failing due to some race conditions using
> > Dummy ARP: the flows in OFTABLE_MAC_LOOKUP (generated by the Dummy ARP)
> > were n
On Mon, May 1, 2023 at 9:35 PM Mark Michelson wrote:
> Wow.
>
> Acked-by: Mark Michelson
>
> On 4/28/23 08:01, Xavier Simonart wrote:
> > This was always failing on some systems (but has no issues on others),
> > depending on which load balancer backend was used.
> >
> > Signed-off-by: Xavier Si
在 2023/5/5 10:55, 汪翰林 写道:
在 2023/5/4 18:14, Ilya Maximets 写道:
On 5/4/23 12:12, Ilya Maximets wrote:
On 4/11/23 11:07, 汪翰林 wrote:
在 2023/4/7 21:20, Simon Horman 写道:
On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote:
When 'cs' is not connected to a server, then
ovsdb_cs_db_compose_l
在 2023/5/4 18:14, Ilya Maximets 写道:
On 5/4/23 12:12, Ilya Maximets wrote:
On 4/11/23 11:07, 汪翰林 wrote:
在 2023/4/7 21:20, Simon Horman 写道:
On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote:
When 'cs' is not connected to a server, then
ovsdb_cs_db_compose_lock_request__ will update
'c
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@ovn.org]
> Sent: Thursday, May 4, 2023 8:32 PM
> To: wangyunjian ; d...@openvswitch.org
> Cc: i.maxim...@ovn.org; luyicai
> Subject: Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix use-after-free when
> xlate_actions().
>
> On
Hi all,
Currently, the OVN project is inconsistent with its policy for creating
minor releases. In many cases, we create a .0 release and then, despite
backporting changes to the branch, never create any follow-up minor
releases.
I propose that we should codify a policy that dictates a speci
Hi all,
A recent thread [1] had several topics of discussion come up about
proposed changes to OVN release management. This thread is specifically
to discuss the support lifetime of OVN releases.
Current documentation discusses two ideas with regards to version
support lifetime
* LTS release
On 5/2/23 17:27, Dumitru Ceara wrote:
> On 4/28/23 16:17, Ilya Maximets wrote:
>> The '-w' command line argument is not passed to test-ovsdb in the
>> OVSDB_CHECK_IDL_WRITE_CHANGED_ONLY_C, so it juts repeats normal
>> tests without testing the feature.
>>
>> Adding the flag. And using the long ver
There is no need to display 'requested_rx/tx_descriptors' and
'configured_rx/tx_descriptors' as they will be the same.
It simpler to just have a single 'n_rxq/txq_desc' value.
Suggested-by: Ilya Maximets
Signed-off-by: Kevin Traynor
---
lib/netdev-dpdk.c | 10 ++
1 file changed, 2 inse
By default OVS configures 2048 descriptors for tx and rx queues
on DPDK devices. It also allows the user to configure those values.
If the values used are not acceptable to the device then queue setup
would fail.
The device exposes it's max/min/alignment requirements and OVS
applies some limits a
v3:
- Changed get_config to remove duplicate rxq/txq sizes
- Simplified by going back to just 'requested_rxq/txq_size' and
'rxq/txq_size' and dropped adding 'adjusted'
- Moved logging to dpdk_process_queue_size()
- Removed Acks as the code has changed a bit
GHA: https://github.com/kevintraynor/o
Hi Dumitru, Mark,
The new version (v4) has been submitted at
https://patchwork.ozlabs.org/project/ovn/patch/20230504165510.4026066-1-odiv...@gmail.com/
> On 3 May 2023, at 17:18, Dumitru Ceara wrote:
>
> On 5/3/23 16:12, Vladislav Odintsov wrote:
>> Hi Dumitru and Mark,
>>
>> thanks for the r
Ilya Maximets writes:
> On 4/19/23 20:40, Paolo Valerio wrote:
>> During the creation of a new connection, there's a chance both key and
>> rev_key end up having the same hash. This is more common in the case
>> of all-zero snat with no collisions. In that case, once the
>> connection is expired,
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#132 FILE: ovn-sb.xml:272:
Let's separate DPDK compilation from the rest of OVS build:
- this avoids multiple jobs building DPDK in parallel, which especially
affects builds in the dpdk-latest branch,
- we separate concerns about DPDK build requirements from OVS build
requirements, like python dependencies,
- building DP
For large OVN_Southbound (or other) databases the default interval of 5000 ms
could be not sufficient to run. This patch adds configuration of OVSDB
inactivity probes for ovn-*ctl utilities.
Initially, on the utility start the hardcoded value of 12 ms is set.
For daemon-mode it is possible to
On 4/21/23 17:16, Adrian Moreno wrote:
> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>
> This breaks the 32Gbps barrier. The new barrier is ~4Tbps caused by
> netdev's API expressing kbps rates using 32-bit integers.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cg
On 4/21/23 17:16, Adrian Moreno wrote:
> Currently, htb rates are capped at ~34Gbps because they are internally
> expressed as 32-bit fields.
>
> Move min and max rates to 64-bit fields and use TCA_HTB_RATE64 and
> TCA_HTB_CEIL64 to configure HTC classes to break this barrier.
>
> In order to tes
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see th
On 4/21/23 17:16, Adrian Moreno wrote:
> tc uses these "rtab" tables to estimate the time (ticks) that it takes
> to send a packet of different sizes. In preparation for the introduction
> of 64-bit rates, add an argument to tc_put_rtab() to allow an external
> 64-bit rate.
>
> Signed-off-by: Adri
On 4/21/23 17:16, Adrian Moreno wrote:
> Instead of relying on feature bits, use the speed value directly as
> maximum rate for htb and hfsc classes.
>
> There is still a limitation with the maximum rate that we can express
> with a 32-bit number in bytes/s (~ 34.3Gbps), but using the actual link
On 4/21/23 17:16, Adrian Moreno wrote:
> Currently, the netdev's speed is being calculated by taking the link's
> feature bits (using netdev_get_features()) and transforming them into
> bps.
>
> This mechanism can be both inaccurate and difficult to maintain, mainly
> because we currently use the
diff --git a/lib/ssl-connect.man b/lib/ssl-connect.man
index 6e54f77ef4d5e..896ce79c6378f 100644
--- a/lib/ssl-connect.man
+++ b/lib/ssl-connect.man
@@ -1,10 +1,12 @@
.IP "\fB\-\-ssl\-protocols=\fIprotocols\fR"
Specifies, in a comma- or space-delimited list, the SSL protocols
\fB\*(PN\fR will en
For large OVN_Southbound (or other) databases the default interval of 5000 ms
could be not sufficient to run. This patch adds configuration of OVSDB
inactivity probes for ovn-*ctl utilities.
Initially, on the utility start the hardcoded value of 12 ms is set.
For daemon-mode it is possible to
Thanks Mark! I will update the series according to your suggestions
after more reviews land to the series.
On Wed, May 3, 2023 at 4:55 PM Mark Michelson wrote:
>
> On 5/2/23 21:12, Ihar Hrachyshka wrote:
> > When a multichassis port belongs to a switch with a localnet port,
> > packets originatin
On 5/4/23 09:09, Simon Horman wrote:
On Wed, May 03, 2023 at 04:05:36PM +0200, Adrian Moreno wrote:
On 4/25/23 14:51, Simon Horman wrote:
On Fri, Apr 21, 2023 at 05:16:48PM +0200, Adrian Moreno wrote:
Currently, htb rates are capped at ~34Gbps because they are internally
expressed as 32-bi
On 4/25/2023 11:51 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 4/25/23 15:21, Roi Dayan wrote:
On 25/04/2023 16:14, Roi Dayan wrote:
On 25/04/2023 15:53, Ilya Maximets wrote:
On 4/25/23 14:31, Roi Dayan wrote:
On 25/04/2023 15:29, Ilya Maximets
On 5/4/23 14:20, wangyunjian via dev wrote:
>
>
>> -Original Message-
>> From: Ilya Maximets [mailto:i.maxim...@ovn.org]
>> Sent: Thursday, May 4, 2023 7:44 PM
>> To: wangyunjian ; d...@openvswitch.org
>> Cc: i.maxim...@ovn.org; luyicai
>> Subject: Re: [ovs-dev] [PATCH] ofproto-dpif-xlat
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@ovn.org]
> Sent: Thursday, May 4, 2023 7:44 PM
> To: wangyunjian ; d...@openvswitch.org
> Cc: i.maxim...@ovn.org; luyicai
> Subject: Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix use-after-free when
> xlate_actions().
>
> On
On 4/19/23 08:29, Yunjian Wang wrote:
> Currently, bundle->cvlans and xbundle->cvlans are pointing to the
> same memory location. This can cause issues if the main thread
> modifies bundle->cvlans and frees it while the revalidator thread
> is still accessing xbundle->cvlans. This can result in use
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
WARNING: Unexpected sign-offs from developers who are not a
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
WARNING: Unexpected sign-offs from developers who are not a
In vxlan mode with more than 2047 lrp in router, build_ports()
prints "all port tunnel ids exhausted", and frees the lrp port.
However, lsp of type "router" connected to the lrp still holds
the pointer in port->peer. This leads to northd crash in
build_lflows().
CallTrace:
build_lswitch_rport_a
Hi
I have sent a new version with your re-write.
Eelco Chaudron 于2022年12月8日周四 19:08写道：
>
>
> On 27 Nov 2022, at 8:28, Peng He wrote:
>
> > The following comments (brought in at 0de8783a9):
> >
> > /* XXX: There's a race window where a flow covering this packet
> > * could have already been ins
The following comments (brought in at 0de8783a9):
/* XXX: There's a race window where a flow covering this packet
* could have already been installed since we last did the flow
* lookup before upcall. This could be solved by moving the
* mutex lock outside the loop, but that's an awful long ti
push_dp_ops only handles delete ops errors but ignores the modify
ops results. It's better to handle all the dp operation errors in
a consistent way.
We observe in the production environment that sometimes a megaflow
with wrong actions keep staying in datapath. The coverage command shows
revalidat
On 4/24/23 9:06 PM, Simon Horman wrote:
On Thu, Apr 20, 2023 at 01:24:08PM +0800, Tao Liu wrote:
In vxlan mode with more than 2047 lrp in router, build_ports()
prints "all port tunnel ids exhausted", and frees the lrp port.
However, lsp of type "router" connected to the lrp still holds
the po
On 4/11/23 15:25, Wan Junjie via dev wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
Hi. Thanks for the patch! See some comemnts inline.
Best
Similar to IPv4 support, add IPv6 support for iPXE chainload.
Signed-off-by: Lorenzo Bianconi
---
controller/pinctrl.c | 36 ++--
lib/ovn-l7.h | 9 +
northd/ovn-northd.c | 4 ++-
tests/ovn.at | 78 +---
tests/test-ovn
According to RFC8415 [0], section 8 "Client/Server Message Formats":
"Options are stored serially in the "options" field, with no padding
between the options. Options are byte-aligned but are not aligned
in any other way (such as on 2-byte or 4-byte boundaries)."
Fix possible unaligned accesses
Lorenzo Bianconi (2):
controller: fix possible unaligned accesses in DHCPv6 code
Introduce IPv6 iPXE chainload support
controller/pinctrl.c | 47 ++
lib/actions.c| 23 ++---
lib/ovn-l7.h | 9 +
northd/ovn-northd.c | 4 ++-
tests/ovn.at
On 5/4/23 12:12, Ilya Maximets wrote:
> On 4/11/23 11:07, 汪翰林 wrote:
>>
>> 在 2023/4/7 21:20, Simon Horman 写道:
>>> On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote:
When 'cs' is not connected to a server, then
ovsdb_cs_db_compose_lock_request__ will update
'cs_db' lock flag,
On 4/11/23 11:07, 汪翰林 wrote:
>
> 在 2023/4/7 21:20, Simon Horman 写道:
>> On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote:
>>> When 'cs' is not connected to a server, then
>>> ovsdb_cs_db_compose_lock_request__ will update
>>> 'cs_db' lock flag, but the lock flag will not
>>> be updated ne
On 3/30/23 10:17, Naveen Yerramneni wrote:
> Add OpenFlow extn to set conntrack entries limit per zone.
> This extn will be used in future to set the zone level limit for
> drop zones used by OVN.
>
> Signed-off-by: Naveen Yerramneni
> Reviewed-by: Simon Horman
> ---
> Notes:
> v1 -> v2
> -
Hello Ilya,
On Wed, May 3, 2023 at 8:06 PM Ilya Maximets wrote:
> > +function build_dpdk()
> > +{
> > +local VERSION_FILE="dpdk-dir/cached-version"
> > +local DPDK_VER=$1
> > +local DPDK_OPTS=""
> > +
> > +rm -rf dpdk-dir
> > +
> > +if [ "${DPDK_VER##refs/*/}" != "${DPDK_VER}"
On 5/4/23 08:59, Ales Musil wrote:
> When the system is busy with multiple test running concurrently
> the modprobe might fail with "Device or resource busy", which
> will fail the whole test. Instead of always trying to load the module
> check if it's already loaded. Also replace the AT_CHECK with
Hi,
sorry for the late reply.
Yes, basically this means going back to v5, but with a minor difference.
In the original v5, the INCONSISTENT to EVICTING change is in the
revalidate_sweep__ phrase.
However，since you have spot that doing so in sweep phrase has a risk: If in
sweep phrase,
we initia
On Wed, May 03, 2023 at 04:05:36PM +0200, Adrian Moreno wrote:
>
>
> On 4/25/23 14:51, Simon Horman wrote:
> > On Fri, Apr 21, 2023 at 05:16:48PM +0200, Adrian Moreno wrote:
> > > Currently, htb rates are capped at ~34Gbps because they are internally
> > > expressed as 32-bit fields.
> > >
> > >
On Wed, May 03, 2023 at 03:53:14PM +0200, Adrian Moreno wrote:
>
>
> On 4/26/23 15:39, Simon Horman wrote:
> > On Fri, Apr 21, 2023 at 05:16:50PM +0200, Adrian Moreno wrote:
> > > In preparation for supporting 64-bit rates in tc policies, move the
> > > allocation and initialization of struct tc_
52 matches
Mail list logo
