Re: [ovs-dev] [ovs-dev v7 1/3] ofproto-dpif-upcall: fix push_dp_ops

2023-05-11 Thread Peng He
Hi, Eelco Chaudron 于2023年5月11日周四 15:04写道: > > > On 4 May 2023, at 9:50, Peng He wrote: > > > Hi, > > > > sorry for the late reply. > > > > Yes, basically this means going back to v5, but with a minor difference. > > > > In the original v5, the INCONSISTENT to EVICTING change is in the > > reval

Re: [ovs-dev] [ovs-dev v8 2/2] dpif-netdev: fix the race comments

2023-05-11 Thread Peng He
Great, thanks! Eelco Chaudron 于2023年5月11日周四 15:02写道: > > > On 4 May 2023, at 13:29, Peng He wrote: > > > The following comments (brought in at 0de8783a9): > > > > /* XXX: There's a race window where a flow covering this packet > > * could have already been installed since we last did the flow >

Re: [ovs-dev] [PATCH v3 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-11 Thread Nobuhiro MIKI
On 2023/05/11 20:50, Ilya Maximets wrote: > On 5/11/23 12:39, Nobuhiro MIKI wrote: >> On 2023/05/11 6:33, Ilya Maximets wrote: >>> On 5/9/23 11:38, Nobuhiro MIKI wrote: It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implement

Re: [ovs-dev] [PATCH v2] tests dpdk: Allow passing in dpdk-extra arguments.

2023-05-11 Thread Ilya Maximets
On 5/11/23 18:13, Frode Nordahl wrote: > At present, the system-dpdk-testsuite makes assumptions about > environment configuration, and will error out if DPDK compatible > interfaces not configured for DPDK are present in the system with > a message like: > > EAL: Probe PCI driver: net_virtio (1af

Re: [ovs-dev] [PATCH v3 2/2] test-stream: Add ssl tests for stream open block

2023-05-11 Thread Ilya Maximets
On 5/11/23 15:38, Stefan Hoffmann wrote: > This tests stream.c and stream.py with ssl connection at > CHECK_STREAM_OPEN_BLOCK. > For the tests, ovsdb needs to be build with libssl. > > Signed-off-by: Stefan Hoffmann > --- > > Changes based on comments from Ilya Maximets: > use m4_join; use m4_su

Re: [ovs-dev] [PATCH v6 ovn 4/9] controller: configure qos through ovs qos table and do not run tc directly

2023-05-11 Thread Lorenzo Bianconi
> On Wed, May 10, 2023 at 10:22 AM Lorenzo Bianconi > wrote: > > > > Rework OVN QoS implementation in order to configure it through OVS QoS > > table instead of running tc command directly bypassing OVS. > > > > Acked-By: Ihar Hrachyshka > > Reviewed-by: Simon Horman > > Tested-by: Rodolfo Alons

Re: [ovs-dev] [PATCH v3 1/2] tests-ovsdb: switch OVSDB_START_IDLTEST to macro

2023-05-11 Thread Ilya Maximets
On 5/11/23 15:35, Stefan Hoffmann wrote: > Define bash function as macro now. Later we can extend this macro for other > usecases. > > Signed-off-by: Stefan Hoffmann > --- > > Rework due to hints from Ilya Maximets: no empty quotes inside brackets and > move m4_define out of m4_divert_text > >

Re: [ovs-dev] [PATCH v2] dpctl: Fix dereferencing null pointer in parse_ct_limit_zones().

2023-05-11 Thread Ilya Maximets
On 5/10/23 10:35, Zhiqi Chen via dev wrote: > Command with empty string following "dpctl/ct-get-limits zone=" > such as "ovs-appctl dpctl/ct-get-limits zone=" will cause > parse_ct_limit_zones() dereferencing null. > > Signed-off-by: Zhiqi Chen Thanks! Applied and backported down to 2.17. Best

[ovs-dev] [PATCH v2] tests dpdk: Allow passing in dpdk-extra arguments.

2023-05-11 Thread Frode Nordahl
At present, the system-dpdk-testsuite makes assumptions about environment configuration, and will error out if DPDK compatible interfaces not configured for DPDK are present in the system with a message like: EAL: Probe PCI driver: net_virtio (1af4:1000) device: :00:03.0 (socket -1) eth_virtio

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-05-11 Thread Frode Nordahl
Hello, Dumitru, Daniel and team, On Thu, May 11, 2023 at 5:23 PM Dumitru Ceara wrote: > > Hi Frode, > > During an internal discussion with RedHat OpenStack folks (Daniel in cc) > about scalability of OVN in OpenStack deployments I remembered that you > mentioned that you're thinking of enhancing

Re: [ovs-dev] [PATCH] tests dpdk: Allow passing in dpdk-extra arguments.

2023-05-11 Thread 0-day Robot
Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (tests/system-dpdk-macros.at). error: could not buil

Re: [ovs-dev] Proposed OVN support lifetime updates

2023-05-11 Thread Numan Siddique
On Thu, May 11, 2023 at 9:29 AM Ilya Maximets wrote: > > On 5/11/23 15:14, Frode Nordahl wrote: > > On Fri, May 5, 2023 at 11:39 AM Dumitru Ceara wrote: > >> > >> On 5/4/23 22:09, Mark Michelson wrote: > >>> Hi all, > >>> > >>> A recent thread [1] had several topics of discussion come up about >

Re: [ovs-dev] [PATCH ovn 1/2] mirror: Enhance port-mirroring to support local OVS port as target.

2023-05-11 Thread Numan Siddique
On Wed, May 10, 2023 at 12:25 PM Han Zhou wrote: > > On Mon, May 8, 2023 at 11:06 AM Mark Michelson wrote: > > > > Hi Han, > > > > For both patches in the series, > > > > Acked-by: Mark Michelson > > > Thanks Mark. I applied to main. > > > I want to put a reply to patch 2 directly, but unfortuna

[ovs-dev] [PATCH] tests dpdk: Allow passing in dpdk-extra arguments.

2023-05-11 Thread Frode Nordahl
At present, the system-dpdk-testsuite makes assumptions about environment configuration, and will error out if DPDK compatible interfaces not configured for DPDK are present in the system with a message like: INFO|EAL: Probe PCI driver: net_virtio (1af4:1000) device: :00:03.0 (socket -1) ERR|

Re: [ovs-dev] [PATCH v3 2/2] test-stream: Add ssl tests for stream open block

2023-05-11 Thread Ilya Maximets
On 5/11/23 15:49, Stefan Hoffmann wrote: > On Thu, 2023-05-11 at 15:38 +0200, Stefan Hoffmann wrote: >> This tests stream.c and stream.py with ssl connection at >> CHECK_STREAM_OPEN_BLOCK. >> For the tests, ovsdb needs to be build with libssl. >> >> Signed-off-by: Stefan Hoffmann >> --- >> >> Chan

[ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

2023-05-11 Thread Dumitru Ceara
Hi Frode, During an internal discussion with RedHat OpenStack folks (Daniel in cc) about scalability of OVN in OpenStack deployments I remembered that you mentioned that you're thinking of enhancing ovn-heater in order to test your types of deployments [0]. I assumed that those are also OpenStack

Re: [ovs-dev] [PATCH v3] backtrace: Extend the backtrace functionality

2023-05-11 Thread Aaron Conole
Ales Musil writes: > Use the backtrace functions that is provided by libc, > this allows us to get backtrace that is independent of > the current memory map of the process. Which in turn can > be used for debugging/tracing purpose. The backtrace > is not 100% accurate due to various optimizations

Re: [ovs-dev] [PATCH v3 2/2] test-stream: Add ssl tests for stream open block

2023-05-11 Thread Stefan Hoffmann
On Thu, 2023-05-11 at 15:38 +0200, Stefan Hoffmann wrote: > This tests stream.c and stream.py with ssl connection at > CHECK_STREAM_OPEN_BLOCK. > For the tests, ovsdb needs to be build with libssl. > > Signed-off-by: Stefan Hoffmann > --- > > Changes based on comments from Ilya Maximets: > use m

[ovs-dev] [PATCH v3 2/2] test-stream: Add ssl tests for stream open block

2023-05-11 Thread Stefan Hoffmann
This tests stream.c and stream.py with ssl connection at CHECK_STREAM_OPEN_BLOCK. For the tests, ovsdb needs to be build with libssl. Signed-off-by: Stefan Hoffmann --- Changes based on comments from Ilya Maximets: use m4_join; use m4_substr directly at call, without using variable in between H

[ovs-dev] [PATCH v3 1/2] tests-ovsdb: switch OVSDB_START_IDLTEST to macro

2023-05-11 Thread Stefan Hoffmann
Define bash function as macro now. Later we can extend this macro for other usecases. Signed-off-by: Stefan Hoffmann --- Rework due to hints from Ilya Maximets: no empty quotes inside brackets and move m4_define out of m4_divert_text tests/ovsdb-idl.at | 83 +---

Re: [ovs-dev] Proposed OVN support lifetime updates

2023-05-11 Thread Ilya Maximets
On 5/11/23 15:14, Frode Nordahl wrote: > On Fri, May 5, 2023 at 11:39 AM Dumitru Ceara wrote: >> >> On 5/4/23 22:09, Mark Michelson wrote: >>> Hi all, >>> >>> A recent thread [1] had several topics of discussion come up about >>> proposed changes to OVN release management. This thread is specifica

Re: [ovs-dev] Proposed OVN support lifetime updates

2023-05-11 Thread Frode Nordahl
On Fri, May 5, 2023 at 11:39 AM Dumitru Ceara wrote: > > On 5/4/23 22:09, Mark Michelson wrote: > > Hi all, > > > > A recent thread [1] had several topics of discussion come up about > > proposed changes to OVN release management. This thread is specifically > > to discuss the support lifetime of

Re: [ovs-dev] [PATCH v2 7/7] tc: Add vxlan encap action with gbp option offload

2023-05-11 Thread Roi Dayan via dev
On 25/04/2023 15:41, Roi Dayan wrote: > From: Gavin Li > > Add TC offload support for vxlan encap with gbp option > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Roi Dayan > --- > acinclude.m4 | 7 > include/linux/tc_act/tc_tunnel_key.h |

Re: [ovs-dev] [PATCH v2 4/7] tc: Add NLA_F_NESTED to nested netlink messages

2023-05-11 Thread Roi Dayan via dev
On 10/05/2023 17:10, Simon Horman wrote: > On Wed, Apr 26, 2023 at 06:39:22PM +0200, Ilya Maximets wrote: >> On 4/25/23 14:41, Roi Dayan wrote: >>> From: Gavin Li >>> >>> Linux kernel netlink module added NLA_F_NESTED flag checking for nested >>> netlink messages in 5.2. A nested message withou

Re: [ovs-dev] [PATCH v2 2/2] test-stream: Add ssl tests for stream open block

2023-05-11 Thread Stefan Hoffmann
On Wed, 2023-05-10 at 21:22 +0200, Ilya Maximets wrote: > On 5/9/23 10:25, Stefan Hoffmann wrote: > > This tests stream.c and stream.py with ssl connection at > > CHECK_STREAM_OPEN_BLOCK. > > For the tests, ovsdb needs to be build with libssl. > > > > Signed-off-by: Stefan Hoffmann > > --- > > t

Re: [ovs-dev] [PATCH v3 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-11 Thread Ilya Maximets
On 5/11/23 12:39, Nobuhiro MIKI wrote: > On 2023/05/11 6:33, Ilya Maximets wrote: >> On 5/9/23 11:38, Nobuhiro MIKI wrote: >>> It supports flowlabel based load balancing by controlling the flowlabel >>> of outer IPv6 header, which is already implemented in Linux kernel as >>> seg6_flowlabel sysctl

Re: [ovs-dev] [PATCH v2] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-11 Thread Frode Nordahl
Hello, Roi, Thank you for your prompt reply, see response in-line below. On Thu, May 11, 2023 at 12:51 PM Roi Dayan wrote: > On 11/05/2023 13:03, Frode Nordahl wrote: > > The tc module combines the use of the `tc_transact` helper > > function for communication with the in-kernel tc infrastructur

Re: [ovs-dev] [PATCH v2] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-11 Thread Roi Dayan via dev
On 11/05/2023 13:03, Frode Nordahl wrote: > The tc module combines the use of the `tc_transact` helper > function for communication with the in-kernel tc infrastructure > with assertions on the reply data by `ofpbuf_at_assert` on the > received data prior to further processing. > > `tc_transact

Re: [ovs-dev] [PATCH v3 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-11 Thread Nobuhiro MIKI
On 2023/05/11 6:33, Ilya Maximets wrote: > On 5/9/23 11:38, Nobuhiro MIKI wrote: >> It supports flowlabel based load balancing by controlling the flowlabel >> of outer IPv6 header, which is already implemented in Linux kernel as >> seg6_flowlabel sysctl [1]. >> >> [1]: https://docs.kernel.org/netwo

[ovs-dev] [PATCH v2] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-11 Thread Frode Nordahl
The tc module combines the use of the `tc_transact` helper function for communication with the in-kernel tc infrastructure with assertions on the reply data by `ofpbuf_at_assert` on the received data prior to further processing. `tc_transact` in turn calls `nl_transact`, which via `nl_transact_mul

Re: [ovs-dev] [PATCH v3 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header.

2023-05-11 Thread Nobuhiro MIKI
On 2023/05/11 5:56, Ilya Maximets wrote: > On 5/9/23 11:37, Nobuhiro MIKI wrote: >> For tunnels such as SRv6, some popular vendor appliances support >> IPv6 flowlabel based load balancing. In preparation for OVS to >> support it, this patch modifies the encapsulation to allow IPv6 >> flowlabel to b

Re: [ovs-dev] [PATCH ovn v6] controller: Prevent race in packet buffering

2023-05-11 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #51 FILE: controller/mac-learn.c:216: bp->expi

[ovs-dev] [PATCH ovn v6] controller: Prevent race in packet buffering

2023-05-11 Thread Ales Musil
There was a race within packet buffering that could result in first packt being dropped. It could happen under following conditions and topology: S1 == R1 == public == R2 == S2 SNAT on R1 and DGP on port connecting R1 with public. 1) The GARP is sent for the DGP SNAT 2) The GARP is delayed on R2 b

Re: [ovs-dev] [PATCH v3 2/2] netdev-dpdk: Add support for userspace port-based ingress packet-per-second policing.

2023-05-11 Thread Eelco Chaudron
On 1 May 2023, at 13:33, mit...@outlook.com wrote: > From: Lin Huang > > OvS has supported packet-per-second policer which can be set at ingress > and egress side in kernel datapath. But the userspace datapath dosen't > support for ingress and egress packet-per-second policing now. > > So, this

Re: [ovs-dev] [PATCH v3 1/2] netdev-dpdk: Add support for userspace port-based egress packet-per-second policing.

2023-05-11 Thread Eelco Chaudron
On 1 May 2023, at 13:33, mit...@outlook.com wrote: > From: Lin Huang > > OvS has supported packet-per-second policer which can be set at ingress > and egress side in kernel datapath. But the userspace datapath dosen't > support for ingress and egress packet-per-second policing now. > > So, this

Re: [ovs-dev] [PATCH v3 1/2] netdev-dpdk: Add support for userspace port-based egress packet-per-second policing.

2023-05-11 Thread Simon Horman
On Wed, May 10, 2023 at 11:43:31PM +0800, miter wrote: > Hi simon, > > > Thanks for your reviewing. > > > On 5/10/2023 10:34 PM, Simon Horman wrote: > > On Mon, May 01, 2023 at 07:33:38PM +0800, mit...@outlook.com wrote: > > > From: Lin Huang ... > > > Examples: > > > $ovs-vsctl set port vho

Re: [ovs-dev] [PATCH v2] netdev-offload: Fix deadlock/recursive use of the netdev_hmap_rwlock rwlock.

2023-05-11 Thread Eelco Chaudron
On 10 May 2023, at 23:41, Ilya Maximets wrote: > On 5/9/23 16:29, Eelco Chaudron wrote: >> When doing performance testing with OVS v3.1 we ran into a deadlock >> situation with the netdev_hmap_rwlock read/write lock. After some >> debugging, it was discovered that the netdev_hmap_rwlock read lo

Re: [ovs-dev] [ovs-dev v7 1/3] ofproto-dpif-upcall: fix push_dp_ops

2023-05-11 Thread Eelco Chaudron
On 4 May 2023, at 9:50, Peng He wrote: > Hi, > > sorry for the late reply. > > Yes, basically this means going back to v5, but with a minor difference. > > In the original v5, the INCONSISTENT to EVICTING change is in the > revalidate_sweep__ phrase. > > However,since you have spot that doing so

Re: [ovs-dev] [ovs-dev v8 2/2] dpif-netdev: fix the race comments

2023-05-11 Thread Eelco Chaudron
On 4 May 2023, at 13:29, Peng He wrote: > The following comments (brought in at 0de8783a9): > > /* XXX: There's a race window where a flow covering this packet > * could have already been installed since we last did the flow > * lookup before upcall. This could be solved by moving the > * m