Re: [ovs-dev] Official Way For Rebuilding OVS

2023-05-18 Thread Frode Nordahl
On Wed, May 17, 2023 at 4:03 PM Lazuardi Nasution wrote: > > Hi Frode, > > Any comparison between using dpkg-buildpackage and debhelper? I'm not sure the Open vSwitch development mailing list is the right forum for distribution specific packaging details, you can find more information on the topi

Re: [ovs-dev] [PATCH 2/2] conntrack: Release nat_conn in case both keys have the same hash.

2023-05-18 Thread Peng He
Hi, Paolo, IIRC, you have a revision version on these patches? I guess it should be closer to the upstream than mine? Aaron Conole 于2023年5月17日周三 21:54写道: > Paolo Valerio writes: > > > Ilya Maximets writes: > > > >> On 5/4/23 19:21, Paolo Valerio wrote: > >>> Ilya Maximets writes: > >>> > >>

Re: [ovs-dev] [PATCH v8 ovn 03/10] northd: add qos_physical_network in port_binding config column

2023-05-18 Thread Lorenzo Bianconi
> On Wed, May 17, 2023 at 5:02 AM Lorenzo Bianconi > wrote: > > > > Introduce qos_physical_network in port_binding config column in order to > > indicate the name of the egress network name where traffic shaping will > > be applied. > > This is a preliminary patch to rework OVN QoS implementation

[ovs-dev] [PATCH v9 ovn 00/10] Configure OVN QoS thorugh OvS db

2023-05-18 Thread Lorenzo Bianconi
Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. This series allows to apply QoS rules on the localnet port related to logical switch ports running on the same datapath. Considering the following netowrk configuration

[ovs-dev] [PATCH v9 ovn 01/10] controller: remove tunnel interfaces from egress_ifaces sset

2023-05-18 Thread Lorenzo Bianconi
Remove tunnel interfaces from egress list in order to not shape them. Acked-by: Numan Siddique Acked-By: Ihar Hrachyshka Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c | 9 - 1 file changed, 9 deletions(-) diff --git a/controller/binding.c b/contro

[ovs-dev] [PATCH v9 ovn 02/10] controller: add incremental processing for ovn-controller qos_map

2023-05-18 Thread Lorenzo Bianconi
Introduce support to process incrementally ovn-controller QoS configuration received from ovn-northd adding qos_map hash map. This is a preliminary patch to rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. Acked-by:

[ovs-dev] [PATCH v9 ovn 03/10] northd: add qos_physical_network in port_binding config column

2023-05-18 Thread Lorenzo Bianconi
Introduce qos_physical_network in port_binding config column in order to indicate the name of the egress network name where traffic shaping will be applied. This is a preliminary patch to rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command dire

[ovs-dev] [PATCH v9 ovn 04/10] controller: configure qos through ovs qos table and do not run tc directly

2023-05-18 Thread Lorenzo Bianconi
Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. Acked-By: Ihar Hrachyshka Reviewed-by: Simon Horman Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 428 ++

[ovs-dev] [PATCH v9 ovn 05/10] controller: improve ovs port lookup by qos

2023-05-18 Thread Lorenzo Bianconi
Introduce ovsport_lookup_by_qos routine in order to speed-up ovs port lookup based on port qos. Acked-by: Numan Siddique Acked-By: Ihar Hrachyshka Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 37 ++--- controller/b

[ovs-dev] [PATCH v9 ovn 06/10] controller: use unsigned long long int for qos_max_rate/qos_min_rate/qos_burst

2023-05-18 Thread Lorenzo Bianconi
This patch allow to configure max/min rate greater than 4Gbps Acked-by: Numan Siddique Acked-By: Ihar Hrachyshka Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git

[ovs-dev] [PATCH v9 ovn 07/10] northd: make queue_id allocation global for the ovn cluster

2023-05-18 Thread Lorenzo Bianconi
In order to avoid possible queue_id clash when we have a localnet and a LSP ports on the same hv, make QoS queue_id allocation global for the ovn cluster. Acked-by: Numan Siddique Signed-off-by: Lorenzo Bianconi --- northd/northd.c | 127 1 file

[ovs-dev] [PATCH v9 ovn 08/10] northd: apply QoS rules on the localnet port related to LSP ports

2023-05-18 Thread Lorenzo Bianconi
This patch allows to apply QoS rules on the localnet port related to logical switch ports running on the same datapath. Considering the following netowrk configuration: LSP{0,1} -- LogicalSwitch -- Localnet0 It is possible to apply the following QoS rules on Localnet0 on egress traffic entering t

[ovs-dev] [PATCH v9 ovn 09/10] controller: get rid of egress_ifaces sset

2023-05-18 Thread Lorenzo Bianconi
egress_ifaces sset is no longer used by ovn-controller, so get rid of it Acked-by: Numan Siddique Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 40 - controller/binding.h| 1 - controller/ovn-controller.c | 10 ++ 3 files

[ovs-dev] [PATCH v9 ovn 10/10] update NEWS with new QoS info

2023-05-18 Thread Lorenzo Bianconi
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2139100 Acked-by: Numan Siddique Acked-By: Ihar Hrachyshka Signed-off-by: Lorenzo Bianconi --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS ind

[ovs-dev] [PATCH ovn v4 0/5] Implement MTU Path Discovery for multichassis ports

2023-05-18 Thread Ihar Hrachyshka
This series fixes a non-optimal behavior with some multichassis ports. Specifically, - when a multichassis port belongs to a switch that also has a localnet port, - because ingress and egress traffic for the port is funnelled through tunnels to guarantee delivery of packets to all chassis tha

[ovs-dev] [PATCH ovn v4 2/5] Track interface MTU in if-status-mgr

2023-05-18 Thread Ihar Hrachyshka
This will be used in a later patch to calculate the effective interface MTU after considering tunneling overhead. NOTE: ideally, OVN would support Logical_Port MTU, in which case we wouldn't have to track OVSDB for interfaces. Signed-off-by: Ihar Hrachyshka --- controller/binding.c| 4

[ovs-dev] [PATCH ovn v4 3/5] if-status: track interfaces for additional chassis

2023-05-18 Thread Ihar Hrachyshka
This will allow all chassis hosting a port to extract interface MTU from if-status-mgr. This will be used in a later patch to calculate the effective path MTU for each port. In addition, it's the right thing to do to claim and mark an interface on all chassis as ovn-installed, even if the chassis

[ovs-dev] [PATCH ovn v4 1/5] Track ip version of tunnel in chassis_tunnel struct

2023-05-18 Thread Ihar Hrachyshka
This will be used in a later patch to calculate tunneling overhead for effective path MTU. Acked-by: Dumitru Ceara Signed-off-by: Ihar Hrachyshka --- controller/local_data.c | 2 ++ controller/local_data.h | 1 + 2 files changed, 3 insertions(+) diff --git a/controller/local_data.c b/controlle

[ovs-dev] [PATCH ovn v4 5/5] Implement MTU Path Discovery for multichassis ports

2023-05-18 Thread Ihar Hrachyshka
When a multichassis port belongs to a switch with a localnet port, packets originating or directed to the multichassis port are NOT sent thorugh the localnet port. Instead, tunneling is enforced in-cluster to guarantee delivery of all packets to all chassis of the port. This behavior has an unfort

[ovs-dev] [PATCH ovn v4 4/5] Add new egress tables to accommodate for too-big packets handling

2023-05-18 Thread Ihar Hrachyshka
The new tables will be used in a later patch as follows: table=37, OFTABLE_OUTPUT_INIT: becomes an initial entry point into the egress pipeline that serves a semantic goal. (Not doing any actual processing at the moment.) table=38, OFTABLE_OUTPUT_LARGE_PKT_DETECT: detect "too-big" IP packets and

[ovs-dev] [PATCH ovn 1/5] northd: Extract aging functionality into separate context

2023-05-18 Thread Ales Musil
Some of the pieces for MAC binding aging can be reused, in order to do that extract them to separate context struct that holds everything that is not MAC binding specific. This is preparation for FDB aging mechanism. Signed-off-by: Ales Musil --- northd/mac-binding-aging.c | 160

[ovs-dev] [PATCH ovn 0/5] Add FDB aging mechanism

2023-05-18 Thread Ales Musil
Add FDB mechanism that is very similar to already existing MAc binding aging mechanism. There are two new config options to achieve that "fdb_age_threshold" that si configurable per logical switch and "fdb_removal_limit" which allows to specify bulk removal limit. The feature is disabled by defau

[ovs-dev] [PATCH ovn 3/5] northd, controller: Add timestamp column to FDB table

2023-05-18 Thread Ales Musil
Add timestamp column which will store timestamp when the FDB row is created or updated. This can be utilized by FDB aging mechanism. Signed-off-by: Ales Musil --- controller/pinctrl.c | 23 --- northd/ovn-northd.c | 2 +- ovn-sb.ovsschema | 7 --- ovn-sb.xml

[ovs-dev] [PATCH ovn 2/5] northd: Rename mac-binding-aging to aging

2023-05-18 Thread Ales Musil
Rename the mac-binding-aging module to aging to reflect that it will be used for more than single aging mechanism. This is preparation for FDB aging mechainsm. Signed-off-by: Ales Musil --- northd/{mac-binding-aging.c => aging.c} | 2 +- northd/{mac-binding-aging.h => aging.h} | 6 +++--- northd

[ovs-dev] [PATCH ovn 4/5] northd, controller: Add FDB timestamp feature indication

2023-05-18 Thread Ales Musil
Add feature indication to every chassis about FDB timestamp support. In case the northd and SB DB is updated before ovn-controller, which would trigger aging loop as the new row would be added with timestamp being 0. That would trigger constant aging mechanism. Signed-off-by: Ales Musil --- cont

[ovs-dev] [PATCH ovn 5/5] northd: Add FDB aging mechanism

2023-05-18 Thread Ales Musil
Add FDB aging mechanism that utilizes the timestamp column in FDB table. When the timestamp exceeds the threshold set for specified logical switch it will be removed from DB. The threshold is configurable per logical switch via other_config "fdb_age_threshold" in seconds. The default value is 0 wh

Re: [ovs-dev] [PATCH ovn 5/5] northd: Add FDB aging mechanism

2023-05-18 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #298 FILE: ovn-nb.xml:174:

[ovs-dev] [PATCH] ovsdb: condition: Process condition changes incrementally.

2023-05-18 Thread Ilya Maximets
In most cases, after the condition change request, the new condition is the same as old one plus minus a few clauses. Today, ovsdb-server will evaluate every database row against all the old clauses and then against all the new clauses in order to tell if an update should be generated. For exampl

[ovs-dev] [PATCH ovn v2] ovs: Bump submodule to v2.17.6

2023-05-18 Thread Ales Musil
Bump submodule to v2.17.6 specifically for: 1989caf9ea5e ("ovsdb-idl: Preserve references for rows deleted in same IDL run as their insertion.") with additional test from: c18415d5ae72 ("ovs: Bump submodule to tip of branch-3.0 and add related test") This commit is combination of multiple cherry

[ovs-dev] [PATCH ovn v2 branch-21.12] ovs: Bump submodule to v2.17.6

2023-05-18 Thread Ales Musil
Bump submodule to v2.17.6 specifically for: 1989caf9ea5e ("ovsdb-idl: Preserve references for rows deleted in same IDL run as their insertion.") with additional test from: c18415d5ae72 ("ovs: Bump submodule to tip of branch-3.0 and add related test") This commit is combination of multiple cherry

Re: [ovs-dev] [PATCH ovn v2] ovs: Bump submodule to v2.17.6

2023-05-18 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed

[ovs-dev] [PATCH] MAINTAINERS.rst: Make myself an active maintainer

2023-05-18 Thread Russell Bryant
I am currently an emeritus committer, but I would like to become active again for a short period of time to work through some governance issues preventing us from updating our committers list following our approved policies for doing so. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++--

Re: [ovs-dev] [PATCH] MAINTAINERS.rst: Make myself an active maintainer

2023-05-18 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > > On 18 May 2023, at 15:40, Russell Bryant wrote: > > I am currently an emeritus committer, but I would like to become > active again for a short period of time to work through some > governance issues preventing us from updating our committers list > followi

Re: [ovs-dev] [PATCH] MAINTAINERS.rst: Make myself an active maintainer

2023-05-18 Thread Russell Bryant
Thanks, I applied this to master. On Thu, May 18, 2023 at 9:44 AM Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean > > > > > > On 18 May 2023, at 15:40, Russell Bryant wrote: > > > > I am currently an emeritus committer, but I would like to become > > active again for a short period of t

Re: [ovs-dev] [PATCH v9 ovn 00/10] Configure OVN QoS thorugh OvS db

2023-05-18 Thread Mark Michelson
Thanks to Lorenzo and everyone who reviewed and tested this series. I have merged it to main. On 5/18/23 05:48, Lorenzo Bianconi wrote: Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. This series allows to apply

[ovs-dev] [OVS-Conf] OVS Conference 2023 dates and attendance Survey

2023-05-18 Thread Michael Santana
Hi all, Thank you to those who attended the OVS conference 2022! We are looking forward to another awesome conference in 2023! We are asking you to fill out this survey as it will help us plan for the OVS Conference 2023. We are trying to gather your preferences for the 2023 conference for dates,

Re: [ovs-dev] [PATCH v3] backtrace: Extend the backtrace functionality

2023-05-18 Thread Ilya Maximets
On 3/23/23 16:09, Ales Musil wrote: > Use the backtrace functions that is provided by libc, > this allows us to get backtrace that is independent of > the current memory map of the process. Which in turn can > be used for debugging/tracing purpose. The backtrace > is not 100% accurate due to variou

[ovs-dev] connect VM on OVN/OVS and BMS on L2

2023-05-18 Thread Tony Liu
Hi, Could you anyone share experiences or point to some reference about how to connect VM on OVN/OVS and BMS on L2? Or say, how can I connect BMS to a logical switch on OVN/OVS? Thanks! Tony ___ dev mailing list d...@openvswitch.org https://mail.openvs

Re: [ovs-dev] [PATCH ovn] northd: centralized reply lb traffic even if FIP is defined

2023-05-18 Thread Lorenzo Bianconi
> On 4/28/23 15:57, Lorenzo Bianconi wrote: > > In the current codebase for distributed gw router port use-case, > > it is not possible to add a load balancer that redirects the traffic > > to a backed if it is even the internal IP of a FIP NAT rule since > > the reply traffic is never centralized.

Re: [ovs-dev] connect VM on OVN/OVS and BMS on L2

2023-05-18 Thread Numan Siddique
On Thu, May 18, 2023 at 12:19 PM Tony Liu wrote: > > Hi, > > Could you anyone share experiences or point to some reference about how > to connect VM on OVN/OVS and BMS on L2? Or say, how can I connect BMS > to a logical switch on OVN/OVS? For this you need to create a localnet port in the logical

Re: [ovs-dev] connect VM on OVN/OVS and BMS on L2

2023-05-18 Thread Tony Liu
Hi Numan, Good to see you pick it up, no need to bother OpenStack alias. My ultimate target is to support VM and BMS L2 connectivity with OpenStack. I used to make that work with other virtual networking stack, not sure how much it's supported by OVN/OVS. Any comments in that context? Thanks! To

Re: [ovs-dev] [ovs-discuss] connect VM on OVN/OVS and BMS on L2

2023-05-18 Thread Numan Siddique
On Thu, May 18, 2023, 1:15 PM Tony Liu via discuss < ovs-disc...@openvswitch.org> wrote: > Hi Numan, > > Good to see you pick it up, no need to bother OpenStack alias. > My ultimate target is to support VM and BMS L2 connectivity with OpenStack. > I used to make that work with other virtual networ

[ovs-dev] [PATCH ovn v5 3/4] ovn-nbctl: Add tier ACL options.

2023-05-18 Thread Mark Michelson
This modifies the acl-add and acl-del commands so that an ACL tier can be specified when adding or deleting ACLs. For acl-add, if the tier is specified, then the ACL created by the command will have that tier set. For acl-del, if the tier is specified, then the tier will be one of the criteria us

[ovs-dev] [PATCH ovn v5 4/4] acls: Add "pass" ACL action.

2023-05-18 Thread Mark Michelson
This allows for evaluating ACLs at the current tier to stop, and to start evaluating ACLs at the next tier. If not using tiers, or if we match on the final ACL tier, then a "pass" verdict results in the default ACL action being applied. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2134

[ovs-dev] [PATCH ovn v5 2/4] northd: Add tiered ACL support.

2023-05-18 Thread Mark Michelson
With this commit, ACLs can now be arranged in hierarchical tiers. A tier number can be assigned to an ACL. When evaluating ACLs, we first will consider ACLs at tier 0. If no matching ACL is found, then we move to tier 1. This continues until a matching ACL is found, or we reach the maximum tier. If

Re: [ovs-dev] [PATCH ovn v5 1/4] northd: Break ACLs into two stages.

2023-05-18 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fa

Re: [ovs-dev] [PATCH ovn v2 branch-21.12] ovs: Bump submodule to v2.17.6

2023-05-18 Thread Mark Michelson
Thanks Ales, This looks good to me. Acked-by: Mark Michelson On 5/18/23 09:26, Ales Musil wrote: Bump submodule to v2.17.6 specifically for: 1989caf9ea5e ("ovsdb-idl: Preserve references for rows deleted in same IDL run as their insertion.") with additional test from: c18415d5ae72 ("ovs: Bu

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-05-18 Thread Mike Pattrick
Several xlate actions used in recursive translation currently store a large amount of information on the stack. This can result in handler threads quickly running out of stack space despite before xlate_resubmit_resource_check() is able to terminate translation. This patch reduces stack usage by ov

[ovs-dev] [PATCH ovn v4 1/2] tests: Use stricter IP match for FORMAT_CT.

2023-05-18 Thread Mark Michelson
The match used in FORMAT_CT matched on "dst=$1". The problem is that if you passed in an IP address like "10.0.0.1", then this could match on "10.0.0.1" and "10.0.0.100" for instance. This can allow for unexpected entries to show up in the output, causing test failures. With this change, the match

[ovs-dev] [PATCH ovn v4 2/2] Pass localnet traffic through CT when a LB is configured.

2023-05-18 Thread Mark Michelson
Current code always skips conntrack for traffic that ingresses or egresses on a localnet port. However, this makes it impossible for traffic to be load-balanced when it arrives on a localnet port. This patch allows for traffic to be load balanced on localnet ports by making two changes: * Localnet

Re: [ovs-dev] [PATCH ovn v3] Pass localnet traffic through CT when a LB is configured.

2023-05-18 Thread Mark Michelson
On 5/17/23 10:21, Numan Siddique wrote: On Wed, May 10, 2023 at 4:05 AM Ales Musil wrote: On Mon, May 8, 2023 at 5:19 PM Mark Michelson wrote: Current code always skips conntrack for traffic that ingresses or egresses on a localnet port. However, this makes it impossible for traffic to be l

Re: [ovs-dev] [PATCH ovn v4 2/2] Pass localnet traffic through CT when a LB is configured.

2023-05-18 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fa

[ovs-dev] [PATCH v2 ovn] northd: centralized reply lb traffic even if FIP is defined

2023-05-18 Thread Lorenzo Bianconi
In the current codebase for distributed gw router port use-case, it is not possible to add a load balancer that redirects the traffic to a backed if it is even the internal IP of a FIP NAT rule since the reply traffic is never centralized. Fix the issue centralizing the traffic if it is the reply p

[ovs-dev] [PATCH ovn 1/2] Prepare for 23.06.0.

2023-05-18 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 4 ++-- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index e29193104..5eeb7ef03 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,5 @@ -Post v23.03.0 -- +OVN v2

[ovs-dev] [PATCH ovn 2/2] Prepare for post-v23.06.0.

2023-05-18 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 5eeb7ef03..ec79e5fe7 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +Post v23.06.0 +- + OVN

Re: [ovs-dev] [PATCH v3] backtrace: Extend the backtrace functionality

2023-05-18 Thread Ilya Maximets
On 5/18/23 17:53, Ilya Maximets wrote: > On 3/23/23 16:09, Ales Musil wrote: >> +log_received_backtrace(int fd) { > > '{' should be on a separate line. > >> +struct backtrace bt; >> + >> +if (read_received_backtrace(fd, &bt, sizeof bt)) { >> +struct ds ds = DS_EMPTY_INITIALIZER; >

Re: [ovs-dev] [ovs-discuss] connect VM on OVN/OVS and BMS on L2

2023-05-18 Thread Tony Liu
Hi Numan, Provider VLAN networks is able to connect VM and BMS on L2. I am going to push this topic further. Provider VLAN network is different from regular virtual network. It seems that I can't create a logical router to connect a provider VLAN and regular VN. The way I am using provider VLAN i

Re: [ovs-dev] [PATCH v3] backtrace: Extend the backtrace functionality

2023-05-18 Thread Ales Musil
On Thu, May 18, 2023 at 11:00 PM Ilya Maximets wrote: > On 5/18/23 17:53, Ilya Maximets wrote: > > On 3/23/23 16:09, Ales Musil wrote: > >> +log_received_backtrace(int fd) { > > > > '{' should be on a separate line. > > > >> +struct backtrace bt; > >> + > >> +if (read_received_backtrace(f