Re: [ovs-dev] [PATCH v4 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

2023-05-22 Thread Nobuhiro MIKI
On 2023/05/22 12:09, Nobuhiro MIKI wrote: > On 2023/05/20 3:56, Ilya Maximets wrote: >> On 5/16/23 07:33, Nobuhiro MIKI wrote: >>> For tunnels such as SRv6, some popular vendor appliances support >>> IPv6 flowlabel based load balancing. In preparation for OVS to >>> support it, this patch modifies

Re: [ovs-dev] [PATCH v3] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-22 Thread Eelco Chaudron
On 19 May 2023, at 12:31, Frode Nordahl wrote: > On Fri, May 19, 2023 at 11:55 AM Eelco Chaudron wrote: >> >> >> >> On 15 May 2023, at 10:04, Frode Nordahl wrote: >> >>> The tc module combines the use of the `tc_transact` helper >>> function for communication with the in-kernel tc infrastructur

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

2023-05-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > > On 19 May 2023, at 16:53, Russell Bryant wrote: > > The following document discusses emeritus committer status: > > https://docs.openvswitch.org/en/latest/internals/committer-emeritus-status/ > > There are several people who I would guess consider themsel

Re: [ovs-dev] [PATCH v3] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-22 Thread Frode Nordahl
On Mon, May 22, 2023 at 11:33 AM Eelco Chaudron wrote: > > > > On 19 May 2023, at 12:31, Frode Nordahl wrote: > > > On Fri, May 19, 2023 at 11:55 AM Eelco Chaudron wrote: > >> > >> > >> > >> On 15 May 2023, at 10:04, Frode Nordahl wrote: > >> > >>> The tc module combines the use of the `tc_transa

Re: [ovs-dev] [PATCH v4 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-22 Thread Ilya Maximets
On 5/22/23 07:05, Nobuhiro MIKI wrote: > On 2023/05/20 10:12, Ilya Maximets wrote: >> On 5/20/23 02:34, Ilya Maximets wrote: >>> On 5/16/23 07:33, Nobuhiro MIKI wrote: It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implemente

Re: [ovs-dev] [PATCH v4 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

2023-05-22 Thread Ilya Maximets
On 5/22/23 10:17, Nobuhiro MIKI wrote: > On 2023/05/22 12:09, Nobuhiro MIKI wrote: >> On 2023/05/20 3:56, Ilya Maximets wrote: >>> On 5/16/23 07:33, Nobuhiro MIKI wrote: For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation fo

Re: [ovs-dev] [PATCH ovn v2 5/6] Implement MTU Path Discovery for multichassis ports

2023-05-22 Thread Dumitru Ceara
On 5/17/23 18:46, Ihar Hrachyshka wrote: > Thank you Dumitru! See below. > > On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote: >> I'm not necessarily rejecting this change. I just wanted to bring up an >> alternative approach (I'm not sure if it's possible to implement it though): >> >> The C

Re: [ovs-dev] [PATCH ovn v2 2/6] Track interface MTU in if-status-mgr

2023-05-22 Thread Dumitru Ceara
On 5/17/23 21:34, Ihar Hrachyshka wrote: > On Tue, May 16, 2023 at 9:40 AM Dumitru Ceara wrote: >> >> On 5/3/23 22:13, Ihar Hrachyshka wrote: >>> This will be used in a later patch to calculate the effective interface >>> MTU after considering tunneling overhead. >>> >>> Signed-off-by: Ihar Hrachy

Re: [ovs-dev] [PATCH ovn v2 6/6] Update multichassis physical flows on interface MTU update

2023-05-22 Thread Dumitru Ceara
On 5/17/23 21:53, Ihar Hrachyshka wrote: > On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote: >> >> On 5/3/23 22:13, Ihar Hrachyshka wrote: >>> Make ICMP Path MTU Discovery flows in table=38 react to underlying >>> interface MTU update. >>> >>> NOTE: ideally, OVN would support Logical_Port MTU,

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-22 Thread Dumitru Ceara
On 5/19/23 20:24, Vladislav Odintsov wrote: > Finally, I’ve managed to find the correct place for this change. > I’ve submitted a patch series here: [1] > > Thanks Dumitru, your help was very valuable! > I’d be glad if you can find some time to review this series. :) > Hi Vladislav, I'll try to

Re: [ovs-dev] [PATCH ovn v2 5/6] Implement MTU Path Discovery for multichassis ports

2023-05-22 Thread Ihar Hrachyshka
On Mon, May 22, 2023 at 7:55 AM Dumitru Ceara wrote: > > On 5/17/23 18:46, Ihar Hrachyshka wrote: > > Thank you Dumitru! See below. > > > > On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote: > >> I'm not necessarily rejecting this change. I just wanted to bring up an > >> alternative approach

Re: [ovs-dev] [PATCH ovn v2 5/6] Implement MTU Path Discovery for multichassis ports

2023-05-22 Thread Dumitru Ceara
On 5/22/23 15:42, Ihar Hrachyshka wrote: > On Mon, May 22, 2023 at 7:55 AM Dumitru Ceara wrote: >> >> On 5/17/23 18:46, Ihar Hrachyshka wrote: >>> Thank you Dumitru! See below. >>> >>> On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote: I'm not necessarily rejecting this change. I just wan

Re: [ovs-dev] [PATCH v3] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-22 Thread Eelco Chaudron
On 22 May 2023, at 12:32, Frode Nordahl wrote: > On Mon, May 22, 2023 at 11:33 AM Eelco Chaudron wrote: >> >> >> >> On 19 May 2023, at 12:31, Frode Nordahl wrote: >> >>> On Fri, May 19, 2023 at 11:55 AM Eelco Chaudron wrote: On 15 May 2023, at 10:04, Frode Nordahl wrote: >>

Re: [ovs-dev] [PATCH ovn v2 5/6] Implement MTU Path Discovery for multichassis ports

2023-05-22 Thread Ihar Hrachyshka
On Mon, May 22, 2023 at 9:55 AM Dumitru Ceara wrote: > > On 5/22/23 15:42, Ihar Hrachyshka wrote: > > On Mon, May 22, 2023 at 7:55 AM Dumitru Ceara wrote: > >> > >> On 5/17/23 18:46, Ihar Hrachyshka wrote: > >>> Thank you Dumitru! See below. > >>> > >>> On Tue, May 16, 2023 at 9:41 AM Dumitru Cea

Re: [ovs-dev] [PATCH v3] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-22 Thread Frode Nordahl
On Mon, May 22, 2023 at 4:31 PM Eelco Chaudron wrote: > > > > On 22 May 2023, at 12:32, Frode Nordahl wrote: > > > On Mon, May 22, 2023 at 11:33 AM Eelco Chaudron wrote: > >> > >> > >> > >> On 19 May 2023, at 12:31, Frode Nordahl wrote: > >> > >>> On Fri, May 19, 2023 at 11:55 AM Eelco Chaudron

Re: [ovs-dev] [PATCH ovn v4 0/5] Implement MTU Path Discovery for multichassis ports

2023-05-22 Thread Mark Michelson
Hi Ihar, Acked-by: Mark Michelson I'm going to wait on merging this since I know others had looked at v1-v3, so I'm going to give them an opportunity to have another look if they want. On 5/18/23 06:56, Ihar Hrachyshka wrote: This series fixes a non-optimal behavior with some multichassis

[ovs-dev] [PATCH ovn] controller: Ignore DNS queries with RRs

2023-05-22 Thread Brian Haley
DNS queries with optional records (RRs), for example, with cookies for EDNS, are not supported by the OVN resolver. Trying to reply sometimes results in mangled responses that clients do not understand. Instead, just return early when one is present, which should trigger a negative response and ca

[ovs-dev] [PATCH ovn v2] controller: Ignore DNS queries with RRs

2023-05-22 Thread Brian Haley
DNS queries with optional records (RRs), for example, with cookies for EDNS, are not supported by the OVN resolver. Trying to reply sometimes results in mangled responses that clients do not understand. Instead, just return early when one is present, which should trigger a negative response and ca

[ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check

2023-05-22 Thread Vladislav Odintsov
Depending on the udp service, it can reply with some udp data. In that case ovn-controller will warn with next message: pinctrl(ovn_pinctrl0)|WARN|handle service check: Unsupported protocol - [11] With this patch ovn-controller ignores UDP packets, which came to pinctrl_handle_svc_check(). This

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation with patch port and controller.

2023-05-22 Thread Paolo Valerio
Ilya Maximets writes: > On 5/15/23 17:22, Paolo Valerio wrote: >> If a packet originating from the controller recirculates after going >> through a patch port, it gets dropped with the following message: >> >> ofproto_dpif_upcall(handler8)|INFO|received packet on unassociated >> datapath port

Re: [ovs-dev] [PATCH v4 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-22 Thread Nobuhiro MIKI
On 2023/05/22 20:41, Ilya Maximets wrote: > On 5/22/23 07:05, Nobuhiro MIKI wrote: >> On 2023/05/20 10:12, Ilya Maximets wrote: >>> On 5/20/23 02:34, Ilya Maximets wrote: On 5/16/23 07:33, Nobuhiro MIKI wrote: > It supports flowlabel based load balancing by controlling the flowlabel >

[ovs-dev] [PATCH v5 0/3] Support flowlabel calculation in SRv6 tunnels

2023-05-22 Thread Nobuhiro MIKI
This patchset adds a feature to support the calculation of flowlabel in SRv6 tunnels. v5: * Write netdev_srv6_flowlabel enum to ipv6 flowlabel in header build. * Fix docs. * Add tests for the same flow. v4: * Set flowlabel on header push. * Fix docs. * Use RSS hash. v3: * Fix building error (spars

[ovs-dev] [PATCH v5 1/3] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

2023-05-22 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 23 +-

[ovs-dev] [PATCH v5 2/3] netdev-native-tnl: Add ipv6_label param in netdev_tnl_ip_build_header.

2023-05-22 Thread Nobuhiro MIKI
For tunnels such as SRv6, some popular vendor appliances support IPv6 flowlabel based load balancing. In preparation for OVS to support it, this patch modifies the encapsulation to allow IPv6 flowlabel to be configured. Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 13 +++--

[ovs-dev] [PATCH v5 3/3] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

2023-05-22 Thread Nobuhiro MIKI
It supports flowlabel based load balancing by controlling the flowlabel of outer IPv6 header, which is already implemented in Linux kernel as seg6_flowlabel sysctl [1]. [1]: https://docs.kernel.org/networking/seg6-sysctl.html Signed-off-by: Nobuhiro MIKI --- lib/netdev-native-tnl.c | 35 +