On 8/8/23 16:53, Aaron Conole wrote:
Adrian Moreno writes:
From: Eric Garver
From: Eric Garver
This adds an explicit drop action. This is used by OVS to drop packets
for which it cannot determine what to do. An explicit action in the
kernel allows passing the reason _why_ the packet is b
On 8/8/23 20:02, Ilya Maximets wrote:
On 8/7/23 18:45, Adrian Moreno wrote:
Create a new drop reason subsystem for openvswitch and add the first
drop reason to represent flow drops.
A flow drop happens when a flow has an empty action-set or there is no
action that consumes the packet (output,
again, I forget the fixes tag ...
0-day Robot 于2023年8月9日周三 11:19写道：
> Bleep bloop. Greetings Peng He, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> ERROR: Author
Add config option called "northd-backoff-interval-ms" that allows
to delay northd engine runs capped by the config option.
When the config option is set to 0 or unspecified, the engine
will run without any restrictions. If the value >0 we will delay
northd engine run by the previous run time capped
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
WARNING: Unexpected sign-offs from developers who are not a
OVS allows overlapping megaflows, as long as the actions of these
megaflows are equal. However, the current implementation of action
modification relies on flow_lookup instead of ufid, this could result
in looking up a wrong megaflow and make the ukeys and megaflows inconsistent
Just like the test
Actually I meet the problem with IPIP.
The IGMP/UDPLITE/SCTP are added because they are supported in tc csum action
now.
From: Simon Horman
Date: 2023-08-04 23:33:43
To: Faicker Mo
Cc: d...@openvswitch.org,i.maxim...@ovn.org
Subject: Re: [ovs-dev] [PATCH v2 1/2] netdev-tc-offload: Add csum
Did some digging: (I was able to compile from a shell, using msbuild)
cd "C:\Program Files (x86)\Microsoft Visual
Studio\2019\Community\MSBuild\Current\Bin\amd64"
.\MSBuild.exe "C:\openvswitch\datapath-windows\ovsext.sln"
Installed sshd using instructions from the following:
https://www.youtube.
I have a Windows kernel build setup for OVS.
Are there any instructions for building via the command line? I feel
constrained in MSVC GUI.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 8/2/23 10:27, Robin Jarry wrote:
> Quoting Paul Ganssle, setuptools maintainer:
>> * The setuptools project has stopped maintaining all direct
>> invocations of setup.py years ago, and distutils is deprecated.
>> There are undoubtedly many ways that your setup.py-based system is
>> broken
On 8/2/23 10:27, Robin Jarry wrote:
> setup.py upload is now deprecated. When used, pypi.org returns an error:
>
>> Upload failed (400): Invalid value for blake2_256_digest. Error: Use
>> a valid, hex-encoded, BLAKE2 message digest.
Nit: It might be better to just use 2-space indentation or some
On 8/2/23 10:27, Robin Jarry wrote:
Hi, Robin. Thanks for the fix!
> The python/build folder contents are completely unrelated to the ovs
> python bindings. These files are only used during the build for various
> subsystems (docs, man pages, code generation, etc.).>
> Having that folder in tha
On Tue, Aug 8, 2023 at 1:15 PM Han Zhou wrote:
>
> On Thu, Aug 3, 2023 at 12:29 PM wrote:
> >
> > From: Numan Siddique
> >
> > When a logical switch has only router ports and if a new VIF port is
> > added, both northd engine and lflow engine handle this change
> > incrementally, but it misses o
On 8/7/23 18:45, Adrian Moreno wrote:
> From: Eric Garver
>
> From: Eric Garver
>
> This adds an explicit drop action. This is used by OVS to drop packets
> for which it cannot determine what to do. An explicit action in the
> kernel allows passing the reason _why_ the packet is being dropped o
On 8/7/23 18:45, Adrian Moreno wrote:
> Create a new drop reason subsystem for openvswitch and add the first
> drop reason to represent flow drops.
>
> A flow drop happens when a flow has an empty action-set or there is no
> action that consumes the packet (output, userspace, recirc, etc).
>
> Im
Bleep bloop. Greetings miter, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#126 FILE: lib/netdev-dpdk.c:629:
kpkts_p
Bleep bloop. Greetings miter, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#84 FILE: NEWS:66:
* Added new Qos t
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
nati
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
nat
From: Lin Huang
v8->v9: fix qos.rst:40:Title underline too short.
v7->v8: fix cody by reviewing.
v6->v7: split pps and bps policer.
v5->v6: fix code by reviewing.
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of dropped packets, and drop that.
v4->
From: Lin Huang
Currently srtcm_policer free packet one by one, if packets are exceed rate
limit.
This patch change srtcm_policer to free pkts by bulk using
rte_pktmbuf_free_bulk().
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(
Adrian Moreno writes:
> Test if the correct drop reason is reported when OVS drops a packet due
> to an explicit flow.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.o
Adrian Moreno writes:
> Make ovs-dpctl.py support explicit drops as:
> "drop" -> implicit empty-action drop
> "drop(0)" -> explicit non-error action drop
I also suggest a test in netlink_checks to make sure drop can't be
followed by additional actions. Something like:
3,drop(0),2
which shou
Adrian Moreno writes:
> Use drop reasons from include/net/dropreason-core.h when a reasonable
> candidate exists.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/ma
Adrian Moreno writes:
> By using an independent drop reason it makes it easy to ditinguish
nit: distinguish
> between QoS-triggered or flow-triggered drop.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
> net/openvswitch/actions.c | 2 +-
> net/openvswitch/drop.h| 1 +
>
Adrian Moreno writes:
> From: Eric Garver
>
> From: Eric Garver
>
> This adds an explicit drop action. This is used by OVS to drop packets
> for which it cannot determine what to do. An explicit action in the
> kernel allows passing the reason _why_ the packet is being dropped or
> zero to indi
Adrian Moreno writes:
> Add a drop reason for packets that are dropped because an action
> returns a non-zero error code.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitc
Adrian Moreno writes:
> Create a new drop reason subsystem for openvswitch and add the first
> drop reason to represent flow drops.
>
> A flow drop happens when a flow has an empty action-set or there is no
> action that consumes the packet (output, userspace, recirc, etc).
>
> Implementation-wis
On Tue, Aug 8, 2023 at 3:14 PM Ilya Maximets wrote:
>
> On 8/8/23 09:17, David Marchand wrote:
> > On Thu, Jul 13, 2023 at 11:02 AM Viacheslav Galaktionov via dev
> > wrote:
> >>
> >> The set_error function is now used regardless of whether experimental APIs
> >> are allowed or not, so it must be
On 8/8/23 09:17, David Marchand wrote:
> On Thu, Jul 13, 2023 at 11:02 AM Viacheslav Galaktionov via dev
> wrote:
>>
>> The set_error function is now used regardless of whether experimental APIs
>> are allowed or not, so it must be defined unconditionally.
>>
>> Fixes: fc06ea9a1883 ("netdev-dpdk:
On 8/8/23 09:20, Peng He wrote:
>
>
> Ilya Maximets mailto:i.maxim...@ovn.org>> 于2023年8月8日周二
> 07:30写道：
>
> On 7/31/23 06:55, Peng He wrote:
> > OVS allows overlapping megaflows, as long as the actions of these
> > megaflows are equal. However, the current implementation of action
>
On 8/8/23 05:50, Numan Siddique wrote:
> On Mon, Aug 7, 2023 at 4:45 PM Dumitru Ceara wrote:
>>
>> On 8/4/23 21:24, num...@ovn.org wrote:
>>> From: Numan Siddique
>>>
>>> When adding the arp req lflows in the 'ls_in_l2_lkup' stage for the
>>> load balancer VIPs associated to a logical router we i
On Thu, Aug 3, 2023 at 12:29 PM wrote:
>
> From: Numan Siddique
>
> When a logical switch has only router ports and if a new VIF port is
> added, both northd engine and lflow engine handle this change
> incrementally, but it misses out on adding a few logical flows
> where we have checks like :
>
Ilya Maximets 于2023年8月8日周二 07:30写道：
> On 7/31/23 06:55, Peng He wrote:
> > OVS allows overlapping megaflows, as long as the actions of these
> > megaflows are equal. However, the current implementation of action
> > modification relies on flow_lookup instead of ufid, this could result
> > in look
On Thu, Jul 13, 2023 at 11:02 AM Viacheslav Galaktionov via dev
wrote:
>
> The set_error function is now used regardless of whether experimental APIs
> are allowed or not, so it must be defined unconditionally.
>
> Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.")
> Signed
36 matches
Mail list logo
