[ovs-dev] [PATCH v2 2/3] dpctl, ovs-ofctl: Unify parsing of ct-flush arguments.

In order to make the command extensible unify the arguments parsing into single function. This will be later on used for the mark and labels arguments. Signed-off-by: Ales Musil --- include/openvswitch/ofp-ct.h | 5 ++-- lib/dpctl.c | 41 --- lib/ofp

[ovs-dev] [PATCH v2 3/3] openflow: Allow CT flush to match on mark and labels.

Extend the current NX_CT_FLUSH with four additional fields, that allow to match on CT entry "mark" or "labels". This is encoded as separate TLV values which is backward compatible. Versions that do not support them will simply ignore it. Extend also the ovs-dpctl and ovs-ofctl command line tools w

[ovs-dev] [PATCH v2 1/3] ofp-prop: Add helper for parsing and storing of ovs_u128.

Add helper methods that allow us to store and parse the ovs_u128 type. Signed-off-by: Ales Musil --- v2: Add missing ofpprop_parse_be128() function. --- include/openvswitch/ofp-prop.h | 5 lib/ofp-prop.c | 44 ++ 2 files changed, 49 insertion

Re: [ovs-dev] [PATCH v3] ofproto-dpif-mirror: Add support for pre-selection filter

On 3 Oct 2023, at 18:14, Mike Pattrick wrote: > On Mon, Oct 2, 2023 at 6:07 AM Simon Horman wrote: >> >> On Fri, Sep 08, 2023 at 12:28:24PM -0400, Mike Pattrick wrote: >>> Currently a bridge mirror will collect all packets and tools like >>> ovs-tcpdump can apply additional filters after they h

[ovs-dev] [PATCH ovn] northd: Incrementally process SB.Load_balancer updates.

Commit 9deb000536e0 ("northd: Remove potential duplicates in SB Load_Balancer table.") added code to northd to ensure that SB duplicates get removed. Quoting from that commit message: The Southbound Load_Balancer table (like the Northbound one) doesn't define an index (e.g., by name). Th

Re: [ovs-dev] [PATCH v3 branch-2.17 2/2] conntrack: Remove nat_conn introducing key directionality.

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH v3 branch-2.17 2/2] conntrack: Remove nat_conn introducing key directionality.

From: Peng He The patch avoids the extra allocation for nat_conn. Currently, when doing NAT, the userspace conntrack will use an extra conn for the two directions in a flow. However, each conn has actually the two keys for both orig and rev directions. This patch introduces a key_node[CT_DIRS] me

[ovs-dev] [PATCH v3 branch-2.17 1/2] conntrack: simplify cleanup path

The conntrack cleanup and allocation code is spread across multiple list invocations. This was changed in mainline code when the timeout expiration lists were refactored, but backporting those fixes would be a rather large effort. Instead, take only the changes we need to backport "contrack: Remo

Re: [ovs-dev] [PATCH v3] ofproto-dpif-mirror: Add support for pre-selection filter

On Mon, Oct 2, 2023 at 6:07 AM Simon Horman wrote: > > On Fri, Sep 08, 2023 at 12:28:24PM -0400, Mike Pattrick wrote: > > Currently a bridge mirror will collect all packets and tools like > > ovs-tcpdump can apply additional filters after they have already been > > duplicated by vswitchd. This can

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

On 19 Jun 2023, at 12:18, Chris Mi wrote: > On 6/19/2023 6:04 PM, Eelco Chaudron wrote: >> >> On 19 Jun 2023, at 7:05, Chris Mi wrote: >> >>> Add three sFlow offload test cases: >>> >>>3: offloads - sflow with sampling=1 - offloads enabled ok >>>4: offloads - sflow with sampling=2 - off

Re: [ovs-dev] [PATCH 1/1] tests/tunnel.at: Add geneve options mirror test

Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: tests/tunnel.at: Add geneve options mi

[ovs-dev] [PATCH 1/1] tests: Update some tests title prefix print.

Use test title prefix according to filename the test is in for tunnel.at and ofproto-dpif.at. Signed-off-by: Roi Dayan --- tests/ofproto-dpif.at | 6 +++--- tests/tunnel.at | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at

Re: [ovs-dev] [PATCH 1/1] tests/tunnel.at: Add geneve options mirror test

On 03/10/2023 16:54, Roi Dayan wrote: > Test geneve options mirror flow doesn't add redundant mirror. > > Signed-off-by: Roi Dayan > --- > tests/tunnel.at | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/tests/tunnel.at b/tests/tunnel.at > index ddeb66bc

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On 10/3/23 15:46, Ales Musil wrote: > > > On Tue, Oct 3, 2023 at 3:40 PM Ilya Maximets > wrote: > > On 10/3/23 07:56, Ales Musil wrote: > > Extend the current NX_CT_FLUSH with four additional fields, > > that allow to match on CT entry "mark" or "labels".

[ovs-dev] [PATCH ovn] system-tests: Make sure that IPv6 address is available right away

Instead of waiting for the address duplication check to finish request that the check is not performed at all. With that we don't have to wait for the "tentative" state to go away and the address is usable right away. Remove check for the link-local address where it is not needed as the wait was ta

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

On 03/10/2023 15:22, Ilya Maximets wrote: > On 10/3/23 10:33, Roi Dayan wrote: >> The cited commit fixed missing mirror packets by reset mirror when >> packets are modified but setting geneve options was also treated as >> a modified packet but should be treated as a part of set_tunnel >> which d

[ovs-dev] [PATCH 1/1] tests/tunnel.at: Add geneve options mirror test

Test geneve options mirror flow doesn't add redundant mirror. Signed-off-by: Roi Dayan --- tests/tunnel.at | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/tunnel.at b/tests/tunnel.at index ddeb66bc9fb7..c0b932110446 100644 --- a/tests/tunnel.at +++ b/test

Re: [ovs-dev] [PATCH v2] tests: Add some tests for byteq module

On 30 Sep 2023, at 10:07, James R T wrote: > On Thu, Sep 28, 2023 at 8:28 PM Eelco Chaudron wrote: >> >> Move stuff in alphabetical order: >> >> #include >> #undef NDEBUG >> #include >> #include >> #include >> #include >> #include >> #include "byteq.h" >> #include "ovstest.h" >> #include

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 3, 2023 at 3:40 PM Ilya Maximets wrote: > On 10/3/23 07:56, Ales Musil wrote: > > Extend the current NX_CT_FLUSH with four additional fields, > > that allow to match on CT entry "mark" or "labels". This > > is encoded as separate TLV values which is backward compatible. > > Versions t

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On 10/3/23 07:56, Ales Musil wrote: > Extend the current NX_CT_FLUSH with four additional fields, > that allow to match on CT entry "mark" or "labels". This > is encoded as separate TLV values which is backward compatible. > Versions that do not support them will simply ignore it. > > Extend also

Re: [ovs-dev] [RFC PATCH 0/7] net: openvswitch: Reduce stack usage

Ilya Maximets writes: > On 9/29/23 09:06, Nicholas Piggin wrote: >> On Wed Sep 27, 2023 at 6:36 PM AEST, Ilya Maximets wrote: >>> On 9/27/23 02:13, Nicholas Piggin wrote: Hi, We've got a report of a stack overflow on ppc64le with a 16kB kernel stack. Openvswitch is just one of

Re: [ovs-dev] [PATCH v2 branch-2.17 2/2] conntrack: Remove nat_conn introducing key directionality.

Simon Horman writes: > On Wed, Sep 27, 2023 at 11:31:22AM -0400, Aaron Conole wrote: >> From: Peng He >> >> The patch avoids the extra allocation for nat_conn. >> Currently, when doing NAT, the userspace conntrack will use an extra >> conn for the two directions in a flow. However, each conn ha

Re: [ovs-dev] [PATCH 1/2] ofp-prop: Add helper for parsing and storing of ovs_u128.

On Tue, Oct 3, 2023 at 3:01 PM Ilya Maximets wrote: > > On 10/3/23 07:56, Ales Musil wrote: > > Add helper methods that allow us to store and parse the > > ovs_u128 type. > > > > Signed-off-by: Ales Musil > > --- > > include/openvswitch/ofp-prop.h | 3 +++ > > lib/ofp-prop.c | 3

Re: [ovs-dev] [PATCH 1/2] ofp-prop: Add helper for parsing and storing of ovs_u128.

On 10/3/23 07:56, Ales Musil wrote: > Add helper methods that allow us to store and parse the > ovs_u128 type. > > Signed-off-by: Ales Musil > --- > include/openvswitch/ofp-prop.h | 3 +++ > lib/ofp-prop.c | 30 ++ > 2 files changed, 33 insertions(+)

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 3, 2023 at 2:28 PM Ilya Maximets wrote: > On 10/3/23 10:33, Simon Horman wrote: > > On Tue, Oct 03, 2023 at 10:18:45AM +0200, Ales Musil wrote: > >> On Tue, Oct 3, 2023 at 10:14 AM Simon Horman wrote: > >> > >>> On Tue, Oct 03, 2023 at 07:56:30AM +0200, Ales Musil wrote: > Exten

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On 10/3/23 10:33, Simon Horman wrote: > On Tue, Oct 03, 2023 at 10:18:45AM +0200, Ales Musil wrote: >> On Tue, Oct 3, 2023 at 10:14 AM Simon Horman wrote: >> >>> On Tue, Oct 03, 2023 at 07:56:30AM +0200, Ales Musil wrote: Extend the current NX_CT_FLUSH with four additional fields, that a

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

On 10/3/23 10:33, Roi Dayan wrote: > The cited commit fixed missing mirror packets by reset mirror when > packets are modified but setting geneve options was also treated as > a modified packet but should be treated as a part of set_tunnel > which doesn't reset mirror. > > Fixes: 1437f51fea92 ("of

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Use helpers from committed connections.

On 9/29/23 17:02, Simon Horman wrote: On Mon, Sep 04, 2023 at 07:45:07PM +0400, Viacheslav Galaktionov via dev wrote: Currently, if the user wants to track related connections, they have to specify a helper in all CT actions, which contradicts the behaviour described in the documentation. Fix t

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

On Tue, Oct 03, 2023 at 01:51:34PM +0300, Roi Dayan wrote: > > On 03/10/2023 13:36, Simon Horman wrote: > > On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: > >> The cited commit fixed missing mirror packets by reset mirror when > >> packets are modified but setting geneve option

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

On 03/10/2023 13:36, Simon Horman wrote: > On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: >> The cited commit fixed missing mirror packets by reset mirror when >> packets are modified but setting geneve options was also treated as >> a modified packet but should be treated as

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: > The cited commit fixed missing mirror packets by reset mirror when > packets are modified but setting geneve options was also treated as > a modified packet but should be treated as a part of set_tunnel > which doesn't reset mirro

Re: [ovs-dev] [PATCH] ofproto-dpif: remove checking setting nd_ext field

On Mon, Sep 28, 2020 at 09:49:47PM +0800, fankaixi...@bytedance.com wrote: > From: "fankaixi.li" > > In order to support openflow rule which setting nd_ext fields in openflow > tables, > we should remove setting nd_ext fields when constructing rule. The ofproto > would > translate it into users

Re: [ovs-dev] [PATCH v3] userspace: fix bad UDP performance issue of veth

On Thu, Sep 24, 2020 at 10:05:16AM +0800, yang_y...@163.com wrote: > From: Yi Yang > > iperf3 UDP performance of veth to veth case is > very very bad because of too many packet loss, > the root cause is rmem_default and wmem_default > are just 212992, but iperf3 UDP test used 8K > UDP size which

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix tun_metadata match after recirc

On Thu, Aug 20, 2020 at 03:45:22PM -0700, Yi-Hung Wei wrote: > Consider the following OpenFlow rules that match on tun_metadata0 after > recirculation. If we start ICMP flow with tun_metadata0=0x1 follow by > a flow with tun_metadata0=0x3, OVS will incorrectly match the second > flow with the tun_

Re: [ovs-dev] [PATCH] connmgr: fix flow-restore-wait not work with controller connects

On Sat, May 09, 2020 at 05:32:22PM +0800, we...@ucloud.cn wrote: > From: wenxu > > When restart the vswitchd with flow-restore-wait. The Vswitch doesn't > connect to the controller util the flow-restore-wait finished. > > Because when bridge_configure_remotes() calls bridge_get_controllers(), >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Check mirror port before do terminate_native_tunnel

On Fri, Jul 26, 2019 at 08:18:39PM +0800, Wang Li wrote: > From: Wang Li > > The problem is the ovs-tcpdump can not capture the ingress vxlan traffics > when it listens on the dpdk port, and the following dump-flows described > the details: > > ovs-tcpdump stopped: > recirc_id(0),in_port(2),pack

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 03, 2023 at 10:18:45AM +0200, Ales Musil wrote: > On Tue, Oct 3, 2023 at 10:14 AM Simon Horman wrote: > > > On Tue, Oct 03, 2023 at 07:56:30AM +0200, Ales Musil wrote: > > > Extend the current NX_CT_FLUSH with four additional fields, > > > that allow to match on CT entry "mark" or "la

[ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

The cited commit fixed missing mirror packets by reset mirror when packets are modified but setting geneve options was also treated as a modified packet but should be treated as a part of set_tunnel which doesn't reset mirror. Fixes: 1437f51fea92 ("ofproto-dpif-upcall: Mirror packets that are modi

Re: [ovs-dev] [PATCH v5 1/1] dpif-netdev: Add per pmd sleep config.

On Fri, Sep 29, 2023 at 01:50:10PM +0100, Kevin Traynor wrote: > Extend 'pmd-sleep-max' so that individual PMD thread cores > may have a specified max sleep request value. > > Existing behaviour is maintained. > > Any PMD thread core without a value will use the global value > if set or default n

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 3, 2023 at 10:14 AM Simon Horman wrote: > On Tue, Oct 03, 2023 at 07:56:30AM +0200, Ales Musil wrote: > > Extend the current NX_CT_FLUSH with four additional fields, > > that allow to match on CT entry "mark" or "labels". This > > is encoded as separate TLV values which is backward co

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 03, 2023 at 07:56:30AM +0200, Ales Musil wrote: > Extend the current NX_CT_FLUSH with four additional fields, > that allow to match on CT entry "mark" or "labels". This > is encoded as separate TLV values which is backward compatible. > Versions that do not support them will simply igno

Re: [ovs-dev] [PATCH 1/2] ofp-prop: Add helper for parsing and storing of ovs_u128.

On Tue, Oct 03, 2023 at 07:56:29AM +0200, Ales Musil wrote: > Add helper methods that allow us to store and parse the > ovs_u128 type. > > Signed-off-by: Ales Musil Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvsw

Re: [ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

On 2023/10/02 20:41, Simon Horman wrote: > + Mike Pattrick > > On Mon, Sep 25, 2023 at 06:09:00PM +0900, Nobuhiro MIKI wrote: >> A conjunctive flow consists of two or more multiple flows with >> conjunction actions. When input to the ofproto/trace command >> matches a conjunctive flow, it outputs