Re: [ovs-dev] [PATCH ovn v2] fix a copy-paste typo

Sure, you are welcome. > Thank you Igor, > > Acked-by: Mark Michelson > > On 10/19/23 00:31, Igor Zhukov wrote: > >> Although this typo does not cause a real error. >> >> Look at my test: https://gcc.godbolt.org/z/hdKc389vd >> >> Signed-off-by: Igor Zhukov >> --- >> controller/ofctrl.c | 2

Re: [ovs-dev] [PATCH v3] Implement ovstest test-odp hexify-keys [--bad-csum].

On Fri, Oct 20, 2023 at 6:53 PM Ilya Maximets wrote: > On 10/21/23 00:40, Ihar Hrachyshka wrote: > > On Fri, Oct 20, 2023 at 6:02 PM Ilya Maximets > wrote: > > > > On 10/20/23 15:15, Ihar Hrachyshka wrote: > > > On Thu, Oct 19, 2023 at 6:29 PM Ilya Maximets

Re: [ovs-dev] [PATCH ovn] tests: Add missing check for scapy.

On Fri, Oct 20, 2023 at 5:42 PM Ilya Maximets wrote: > On 10/20/23 21:43, Ihar Hrachyshka wrote: > > On Fri, Oct 20, 2023 at 12:26 PM Mark Michelson > wrote: > > > >> The "IPv6 ND Router Solicitation responder" test was altered to test > >> more cases. When the test was updated, the author

Re: [ovs-dev] [PATCH] tc: Improve logging of mismatched actions.

On 10/19/23 13:27, Simon Horman wrote: > On Wed, Oct 18, 2023 at 10:46:10PM +0200, Ilya Maximets wrote: >> Currently we log the 980-ish byte long tc_action structure as a >> single long hex string. That is very hard to read and hard to >> spot the difference between two. And most of the fields

[ovs-dev] [PATCH] tests/system-traffic: Ensure no name resolution for tcpdump.

Depending on system configuration, executing tcpdump without the -n parameter, may prolong the execution time for tcpdump while it attempts name resolution. This delay may in turn lead to test failures due to contents of tables to check being evicted. We recently started to see this problem with

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Pause revalidators when purging.

On 10/20/23 14:41, Simon Horman wrote: > On Thu, Oct 19, 2023 at 03:27:29PM +0200, Eelco Chaudron wrote: >> >> >> On 18 Oct 2023, at 16:23, David Marchand wrote: >> >>> This issue has been observed when running traffic tests with a dpdk >>> enabled userspace datapath (though those tests are added

Re: [ovs-dev] [PATCH v3] Implement ovstest test-odp hexify-keys [--bad-csum].

On 10/21/23 00:40, Ihar Hrachyshka wrote: > On Fri, Oct 20, 2023 at 6:02 PM Ilya Maximets > wrote: > > On 10/20/23 15:15, Ihar Hrachyshka wrote: > > On Thu, Oct 19, 2023 at 6:29 PM Ilya Maximets

Re: [ovs-dev] [PATCH v3] Implement ovstest test-odp hexify-keys [--bad-csum].

On Fri, Oct 20, 2023 at 6:02 PM Ilya Maximets wrote: > On 10/20/23 15:15, Ihar Hrachyshka wrote: > > On Thu, Oct 19, 2023 at 6:29 PM Ilya Maximets > wrote: > > > > On 10/19/23 16:11, Ihar Hrachyshka wrote: > > > The command reads a flow string and an optional

Re: [ovs-dev] [PATCH v3] Implement ovstest test-odp hexify-keys [--bad-csum].

On 10/20/23 15:15, Ihar Hrachyshka wrote: > On Thu, Oct 19, 2023 at 6:29 PM Ilya Maximets > wrote: > > On 10/19/23 16:11, Ihar Hrachyshka wrote: > > The command reads a flow string and an optional additional payload on > > stdin and produces a hex-string

Re: [ovs-dev] [PATCH ovn] tests: Add missing check for scapy.

On 10/20/23 21:43, Ihar Hrachyshka wrote: > On Fri, Oct 20, 2023 at 12:26 PM Mark Michelson wrote: > >> The "IPv6 ND Router Solicitation responder" test was altered to test >> more cases. When the test was updated, the author updated the test to >> use fmt_pkt instead of constructing the packets

Re: [ovs-dev] [RFC OVN] DHCP Proxy Agent support for overlay subnets

Hi. To confirm, are you trying to implement a (permutation of?) https://www.rfc-editor.org/rfc/rfc3046.html here? If so, the feature should probably be renamed into DHCP Relay Agent support. Please clarify if that's your intent here. Thanks, Ihar On 8/22/23 10:36 PM, naveen.yerramneni

Re: [ovs-dev] [PATCH ovn] controller, northd: Wait for cleanup before replying to exit

On 10/6/23 3:02 AM, Ales Musil wrote: The unixctl exit command would receive reply immediately which is confusing and can cause some issues in some tests if the cleanup takes longer than expected. To avoid that make sure we reply to the exit command only after the main cleanup was done so there

Re: [ovs-dev] [PATCH v3 ovn] controller: split mg action in table 39 and 40 to fit kernel netlink buffer size

Thank you for the follow-up patches, Lorenzo. Acked-by: Mark Michelson On 10/13/23 17:29, Lorenzo Bianconi wrote: Introduce the capability to split multicast group openflow actions created in consider_mc_group routine in multiple buffers if the single buffer size is over netlink buffer size

Re: [ovs-dev] [PATCH ovn] controller, northd: Wait for cleanup before replying to exit

I pushed this to all branches from main back to 22.03. On 10/16/23 14:29, Mark Michelson wrote: Hi Ales, This looks good to me, thanks! Acked-by: Mark Michelson On 10/6/23 03:02, Ales Musil wrote: The unixctl exit command would receive reply immediately which is confusing and can cause

Re: [ovs-dev] [PATCH ovn] tests: Add missing check for scapy.

On Fri, Oct 20, 2023 at 12:26 PM Mark Michelson wrote: > The "IPv6 ND Router Solicitation responder" test was altered to test > more cases. When the test was updated, the author updated the test to > use fmt_pkt instead of constructing the packets by hand. Unfortunately, > this change did not

Re: [ovs-dev] [PATCH ovn v2] fix a copy-paste typo

Thank you Igor, Acked-by: Mark Michelson On 10/19/23 00:31, Igor Zhukov wrote: Although this typo does not cause a real error. Look at my test: https://gcc.godbolt.org/z/hdKc389vd Signed-off-by: Igor Zhukov --- controller/ofctrl.c | 2 +- northd/northd.c | 2 +- 2 files changed, 2

Re: [ovs-dev] [PATCH ovn] tests: Add missing check for scapy.

On 10/20/23 13:09, Ilya Maximets wrote: On 10/20/23 18:25, Mark Michelson wrote: The "IPv6 ND Router Solicitation responder" test was altered to test more cases. When the test was updated, the author updated the test to use fmt_pkt instead of constructing the packets by hand. Unfortunately,

[ovs-dev] [PATCH 2/2] vswitch.xml: Add entry for dpdkvhostuser userspace-tso.

get_status for dpdkvhostuser(/client) netdev class may display userspace-tso status. Fixes: a5669fd51c9b ("netdev-dpdk: Drop TSO in case of conflicting virtio features.") Signed-off-by: Kevin Traynor --- vswitchd/vswitch.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git

[ovs-dev] [PATCH 1/2] vswitch.xml: Add dpdkvhostuser group status.

Add group for dpdkvhostuser(/client) netdev. Adding as a single group as they display the same status, one of which is 'mode' to indicate if it's client or server. Fixes: b2e8b12f8a82 ("netdev-dpdk: add vhost-user get_status.") Signed-off-by: Kevin Traynor --- vswitchd/vswitch.xml | 30

Re: [ovs-dev] [PATCH ovn] tests: Add missing check for scapy.

On 10/20/23 18:25, Mark Michelson wrote: > The "IPv6 ND Router Solicitation responder" test was altered to test > more cases. When the test was updated, the author updated the test to > use fmt_pkt instead of constructing the packets by hand. Unfortunately, > this change did not include the

Re: [ovs-dev] [PATCH 0/7] net: openvswitch: Reduce stack usage

"Nicholas Piggin" writes: > On Wed Oct 11, 2023 at 11:23 PM AEST, Aaron Conole wrote: >> Nicholas Piggin writes: >> >> > Hi, >> > >> > I'll post this out again to keep discussion going. Thanks all for the >> > testing and comments so far. >> >> Thanks for the update - did you mean for this to

Re: [ovs-dev] [PATCH ovn] tests: Add missing check for scapy.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: "Fixes" tag is malformed. Use the following format: git log -1

[ovs-dev] [PATCH ovn] tests: Add missing check for scapy.

The "IPv6 ND Router Solicitation responder" test was altered to test more cases. When the test was updated, the author updated the test to use fmt_pkt instead of constructing the packets by hand. Unfortunately, this change did not include the directive to skip the test if scapy is not installed.

Re: [ovs-dev] [PATCH v3 3/3] system-traffic.at: Test conntrack + FTP server running on a non-standard port.

Viacheslav Galaktionov via dev writes: > All existing test iterations assume that the FTP server is running on a > standard port, which may not always be the case. These tests helped find > problems in conntrack alg processing with non-standard ports. > > Perform the necessary adjustments to

Re: [ovs-dev] [PATCH v3 1/3] ofp-prop: Add helper for parsing and storing of ovs_u128.

On 18 Oct 2023, at 8:28, Ales Musil wrote: > Add helper methods that allow us to store and parse the > ovs_u128 type. > > Signed-off-by: Ales Musil This patch looks good to me. I only reviewed the first patch, as due to a missing cover letter I was fooled and thought this series was all

Re: [ovs-dev] [PATCH v2] Implement ovstest test-odp hexify-keys [--bad-csum].

On Fri, Oct 20, 2023 at 8:40 AM Simon Horman wrote: > On Thu, Oct 19, 2023 at 09:00:39AM -0400, Ihar Hrachyshka wrote: > > On 10/19/23 7:14 AM, Simon Horman wrote: > > > On Thu, Oct 19, 2023 at 02:57:26AM +, Ihar Hrachyshka wrote: > > > > The command reads a flow string and an optional

Re: [ovs-dev] [PATCH v3] Implement ovstest test-odp hexify-keys [--bad-csum].

On Thu, Oct 19, 2023 at 6:29 PM Ilya Maximets wrote: > On 10/19/23 16:11, Ihar Hrachyshka wrote: > > The command reads a flow string and an optional additional payload on > > stdin and produces a hex-string representation of the corresponding > > frame on stdout. It may receive more than a

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Pause revalidators when purging.

On Thu, Oct 19, 2023 at 03:27:29PM +0200, Eelco Chaudron wrote: > > > On 18 Oct 2023, at 16:23, David Marchand wrote: > > > This issue has been observed when running traffic tests with a dpdk > > enabled userspace datapath (though those tests are added in a separate > > series). > > However,

Re: [ovs-dev] [PATCH v2] Implement ovstest test-odp hexify-keys [--bad-csum].

On Thu, Oct 19, 2023 at 09:00:39AM -0400, Ihar Hrachyshka wrote: > On 10/19/23 7:14 AM, Simon Horman wrote: > > On Thu, Oct 19, 2023 at 02:57:26AM +, Ihar Hrachyshka wrote: > > > The command reads a flow string and an optional additional payload on > > > stdin and produces a hex-string

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

Hi David, On Wed, Oct 18, 2023 at 01:49:08PM +0200, David Marchand wrote: > Hello Simon, > > On Fri, Oct 13, 2023 at 2:53 PM David Marchand > wrote: > > On Tue, Oct 10, 2023 at 5:10 PM Simon Horman wrote: > > > > > > On Mon, Oct 09, 2023 at 05:06:51PM +0200, David Marchand wrote: > > > > A

Re: [ovs-dev] [RFC v2 1/1] Add global option to output JSON from ovs-appctl cmds.

On 20 Oct 2023, at 12:43, jm...@redhat.com wrote: > From: Jakob Meng > > This patch follows an alternative approach to RFC [0]. > > For monitoring systems such as Prometheus it would be beneficial if OVS > and OVS-DPDK would expose statistics in a machine-readable format. > Several approaches

Re: [ovs-dev] [RFC v2 1/1] Add global option to output JSON from ovs-appctl cmds.

Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch failed: lib/dpctl.c:2990 error: lib/dpctl.c: patch does not apply error: patch failed:

Re: [ovs-dev] [RFC] Add global option to output JSON from ovs-appctl cmds.

Superseeded by: https://patchwork.ozlabs.org/project/openvswitch/patch/20231020104320.1417664-2-jm...@redhat.com/ ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [RFC v2 0/1] Add global option to output JSON from ovs-appctl cmds.

From: Jakob Meng Follow up to [0] which fixes line endings. https://patchwork.ozlabs.org/project/openvswitch/patch/20231020093954.1410995-1-jm...@redhat.com/ Jakob Meng (1): Add global option to output JSON from ovs-appctl cmds. lib/bfd.c | 16 ++- lib/cfm.c

Re: [ovs-dev] [PATCH v4] bond: Always revalidate unbalanced bonds when active member changes.

On 10/20/23 11:56, Eelco Chaudron wrote: > > > On 19 Oct 2023, at 17:29, Mike Pattrick wrote: > >> On Thu, Oct 19, 2023 at 9:00 AM Eelco Chaudron wrote: >>> >>> >>> >>> On 19 Oct 2023, at 4:37, Mike Pattrick wrote: >>> Currently a bond will not always revalidate when an active member

Re: [ovs-dev] [PATCH v6 3/3] netdev-afxdp: Sync and clean {get, set}_config() callbacks.

On 13/10/2023 10:07, jm...@redhat.com wrote: From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for

Re: [ovs-dev] [PATCH v6 1/3] netdev-dpdk: Sync and clean {get, set}_config() callbacks.

On 13/10/2023 10:07, jm...@redhat.com wrote: From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for

Re: [ovs-dev] [PATCH v6 2/3] netdev-dummy: Sync and clean {get, set}_config() callbacks.

On 13/10/2023 10:07, jm...@redhat.com wrote: From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for

Re: [ovs-dev] [PATCH v6 0/3] netdev: Sync and clean {get, set}_config() callbacks.

On 13/10/2023 10:07, jm...@redhat.com wrote: From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for

Re: [ovs-dev] [RFC] Add global option to output JSON from ovs-appctl cmds.

Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch failed: lib/bfd.c:912 error: lib/bfd.c: patch does not apply error: patch failed:

Re: [ovs-dev] [PATCH v4] bond: Always revalidate unbalanced bonds when active member changes.

On 19 Oct 2023, at 17:29, Mike Pattrick wrote: > On Thu, Oct 19, 2023 at 9:00 AM Eelco Chaudron wrote: >> >> >> >> On 19 Oct 2023, at 4:37, Mike Pattrick wrote: >> >>> Currently a bond will not always revalidate when an active member >>> changes. This can result in counter-intuitive behaviors

Re: [ovs-dev] [RFC v2 1/1] Add command args to output JSON from ovs-appctl commands.

Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate spacing around cast #475 FILE: ofproto/ofproto-dpif.c:6725:

Re: [ovs-dev] [PATCH] [RFC] Add options to output JSON from ovs-appctl commands.

Superseeded by: https://patchwork.ozlabs.org/project/openvswitch/patch/20231020092205.710399-2-jm...@redhat.com/ ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [RFC v2 1/1] Add command args to output JSON from ovs-appctl commands.

From: Jakob Meng For monitoring systems such as Prometheus it would be beneficial if OVS and OVS-DPDK would expose statistics in a machine-readable format. Several approaches like UNIX socket, OVSDB queries and JSON output from ovs-xxx tools have been proposed [0],[1]. This proof of concept

[ovs-dev] [RFC v2 0/1] Add command args to output JSON from ovs-appctl commands.

From: Jakob Meng This is a follow up with small changes to the previous RFC [0]: * Nasty double-free bug has been fixed. * Formatting has been updated to satisfy 0-day Robot. However, 0-day Robot will still complain because it interprets the command help "[(-o|--output=)text|json]" as a cast 