Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread Roi Dayan via dev
On 13/11/2023 19:08, Aaron Conole wrote: > Roi Dayan writes: > >> codespell dictionary contains a list of widely used words >> which enchant alone could fail on. for an example: >> refcount, pthread, enqueuing, etc. >> Load that dictionary, if exists, into enchant spell checker. >> >> Signed-o

Re: [ovs-dev] [PATCH ovn v2 0/2] Documentation: Fix the Read The Docs build.

2023-11-13 Thread Dumitru Ceara
On 11/13/23 17:30, Ilya Maximets wrote: > Since last month ReadTheDocs only supports building with a new > configuration file provided in the repository itself: > https://blog.readthedocs.com/migrate-configuration-v2/ > > So, all our documentation builds are failing for quite some time. > > Als

Re: [ovs-dev] [PATCH ovn branch-22.03 v2] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-13 Thread Ilya Maximets
On 11/13/23 13:13, Eelco Chaudron wrote: > > > On 13 Nov 2023, at 12:43, Vladislav Odintsov wrote: > >>> On 13 Nov 2023, at 14:17, Eelco Chaudron wrote: >>> >>> >>> >>> On 8 Nov 2023, at 14:39, Vladislav Odintsov wrote: >>> Hi Ilya, Eelco, I’ve tried this patch against 3.1 and la

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread Aaron Conole
Roi Dayan writes: > codespell dictionary contains a list of widely used words > which enchant alone could fail on. for an example: > refcount, pthread, enqueuing, etc. > Load that dictionary, if exists, into enchant spell checker. > > Signed-off-by: Roi Dayan > --- Thanks for working on this.

Re: [ovs-dev] [PATCH ovn] py-requirements: Remove hacking dependency and use recent flake8.

2023-11-13 Thread Ilya Maximets
On 11/13/23 17:23, Dumitru Ceara wrote: > On 11/13/23 15:15, Ilya Maximets wrote: >> On 11/13/23 14:47, Dumitru Ceara wrote: >>> On 11/13/23 14:41, Ilya Maximets wrote: On 11/13/23 14:33, Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following > erro

[ovs-dev] [PATCH ovn v2] py-requirements: Remove hacking dependency and use recent flake8.

2023-11-13 Thread Dumitru Ceara
Without this, when using Python 3.12 and flake8 5.0.4, the following errors are flagged: tests/check_acl_log.py:97:25: E231 missing whitespace after ':' tests/check_acl_log.py:102:71: E231 missing whitespace after ':' This was reported and discussed in a couple of contexts: https://mail.openvs

[ovs-dev] [PATCH ovn branch-22.03 v2] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. Signed-off-by: Dumitru Ceara This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to bra

[ovs-dev] [PATCH ovn branch-22.06 v2] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump s

[ovs-dev] [PATCH ovn branch-22.09 v2] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump s

[ovs-dev] [PATCH ovn v2 1/2] Documentation: Use theme from Read The Docs.

2023-11-13 Thread Ilya Maximets
'ovs-sphinx-theme' is designed to look like an openvswitch.org website. It contains OVS logo and navigation bars from the openvswitch.org. And that doesn't really make a lot of sense for OVN. Also, currently the ovs-sphinx-theme is not actually installed by the Read The Docs configuration, so th

[ovs-dev] [PATCH ovn v2 2/2] readthedocs: Add the configuration file.

2023-11-13 Thread Ilya Maximets
Since last month ReadTheDocs only supports building with a new configuration file provided in the repository itself: https://blog.readthedocs.com/migrate-configuration-v2/ So, all our documentation builds are failing for quite some time. Add the configuration file to unblock documentation updat

[ovs-dev] [PATCH ovn v2 0/2] Documentation: Fix the Read The Docs build.

2023-11-13 Thread Ilya Maximets
Since last month ReadTheDocs only supports building with a new configuration file provided in the repository itself: https://blog.readthedocs.com/migrate-configuration-v2/ So, all our documentation builds are failing for quite some time. Also, the use of ovs-sphinx-theme is a little weird. Te

[ovs-dev] [PATCH ovn branch-22.12 v2] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump su

[ovs-dev] [PATCH ovn branch-23.03 v2] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump s

[ovs-dev] [PATCH ovn branch-23.06 v2] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread Dumitru Ceara
This picks up the following relevant patch: 4c027ebd3bb1 ("ovs.tmac: Fix troff warning in versions above groff-1.23.") Without it the 'rpm-fedora' make target is broken, failing with: troff:vswitchd/ovs-vswitchd.8:1298: warning: cannot select font 'CW' This also partially backports the simila

Re: [ovs-dev] [PATCH ovn] py-requirements: Remove hacking dependency and use recent flake8.

2023-11-13 Thread Dumitru Ceara
On 11/13/23 15:15, Ilya Maximets wrote: > On 11/13/23 14:47, Dumitru Ceara wrote: >> On 11/13/23 14:41, Ilya Maximets wrote: >>> On 11/13/23 14:33, Dumitru Ceara wrote: Without this, when using Python 3.12 and flake8 5.0.4, the following errors are flagged: tests/check_acl_log.py:9

Re: [ovs-dev] [PATCH ovn branch-22.03] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH ovn branch-22.06] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH ovn branch-22.09] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH ovn branch-22.12] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH ovn] py-requirements: Remove hacking dependency and use recent flake8.

2023-11-13 Thread Ilya Maximets
On 11/13/23 14:47, Dumitru Ceara wrote: > On 11/13/23 14:41, Ilya Maximets wrote: >> On 11/13/23 14:33, Dumitru Ceara wrote: >>> Without this, when using Python 3.12 and flake8 5.0.4, the following >>> errors are flagged: >>> tests/check_acl_log.py:97:25: E231 missing whitespace after ':' >>> t

Re: [ovs-dev] [PATCH ovn branch-23.03] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH ovn branch-22.06] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Dumitru Ceara
On 11/13/23 14:45, Ilya Maximets wrote: > On 11/13/23 13:48, Dumitru Ceara wrote: >> It's better to use a release tag now that one is available. >> >> This also partially backports the similar commit from branch-23.09: >> >> commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 >> Author: Ales Musil >>

Re: [ovs-dev] [PATCH ovn] py-requirements: Remove hacking dependency and use recent flake8.

2023-11-13 Thread Dumitru Ceara
On 11/13/23 14:41, Ilya Maximets wrote: > On 11/13/23 14:33, Dumitru Ceara wrote: >> Without this, when using Python 3.12 and flake8 5.0.4, the following >> errors are flagged: >> tests/check_acl_log.py:97:25: E231 missing whitespace after ':' >> tests/check_acl_log.py:102:71: E231 missing whit

Re: [ovs-dev] [PATCH ovn branch-22.06] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Ilya Maximets
On 11/13/23 13:48, Dumitru Ceara wrote: > It's better to use a release tag now that one is available. > > This also partially backports the similar commit from branch-23.09: > > commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 > Author: Ales Musil > Date: Thu Aug 31 09:27:20 2023 +0200 Please,

Re: [ovs-dev] [PATCH ovn] py-requirements: Remove hacking dependency and use recent flake8.

2023-11-13 Thread Ilya Maximets
On 11/13/23 14:33, Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following > errors are flagged: > tests/check_acl_log.py:97:25: E231 missing whitespace after ':' > tests/check_acl_log.py:102:71: E231 missing whitespace after ':' > > This was reported and di

Re: [ovs-dev] [PATCH ovn] fake-multinode-ci: Use python version '3.11' instead of '3.x'.

2023-11-13 Thread Dumitru Ceara
On 11/9/23 22:47, Dumitru Ceara wrote: > On 11/7/23 22:33, Mark Michelson wrote: >> On 11/6/23 23:47, Dumitru Ceara wrote: >>> On 11/2/23 16:30, num...@ovn.org wrote: From: Numan Siddique With the 'ubuntu-latest' image in github CI,  OVS compilation is failing with the below er

Re: [ovs-dev] [PATCH ovn] check_acl_log: Format log printing according to E231 flake8 rule.

2023-11-13 Thread Dumitru Ceara
On 11/13/23 11:41, Dumitru Ceara wrote: > On 11/13/23 11:07, Ales Musil wrote: >> On Sat, Nov 11, 2023 at 11:40 PM Dumitru Ceara wrote: >> >>> Without this, when using Python 3.12 and flake8 5.0.4, the following >>> errors are flagged: >>> tests/check_acl_log.py:97:25: E231 missing whitespace af

[ovs-dev] [PATCH ovn] py-requirements: Remove hacking dependency and use recent flake8.

2023-11-13 Thread Dumitru Ceara
Without this, when using Python 3.12 and flake8 5.0.4, the following errors are flagged: tests/check_acl_log.py:97:25: E231 missing whitespace after ':' tests/check_acl_log.py:102:71: E231 missing whitespace after ':' This was reported and discussed in a couple of contexts: https://mail.openvs

Re: [ovs-dev] [PATCH ovn branch-23.06] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH ovn] fake-multinode-ci: Use python version '3.11' instead of '3.x'.

2023-11-13 Thread Ilya Maximets
On 11/7/23 22:33, Mark Michelson wrote: > On 11/6/23 23:47, Dumitru Ceara wrote: >> On 11/2/23 16:30, num...@ovn.org wrote: >>> From: Numan Siddique >>> >>> With the 'ubuntu-latest' image in github CI, OVS compilation >>> is failing with the below error: >>> >>> --- >>> python/ovs/tests/test_dns_

Re: [ovs-dev] [PATCH ovn 1/2] Documentation: Use theme from Read The Docs.

2023-11-13 Thread Ilya Maximets
On 11/6/23 17:06, Mark Michelson wrote: > Hi Ilya, > > Thanks for fixing this. > > Acked-by: Mark Michelson > > I have one suggestion below. > > On 11/2/23 12:15, Ilya Maximets wrote: >> 'ovs-sphinx-theme' is designed to look like an openvswitch.org >> website. It contains OVS logo and naviga

Re: [ovs-dev] [PATCH v2 0/1] improve checkpatch spell checker

2023-11-13 Thread Roi Dayan via dev
On 13/11/2023 12:52, Roi Dayan wrote: > Him > > The first patch is for using enchant add_to_session() to add > words to current session only. > The second patch is for improving the spell checker by adding > the codespell dictionary of words. > > v2 > - Load codespell dictionary if exists into

[ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread Roi Dayan via dev
codespell dictionary contains a list of widely used words which enchant alone could fail on. for an example: refcount, pthread, enqueuing, etc. Load that dictionary, if exists, into enchant spell checker. Signed-off-by: Roi Dayan --- utilities/checkpatch.py | 19 +++ 1 file chang

[ovs-dev] [PATCH v3 1/2] checkpatch: Fix personal word list storage.

2023-11-13 Thread Roi Dayan via dev
From: Gaetan Rivet The enchant dictionary synchronizes additions to the source file. Keep the two word source separate by adding the extra words only to the current session. Signed-off-by: Gaetan Rivet Acked-by: Roi Dayan --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 d

[ovs-dev] [PATCH v3 0/2] improve checkpatch spell checker

2023-11-13 Thread Roi Dayan via dev
Hi, The first patch is for using enchant add_to_session() to add words to current session only. The second patch is for improving the spell checker by adding the codespell dictionary of words. v3 - sent in v2 only one patch by mistake. v2 - Load codespell dictionary if exists into enchant sessio

Re: [ovs-dev] [PATCH v6] revalidator: add a USDT probe after evaluation when flows are deleted.

2023-11-13 Thread Eelco Chaudron
On 23 Dec 2022, at 18:02, kevin sprague wrote: > Hi Eelco, > > I've been busy finishing up school, I should have some time to sit down > with it in the next week or so. Hi Kevin, Are you still planning on looking at this? I know it’s more than a year ago you posted this, but I still think thi

[ovs-dev] [PATCH ovn branch-22.03] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. Signed-off-by: Dumitru Ceara This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to bra

[ovs-dev] [PATCH ovn branch-22.06] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump submodule to

[ovs-dev] [PATCH ovn branch-22.09] ovs: Bump submodule to use v3.0.5.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump submodule to

[ovs-dev] [PATCH ovn branch-22.12] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump submodule to

[ovs-dev] [PATCH ovn branch-23.03] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil Date: Thu Aug 31 09:27:20 2023 +0200 ovs: Bump submodule to branch-3.2 Bump submodule to

[ovs-dev] [PATCH ovn branch-23.06] ovs: Bump submodule to v3.1.3.

2023-11-13 Thread Dumitru Ceara
This picks up the following relevant patch: 4c027ebd3bb1 ("ovs.tmac: Fix troff warning in versions above groff-1.23.") Without it the 'rpm-fedora' make target is broken, failing with: troff:vswitchd/ovs-vswitchd.8:1298: warning: cannot select font 'CW' This also partially backports the simila

[ovs-dev] [PATCH ovn branch-23.09] ovs: Bump submodule to v3.2.1.

2023-11-13 Thread Dumitru Ceara
It's better to use a release tag now that one is available. This picks up the following relevant patch: 0d0e95cd2ae6 ("ovsdb: Fix potential leak when making diff of conditions.") Signed-off-by: Dumitru Ceara --- ovs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovs b/ovs

[ovs-dev] [PATCH ovn v2] DNS: allow defining records that owned by OVN only

2023-11-13 Thread Mohammad Heib
Currently OVN allows users to create DNS records and define domains within these records. These domains can be associated with IPV4 or IPv6 or both, when the user creates a domain with both IPv4 and IPv6 ovn will answer each query for this domain immediately and everything works as expected. But

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-13 Thread Eelco Chaudron
On 13 Nov 2023, at 12:43, Vladislav Odintsov wrote: >> On 13 Nov 2023, at 14:17, Eelco Chaudron wrote: >> >> >> >> On 8 Nov 2023, at 14:39, Vladislav Odintsov wrote: >> >>> Hi Ilya, Eelco, >>> >>> I’ve tried this patch against 3.1 and latest master branch. There are no >>> warnings anymore, >>

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-13 Thread Vladislav Odintsov
> On 13 Nov 2023, at 14:17, Eelco Chaudron wrote: > > > > On 8 Nov 2023, at 14:39, Vladislav Odintsov wrote: > >> Hi Ilya, Eelco, >> >> I’ve tried this patch against 3.1 and latest master branch. There are no >> warnings anymore, >> but it seems that in my installation it has broken offloa

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-13 Thread Eelco Chaudron
On 8 Nov 2023, at 14:39, Vladislav Odintsov wrote: > Hi Ilya, Eelco, > > I’ve tried this patch against 3.1 and latest master branch. There are no > warnings anymore, > but it seems that in my installation it has broken offload capability. Yes, this is expected, this specific flow can not be of

Re: [ovs-dev] [PATCH v8 2/9] system-dpdk: Don't require hugetlbfs.

2023-11-13 Thread Eelco Chaudron
On 27 Oct 2023, at 17:41, David Marchand wrote: > On Fri, Oct 27, 2023 at 5:31 PM David Marchand > wrote: >> >> dpdk-testpmd does not need hugetlbfs backing as we don't require >> multiprocess support in OVS unit tests. >> >> Switch to --in-memory and remove the (then unneeded) check on >> huge

Re: [ovs-dev] [PATCH v2 1/1] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (utilities/checkpatch.py). error: could not build fake an

[ovs-dev] [PATCH v2 1/1] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread Roi Dayan via dev
codespell dictionary contains a list of widely used words which enchant alone could fail on. for an example: refcount, pthread, enqueuing, etc. Load that dictionary, if exists, into enchant spell checker. Signed-off-by: Roi Dayan --- utilities/checkpatch.py | 19 +++ 1 file chang

[ovs-dev] [PATCH v2 0/1] improve checkpatch spell checker

2023-11-13 Thread Roi Dayan via dev
Him The first patch is for using enchant add_to_session() to add words to current session only. The second patch is for improving the spell checker by adding the codespell dictionary of words. v2 - Load codespell dictionary if exists into enchant session instead of adding the entire dictionary.

Re: [ovs-dev] [PATCH 1/2] checkpatch.py: Load personal words list.

2023-11-13 Thread Roi Dayan via dev
On 13/11/2023 11:46, Eelco Chaudron wrote: > > > On 12 Nov 2023, at 8:22, Roi Dayan wrote: > >> On 10/11/2023 16:23, Aaron Conole wrote: >>> Roi Dayan writes: >>> On 08/11/2023 21:04, Aaron Conole wrote: > Roi Dayan via dev writes: > >> On 02/11/2023 16:11, Eelco Chaudron wr

Re: [ovs-dev] [PATCH ovn] check_acl_log: Format log printing according to E231 flake8 rule.

2023-11-13 Thread Dumitru Ceara
On 11/13/23 11:07, Ales Musil wrote: > On Sat, Nov 11, 2023 at 11:40 PM Dumitru Ceara wrote: > >> Without this, when using Python 3.12 and flake8 5.0.4, the following >> errors are flagged: >> tests/check_acl_log.py:97:25: E231 missing whitespace after ':' >> tests/check_acl_log.py:102:71: E2

Re: [ovs-dev] [PATCH ovn] check_acl_log: Format log printing according to E231 flake8 rule.

2023-11-13 Thread Ales Musil
On Sat, Nov 11, 2023 at 11:40 PM Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following > errors are flagged: > tests/check_acl_log.py:97:25: E231 missing whitespace after ':' > tests/check_acl_log.py:102:71: E231 missing whitespace after ':' > > While thi

Re: [ovs-dev] [PATCH v8 7/9] system-dpdk: Remove tap interfaces from vport MTU tests.

2023-11-13 Thread Eelco Chaudron
On 27 Oct 2023, at 17:31, David Marchand wrote: > The unit tests for changing MTU with vhost-user ports are not using > those tap interfaces. > > Signed-off-by: David Marchand Thanks this change looks good to me. Acked-by: Eelco Chaudron ___ dev

Re: [ovs-dev] [PATCH 1/2] checkpatch.py: Load personal words list.

2023-11-13 Thread Eelco Chaudron
On 12 Nov 2023, at 8:22, Roi Dayan wrote: > On 10/11/2023 16:23, Aaron Conole wrote: >> Roi Dayan writes: >> >>> On 08/11/2023 21:04, Aaron Conole wrote: Roi Dayan via dev writes: > On 02/11/2023 16:11, Eelco Chaudron wrote: >> >> On 2 Nov 2023, at 14:20, Roi Dayan via de

Re: [ovs-dev] [PATCH v7 2/3] netdev-afxdp: Sync and clean {get, set}_config() callbacks.

2023-11-13 Thread Jakob Meng
On 03.11.23 22:44, Ilya Maximets wrote: > On 10/30/23 10:49, jm...@redhat.com wrote: >> From: Jakob Meng >> >> For better usability, the function pairs get_config() and >> set_config() for netdevs should be symmetric: Options which are >> accepted by set_config() should be returned by get_config()

[ovs-dev] [PATCH v8 3/3] netdev-dpdk: Sync and clean {get, set}_config() callbacks.

2023-11-13 Thread jmeng
From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for set_config() only. This patch moves key-value pair

[ovs-dev] [PATCH v8 1/3] netdev-dummy: Sync and clean {get, set}_config() callbacks.

2023-11-13 Thread jmeng
From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for set_config() only. This patch also moves key-value

[ovs-dev] [PATCH v8 2/3] netdev-afxdp: Sync and clean {get, set}_config() callbacks.

2023-11-13 Thread jmeng
From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for set_config() only. This patch also moves key-value

[ovs-dev] [PATCH v8 0/3] netdev: Sync and clean {get, set}_config() callbacks.

2023-11-13 Thread jmeng
From: Jakob Meng This patch series incorporates Ilya's comments for v7 and has been rebased to master: * fixed afxdp status descriptions in vswitchd/vswitch.xml * be consistent with rx/Rx/RX/tx/Tx/TX in vswitchd/vswitch.xml Jakob Meng (3): netdev-dummy: Sync and clean {get,set}_config() callb