On 27 Nov 2023, at 19:16, Ilya Maximets wrote:
> On 11/27/23 13:41, Eelco Chaudron wrote:
>> I ran 80 series of full tests, and the following tests showed failures:
>
> Hi, Eelco.
>
> It looks like this patch should go before enabling the actual testing.
> Some of the previous patches in the sat
On 27 Nov 2023, at 19:14, Ilya Maximets wrote:
> On 11/27/23 13:40, Eelco Chaudron wrote:
>> Install additional packages and drivers required by
>> make check-dpdk.
>>
>> Signed-off-by: Eelco Chaudron
>> ---
>> .ci/dpdk-build.sh|2 +-
>> .github/workflows/build-and-tes
Change the ct-flush and ct-flush-zone to RW
as they do in fact modify the state.
Fixes: 2a7c4805a76d ("Add OpenFlow command to flush conntrack table entries.")
Fixes: 08146bf7d9b4 ("openflow: Add extension to flush CT by generic match.")
Signed-off-by: Ales Musil
---
utilities/ovs-ofctl.c | 4 ++
CT flush extension would silently ignore unknown properties,
which could lead to potential surprise by deleting more than
it was requested to. Return error on unknown property instead
to avoid this problem and at the same time inform the user
that the specified property is not supported.
Fixes: 08
On 27 Nov 2023, at 19:05, Ilya Maximets wrote:
> On 11/27/23 13:39, Eelco Chaudron wrote:
>> Signed-off-by: Eelco Chaudron
>> ---
>> .github/workflows/build-and-test.yml |4
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/.github/workflows/build-and-test.yml
>> b/.github/workf
On 27 Nov 2023, at 19:04, Ilya Maximets wrote:
> On 11/27/23 13:39, Eelco Chaudron wrote:
>> This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip
>> tests that won't execute successfully through GitHub actions.
>> We could not use the -k !keyword option, as it can not be
>> combined wit
On 27 Nov 2023, at 19:03, Ilya Maximets wrote:
> On 11/27/23 13:38, Eelco Chaudron wrote:
>
> Some minimal commit message would be nice, since this patch
> contains several design decisions that may use justification,
> e.g. split of the testsuite in two parts, base image upgrade
> and new depe
On 27 Nov 2023, at 18:58, Ilya Maximets wrote:
> On 11/27/23 13:38, Eelco Chaudron wrote:
>> Signed-off-by: Eelco Chaudron
>> ---
>> .ci/linux-build.sh |9 +
>> .github/workflows/build-and-test.yml |3 +++
>> 2 files changed, 8 insertions(+), 4 deletions(-)
>
On Mon, Nov 27, 2023 at 7:36 PM Ilya Maximets wrote:
> On 11/16/23 16:08, Ales Musil wrote:
> > The CT flush is not capable of partial flush based
> > on the touples and zone combinations. Extend it
> > so it also accepts mark and labels. As part of this
> > series unify parsing of arguments in d
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#4484 F
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#649 FILE: northd/en-ls-stateful.h:49:
HMAP
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#387 FILE: northd/northd.c:1196
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#100 FILE: northd/en-lr-nat.h:90:
HMAP_FOR_
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#178 FILE: northd/northd.c:4865:
/* XXX Why ca
On Mon, Nov 27, 2023 at 9:34 PM wrote:
>
> From: Numan Siddique
>
> This patch series adds incremental processing in the lflow engine
> node to handle changes to northd and other engine nodes.
> Changed related to load balancers and NAT are mainly handled in
> this patch series.
>
> This patch se
From: Numan Siddique
Any changes to northd engine node due to load balancers
are now handled in 'sync_to_sb_lb' node to sync the changed
load balancers to SB load balancers.
The logic to sync the SB load balancers is changed a bit and it
now mimics the SB lflow sync.
Below are the scale testing
From: Numan Siddique
Signed-off-by: Numan Siddique
---
northd/en-lflow.c| 29 +++
northd/en-lflow.h| 1 +
northd/en-ls-stateful.c | 3 ++
northd/en-ls-stateful.h | 23 +++
northd/inc-proc-northd.c | 3 +-
northd/northd.c | 56 +++
From: Numan Siddique
Signed-off-by: Numan Siddique
---
northd/inc-proc-northd.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/northd/inc-proc-northd.c b/northd/inc-proc-northd.c
index 7b1c6597e2..28f397ff39 100644
--- a/northd/inc-proc-northd.c
+++ b/northd/inc-pro
From: Numan Siddique
Since northd tracked data has the changed lb data, northd
engine handler for lflow engine now handles the lb changes
incrementally. All the lflows generated for each lb is
stored in the ovn_lb_datapaths->lflow_ref and this is used
similar to how we handle ovn_port changes.
From: Numan Siddique
A new engine node "global_config" is added which handles the changes
to NB_Global an SB_Global tables. It also creates these rows if
not present.
Without the I-P, any changes to the options column of these tables
result in recompute of 'northd' and 'lflow' engine nodes.
Si
From: Numan Siddique
Signed-off-by: Numan Siddique
---
northd/en-lflow.c| 29 +++
northd/en-lflow.h| 1 +
northd/en-lr-stateful.c | 39 -
northd/en-lr-stateful.h | 26 +++
northd/inc-proc-northd.c | 3 +-
northd/northd.c | 370 ++
From: Numan Siddique
Signed-off-by: Numan Siddique
---
lib/lb.c| 96 -
lib/lb.h| 57 -
northd/northd.c | 111
northd/northd.h | 28
4 files changed, 1
From: Numan Siddique
This new engine now maintains the load balancer and ACL data of a
logical switch which was earlier part of northd engine node data.
The main inputs to this engine are:
- northd node
- Port group node
A record for each logical switch is maintained in the 'ls_statefuls
From: Numan Siddique
Previous commits added new engine nodes to store logical router's
stateful (LB and NAT data). Make use of the data stored by these
engine nodes to generate logical flows related to router's LBs and NATs.
Signed-off-by: Numan Siddique
---
northd/en-lflow.c| 3 -
From: Numan Siddique
This new engine now maintains the load balancer and NAT data of a
logical router which was earlier part of northd engine node data.
The main inputs to this engine are:
- northd node
- lr_nat node
- lb_data node
A record for each logical router is maintained in the '
From: Numan Siddique
This new engine now maintains the NAT related data for each
logical router which was earlier maintained by the northd
engine node in the 'struct ovn_datapath'. The input to
this engine node is 'northd'.
A record for each logical router (lr_nat_record) is maintained
in the '
From: Numan Siddique
It also moves the logical router port IPv6 prefix delegation
updates to "sync-from-sb" engine node.
With these changes, northd engine node doesn't need to do much
for SB Port binding changes other than updating 'op->sb'. And
there is no need to fall back to recompute. Prio
From: Numan Siddique
northd engine tracking data now has the following tracking data
- changed ovn_ports (right now only changed logical switch ports are
tracked.)
- changed load balancers.
This separation becomes easier to add lflow handling for these
changes in lflow northd engine hand
From: Numan Siddique
These tests cover scenarios for load balancers and NATs
and check for the 'northd' and 'lflow' engine node
recompute and compute stats.
Signed-off-by: Numan Siddique
---
tests/ovn-macros.at | 44
tests/ovn-northd.at | 241 ++---
From: Numan Siddique
This patch series adds incremental processing in the lflow engine
node to handle changes to northd and other engine nodes.
Changed related to load balancers and NAT are mainly handled in
this patch series.
This patch series can also be found here -
https://github.com/numans
Thank you Dumitru.
Acked-by: Mark Michelson
I've merged this to main and branch-23.09.
On 11/24/23 06:00, Dumitru Ceara wrote:
We forgot to register the port group and meter stopwatches. Without
that no data is actually collected.
Fixes: 2225c0755540 ("northd: Move port group processing to
On 11/16/23 16:08, Ales Musil wrote:
> The CT flush is not capable of partial flush based
> on the touples and zone combinations. Extend it
> so it also accepts mark and labels. As part of this
> series unify parsing of arguments in dpctl and ovs-ofctl
> for the ct flush command.
Hi, Ales. Thanks
On Fri, Nov 3, 2023 at 12:01 AM Dexia Li via dev
wrote:
>
> For userspace datapath, this patch provides vxlan and geneve tunnel tso.
> Only support userspace vxlan or geneve tunnel, meanwhile support
> tunnel outter and inner csum offload. If netdev do not support offload
> features, there is
On 11/27/23 18:36, Eelco Chaudron wrote:
> This patch detects new static analyze issues, and report them.
> It does this by reporting on the delta for this branch, compared
> to the previous branch.
>
> For example the error might look like this:
>
> error level: +0 -0 no changes
> warning le
On 11/27/23 13:41, Eelco Chaudron wrote:
> I ran 80 series of full tests, and the following tests showed failures:
Hi, Eelco.
It looks like this patch should go before enabling the actual testing.
Some of the previous patches in the sat failed CI because of these issues.
>
> 802.1ad - vlan_lim
On 11/27/23 13:40, Eelco Chaudron wrote:
> Install additional packages and drivers required by
> make check-dpdk.
>
> Signed-off-by: Eelco Chaudron
> ---
> .ci/dpdk-build.sh|2 +-
> .github/workflows/build-and-test.yml |2 +-
> python/test_requirements.txt |
On 11/27/23 13:39, Eelco Chaudron wrote:
> Signed-off-by: Eelco Chaudron
> ---
> .github/workflows/build-and-test.yml |4
> 1 file changed, 4 insertions(+)
>
> diff --git a/.github/workflows/build-and-test.yml
> b/.github/workflows/build-and-test.yml
> index db0a1ac39..d74668f61 100644
On 11/27/23 13:39, Eelco Chaudron wrote:
> Signed-off-by: Eelco Chaudron
> ---
> .github/workflows/build-and-test.yml |4
> 1 file changed, 4 insertions(+)
>
> diff --git a/.github/workflows/build-and-test.yml
> b/.github/workflows/build-and-test.yml
> index 586b0cdd9..db0a1ac39 100644
On 11/27/23 13:39, Eelco Chaudron wrote:
> This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip
> tests that won't execute successfully through GitHub actions.
> We could not use the -k !keyword option, as it can not be
> combined with a range of tests.
>
> Signed-off-by: Eelco Chaudron
>
On 11/27/23 13:38, Eelco Chaudron wrote:
Some minimal commit message would be nice, since this patch
contains several design decisions that may use justification,
e.g. split of the testsuite in two parts, base image upgrade
and new dependencies.
> Signed-off-by: Eelco Chaudron
> ---
> .ci/linux
On 11/27/23 13:38, Eelco Chaudron wrote:
> Signed-off-by: Eelco Chaudron
> ---
> .ci/linux-build.sh |9 +
> .github/workflows/build-and-test.yml |3 +++
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
>
This patch detects new static analyze issues, and report them.
It does this by reporting on the delta for this branch, compared
to the previous branch.
For example the error might look like this:
error level: +0 -0 no changes
warning level: +2 +0
New issue "deadcode.DeadStores Value store
> Op 27 nov 2023 om 18:23 heeft Aaron Conole het volgende
> geschreven:
>
> Eelco Chaudron writes:
>
>> Hi Aaron,
>>
>> Guess the Robot does some magic checkout resulting in no parent branch.
>
> This is actually a failure with the github build. Robot simply pushes
> to the series branch
Eelco Chaudron writes:
> Hi Aaron,
>
> Guess the Robot does some magic checkout resulting in no parent branch.
This is actually a failure with the github build. Robot simply pushes
to the series branch.
> Can you let me know how the branch for the run gets created, so I can
> figure out how to
On 27 Nov 2023, at 13:53, David Marchand wrote:
> Hello Eelco,
>
> On Mon, Nov 27, 2023 at 1:39 PM Eelco Chaudron wrote:
>>
>> When new drivers are introduced, the cache key is not accurately computed.
>> Previously, the dpdk build process was integrated into the main Linux
>> build script, whe
On 27 Nov 2023, at 13:58, Ilya Maximets wrote:
> On 11/27/23 13:38, Eelco Chaudron wrote:
>> This set of patches incorporates the remaining make check tests into
>> the GitHub action run. Notably, this inclusion does not appear to
>> extend the overall run time, as the newly added tests complete
On 11/27/23 13:38, Eelco Chaudron wrote:
> This set of patches incorporates the remaining make check tests into
> the GitHub action run. Notably, this inclusion does not appear to
> extend the overall run time, as the newly added tests complete prior
> to the existing ones.
Hmm. This doesn't soun
Hello Eelco,
On Mon, Nov 27, 2023 at 1:39 PM Eelco Chaudron wrote:
>
> When new drivers are introduced, the cache key is not accurately computed.
> Previously, the dpdk build process was integrated into the main Linux
> build script, where specific lines were employed to generate the key.
> Since
I ran 80 series of full tests, and the following tests showed failures:
802.1ad - vlan_limit
+2023-11-20T10:32:11.245Z|1|dpif_netdev(revalidator5)|ERR|internal
error parsing flow key recirc_id(0),dp_hash(0),skb_priority(0),
in_port(2),skb_mark(0),ct_state(0),ct_zone(0),ct_mark(0)
Signed-off-by: Eelco Chaudron
---
.github/workflows/build-and-test.yml |4
1 file changed, 4 insertions(+)
diff --git a/.github/workflows/build-and-test.yml
b/.github/workflows/build-and-test.yml
index 1e92a0e2b..710757693 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github
Install additional packages and drivers required by
make check-dpdk.
Signed-off-by: Eelco Chaudron
---
.ci/dpdk-build.sh|2 +-
.github/workflows/build-and-test.yml |2 +-
python/test_requirements.txt |1 +
3 files changed, 3 insertions(+), 2 deletions(-)
When new drivers are introduced, the cache key is not accurately computed.
Previously, the dpdk build process was integrated into the main Linux
build script, where specific lines were employed to generate the key.
Since it is now separated into two distinct files, this patch will
compute the key b
Signed-off-by: Eelco Chaudron
---
.github/workflows/build-and-test.yml |4
1 file changed, 4 insertions(+)
diff --git a/.github/workflows/build-and-test.yml
b/.github/workflows/build-and-test.yml
index db0a1ac39..d74668f61 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github
Signed-off-by: Eelco Chaudron
---
.github/workflows/build-and-test.yml |4
1 file changed, 4 insertions(+)
diff --git a/.github/workflows/build-and-test.yml
b/.github/workflows/build-and-test.yml
index 586b0cdd9..db0a1ac39 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github
This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip
tests that won't execute successfully through GitHub actions.
We could not use the -k !keyword option, as it can not be
combined with a range of tests.
Signed-off-by: Eelco Chaudron
---
.ci/linux-build.sh |2 +-
.
Signed-off-by: Eelco Chaudron
---
.ci/linux-build.sh |8 ++--
.github/workflows/build-and-test.yml | 15 ---
python/test_requirements.txt |4 +++-
3 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-bui
Signed-off-by: Eelco Chaudron
---
.ci/linux-build.sh |9 +
.github/workflows/build-and-test.yml |3 +++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index aa2ecc505..e9e1e24b5 100755
--- a/.ci/linux-build.
This set of patches incorporates the remaining make check tests into
the GitHub action run. Notably, this inclusion does not appear to
extend the overall run time, as the newly added tests complete prior
to the existing ones.
V2:
Added patch to fix DPDK cache key generation.
Eelco Chaudron (9):
On 11/24/23 11:32, David Marchand wrote:
> On Thu, Nov 23, 2023 at 12:50 PM Kevin Traynor wrote:
>>
>> Update the CI and docs to use DPDK 21.11.5.
>>
>> Signed-off-by: Kevin Traynor
>> ---
>> .ci/linux-build.sh | 2 +-
>> Documentation/faq/releases.rst | 2 +-
>> Document
59 matches
Mail list logo
