Re: [ovs-dev] [PATCH v3] ci: Add clang-analyze to GitHub actions.

2023-12-20 Thread Eelco Chaudron
On 19 Dec 2023, at 16:35, Eelco Chaudron wrote: > On 15 Dec 2023, at 10:34, Ilya Maximets wrote: > >> On 12/7/23 10:32, Eelco Chaudron wrote: >>> This patch detects new static analyze issues, and report them. >>> It does this by reporting on the delta for this branch, compared >>> to the base br

[ovs-dev] [PATCH v4] ci: Add clang-analyze to GitHub actions.

2023-12-20 Thread Eelco Chaudron
This patch identifies new static analysis issues during a GitHub action run and reports them. The process involves analyzing the changes introduced in the current commit and comparing them to those in the preceding commit. However, there are two cases when the GitHub push action runner does not pr

Re: [ovs-dev] [PATCH v5 11/12] ci: Allow make check-dpdk to run the MFEX tests.

2023-12-20 Thread Eelco Chaudron
On 20 Dec 2023, at 8:38, Eelco Chaudron wrote: > On 19 Dec 2023, at 19:45, Simon Horman wrote: > >> On Tue, Dec 19, 2023 at 06:38:57PM +, Simon Horman wrote: >>> On Tue, Dec 19, 2023 at 01:44:29PM +0100, Eelco Chaudron wrote: Currently, if you use the python/test_requirements.txt file t

Re: [ovs-dev] [PATCH v5 11/12] ci: Allow make check-dpdk to run the MFEX tests.

2023-12-20 Thread Simon Horman
On Wed, Dec 20, 2023 at 02:23:16PM +0100, Eelco Chaudron wrote: > > > On 20 Dec 2023, at 8:38, Eelco Chaudron wrote: > > > On 19 Dec 2023, at 19:45, Simon Horman wrote: > > > >> On Tue, Dec 19, 2023 at 06:38:57PM +, Simon Horman wrote: > >>> On Tue, Dec 19, 2023 at 01:44:29PM +0100, Eelco Ch

Re: [ovs-dev] [PATCH v5 11/12] ci: Allow make check-dpdk to run the MFEX tests.

2023-12-20 Thread Eelco Chaudron
On 20 Dec 2023, at 14:32, Simon Horman wrote: > On Wed, Dec 20, 2023 at 02:23:16PM +0100, Eelco Chaudron wrote: >> >> >> On 20 Dec 2023, at 8:38, Eelco Chaudron wrote: >> >>> On 19 Dec 2023, at 19:45, Simon Horman wrote: >>> On Tue, Dec 19, 2023 at 06:38:57PM +, Simon Horman wrote:

Re: [ovs-dev] [PATCH v4] ci: Add clang-analyze to GitHub actions.

2023-12-20 Thread Simon Horman
On Wed, Dec 20, 2023 at 11:19:21AM +0100, Eelco Chaudron wrote: > This patch identifies new static analysis issues during a GitHub action > run and reports them. The process involves analyzing the changes introduced > in the current commit and comparing them to those in the preceding commit. > > H

Re: [ovs-dev] [PATCH v3] ci: Add clang-analyze to GitHub actions.

2023-12-20 Thread Aaron Conole
Eelco Chaudron writes: > On 19 Dec 2023, at 16:35, Eelco Chaudron wrote: > >> On 15 Dec 2023, at 10:34, Ilya Maximets wrote: >> >>> On 12/7/23 10:32, Eelco Chaudron wrote: This patch detects new static analyze issues, and report them. It does this by reporting on the delta for this bran

[ovs-dev] [PATCH ovn 4/4] ic/tests: add unit test for ic sync command

2023-12-20 Thread Mohammad Heib
add unit test that check validate that sync command sync ISB properly Signed-off-by: Mohammad Heib --- tests/ovn-ic.at | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/ovn-ic.at b/tests/ovn-ic.at index 5cc504e17..7464658ff 100644 --- a/tests/ovn-ic.at +++ b/tests

[ovs-dev] [PATCH ovn 2/4] ovn-ic: implement basic INB change handling status

2023-12-20 Thread Mohammad Heib
This patch implements a basic sequence number protocol that can be used by CMS to determine if the changes applied to INB are successfully propagated to ISB. The implementation of this patch relies on OVN-ICs instances to update the ISB by adding a per AZ a nb_ic_cfg counter that will be updated b

[ovs-dev] [PATCH ovn 1/4] IC: interconnect DBs add basic Information Flow columns

2023-12-20 Thread Mohammad Heib
Add basic flow columns to interconnect northbound DB and interconnect Southbound DB. Those columns will be used by future patches to add basic support for Information Flow in OVN interconnect. Signed-off-by: Mohammad Heib --- NEWS| 8 ovn-ic-nb.ovsschema | 6 --

[ovs-dev] [PATCH ovn 3/4] IC: Make it possible for CMS to detect when the ISB is up-to-date.

2023-12-20 Thread Mohammad Heib
Until now, there has been no reliable for the CMS to detect when changes made to the INB configuration have been passed through to the ISB, This commit adds this feature to the system, by adding sequence numbers to the INB and ISB and adding code in ovn-ic-nbctl, ovn-ic to keep those sequence numbe

Re: [ovs-dev] [PATCH ovn 1/4] IC: interconnect DBs add basic Information Flow columns

2023-12-20 Thread 0-day Robot
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fai

Re: [ovs-dev] [PATCH v4] ci: Add clang-analyze to GitHub actions.

2023-12-20 Thread Eelco Chaudron
On 20 Dec 2023, at 11:19, Eelco Chaudron wrote: > This patch identifies new static analysis issues during a GitHub action > run and reports them. The process involves analyzing the changes introduced > in the current commit and comparing them to those in the preceding commit. > > However, there

Re: [ovs-dev] [PATCH v3] ci: Add clang-analyze to GitHub actions.

2023-12-20 Thread Eelco Chaudron
On 20 Dec 2023, at 15:04, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 19 Dec 2023, at 16:35, Eelco Chaudron wrote: >> >>> On 15 Dec 2023, at 10:34, Ilya Maximets wrote: >>> On 12/7/23 10:32, Eelco Chaudron wrote: > This patch detects new static analyze issues, and report them.

[ovs-dev] [PATCH ovn v2 1/4] IC: interconnect DBs add basic Information Flow columns

2023-12-20 Thread Mohammad Heib
Add basic flow columns to interconnect northbound DB and interconnect Southbound DB. Those columns will be used by future patches to add basic support for Information Flow in OVN interconnect. Signed-off-by: Mohammad Heib --- v3: rebase over main. --- NEWS| 8 ovn-ic-

[ovs-dev] [PATCH ovn v2 2/4] ovn-ic: implement basic INB change handling status

2023-12-20 Thread Mohammad Heib
This patch implements a basic sequence number protocol that can be used by CMS to determine if the changes applied to INB are successfully propagated to ISB. The implementation of this patch relies on OVN-ICs instances to update the ISB by adding a per AZ a nb_ic_cfg counter that will be updated b

[ovs-dev] [PATCH ovn v2 3/4] IC: Make it possible for CMS to detect when the ISB is up-to-date.

2023-12-20 Thread Mohammad Heib
Until now, there has been no reliable for the CMS to detect when changes made to the INB configuration have been passed through to the ISB, This commit adds this feature to the system, by adding sequence numbers to the INB and ISB and adding code in ovn-ic-nbctl, ovn-ic to keep those sequence numbe

[ovs-dev] [PATCH ovn v2 4/4] ic/tests: add unit test for ic sync command

2023-12-20 Thread Mohammad Heib
add unit test that check validate that sync command sync ISB properly Signed-off-by: Mohammad Heib --- tests/ovn-ic.at | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/ovn-ic.at b/tests/ovn-ic.at index d4c436f84..da7c37817 100644 --- a/tests/ovn-ic.at +++ b/tests

Re: [ovs-dev] [PATCH ovn v2 3/4] IC: Make it possible for CMS to detect when the ISB is up-to-date.

2023-12-20 Thread 0-day Robot
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator

Re: [ovs-dev] [PATCH 0/7] python: Miscelaneous flow parsing fixes

2023-12-20 Thread Eelco Chaudron
On 1 Dec 2023, at 20:15, Ilya Maximets wrote: > On 12/1/23 18:49, Adrian Moreno wrote: >> this series contains some miscelaneous fixes in the flow parsing >> library. >> >> Adrian Moreno (7): >> python: Do not compare types, use 'insinstance'. >> python: ovs: flow: Fix typo in n_packets. >>

Re: [ovs-dev] [PATCH 0/7] python: Miscelaneous flow parsing fixes

2023-12-20 Thread Adrian Moreno
On 12/20/23 16:55, Eelco Chaudron wrote: On 1 Dec 2023, at 20:15, Ilya Maximets wrote: On 12/1/23 18:49, Adrian Moreno wrote: this series contains some miscelaneous fixes in the flow parsing library. Adrian Moreno (7): python: Do not compare types, use 'insinstance'. python: ovs: fl

[ovs-dev] [PATCH v2 0/6] python: Miscelaneous flow parsing fixes.

2023-12-20 Thread Adrian Moreno
This series contains some miscelaneous fixes in the flow parsing library. V2: - Rebased and dropped first patch. Adrian Moreno (6): python: ovs: flow: Fix typo in n_packets. python: ovs: flow: Add sample to nested actions. python: ovs: flow: Add dp hash and meter actions. python: ovs: fl

[ovs-dev] [PATCH v2 1/6] python: ovs: flow: Fix typo in n_packets.

2023-12-20 Thread Adrian Moreno
They key used in flows is "n_packets". Signed-off-by: Adrian Moreno --- python/ovs/flow/ofp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/flow/ofp.py b/python/ovs/flow/ofp.py index 20231fd9f..f1a720d75 100644 --- a/python/ovs/flow/ofp.py +++ b/python/ovs/flow/

[ovs-dev] [PATCH v2 3/6] python: ovs: flow: Add dp hash and meter actions.

2023-12-20 Thread Adrian Moreno
Add missing actions. Signed-off-by: Adrian Moreno --- python/ovs/flow/odp.py | 9 + 1 file changed, 9 insertions(+) diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py index ef7e5d6b8..46697a1bc 100644 --- a/python/ovs/flow/odp.py +++ b/python/ovs/flow/odp.py @@ -204,6 +204,7 @

[ovs-dev] [PATCH v2 2/6] python: ovs: flow: Add sample to nested actions.

2023-12-20 Thread Adrian Moreno
Add the sample action to those that can be called in nested actions (such as clone). Signed-off-by: Adrian Moreno --- python/ovs/flow/odp.py | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py index 8

[ovs-dev] [PATCH v2 4/6] python: ovs: flow: Add idle_age to openflow flows.

2023-12-20 Thread Adrian Moreno
Add missing key. Signed-off-by: Adrian Moreno --- python/ovs/flow/ofp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ovs/flow/ofp.py b/python/ovs/flow/ofp.py index f1a720d75..3d3226c91 100644 --- a/python/ovs/flow/ofp.py +++ b/python/ovs/flow/ofp.py @@ -176,6 +176,7 @@ class OFPFl

[ovs-dev] [PATCH v2 5/6] python: ovs: flow: Make check_pkt_len action a list.

2023-12-20 Thread Adrian Moreno
In general, most actions must be lists since the keys can be repeated. Signed-off-by: Adrian Moreno --- python/ovs/flow/odp.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py index 46697a1bc..7d9b165d4 100644 --- a/python/

[ovs-dev] [PATCH v2 6/6] python: ovs: flow: Add meter_id to controller.

2023-12-20 Thread Adrian Moreno
Add missing option to controller action. Signed-off-by: Adrian Moreno --- python/ovs/flow/ofp_act.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ovs/flow/ofp_act.py b/python/ovs/flow/ofp_act.py index c540443ea..2c85076a3 100644 --- a/python/ovs/flow/ofp_act.py +++ b/python/ovs/flo

Re: [ovs-dev] [PATCH ovn v3 16/16] northd: Add northd change handler for sync_to_sb_lb node.

2023-12-20 Thread Numan Siddique
On Mon, Dec 18, 2023 at 9:08 AM Dumitru Ceara wrote: > > On 11/28/23 03:38, num...@ovn.org wrote: > > From: Numan Siddique > > > > Any changes to northd engine node due to load balancers > > are now handled in 'sync_to_sb_lb' node to sync the changed > > load balancers to SB load balancers. > > >

Re: [ovs-dev] [PATCH] Documentation: Add section on inclusive language.

2023-12-20 Thread Jakob Meng
On 14.12.23 23:06, Aaron Conole wrote: > Simon Horman writes: > >> As a community we should strive to be inclusive. >> As such it seems appropriate to adopt an word list, >> to help guide the use of inclusive language. >> >> This patch proposes use of the Inclusive Naming Word List v1.0. >> >> Lin