Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-23 Thread Han Zhou
On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > > On 1/11/24 16:31, num...@ovn.org wrote: > > + > > +void > > +lflow_table_add_lflow(struct lflow_table *lflow_table, > > + const struct ovn_datapath *od, > > + const unsigned long *dp_bitmap, size_t d

Re: [ovs-dev] [PATCH OVN] DHCP Relay Agent support for overlay subnets

2024-01-23 Thread Numan Siddique
On Tue, Jan 23, 2024 at 8:02 PM Naveen Yerramneni wrote: > > > > > On 16-Jan-2024, at 2:30 AM, Numan Siddique wrote: > > > > On Tue, Dec 12, 2023 at 1:05 PM Naveen Yerramneni > > wrote: > >> > >>This patch contains changes to enable DHCP Relay Agent support for > >> overlay subnets. > >> >

Re: [ovs-dev] [PATCH OVN] DHCP Relay Agent support for overlay subnets

2024-01-23 Thread Naveen Yerramneni
> On 16-Jan-2024, at 2:30 AM, Numan Siddique wrote: > > On Tue, Dec 12, 2023 at 1:05 PM Naveen Yerramneni > wrote: >> >>This patch contains changes to enable DHCP Relay Agent support for >> overlay subnets. >> >>USE CASE: >>-- >> - Enable IP address assignment for o

Re: [ovs-dev] [PATCH ovn] pinctrl: dns: Ignore additional additional records.

2024-01-23 Thread Mark Michelson
Hi Dumitru. Two questions: 1) Did you mean to title this as "additional additional records?" Or did you just mean "additional records?" 2) Should this include a test? I'm thinking you could construct a DNS query that includes an EDNS AR and ensure that OVN responds to it. Thanks, Mark Mich

Re: [ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-23 Thread Mark Michelson
Hi Dumitru, Acked-by: Mark Michelson I think this change is good. I looked through the documentation for the "external_port_range" column in the NAT table. This change appears to actually make the documentation *more* accurate rather than to introduce any potentially undesirable behavior cha

[ovs-dev] [PATCH v4 ovn] ovn: Add geneve PMTUD support.

2024-01-23 Thread Lorenzo Bianconi
Introduce specif flows for E/W ICMPv{4,6} packets if tunnelled packets do not fit path MTU. This patch enable PMTUD for East/West Geneve traffic. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2241711 Tested-at: https://github.com/LorenzoBianconi/ovn/actions/runs/7627345562/job/20777962

[ovs-dev] [PATCH ovn] northd: Make sure that affinity flows match on VIP.

2024-01-23 Thread Ales Musil
Consider the two following LBs: 1) 192.168.0.100:8080 -> 192.168.0.10:80 affinity_timeout=120, skip_snat=true 2) 172.10.0.100:8080 -> 192.168.0.10:80 affinity_timeout=120, skip_snat=false Connected to the same LR with "lb_force_snat_ip" option set. This combination would produce two flows w

Re: [ovs-dev] [PATCH ovn 2/2] OVN-SB: Exposes igmp group protocol version through IGMP table.

2024-01-23 Thread Mohammad Heib
On Tue, Jan 23, 2024 at 4:10 PM Dumitru Ceara wrote: > On 1/23/24 14:58, Mohammad Heib wrote: > >>> static struct pinctrl pinctrl; > >>> @@ -3586,11 +3587,21 @@ pinctrl_update(const struct ovsdb_idl *idl, > >> const char *br_int_name) > >>> if (dns_supports_ovn_owned != pinctrl.dns_supports

[ovs-dev] [PATCH ovn] pinctrl: dns: Ignore additional additional records.

2024-01-23 Thread Dumitru Ceara
EDNS is backwards compatible so it's safe to just ignore additional ARs. Reported-at: https://github.com/ovn-org/ovn/issues/228 Reported-at: https://issues.redhat.com/browse/FDP-222 Signed-off-by: Dumitru Ceara --- controller/pinctrl.c | 20 ++-- 1 file changed, 10 insertions(+),

Re: [ovs-dev] [PATCH ovn 2/2] OVN-SB: Exposes igmp group protocol version through IGMP table.

2024-01-23 Thread Dumitru Ceara
On 1/23/24 14:58, Mohammad Heib wrote: >>> static struct pinctrl pinctrl; >>> @@ -3586,11 +3587,21 @@ pinctrl_update(const struct ovsdb_idl *idl, >> const char *br_int_name) >>> if (dns_supports_ovn_owned != pinctrl.dns_supports_ovn_owned) { >>> pinctrl.dns_supports_ovn_owned = dns_s

Re: [ovs-dev] [PATCH ovn 2/2] OVN-SB: Exposes igmp group protocol version through IGMP table.

2024-01-23 Thread Mohammad Heib
On Mon, Jan 22, 2024 at 5:26 PM Dumitru Ceara wrote: > On 1/22/24 15:14, Mohammad Heib wrote: > > Expose the igmp/mld group protocol version through the > > IGMP_GROUP table in SBDB. > > > > This patch can be used by ovn consumer for debuggability purposes, user > > now can match between the pro

Re: [ovs-dev] [PATCH ovn 1/2] ovs: Bump submodule to include igmp protocol version.

2024-01-23 Thread Mohammad Heib
Hi Dumitru, Thank you for the review, yes sure will bump the submodule to the last stable once they fix the issue. Thanks On Mon, Jan 22, 2024 at 5:01 PM Dumitru Ceara wrote: > On 1/22/24 15:14, Mohammad Heib wrote: > > Specifically the following commit: > > 077d0bad0436 ("mcast-snooping: Sto

[ovs-dev] [PATCH ovn v2] ovn-ic: Handle NB:name updates properly.

2024-01-23 Thread Mohammad Heib
When the user updates the NB_GLOBAL.name after registering to IC Databases if the user already has defined chassis as a gateway that will cause ovn-ic instance to run in an infinity loop trying to update the gateways and insert the current gateway to the SB.chassis tables as a remote chassis (we ma

Re: [ovs-dev] [PATCH] userspace: Check for inner L3 while preparing encapsulated packets.

2024-01-23 Thread Mike Pattrick
On Tue, Jan 23, 2024 at 7:41 AM Ilya Maximets wrote: > > On 1/22/24 23:24, Mike Pattrick wrote: > > On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote: > >> > >> On 1/22/24 21:33, Mike Pattrick wrote: > >>> On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote: > > On 1/22/24 18:51, Mik

Re: [ovs-dev] [PATCH ovn 3/3] ovn-controller: Support VIF-based local encap IPs selection.

2024-01-23 Thread Ales Musil
On Wed, Jan 17, 2024 at 6:48 AM Han Zhou wrote: > Commit dd527a283cd8 partially supported multiple encap IPs. It supported > remote encap IP selection based on the destination VIF's encap_ip > configuration. This patch adds the support for selecting local encap IP > based on the source VIF's enca

Re: [ovs-dev] [PATCH ovn 2/3] encaps: Create separate tunnels for multiple local encap IPs.

2024-01-23 Thread Ales Musil
On Wed, Jan 17, 2024 at 6:48 AM Han Zhou wrote: > In commit dd527a283cd8, it created separate tunnels for different remote > encap IPs of the same remote chassis, but when the current chassis is > the one that has multiple encap IPs configured, it only uses the first > encap IP. This patch create

Re: [ovs-dev] [PATCH ovn 1/3] encaps: Refactor the naming related to tunnels.

2024-01-23 Thread Ales Musil
On Wed, Jan 17, 2024 at 6:48 AM Han Zhou wrote: > Rename vars and structs to reflect the fact that there can be multiple > tunnels for each individual chassis. Also update the documentation of > external_ids:ovn-encap-ip. > > Signed-off-by: Han Zhou > --- > controller/encaps.c | 77

[ovs-dev] [PATCH ovn] Controller: Handle unconditional IDL messages while paused.

2024-01-23 Thread Mohammad Heib
If the user triggers a pause command to the ovn-controller the current implementation will wait for commands from unixctl server only and ignore the other component. This implementation works fine if we don't have inactivity_probe set in the SB DataBase, but once the user sets the inactivity_probe

Re: [ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-23 Thread Ales Musil
On Mon, Jan 22, 2024 at 3:55 PM Dumitru Ceara wrote: > This is to avoid unexpected behavior changes due to the underlying > datapath (e.g., kernel) changing defaults. If we don't explicitly > request a port selection algorithm, OVS leaves it up to the > datapath to decide how to do the port sele

Re: [ovs-dev] [PATCH] userspace: Check for inner L3 while preparing encapsulated packets.

2024-01-23 Thread Ilya Maximets
On 1/22/24 23:24, Mike Pattrick wrote: > On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote: >> >> On 1/22/24 21:33, Mike Pattrick wrote: >>> On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote: On 1/22/24 18:51, Mike Pattrick wrote: > The OVN test suite identified a bug in dp_pack

Re: [ovs-dev] [PATCH ovn v3] controller: fixed potential segfault when changing tunnel_key and deleting ls

2024-01-23 Thread Dumitru Ceara
On 1/4/24 11:43, Dumitru Ceara wrote: > On 12/8/23 13:44, Xavier Simonart wrote: >> When a tunnel_key for a datapath was changed, the local_datapaths hmap was >> not properly updated >> as the old/initial entry was not removed. >> - If the datapath was not deleted at the same time, a new entry (fo

Re: [ovs-dev] [PATCH ovn] controller: Don't release LRP until its claimed

2024-01-23 Thread Dumitru Ceara
On 1/23/24 11:55, Dumitru Ceara wrote: [...] >> +static void * >> +en_lrp_claims_init(struct engine_node *node OVS_UNUSED, struct engine_arg >> *arg OVS_UNUSED) > > Checkpatch reports "WARNING: Line is 90 characters long (recommended > limit is 79)". > >> +{ >> +struct ed_type_lrp_claims *

Re: [ovs-dev] [PATCH ovn] controller: Don't release LRP until its claimed

2024-01-23 Thread Dumitru Ceara
Hi Ihtisham ul Haq, Thanks for the patch and sorry for the delay in reviewing it! On 12/19/23 17:46, Ihtisham ul Haq via dev wrote: > Previously LRP would be released as soon as the BFD session to > another chassis is established even if that chassis is unable to > claim the LRP for whatever reas

Re: [ovs-dev] [PATCH ovn] ovn-ic: handle NB:name updates properly

2024-01-23 Thread Dumitru Ceara
On 12/18/23 15:25, Mohammad Heib wrote: > When the user updates the NB_GLOBAL.name after registering > to IC Databases if the user already has defined chassis as a gateway > that will cause ovn-ic instance to run in an infinity loop trying > to update the gateways and insert the current gateway to

Re: [ovs-dev] [PATCH] dp-packet: Reset offload flags when clearing a packet.

2024-01-23 Thread Dumitru Ceara
On 1/23/24 00:11, Mike Pattrick wrote: > The OVN test suite identified a bug in dp_packet_ol_send_prepare() where > a BFD packet flagged as double encapsulated would trigger a seg fault. > The problem surfaced because bfd_put_packet was reusing a packet > allocated on the stack that wasn't having i