On Tue, May 28, 2024 at 9:52 PM Mark Michelson wrote:
> Thanks Ales, I have just one question about this.
>
>
Hi Mark,
thank you for the review.
>
> I noticed that you have updated the output of `ovn-nbctl lr-nat-list` to
> include the match if it is configured. I'm curious if there is any
> u
Signed-off-by: Sunyang Wu
---
lib/netdev-offload-dpdk.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 623005b1c..524942457 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@
created a new column in the southbound database to hardcode a human readable
description for flows. This first use is describing why the flow is dropping
packets.
The new column is called flow_desc and will create southbound database entries
like this
_uuid : 20f1897b-477e-47ae-a32
The only other suggestion I have is that it might be worth using the
sFlow-RT "sflow-test" app from time to time as an external test that will
only pass if the sFlow agent in OVS is behaving correctly for both counters
and packet samples. In addition to the browser UI it has an API that can be
quer
Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd
connections and northd static_route/policy_route changes.
Reported-at: https://issues.redhat.com/browse/FDP-600
Signed-off-by: Lorenzo Bianconi
---
Changes since v1:
- add incremental processing logic for bfd_consumer node to
On Wed, Apr 24, 2024 at 11:51 AM Lorenzo Bianconi
wrote:
>
> Similar to what is already implemented for routed e/w traffic,
> introduce pmtud support for e/w traffic between two logical switch ports
> connected to the same logical switch, but running on two different
> hypervisors.
>
> Acked-by: M
On 5/28/24 1:39 PM, Nathan Chancellor wrote:
On Mon, May 27, 2024 at 02:36:41PM -0700, John Hubbard wrote:
...
diff --git a/tools/testing/selftests/net/Makefile
b/tools/testing/selftests/net/Makefile
index bd01e4a0be2c..9a3b766c8781 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools
On Mon, May 27, 2024 at 02:36:41PM -0700, John Hubbard wrote:
> When building with clang, via:
>
> make LLVM=1 -C tools/testing/selftest
>
> ...clang warns that "a variable sized type not at the end of a struct or
> class is a GNU extension".
>
> These cases are not easily changed, because t
On 5/27/24 13:00, Roi Dayan via dev wrote:
> Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
>
> lib/netdev-linux.c: In function ‘netdev_linux_construct’:
> lib/netdev-linux.c:7003:15: error: array subscript ‘struct ethtool_cmd[0]’ is
> partly outside array bounds of ‘union [1]’ [-Werror=ar
On Tue, May 28, 2024 at 4:26 PM Ilya Maximets wrote:
>
> On 5/27/24 21:08, Mike Pattrick wrote:
> > Clang's static analyzer noted that the output from
> > netdev_linux_get_speed_locked can be checked even if this function
> > doesn't set any values.
> >
> > Now we always set those values to a sane
On 5/27/24 21:08, Mike Pattrick wrote:
> Clang's static analyzer noted that the output from
> netdev_linux_get_speed_locked can be checked even if this function
> doesn't set any values.
>
> Now we always set those values to a sane default in all cases.
>
> Fixes: b8f8fad86435 ("netdev-linux: Use
Hi Ales,
I have some nitpicky findings on this. I think they can be fixed when
the patch is merged, so
Acked-by: Mark Michelson
See below for my findings/questions.
On 5/3/24 03:26, Ales Musil wrote:
Use the newly added NAT match and priority column in logical flows.
This allows to differe
Thanks Ales, I have just one question about this.
I noticed that you have updated the output of `ovn-nbctl lr-nat-list` to
include the match if it is configured. I'm curious if there is any
utility in printing the priority as well?
On 5/3/24 03:26, Ales Musil wrote:
Add support for match and
Thanks Ales, it looks good to me.
Acked-by: Mark Michelson
On 5/3/24 03:26, Ales Musil wrote:
The priority calculation was scattered in multiple places which
could result in errors when the code is being updated. Move it
to common function that makes it very clear how is the priority
calculate
On 5/28/24 13:39, Eelco Chaudron wrote:
> This patch fixes an uninitialized gso_type case in
> netdev_linux_prepend_vnet_hdr() by returning an error.
>
> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
> Signed-off-by: Eelco Chaudron
> ---
> lib/netdev-linux.c | 5 ++
On 5/28/24 13:39, Eelco Chaudron wrote:
> Changed sFlowRcvrTimeout to a uint32_t to avoid time_t warnings
> reported by Coverity. A uint32_t is more than large enough as
> this is a (seconds) tick counter and OVS is not even using this.
>
> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to
Eelco Chaudron writes:
> Fix the warning from Coverity about potential truncation of the
> time_t value when copying to a local variable by changing the
> local variable's type to time_t.
>
> ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb
> entry.")
It seems "Fixes:"
On Tue, May 28, 2024 at 7:46 AM Eelco Chaudron wrote:
>
> Fix the warning from Coverity about potential truncation of the
> time_t value when copying to a local variable by changing the
> local variable's type to time_t.
>
> ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb
On Tue, May 28, 2024 at 7:46 AM Eelco Chaudron wrote:
>
> The sFlow library uses a uint32_t to configure timeout ticks, but
> stores this value as a time_t. Although this doesn't cause functional
> issues, it wastes space and confuses Coverity, potentially indicating
> a Y2K38 problem when storing
On 5/28/24 19:35, Ilya Maximets wrote:
> On 5/21/24 10:38, Martin Kalcok wrote:
>> Help text for 'ovsdb-client dump' does not mention that it's capable
>> of dumping a specific column's contents if the user supplies the
>> column's name as a fourth positional argument.
>>
>> Signed-off-by: Martin K
On 5/21/24 10:38, Martin Kalcok wrote:
> Help text for 'ovsdb-client dump' does not mention that it's capable
> of dumping a specific column's contents if the user supplies the
> column's name as a fourth positional argument.
>
> Signed-off-by: Martin Kalcok
> ---
> ovsdb/ovsdb-client.c | 6 +++-
On Tue, May 28, 2024 at 7:46 AM Eelco Chaudron wrote:
>
> Coverity has flagged the use of a potentially unsafe function.
> Although this is not a concern in this case since it's not used for
> encryption, we should replace it with the OVS implementation to
> achieve better randomness.
>
> Fixes: c
On 5/25/24 12:18, wushao...@chinatelecom.cn wrote:
> From: Shaohua Wu
>
> In scenarios with multiple PMDs, there may be
> simultaneous requests for recirc_id from multiple
> PMD threads.In recirc_alloc_id_ctx, we first check
> if there is a duplicate entry in the metadata_map
> for the same froze
On Tue, May 28, 2024 at 7:46 AM Eelco Chaudron wrote:
>
> Fix unintentional integer overflow reported by Coverity by adding
> the LL suffix to the numerical literals used in the multiplication.
>
> Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
> Signed-off-by: Eelco Chaudron
On 5/26/24 10:31, Roi Dayan via dev wrote:
> From: Maor Dickman
>
> The cited commit reserved lower tc priorities for IP ethertypes in order
> to give IP traffic higher priority than other management traffic.
> In case of of vlan encap traffic, IP traffic will still get lower
> priority.
>
> Fix
On 5/23/24 09:50, wushao...@chinatelecom.cn wrote:
> From: Shaohua Wu
>
> description:
> The statistics for the cached DP flow table are updated in
> packet_batch_per_flow_execute. There might be a timing gap
> where the dp flow in the batch reaches its aging time and
> is prematurely aged. If ac
On 5/22/24 14:47, Eelco Chaudron wrote:
>
>
> On 21 May 2024, at 17:47, Simon Horman wrote:
>
>> On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote:
>>>
>>>
>>> On 20 May 2024, at 20:13, Simon Horman wrote:
>>>
From: Ville Skyttä
Fix CONFIG_HAVE_EBPF_JIT Kconfig optio
On 5/28/24 11:25, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 23.11.1.
>
> Signed-off-by: Kevin Traynor
> ---
> v2: update NEWS
> ---
> .github/workflows/build-and-test.yml | 4 ++--
> Documentation/faq/releases.rst | 10 +-
> Documentation/intro/install/dpdk.rst |
On 5/28/24 11:25, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 23.11.1.
>
> Signed-off-by: Kevin Traynor
> ---
> v2: update NEWS
> ---
> .github/workflows/build-and-test.yml | 4 ++--
> Documentation/faq/releases.rst | 10 +-
> Documentation/intro/install/dpdk.rst |
On 5/28/24 11:25, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 22.11.5.
>
> Signed-off-by: Kevin Traynor
> ---
> v2: no change
> ---
> .github/workflows/build-and-test.yml | 2 +-
> Documentation/faq/releases.rst | 8
> Documentation/intro/install/dpdk.rst | 8 ---
On 5/28/24 11:25, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 22.11.5.
>
> Signed-off-by: Kevin Traynor
> ---
> v2: no change
> ---
> .github/workflows/build-and-test.yml | 2 +-
> Documentation/faq/releases.rst | 6 +++---
> Documentation/intro/install/dpdk.rst | 8
Hi Ilya,
Thanks for the fix!
Some time ago we internally noticed a problem with index updates, which was not
a real issue, but I tried your fix and it fixes our original issue.
How we observed that issue:
In terminal one:
ovn-nbctl ls-add test
In terminal two:
Run python, load IDL and query th
On 5/28/24 11:25, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 21.11.7.
>
> Signed-off-by: Kevin Traynor
> ---
> v2: no change
> ---
> .ci/linux-build.sh | 2 +-
> Documentation/faq/releases.rst | 4 ++--
> Documentation/intro/install/dpdk.rst | 8
>
On 5/28/24 11:25, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 21.11.7.
>
> Signed-off-by: Kevin Traynor
> ---
> v2: no change
> ---
> .ci/linux-build.sh | 2 +-
> Documentation/faq/releases.rst | 2 +-
> Documentation/intro/install/dpdk.rst | 8
> N
On 5/23/24 09:40, laixiangwu wrote:
> Description:
>
> when 1) The fragment timeout is between 15 seconds and 25 seconds; 2)
> The ipf_list currently has received more than 32 fragments, and there
> are other fragments of same big packet that have not been received.
>
> When the above two scena
On 5/28/24 14:36, Eelco Chaudron wrote:
>
>
> On 24 May 2024, at 11:20, Emma Finn wrote:
>
>> The AVX implementation for calcualting checksums was not
>> handling carry-over addition correctly in some cases.
>> This patch adds an additional shuffle to add 16-bit padding to
>> the final part of t
On Tue, May 28, 2024 at 7:46 AM Eelco Chaudron wrote:
>
> Fix unintentional integer overflow reported by Coverity by adding
> the ULL suffix to the numerical literals used in the multiplications.
>
> Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink
> message")
> Signed-off-b
On 24 May 2024, at 11:20, Emma Finn wrote:
> The AVX implementation for calcualting checksums was not
> handling carry-over addition correctly in some cases.
> This patch adds an additional shuffle to add 16-bit padding to
> the final part of the calculation to handle such cases. This
> commit a
On 5/28/24 13:27, Eelco Chaudron wrote:
>
>
> On 28 May 2024, at 1:04, Neil McKee wrote:
>
>> Would it help if I set up a separate github project for this sFlow encoding
>> C code? Then we could make it easier to incorporate in OVS by fixing the
>> whitespace and indentation issues there, and m
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 97 characters long (recommended limit is 79)
#38 FILE: lib/sflow_api.h:255:
This patch fixes an uninitialized gso_type case in
netdev_linux_prepend_vnet_hdr() by returning an error.
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib
Coverity was flagged that the uninitialized output variable was used
in the ctl_context_init_command() function. This patch initializes
the variable.
In addition it also destroys the ds string in ctl_context_done()
in case it's not cleared properly.
Fixes: 07ff77ccb82a ("db-ctl-base: Make common
Fix the warning from Coverity about potential truncation of the
time_t value when copying to a local variable by changing the
local variable's type to time_t.
ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb
entry.")
Signed-off-by: Eelco Chaudron
---
ofproto/ofproto-dpi
Changed sFlowRcvrTimeout to a uint32_t to avoid time_t warnings
reported by Coverity. A uint32_t is more than large enough as
this is a (seconds) tick counter and OVS is not even using this.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
Fix unintentional integer overflow reported by Coverity by adding
the LL suffix to the numerical literals used in the multiplication.
Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
Signed-off-by: Eelco Chaudron
---
lib/cfm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
The sFlow library uses a uint32_t to configure timeout ticks, but
stores this value as a time_t. Although this doesn't cause functional
issues, it wastes space and confuses Coverity, potentially indicating
a Y2K38 problem when storing uint32_t values in time_t. This patch
updates the internal data
Coverity has flagged the use of a potentially unsafe function.
Although this is not a concern in this case since it's not used for
encryption, we should replace it with the OVS implementation to
achieve better randomness.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Fix unintentional integer overflow reported by Coverity by adding
the ULL suffix to the numerical literals used in the multiplications.
Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink message")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 4 ++--
1 file changed,
This series addresses several high-priority Coverity issues.
Delta from v1 -> v2:
- Add cover letter.
- Split first patch and update commit subject.
- Added ds_destroy() to context_done().
- Changed invalid gso_type handling by returning an error + log message.
- Changed sFlowRcvrTimeout to be us
On 28 May 2024, at 1:04, Neil McKee wrote:
> Would it help if I set up a separate github project for this sFlow encoding
> C code? Then we could make it easier to incorporate in OVS by fixing the
> whitespace and indentation issues there, and maybe change all the "time_t"
> variables to uint32_
On 27 May 2024, at 16:42, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Instead of casting time_t to uint32_t for the 0x comparison,
>> define a TIME_T_MAX and use it for both setting and comparison.
>>
>> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the b
On 27 May 2024, at 16:56, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> This patch fixes a uninitialized gso_type case in
>> netdev_linux_prepend_vnet_hdr().
>>
>> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
>> Signed-off-by: Eelco Chaudron
On 27 May 2024, at 16:50, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Coverity was flagged that the uninitialized output variable was used
>> in the ctl_context_init_command() function. This patch initializes
>> the variable.
>>
>> Fixes: 07ff77ccb82a ("db-ctl-base: Make c
Update the CI and docs to use DPDK 22.11.5.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 6 +++---
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files cha
Update the CI and docs to use DPDK 23.11.1.
Signed-off-by: Kevin Traynor
---
v2: update NEWS
---
.github/workflows/build-and-test.yml | 4 ++--
Documentation/faq/releases.rst | 10 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
Update the CI and docs to use DPDK 22.11.5.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 8
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files c
Update the CI and docs to use DPDK 23.11.1.
Signed-off-by: Kevin Traynor
---
v2: update NEWS
---
.github/workflows/build-and-test.yml | 4 ++--
Documentation/faq/releases.rst | 10 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
Update the CI and docs to use DPDK 21.11.7.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 2 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files changed
Update the CI and docs to use DPDK 21.11.7.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 4 ++--
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files chang
On 27/05/2024 23:28, Ilya Maximets wrote:
> On 5/23/24 18:00, Kevin Traynor wrote:
>> Update the CI and docs to use DPDK 23.11.1.
>>
>> Signed-off-by: Kevin Traynor
>> ---
>> .github/workflows/build-and-test.yml | 4 ++--
>> Documentation/faq/releases.rst | 10 +-
>> Documentation/
Getting the following message while trying to build a debian package.
debian/openvswitch-switch.init
debian/openvswitch-switch.postinst
See above for files that use tabs for indentation.
Please use spaces instead.
Fix it.
Signed-off-by: Roi Dayan
---
debian/openvswitch-switch.init | 22 +
On 27 May 2024, at 16:04, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Fix three Unintentional integer overflow reports by adding the
>> ULL/LL suffix to the numerical literals used in the multiplications.
>>
>> Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode
62 matches
Mail list logo
