> On 29 Mar 2023, at 16:21, Dumitru Ceara wrote:
>
> On 3/29/23 12:00, Abhiram Sangana wrote:
>>>>> @@ -896,6 +904,26 @@ put_local_common_flows(uint32_t dp_key,
>>>>>pb->header_.uuid.parts[0], &match, ofpacts
Hi Dumitru,
Thanks for reviewing the patch.
> On 23 Mar 2023, at 20:59, Dumitru Ceara wrote:
>
> On 3/17/23 20:34, Numan Siddique wrote:
>> On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana
>> wrote:
>>>
>>> This patch adds support to commit connecti
> On 18 Mar 2023, at 01:04, Numan Siddique wrote:
>
> On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana
> wrote:
>>
>> This patch adds support to commit connections dropped/rejected by
>> ACLs to the connection tracking table. Dropped connections are
>
> On 13 Feb 2023, at 16:35, Abhiram Sangana wrote:
>
> This patch adds support to commit connections dropped/rejected by
> ACLs to the connection tracking table. Dropped connections are
> committed to conntrack only if NB_Global options:ct_commit_acl_drop
> is set to true
ntified by
MFF_LOG_ACL_DROP_ZONE register. An ACL with "drop" or "reject" action
and non-empty label translates to include "ct_commit_drop" in its
actions instead of simply dropping/rejecting the packet.
Signed-off-by: Abhiram Sangana
---
controller/ovn-controller.c | 14
> On 3 Feb 2023, at 16:08, Mark Michelson wrote:
>
> On 1/25/23 05:36, Abhiram Sangana wrote:
>> Hi Mark,
>> I have replied to your comments. Can you please have a look when you get a
>> chance?
>
> I had a look at the code itself, and from a purely mecha
Hi Mark,
I have replied to your comments. Can you please have a look when you get a
chance?
Thanks,
Abhiram Sangana
> On 17 Jan 2023, at 12:37, Abhiram Sangana wrote:
>
> Hi Mark,
>
> Thanks for reviewing the patch.
>
>> On 16 Jan 2023, at 21:34, Mark Michelson wro
https://github.com/openvswitch/ovs/commit/cb2a5486a3a3756ee3868da0050d737c8989770c
> Thanks,
> Mark Michelson
Thanks,
Abhiram Sangana
> On 1/13/23 07:44, Abhiram Sangana wrote:
>> This patch commits connections dropped/rejected by ACLs with label
>> (introduced in 0e0228be (northd: A
by ACLs
besides the existing ACL logging and drop sampling approaches.
Signed-off-by: Abhiram Sangana
---
controller/ovn-controller.c | 14 +++--
controller/physical.c| 32 ++-
include/ovn/actions.h| 1 +
include/ovn/logical-fields.h | 1 +
lib/actions.c
Hi Adrian,
I apologise for the delay in replying back.
> On 14 Nov 2022, at 13:05, Adrian Moreno wrote:
>
> Hi,
>
> On 10/20/22 15:49, Abhiram Sangana wrote:
>> Hi Dumitru,
>> Thanks for reviewing the patch.
>>> On 19 Oct 2022, at 14:09, Dumit
> On 1 Nov 2022, at 12:35, Dumitru Ceara wrote:
>
> On 11/1/22 12:40, Abhiram Sangana wrote:
>>
>>
>>> On 21 Oct 2022, at 10:58, Dumitru Ceara wrote:
>>>
>>> On 10/20/22 17:34, Abhiram Sangana wrote:
>>>> Hi Dumitru,
>>&g
> On 21 Oct 2022, at 10:58, Dumitru Ceara wrote:
>
> On 10/20/22 17:34, Abhiram Sangana wrote:
>> Hi Dumitru,
>>
>> Can you please check if the implementation for the proposal looks ok?
>> Will send out v1 with the review comments and tests.
>> Also,
parent LS doesn’t have drop ACLs with labels.
Thanks,
Abhiram Sangana
> On 20 Oct 2022, at 15:18, Dumitru Ceara wrote:
>
> On 10/20/22 15:49, Abhiram Sangana wrote:
>> Hi Dumitru,
>>
>> Thanks for reviewing the patch.
>>
>>> On 19 Oct 2022, at 14:09,
Hi Dumitru,
Thanks for reviewing the patch.
> On 19 Oct 2022, at 14:09, Dumitru Ceara wrote:
>
> Hi Abhiram,
>
> Thanks for the patch! I only skimmed the changes so this is not a full
> review but more of a discussion starter.
>
> On 10/18/22 17:33, Abhiram Sanga
ntly dropping the packet.
Signed-off-by: Abhiram Sangana
---
controller/ovn-controller.c | 23 ++---
controller/physical.c| 32 +--
include/ovn/actions.h| 1 +
include/ovn/logical-fields.h | 1 +
lib/actions.c| 50
Thank you for reviewing the patch, Mark and Han.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Mark,
Thanks for reviewing the patch. I have made the suggested changes and sent out
a v2 patch.
Thanks,
Abhiram Sangana
On 19 May 2022, at 21:06, Mark Michelson
mailto:mmich...@redhat.com>> wrote:
Hi Abhiram,
This is a great idea. I only have a couple of minor comments
ehavior by inferring the DGP where the NAT
rule needs to be applied based on the "external_ip" column of the
NAT rule when "gateway_port" column is not set.
Signed-off-by: Abhiram Sangana
---
lib/ovn-util.c| 56
lib/ovn-util.h
ehavior by inferring the DGP where the NAT
rule needs to be applied based on the "external_ip" column of the
NAT rule when "gateway_port" column is not set.
Signed-off-by: Abhiram Sangana
---
northd/northd.c | 49 --
northd/ovn-northd.8.x
Thanks for reviewing, Mark. Can we merge the patch if it looks good?
Thanks,
Abhiram Sangana
> On 4 Apr 2022, at 21:05, Mark Michelson wrote:
>
> Hi Abhriam,
>
> Thanks for you patience on this. It looks good by me.
>
> Ack
Hi Numan,
Uploaded v5 patch making the column as weak reference and fixing the tests with
—sync=sb.
V4 patch was already ignoring a NAT rule if gateway_port is not set and LR has
multiple DGP.
The behaviour is same in v5.
Will send out a patch to determine gateway port for a NAT rule when it is
an error to not set this
column for a NAT rule when the router has multiple DGPs.
This patch also updates the NAT commands in ovn-nbctl to support the
new column.
Signed-off-by: Abhiram Sangana
---
NEWS | 1 +
northd/northd.c | 184 +--
Hi Numan,
Is it ok if we make the “gateway_port” column optional in a subsequent patch?
Will send out a v5 patch that addresses other comments.
Thanks,
Abhiram Sangana
> On 30 Mar 2022, at 19:32, Numan Siddique wrote:
>
> On Wed, Mar 30, 2022 at 1:41 PM Abhiram Sangana
> wrot
T_CHECK is
> called.
>
> There are many places in the test case you can do the same i..e use
> --wait=sb/hv.
>
> Can you please check and add this in the relevant places ?
Sure, will fix this.
Thanks,
Abhiram Sangana
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
CHECK is
called.
There are many places in the test case you can do the same i..e use
--wait=sb/hv.
Can you please check and add this in the relevant places ?
Sure, will fix this.
Thanks,
Abhiram Sangana
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
an error to not set this
column for a NAT rule when the router has multiple DGPs.
This patch also updates the NAT commands in ovn-nbctl to support the
new column.
Signed-off-by: Abhiram Sangana
---
NEWS | 1 +
northd/northd.c | 184 +--
> On 22 Mar 2022, at 14:31, Mark Michelson wrote:
>
> No, that was not my intention. Basically, the following forms would never
> return an error:
>
> ovn-nbctl lr-nat-del my_router dnat (type only)
> ovn-nbctl lr-nat-del my_router dnat 172.16.0.1 (type and IP)
> ovn-nbctl lr-nat-del my_rout
we never expect to match a single
NAT rule and hence, we would not need —if_exists, right? I will retain the arg
but we might never hit that case.
Thanks,
Abhiram Sangana
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hey Mark,
Thanks for reviewing the patch. Regarding `ovn-nbctl lr-nat-del`, I
have updated the command to have the following structure:
`lr-nat-del ROUTER [TYPE [IP [GATEWAY_PORT]]]`. Most of the
earlier checks are not enforced unless `GATEWAY_PORT` is also
passed.
With the new patch, a NAT rule
an error to not set this
column for a NAT rule when the router has multiple DGPs.
This patch also updates the NAT commands in ovn-nbctl to support the
new column.
Signed-off-by: Abhiram Sangana
---
NEWS | 1 +
northd/northd.c | 182 +++---
Hi Mark,
Thanks for looking into this patch.
> On 5 Jan 2022, at 22:01, Mark Michelson wrote:
>
> Hi,
>
> I haven't done a full review of this patch, but I have noticed a problem
> pretty early on when I started looking.
>
> The new ip_in_lrp_networks() function that is added here is intende
packets entering or leaving a specific
DGP only if the external_ip of the rule belongs to the same subnet as the
DGP.
This patch also updates ovn-nbctl to accept multiple NAT rules of type
`snat` with the same logical_ip but different external_ip for a logical
router.
Signed-off-by: Abhiram Sangana
packets entering or leaving a specific
DGP only if the external_ip of the rule belongs to the same subnet as the
DGP.
This patch also updates ovn-nbctl to accept multiple NAT rules of type
`snat` with the same logical_ip but different external_ip for a logical
router.
Signed-off-by: Abhiram Sangana
packets entering or leaving a specific
DGP only if the external_ip of the rule belongs to the same subnet as the
DGP.
This patch also updates ovn-nbctl to accept multiple NAT rules of type
`snat` with the same logical_ip but different external_ip for a logical
router.
Signed-off-by: Abhiram Sangana
34 matches
Mail list logo
