drop extra space? (I noticed it was originally like this.
...
> +#define MODULE_ALIAS_GENL_FAMILY(family) \
> + MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-"
> family)
I would still make this TAB indented.
efine MODULE_ALIAS_GENL_FAMILY(family) \
> + MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-"
> family)
This is using the macro defined in net.h which seems not being included.
--
With Best Regards,
Andy Shevchenko
_
On Wed, Feb 8, 2023 at 6:29 AM Jakub Kicinski wrote:
> On Mon, 6 Feb 2023 18:13:12 +0200 Andy Shevchenko wrote:
> > +static inline bool string_is_valid(const char *s, int len)
> > +{
> > + return memchr(s, '\0', len) ? true : false;
> > +}
>
> I was
:
> Reviewed-by: Jiri Pirko
Thank you!
--
With Best Regards,
Andy Shevchenko
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Use string_is_terminated() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v3: renamed to string_is_terminated (Jakub)
v2: added tag and updated subject (Simon)
net/netlink/genetlink.c | 4
Use string_is_terminated() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v3: renamed to string_is_terminated (Jakub)
v2: added tag and updated subject (Simon)
net/openvswitch/conntrack.c | 5
Move string_is_valid() to the header for wider use.
While at it, rename to string_is_terminated() to be
precise about its semantics.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v3: renamed to string_is_terminated (Jakub)
v2: added tag and updated subject (Simon)
include/linux
Move string_is_valid() to the header for wider use.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v2: added tag and updated subject (Simon)
include/linux/string_helpers.h | 5 +
net/tipc/netlink_compat.c | 6 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff
Use string_is_valid() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v2: added tag and updated subject (Simon)
net/netlink/genetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Use string_is_valid() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Horman
---
v2: added tag and updated subject (Simon)
net/openvswitch/conntrack.c | 5 +++--
1 file changed, 3 insertions(+), 2
Move string_is_valid() to the header for wider use.
Signed-off-by: Andy Shevchenko
---
include/linux/string_helpers.h | 5 +
net/tipc/netlink_compat.c | 6 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/linux/string_helpers.h b/include/linux
Use string_is_valid() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
---
net/openvswitch/conntrack.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch
Use string_is_valid() helper instead of cpecific memchr() call.
This shows better the intention of the call.
Signed-off-by: Andy Shevchenko
---
net/netlink/genetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index
again it's not more clear. Authors here are going for
> a 24-bit number, and masking seems like a clear way to express that.
We have some 24-bit APIs (and 48-bit) already in kernel, why not to have
get_random_u24() ?
--
With Best Regards,
Andy Shevchenko
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
; have a chance to flow through subsystem trees.
+1 to all arguments for the splitting.
I looked a bit into the code I have the interest to, but I won't spam people
with not-so-important questions / comments / tags, etc.
--
With Best Regards,
Andy Shevchenko
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
catch. I'll move these to patch #1.
I believe coccinelle is able to handle this kind of code as well, so Kees'
proposal to use it seems more plausible since it's less error prone and more
flexible / powerful.
--
With Best Regards,
Andy Shevchenko
___
masked_flow_lookup(ti, match->key, mask, _mask_hit);
> + flow = masked_flow_lookup(ti, match->key, mask, NULL);
> if (flow && ovs_identifier_is_key(>id) &&
> ovs_flow_cmp_unmasked_key(flow, match)) {
> return flow;
> --
> 2.18.1
>
--
With Best Regards,
Andy Shevchenko
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
17 matches
Mail list logo
