[ovs-dev] [PATCH v2] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings

2019-05-16 Thread Ankur Sharma
queueing logic added by 1c24b2f490ba002bbfeb23006965188a7c5b9747. Signed-off-by: Ankur Sharma Reported-by: Ankur Sharma CC: Lorenzo Bianconi Fixes: 1c24b2f490ba ("OVN: fix pinctrl ip buffering for gw router port") --- ovn/controller/pinctrl.c | 9 ++--- 1 file changed, 6 insertions(

Re: [ovs-dev] [PATCH v1] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings

2019-05-15 Thread Ankur Sharma
Hi Numan, Just confirming, anything else pending from my side? or given that patch has been Acked, hence someone will apply it to master? Thanks Regards, Ankur From: Numan Siddique Sent: Wednesday, May 15, 2019 11:43 AM To: Ankur Sharma Cc: Han Zhou ; ovs-dev@openvswitch.org Subject: Re

[ovs-dev] [PATCH v8 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-05-10 Thread Ankur Sharma
, and hence in the absence of NATing configuration we need redirect the packet to gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 24 +++- ovn/controller/pinctrl.c | 205 ++ ovn/controller/pinctrl.h | 6 + ovn/lib/ovn-util.c

[ovs-dev] [PATCH v8 0/2] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-05-10 Thread Ankur Sharma
nd commit message. * Converted the patchset to 2 patches. * Changes in nbctl to NOT set to network_type during logical switch create. * Fixed 3 space indentation. v2 -> v3 - * Rebased with TOT. v1 -> v2 -- * Fixed unit tests and review comments. Ankur Sharma (2): OVN: En

[ovs-dev] [PATCH v8 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-10 Thread Ankur Sharma
ther avoid redirection totally (if there is no NAT) or do redirection based on router port mac, rather than encap over a tunnel. Signed-off-by: Ankur Sharma --- ovn/controller/binding.c| 12 +-- ovn/controller/chassis.c| 64 +++- ovn/controller/chassis.h| 4 + ovn/c

Re: [ovs-dev] [PATCH v7 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-05-10 Thread Ankur Sharma
Hi Numan, Thanks for trying out the patch. Please find my comments inline. Regards, Ankur From: Numan Siddique Sent: Friday, May 10, 2019 5:44 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 2/2] OVN: Enable N-S Traffic, Vlan backed DVR On Thu, May 9, 2019

Re: [ovs-dev] [PATCH v7 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-10 Thread Ankur Sharma
in this regard, let me know if i can take it as a follow up activity, we can have a more thorough discussion on it. Thanks Regards, Ankur From: Numan Siddique Sent: Friday, May 10, 2019 5:39 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 1/2] OVN: Enable E

Re: [ovs-dev] [PATCH v1] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings

2019-05-10 Thread Ankur Sharma
:47 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings On Fri, May 10, 2019 at 2:46 PM Ankur Sharma mailto:ankur.sha...@nutanix.com>> wrote: > > ISSUE: > a. As soon as en

[ovs-dev] [PATCH v1] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings

2019-05-10 Thread Ankur Sharma
ut_mac_bindings back in run_put_mac_bindings. b. Additioanlly, logic mentioned in ROOT_CAUSE.b has been changed in 1c24b2f490ba002bbfeb23006965188a7c5b9747, hence updated the documentation in pinctrl.c accordingly. Signed-off-by: Ankur Sharma --- ovn/controller/pinctrl.c | 9 ++--- 1 file changed, 6 insert

Re: [ovs-dev] [PATCH v5 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-08 Thread Ankur Sharma
Hi Numan, Thanks for the feedback. Submitted v7 with updated ovn-architecture.xml. Thanks Regards, Ankur From: Numan Siddique Sent: Wednesday, May 8, 2019 4:30 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v5 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

[ovs-dev] [PATCH v7 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-05-08 Thread Ankur Sharma
, and hence in the absence of NATing configuration we need redirect the packet to gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 24 +++- ovn/controller/pinctrl.c | 205 ++ ovn/controller/pinctrl.h | 6 + ovn/lib/ovn-util.c

[ovs-dev] [PATCH v7 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-08 Thread Ankur Sharma
ther avoid redirection totally (if there is no NAT) or do redirection based on router port mac, rather than encap over a tunnel. Signed-off-by: Ankur Sharma --- ovn/controller/binding.c| 12 +-- ovn/controller/chassis.c| 64 +++- ovn/controller/chassis.h| 4 + ovn/c

[ovs-dev] [PATCH v7 0/2] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-05-08 Thread Ankur Sharma
2 patches. * Changes in nbctl to NOT set to network_type during logical switch create. * Fixed 3 space indentation. v2 -> v3 - * Rebased with TOT. v1 -> v2 -- * Fixed unit tests and review comments. Ankur Sharma (2): OVN: Enable E-W Traffic, Vlan backed DVR OVN: Enable N-S Tra

[ovs-dev] [PATCH v6 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-05-07 Thread Ankur Sharma
, and hence in the absence of NATing configuration we need redirect the packet to gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 24 +++- ovn/controller/pinctrl.c | 205 +++ ovn/controller/pinctrl.h | 6 + ovn/lib/ovn-util.c

[ovs-dev] [PATCH v6 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-07 Thread Ankur Sharma
ther avoid redirection totally (if there is no NAT) or do redirection based on router port mac, rather than encap over a tunnel. Signed-off-by: Ankur Sharma --- ovn/controller/binding.c| 12 +-- ovn/controller/chassis.c| 64 +++- ovn/controller/chassis.h| 4 + ovn/c

[ovs-dev] [PATCH v6 0/2] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-05-07 Thread Ankur Sharma
ogical switch create. * Fixed 3 space indentation. v2 -> v3 - * Rebased with TOT. v1 -> v2 -- * Fixed unit tests and review comments. Ankur Sharma (2): OVN: Enable E-W Traffic, Vlan backed DVR OVN: Enable N-S Traffic, Vlan backed DVR ovn/controller/binding.c| 12

Re: [ovs-dev] [PATCH v5 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-07 Thread Ankur Sharma
Hi Numan, Thank you so much for trying out the patch. Please find my replies inline regarding your test. For other comments in the code, i will be happy to make the change and v6 will have it. Thanks Regards, Ankur From: Numan Siddique Sent: Tuesday, May 7, 2019 10:07 AM To: Ankur Sharma

Re: [ovs-dev] [PATCH v4 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-02 Thread Ankur Sharma
Hi Numan, Thanks for the feedback. Just submitted the V5, please take a look. Regards, Ankur From: Numan Siddique Sent: Thursday, May 2, 2019 1:54 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v4 1/2] OVN: Enable E-W Traffic, Vlan backed DVR On Thu, May 2

[ovs-dev] [PATCH v5 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-05-02 Thread Ankur Sharma
, and hence in the absence of NATing configuration we need redirect the packet to gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 24 +++- ovn/controller/pinctrl.c | 205 +++ ovn/controller/pinctrl.h | 6 + ovn/lib/ovn-util.c

[ovs-dev] [PATCH v5 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-02 Thread Ankur Sharma
ther avoid redirection totally (if there is no NAT) or do redirection based on router port mac, rather than encap over a tunnel. Signed-off-by: Ankur Sharma --- ovn/controller/binding.c| 12 +-- ovn/controller/chassis.c| 66 +++- ovn/controller/chassis.h| 4 + ovn/c

[ovs-dev] [PATCH v5 0/2] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-05-02 Thread Ankur Sharma
th traffic in the absence of NAT etc. This series does not cover following: (will be sent out for review in follow up series once this series is reviewed/committed) a. Network Address Translation. b. Ensuring VMs mac is learnt in underlay network to avoid flooding of L3 flows. Ankur Sharma (2): OVN: Enable E

Re: [ovs-dev] [PATCH v4 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-01 Thread Ankur Sharma
, Ankur From: Numan Siddique Sent: Monday, April 29, 2019 3:55 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v4 1/2] OVN: Enable E-W Traffic, Vlan backed DVR On Fri, Apr 26, 2019 at 5:47 AM Ankur Sharma mailto:ankur.sha...@nutanix.com>> wrote: Hi Numan,

Re: [ovs-dev] [PATCH v4 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-04-25 Thread Ankur Sharma
on inline on rest of the comments. Will make these changes in v5. Thanks Regards, Ankur From: Numan Siddique Sent: Thursday, April 25, 2019 1:40 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v4 1/2] OVN: Enable E-W Traffic, Vlan backed DVR On Thu, Apr 25, 2019

Re: [ovs-dev] [PATCH v3 0/4] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-04-24 Thread Ankur Sharma
indentations. Please take a look. Appreciate your feedback. Regards, Ankur -Original Message- From: Ben Pfaff Sent: Wednesday, April 17, 2019 11:17 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 0/4] OVN: Distributed Virtual Router for Vlan Backed Networks

[ovs-dev] [PATCH v4 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-04-24 Thread Ankur Sharma
, and hence in the absence of NATing configuration we need redirect the packet to gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 24 +++- ovn/controller/pinctrl.c | 206 +++ ovn/controller/pinctrl.h | 6 + ovn/lib/ovn-util.c

[ovs-dev] [PATCH v4 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-04-24 Thread Ankur Sharma
"vlan". This is done to simplify the coding, otherwise anytime where implementation has to differ for overlay and vlan backed logical switches, we will have to go through all the ports and see if it has a localnet port or not. Signed-off-by: Ankur Sharma --- ovn/controller/binding.c

[ovs-dev] [PATCH v4 0/2] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-04-24 Thread Ankur Sharma
th traffic in the absence of NAT etc. This series does not cover following: (will be sent out for review in follow up series once this series is reviewed/committed) a. Network Address Translation. b. Ensuring VMs mac is learnt in underlay network to avoid flooding of L3 flows. Ankur Sharma (2): OVN:

Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-22 Thread Ankur Sharma
Hi Ben, You are right, somehow missed these comments. Will submit a v4 soon. Thanks Regards, Ankur -Original Message- From: Ben Pfaff Sent: Monday, April 22, 2019 1:30 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user

Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-17 Thread Ankur Sharma
Hi Ben, Sorry, somehow messed up the 3rd patch. Submitted a v4 of this series. Thanks Regards, Ankur -Original Message- From: Ben Pfaff Sent: Wednesday, April 17, 2019 10:46 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user

[ovs-dev] [PATCH v4 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-17 Thread Ankur Sharma
This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. Signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [PATCH v4 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-04-17 Thread Ankur Sharma
-by: Ankur Sharma --- include/ovn/actions.h | 3 ++ ovn/lib/actions.c | 78 +-- ovn/ovn-sb.xml| 39 ++ tests/ovn.at | 16 +++ 4 files changed, 117 insertions(+), 19 deletions(-) diff --git a/include/ovn

[ovs-dev] [PATCH v4 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-04-17 Thread Ankur Sharma
for storing other values like, identifier for corresponidng OVN ACL/Security group etc. Signed-off-by: Ankur Sharma --- Documentation/tutorials/ovn-openstack.rst | 12 ovn/lib/logical-fields.c | 3 ++ ovn/northd/ovn-northd.8.xml | 14 - ovn/northd/ovn

[ovs-dev] [PATCH v4 0/3] Associate identifier with OVN ACL connection tracking entry

2019-04-17 Thread Ankur Sharma
0[1] = 1; reg0[3] = 1; xxreg1 = 0x1234; next;) . . . table=7 (ls_out_stateful), ... match=(reg0[1] == 1 && reg0[3] == 1), action=(ct_commit(ct_mark=0/1, ct_label=xxreg1); next;) Ankur Sharma (3): OVN ACL: Replac

[ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-16 Thread Ankur Sharma
This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. Signed-off-by: Ankur Sharma --- ovn/ovn

[ovs-dev] [PATCH v3 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-04-16 Thread Ankur Sharma
-by: Ankur Sharma --- include/ovn/actions.h | 3 ++ ovn/lib/actions.c | 77 +-- ovn/ovn-sb.xml| 20 +++-- tests/ovn.at | 16 +++ 4 files changed, 99 insertions(+), 17 deletions(-) diff --git a/include/ovn/actions.h b

[ovs-dev] [PATCH v3 0/3] Associate identifier with OVN ACL connection tracking entry

2019-04-16 Thread Ankur Sharma
, ct_label=xxreg1); next;) Ankur Sharma (3): OVN ACL: Replace the usage of ct_label with ct_mark OVN ACL: Allow ct_mark and ct_label values to be set from register as well OVN ACL: Allow a user to input ct.label value for an acl Documentation/tutorials/ovn-openstack.rst | 12 ++---

[ovs-dev] [PATCH v3 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-04-16 Thread Ankur Sharma
for storing other values like, identifier for corresponidng OVN ACL/Security group etc. Signed-off-by: Ankur Sharma --- Documentation/tutorials/ovn-openstack.rst | 12 ovn/lib/logical-fields.c | 3 ++ ovn/northd/ovn-northd.8.xml | 14 - ovn/northd/ovn

[ovs-dev] [PATCH v3 4/4] L3 N-S support in ovn, avoid chassis redirection as default for vlan backed networks

2019-04-16 Thread Ankur Sharma
traffic need not go via redirect chassis for VLAN backed networks. In the absence of NATing (or any other service provided by a centralized chassis), we need not redirect the South to North traffic for non overlay traffic. Signed-off-by: Ankur Sharma --- ovn/northd/ovn-northd.c | 43

[ovs-dev] [PATCH v3 3/4] L3 N-S support in ovn, do not replace router port mac on gateway chassis

2019-04-16 Thread Ankur Sharma
router. This Patch: a. Do not replace router port mac, if the corrsponding cr- port is resident on current chassis. b. We do not need this, as gateway chassis is where we will advertise the router port mac. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 26 ++-- ovn

[ovs-dev] [PATCH v3 2/4] L3 N-S support in ovn, advertise router port mac from gateway chassis

2019-04-16 Thread Ankur Sharma
, then south to north traffic will also go via gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/pinctrl.c | 167 --- ovn/lib/ovn-util.c | 31 + ovn/lib/ovn-util.h | 6 ++ 3 files changed, 195 insertions(+), 9 deletions

[ovs-dev] [PATCH v3 1/4] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-04-16 Thread Ankur Sharma
ority=150. For example: cookie=0x0, duration=67765.830s, table=65, n_packets=0, n_bytes=0, idle_age=65534, hard_age=65534, priority=150,reg15=0x1,metadata=0x4, dl_src=00:00:01:01:02:03 actions=mod_dl_src:aa:bb:cc:dd:ee:ff, mod_vlan_vid:1000,output:16 c. Unit tests to validate above. Signed-o

[ovs-dev] [PATCH v3 0/4] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-04-16 Thread Ankur Sharma
th traffic in the absence of NAT etc. This series does not cover following: (will be sent out for review in follow up series once this series is reviewed/committed) a. Network Address Translation. b. Ensuring VMs mac is learnt in underlay network to avoid flooding of L3 flows. Ankur Sharma (4): L3 E-W Supp

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-04-12 Thread Ankur Sharma
: Friday, April 12, 2019 10:32 AM To: Ankur Sharma Cc: Numan Siddique; Mark Michelson; Han Zhou; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac. On Thu, Apr 11, 2019 at 06:24:10PM +, Ankur Sharma wrote: > Gen

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-04-11 Thread Ankur Sharma
help. Regards, Ankur From: Ankur Sharma Sent: Friday, March 22, 2019 11:30 AM To: 'Numan Siddique' ; Mark Michelson ; 'Han Zhou' Cc: ovs-dev@openvswitch.org Subject: RE: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac. Hi Numan, Sure, sounds good

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-03-22 Thread Ankur Sharma
22, 2019 6:59 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac. On Tue, Mar 19, 2019 at 12:33 AM Ankur Sharma mailto:ankur.sha...@nutanix.com>> wrote: Hi Numan, Thanks a lot for c

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-03-18 Thread Ankur Sharma
looks similar to ovn-encap-ip, ovn-bridge-mappings etc. However, we can deviate from that if it simplifies adoption by CMS and community is inclined towards it as well. Thanks again for the feedback. Regards, Ankur From: Numan Siddique Sent: Friday, March 15, 2019 11:27 PM To: Ankur Sharma Cc

[ovs-dev] [RFC PATCH v2 4/4] L3 N-S support in ovn, avoid chassis redirection as default for vlan backed networks

2019-03-15 Thread Ankur Sharma
traffic need not go via redirect chassis for VLAN backed networks. In the absence of NATing (or any other service provided by a centralized chassis), we need not redirect the South to North traffic for non overlay traffic. Signed-off-by: Ankur Sharma --- ovn/northd/ovn-northd.c | 43

[ovs-dev] [RFC PATCH v2 3/4] L3 N-S support in ovn, do not replace router port mac on gateway chassis

2019-03-15 Thread Ankur Sharma
router. This Patch: a. Do not replace router port mac, if the corrsponding cr- port is resident on current chassis. b. We do not need this, as gateway chassis is where we will advertise the router port mac. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 30 -- ovn

[ovs-dev] [RFC PATCH v2 1/4] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-03-15 Thread Ankur Sharma
ority=150. For example: cookie=0x0, duration=67765.830s, table=65, n_packets=0, n_bytes=0, idle_age=65534, hard_age=65534, priority=150,reg15=0x1,metadata=0x4, dl_src=00:00:01:01:02:03 actions=mod_dl_src:aa:bb:cc:dd:ee:ff, mod_vlan_vid:1000,output:16 c. Unit tests to validate above. Signed-o

[ovs-dev] [RFC PATCH v2 2/4] L3 N-S support in ovn, advertise router port mac from gateway chassis

2019-03-15 Thread Ankur Sharma
, then south to north traffic will also go via gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/pinctrl.c | 173 --- ovn/lib/ovn-util.c | 31 + ovn/lib/ovn-util.h | 6 ++ 3 files changed, 201 insertions(+), 9 deletions

[ovs-dev] [RFC PATCH v2 0/4] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-03-15 Thread Ankur Sharma
th traffic in the absence of NAT etc. This series does not cover following: (will be sent out for review in follow up series once this series is reviewed/committed) a. Network Address Translation. b. Ensuring VMs mac is learnt in underlay network to avoid flooding of L3 flows. Ankur Sharma (4): L3 E-W Supp

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-03-05 Thread Ankur Sharma
Hi Numan, Thank you so much for review and initial comments. Please find my response inline. Please go through the explanations and we can discuss further from there. Thanks again for review. Regards, Ankur From: Numan Siddique Sent: Wednesday, February 27, 2019 6:00 AM To: Ankur Sharma Cc

[ovs-dev] [RFC PATCH v2 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-03-04 Thread Ankur Sharma
This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. Signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [RFC PATCH v2 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-03-04 Thread Ankur Sharma
for storing other values like, identifier for corresponidng OVN ACL/Security group etc. Signed-off-by: Ankur Sharma --- Documentation/tutorials/ovn-openstack.rst | 12 ovn/lib/logical-fields.c | 3 ++ ovn/northd/ovn-northd.8.xml | 14 - ovn/northd/ovn

[ovs-dev] [RFC PATCH v2 0/3] Associate identifier with OVN ACL connection tracking entry

2019-03-04 Thread Ankur Sharma
, ct_label=xxreg1); next;) Ankur Sharma (3): OVN ACL: Replace the usage of ct_label with ct_mark OVN ACL: Allow ct_mark and ct_label values to be set from register as well OVN ACL: Allow a user to input ct.label value for an acl Documentation/tutorials/ovn-openstack.rst | 12 ++---

Re: [ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn, northd changes to read logical switch network type.

2019-02-25 Thread Ankur Sharma
Hi Ben, Sure, will merged 1,2 and 3 in a single patch. V2 will have this change. Regards, Ankur -Original Message- From: Ben Pfaff Sent: Monday, February 25, 2019 9:43 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-02-25 Thread Ankur Sharma
Hi Ben, Yes, I am aware of these failures. I mentioned about them in Cover Letter as well. Yes, V2 will have fix for them as well, I am actively working on it. Thanks Regards, Ankur -Original Message- From: Ben Pfaff Sent: Monday, February 25, 2019 9:31 AM To: Ankur Sharma Cc: ovs

Re: [ovs-dev] [RFC PATCH v1 0/6] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-02-25 Thread Ankur Sharma
Hi Ben, Thanks a lot for review. Sure, I will update Architecture documentation as well in V2. Thanks Regards, Ankur -Original Message- From: Ben Pfaff Sent: Monday, February 25, 2019 9:00 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 0/6] OVN

[ovs-dev] [RFC PATCH v1 6/6] L3 N-S support in ovn, avoid chassis redirection as default for vlan backed networks

2019-02-20 Thread Ankur Sharma
traffic need not go via redirect chassis for VLAN backed networks. In the absence of NATing (or any other service provided by a centralized chassis), we need not redirect the South to North traffic for non overlay traffic. Signed-off-by: Ankur Sharma --- ovn/northd/ovn-northd.c | 41

[ovs-dev] [RFC PATCH v1 5/6] L3 N-S support in ovn, do not replace router port mac on gateway chassis

2019-02-20 Thread Ankur Sharma
router. This Patch: a. Do not replace router port mac, if the corrsponding cr- port is resident on current chassis. b. We do not need this, as gateway chassis is where we will advertise the router port mac. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 30 -- ovn

[ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-02-20 Thread Ankur Sharma
cookie=0x0, duration=67765.830s, table=65, n_packets=0, n_bytes=0, idle_age=65534, hard_age=65534, priority=150,reg15=0x1,metadata=0x4, dl_src=00:00:01:01:02:03 actions=mod_dl_src:aa:bb:cc:dd:ee:ff, mod_vlan_vid:1000,output:16 Signed-off-by: Ankur Sharma --- ovn/contro

[ovs-dev] [RFC PATCH v1 4/6] L3 N-S support in ovn, advertise router port mac from gateway chassis

2019-02-20 Thread Ankur Sharma
, then south to north traffic will also go via gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/pinctrl.c | 173 --- ovn/lib/ovn-util.c | 31 + ovn/lib/ovn-util.h | 6 ++ 3 files changed, 201 insertions(+), 9 deletions

[ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn, northd changes to read logical switch network type.

2019-02-20 Thread Ankur Sharma
= [overlay|vlan] c. This value will help with logical flow changes for L3. d. Unit tests to validate the content in southbound database. Signed-off-by: Ankur Sharma --- ovn/northd/ovn-northd.c | 40 ovn/ovn-sb.xml | 7 +++ tests/ovn-northd.at

[ovs-dev] [RFC PATCH v1 1/6] Vlan Support in ovn, add network type in northbound schema

2019-02-20 Thread Ankur Sharma
cal switch. ovn-nbctl ls-set-network-type SWITCH vlan|overlay Signed-off-by: Ankur Sharma --- ovn/ovn-nb.ovsschema | 8 ++-- ovn/ovn-nb.xml| 9 + ovn/utilities/ovn-nbctl.c | 45 +---

[ovs-dev] [RFC PATCH v1 0/6] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-02-20 Thread Ankur Sharma
test cases are failing, i am debugging the same. Still sending out the patches to kick start the review process, v2 will address the unit test failure as well. Ankur Sharma (6): Vlan Support in ovn, add network type in northbound schema Vlan Support in ovn, northd changes to read logical switch networ

Re: [ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-02-07 Thread Ankur Sharma
From: Ben Pfaff Sent: Wednesday, February 6, 2019 6:11 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl I'd like to hear some kind of overall use case here. Sure, you can use it to identify

Re: [ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-02-06 Thread Ankur Sharma
Pfaff Sent: Tuesday, February 5, 2019 1:40 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl On Fri, Jan 11, 2019 at 12:16:39AM +, Ankur Sharma wrote: > This patch allows user to associate a va

Re: [ovs-dev] [RFC PATCH v1 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-02-06 Thread Ankur Sharma
case thus far, it was missing in OVN. Thanks again for review, V2 will have all the comments addressed. Regards, Ankur -Original Message- From: Ben Pfaff Sent: Tuesday, February 5, 2019 1:30 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 2/3

Re: [ovs-dev] [RFC PATCH v1 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-02-06 Thread Ankur Sharma
- From: Ben Pfaff Sent: Tuesday, February 5, 2019 1:21 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 1/3] OVN ACL: Replace the usage of ct_label with ct_mark On Fri, Jan 11, 2019 at 12:16:35AM +, Ankur Sharma wrote: > OVN ACL implementation used ct_la

[ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-01-10 Thread Ankur Sharma
This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. signed-off-by: Ankur Sharma --- ovn

[ovs-dev] [RFC PATCH v1 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-01-10 Thread Ankur Sharma
-by: Ankur Sharma --- include/ovn/actions.h | 3 +++ ovn/lib/actions.c | 73 ++- 2 files changed, 70 insertions(+), 6 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/actions.h index 1c0c67c..58b96a1 100644 --- a/include/ovn/actions.h +++ b

[ovs-dev] [RFC PATCH v1 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-01-10 Thread Ankur Sharma
for storing other values like, identifier for corresponidng OVN ACL/Security group etc. signed-off-by: Ankur Sharma --- ovn/lib/logical-fields.c| 1 + ovn/northd/ovn-northd.8.xml | 14 ++--- ovn/northd/ovn-northd.c | 48 ++--- tests/ovn.at

[ovs-dev] [RFC PATCH v1 0/3] Associate identifier with OVN ACL connection tracking entry

2019-01-10 Thread Ankur Sharma
, ct_label=xxreg1); next;) Ankur Sharma (3): OVN ACL: Replace the usage of ct_label with ct_mark OVN ACL: Allow ct_mark and ct_label values to be set from register as well OVN ACL: Allow a user to input ct.label value for an acl include/ovn/actions.h | 3 ++ ovn/lib/actions.c

Re: [ovs-dev] OVN multicast enhancements

2018-11-16 Thread Ankur Sharma
Hi Mark, Thanks for the write up. Initial proposal looks to be a good starting point. Please find my feedback inline. Regards, Ankur From: ovs-dev-boun...@openvswitch.org on behalf of Mark Michelson Sent: Thursday, November 15, 2018 2:20 PM To:

Re: [ovs-dev] VLAN tenant network patches

2018-11-15 Thread Ankur Sharma
, 2018 1:06:34 AM To: Gurucharan Shetty; Numan Siddique Cc: Ankur Sharma; ovs dev Subject: Re: [ovs-dev] VLAN tenant network patches Thanks for looking at this and keeping it moving forward. I'm also fine with both ways of implementing the feature, and of course, having distributed E/W for VLAN

Re: [ovs-dev] VLAN tenant network patches

2018-11-14 Thread Ankur Sharma
e are focused on getting basic functionality to work correctly first. Please feel free to put forth more queries/concerns you have, i will be happy to explain. Thanks again for review. Regards, Ankur From: Guru Shetty Sent: Monday, November 12, 2018 9:58:07 A

Re: [ovs-dev] VLAN tenant network patches

2018-11-11 Thread Ankur Sharma
November 9, 2018 11:45 AM To: ovs dev Cc: Ankur Sharma; Numan Siddique; Ben Pfaff Subject: VLAN tenant network patches I have tried to summarize the problem statement that Numan and Ankur are trying to solve here based on my understanding so far. Please correct me and I will revise it along.

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-11-10 Thread Ankur Sharma
your time and feel free to put up your understanding, i will be happy to explain. Thanks Regards, Ankur From: Guru Shetty Sent: Thursday, November 8, 2018 8:35:07 AM To: Ankur Sharma Cc: ovs-dev Subject: Re: [ovs-dev] OVN based distributed virtual routing for V

Re: [ovs-dev] [PATCH v1 3/3] Vlan Support in ovn, northd changes to read logical switch network type.

2018-11-10 Thread Ankur Sharma
Hi Ben, Yes, v2 will have both L2 and L3 E-W changes. Thanks for taking an initial look. Regards, Ankur From: Ben Pfaff Sent: Thursday, November 8, 2018 6:33:23 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 3/3] Vlan Support

Re: [ovs-dev] [PATCH 1/2] ovn: Avoid tunneling for VLAN packets redirected to a gateway chassis

2018-11-08 Thread Ankur Sharma
is not block the patch :). If rest of the community is fine with the approach in this series, then please feel free to go ahead. Just wanted to raise the concern. Thanks Regards, Ankur From: Numan Siddique Sent: Saturday, November 3, 2018 5:26 AM To: Ankur Sharma Cc

Re: [ovs-dev] [PATCH v1 3/3] Vlan Support in ovn, northd changes to read logical switch network type.

2018-11-08 Thread Ankur Sharma
From: Ben Pfaff Sent: Monday, November 5, 2018 1:10:36 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 3/3] Vlan Support in ovn, northd changes to read logical switch network type. I don't see where this series actually changes behavior on the hypervisors. Can y

Re: [ovs-dev] [PATCH v1 2/3] Vlan Support in ovn, add nbctl commands to set network type

2018-11-08 Thread Ankur Sharma
From: Ben Pfaff Sent: Monday, November 5, 2018 1:06:20 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 2/3] Vlan Support in ovn, add nbctl commands to set network type On Fri, Oct 26, 2018 at 01:39:43AM +0000, Ankur Sharma wrote: > As a part of proposal fo

Re: [ovs-dev] [PATCH v1 1/3] Vlan Support in ovn, add network type in northbound schema

2018-11-08 Thread Ankur Sharma
Hi Ben, Thanks for taking a look. Sure, i will handle this in v2. Regards, Ankur From: Ben Pfaff Sent: Monday, November 5, 2018 1:03:24 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 1/3] Vlan Support in ovn, add network type

Re: [ovs-dev] [PATCH 1/2] ovn: Avoid tunneling for VLAN packets redirected to a gateway chassis

2018-11-01 Thread Ankur Sharma
Hi Numan, Mark, Thanks for the patch. Description explains the problem statement and solution really well. I have following comments: a. Regarding the solution: i. I think referring to a non connected port in a logical datapath pipeline is probably not the right way. i.e as per the

[ovs-dev] [PATCH v1 3/3] Vlan Support in ovn, northd changes to read logical switch network type.

2018-10-25 Thread Ankur Sharma
with logical flow changes for L3. d. Unit tests to validate the content in southbound database. Signed-off-by: Ankur Sharma --- ovn/northd/ovn-northd.c | 40 ovn/ovn-sb.xml | 7 +++ tests/ovn-northd.at | 22 ++ 3 files

[ovs-dev] [PATCH v1 2/3] Vlan Support in ovn, add nbctl commands to set network type

2018-10-25 Thread Ankur Sharma
-56f2aa2ea878 (bar) (type: overlay) 531e6f24-f6ae-4ea3-856d-ac986f900770 (foo) (type: vlan) d. Unit tests to validate this command Signed-off-by: Ankur Sharma --- ovn/utilities/ovn-nbctl.c | 38 ++ tests/ovn-nbctl.at| 40

[ovs-dev] [PATCH v1 1/3] Vlan Support in ovn, add network type in northbound schema

2018-10-25 Thread Ankur Sharma
olumn name: i. network_type: Represents whether network is vlan backed or overlay. Signed-off-by: Ankur Sharma --- ovn/ovn-nb.ovsschema | 4 +++- ovn/ovn-nb.xml | 9 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Ankur Sharma
Hi Han, Appreciate your feedback. Please find the reply inline. Thanks Regards, Ankur From: Han Zhou Sent: Friday, October 19, 2018 5:17 PM To: Ankur Sharma Cc: Mark Michelson ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Ankur Sharma
Hi Guru, Thanks for taking a look. Please find the detailed explanation of problem statement inline. Thanks Regards, Ankur From: Guru Shetty Sent: Friday, October 19, 2018 9:35 AM To: Ankur Sharma Cc: ovs-dev Subject: Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Ankur Sharma
Hi Han, Thanks a lot for review. Please find my replies inline. Please feel free to put forth more points for discussion. Thanks Regards, Ankur From: Han Zhou Sent: Thursday, October 18, 2018 11:55 PM To: Ankur Sharma Cc: Mark Michelson ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] OVN

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-18 Thread Ankur Sharma
. Thanks Regards, Ankur -Original Message- From: Ankur Sharma Sent: Wednesday, October 17, 2018 3:37 PM To: 'Mark Michelson' ; ovs-dev@openvswitch.org Subject: RE: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks Hi Mark, Thanks a lot for the feedback. Regarding

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-17 Thread Ankur Sharma
of these glitches in our next conversations. Appreciate your comments on the proposal, please find my replies inline. Thanks Regards, Ankur -Original Message- From: Mark Michelson Sent: Wednesday, October 17, 2018 2:50 PM To: Ankur Sharma ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev

[ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-16 Thread Ankur Sharma
Hi, We have done some effort in evaluating usage of OVN for Distributed Virtual Routing (DVR) for vlan backed networks. We would like to take it forward with the community. We understand that some of the work could be overlapping with existing patches in review. We would appreciate the

<    1   2   3