by default. For additional information please
check the tso.rst document.
Signed-off-by: Flavio Leitner
---
Documentation/automake.mk | 1 +
Documentation/topics/dpdk/index.rst | 1 +
Documentation/topics/dpdk/tso.rst | 96 +
NEWS| 1 +
lib
23.3 Gbits/sec
Ext Host 9.99 Gbits/sec 10.1 Gbits/sec
Used iperf3 -u to test UDP traffic limited at default 1Mbits/sec
and noticed no change with the exception for tunneled packets (not
supported).
Travis, AppVeyor, and Cirrus-ci passed.
Flavio Leitner (3):
dp-packet: preserve
There is no support for multi-segmented buffers, so flag
that to vhost library.
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 6 ++
1 file changed, 6 insertions(+)
Changelog:
- v3
* added period at the end of comments.
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index
The headroom is useful if the packet needs to insert additional
header, so preserve the original headroom when cloning the batch.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index
Hi Ian,
Thanks for the reviews. I agree with your comments for the other
patches. This one I will answer them inline.
On Mon, Jan 06, 2020 at 08:24:48PM +, Stokes, Ian wrote:
>
>
> On 12/31/2019 8:14 PM, Flavio Leitner wrote:
> > Abbreviated as TSO, TCP Segmentation Offlo
DPDK included a couple flags EXT_ATTACHED_MBUF and IND_ATTACHED_MBUF
which are not really offloading flags, so this patch fixes to reset
only offloading flags or to reset only those flags when needed.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.c | 4 +++-
lib/dp-packet.h | 2 +-
2 files
by default.
Signed-off-by: Flavio Leitner
---
Documentation/automake.mk | 1 +
Documentation/topics/dpdk/index.rst | 1 +
Documentation/topics/dpdk/tso.rst | 89
NEWS| 1 +
lib/automake.mk | 2 +
lib/conntrack.c
There is no support for multi-segmented buffers, so flag
that to vhost library.
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 2423d26ee..57bff5e58 100644
--- a/lib/netdev-dpdk.c
+++ b/lib
works.
The TSO is enabled in the vhost-user ports in client mode and linux ports
in userspace.
This patchset is based on branch dpdk-latest (v19.11 required).
There are good improvements sending to or receiving from veth pairs or
tap devices as well.
Flavio Leitner (4):
dp-packet: preserve
The headroom is useful if the packet needs to insert additional
header, so preserve the original headroom when cloning the batch.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index
On Wed, Dec 04, 2019 at 09:09:42PM +0100, David Marchand wrote:
> On Wed, Dec 4, 2019 at 8:52 PM Flavio Leitner wrote:
> >
> > On Mon, Dec 02, 2019 at 05:03:30PM +0100, David Marchand wrote:
> > > Most DPDK components make the assumption that rte_lcore_id() returns
>
|INFO|Initialised lcore 1 for
core 8
I didn't find any issues with either the patch or with the tests.
Acked-by: Flavio Leitner
Thanks
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Dec 03, 2019 at 05:26:51PM +0100, Ilya Maximets wrote:
> On 03.12.2019 14:12, Flavio Leitner wrote:
> > On Tue, Dec 03, 2019 at 01:15:23PM +0100, Ilya Maximets wrote:
> >> On 02.12.2019 14:44, Flavio Leitner wrote:
> >>> Abbreviated as TSO, TCP Segmentat
On Tue, Dec 03, 2019 at 12:59:24PM +, Stokes, Ian wrote:
>
>
> On 12/3/2019 12:15 PM, Ilya Maximets wrote:
> > On 02.12.2019 14:44, Flavio Leitner wrote:
> > > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > > the network stack
On Tue, Dec 03, 2019 at 01:15:23PM +0100, Ilya Maximets wrote:
> On 02.12.2019 14:44, Flavio Leitner wrote:
> > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > the network stack to delegate the TCP segmentation to the NIC reducing
> > the pe
There is no support for multi-segmented buffers, so flag
that to vhost library.
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 2423d26ee..cd035f76e 100644
--- a/lib/netdev-dpdk.c
+++ b/lib
by default.
Signed-off-by: Flavio Leitner
---
Documentation/automake.mk | 1 +
Documentation/topics/dpdk/index.rst | 1 +
Documentation/topics/dpdk/tso.rst | 83 +
NEWS| 1 +
lib/automake.mk | 2 +
lib/dp
The headroom is useful if the packet needs to insert additional
header, so preserve the original headroom when cloning the batch.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index
DPDK included a couple flags EXT_ATTACHED_MBUF and IND_ATTACHED_MBUF
which are not really offloading flags, so this patch fixes to reset
only offloading flags or to reset only those flags when needed.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.c | 4 +++-
lib/dp-packet.h | 2 +-
2 files
---
There are good improvements sending to veth pairs or tap devices too.
Flavio Leitner (4):
dp-packet: preserve headroom when cloning a pkt batch
vhost: Disable multi-segmented buffers
dp-packet: handle new dpdk buffer flags
netdev-dpdk: Add TCP Segmentation Offload support
Documentation/automake.mk
mentation. Claiming to completely remove this functionality
> from OVS in one of the next releases.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, 25 Nov 2019 15:08:44 +0100
Ilya Maximets wrote:
> On 25.11.2019 13:51, Flavio Leitner wrote:
> > On Mon, 25 Nov 2019 11:11:44 +0100
> > Ilya Maximets wrote:
> >
> >> This fixes OSX build on Travis:
> >>
> >> ovs-vswitchd.conf.db.5:4061
o-dpif: Expose datapath ND Extensions
> capability to ovsdb") Signed-off-by: Ilya Maximets
> ---
> vswitchd/vswitch.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Do you think it would be useful if checkpatch.py catch that?
Acked-by: Flavio Leitner
>
>
On Thu, 21 Nov 2019 17:22:49 -0800
Ben Pfaff wrote:
> On Wed, Nov 20, 2019 at 11:28:03AM -0300, Flavio Leitner wrote:
> > On Wed, 20 Nov 2019 11:21:13 -0300
> > Flavio Leitner wrote:
> >
> > > The IPv6 ND Extensions is only implemented in userspace datapa
Document and expose datapath ND Extensions capability to ovsdb.
Fixes: d0d571493 ("ofproto-dpif: Allow IPv6 ND Extensions only if supported")
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif.c | 1 +
vswitchd/vswitch.xml | 5 +
2 files changed, 6 insertions(+)
diff --git
On Wed, 20 Nov 2019 11:21:13 -0300
Flavio Leitner wrote:
> The IPv6 ND Extensions is only implemented in userspace datapath,
> but nothing prevents that to be used with other datapaths.
>
> This patch probes the datapath and only allows if the support
> is available.
>
")
Signed-off-by: Flavio Leitner
---
lib/odp-util.c | 17 ++--
lib/odp-util.h | 6 -
ofproto/ofproto-dpif.c | 59 +-
tests/test-odp.c | 1 +
4 files changed, 73 insertions(+), 10 deletions(-)
diff --git a/lib/odp-ut
| 4
> acinclude.m4| 24 ++--
> lib/dpdk.c | 2 ++
> 5 files changed, 34 insertions(+), 8 deletions(-)
New option noted in NEWS, warning for those users enabling the
option, documentation
On Wed, 6 Nov 2019 01:59:41 +0530
Ramana Reddy wrote:
> Hi Flavio,
> As per your inputs, I modified the gso_size, and now
> skb_gso_validate_mtu(skb, mtu) is returning true, and
> ip_finish_output2(sk, skb) and dst_neigh_output(dst, neigh, skb); are
> getting called. But still, I am seeing the
On Mon, 4 Nov 2019 18:16:26 +0100
Ilya Maximets wrote:
> On 04.11.2019 17:21, Flavio Leitner wrote:
> >
> > Hi Ilya,
> >
> > On Fri, 1 Nov 2019 13:06:33 +0100
> > Ilya Maximets wrote:
> >
> >> The conventional way for packet dumping in OVS i
IO_NET_HDR_GSO_NONE;
> }
> Regards,
> Ramana
>
>
> On Mon, Nov 4, 2019 at 8:39 PM Flavio Leitner
> wrote:
>
> >
> > Hi,
> >
> > What's the value you're passing on gso_size in struct
> > virtio_net_hdr? You need to leave
Hi Ilya,
On Fri, 1 Nov 2019 13:06:33 +0100
Ilya Maximets wrote:
> The conventional way for packet dumping in OVS is to use ovs-tcpdump
> that works via traffic mirroring. DPDK pdump could probably be used
> for some lower level debugging, but it is not commonly used for
> various reasons.
>
Hi,
What's the value you're passing on gso_size in struct virtio_net_hdr?
You need to leave room for the encapsulation header, e.g.:
gso_size = iface_mtu - virtio_net_hdr->hdr_len
fbl
On Mon, 4 Nov 2019 01:11:36 +0530
Ramana Reddy wrote:
> Hi,
> I am wondering if anyone can help me with
On Mon, 14 Oct 2019 10:37:43 -0700
Yi-Hung Wei wrote:
> From: Flavio Leitner
>
> upstream patch:
>
> commit fa7e428c6b7ed3281610511a2b2ec716d9894be8
> Author: Flavio Leitner
> Date: Mon Mar 25 15:58:31 2019 -0300
>
> openvswitch: add seqadj extension when
On Fri, Sep 27, 2019 at 10:05:53AM -0300, Flavio Leitner wrote:
> On Thu, Sep 26, 2019 at 07:49:28AM -0700, Ben Pfaff wrote:
> > On Thu, Sep 26, 2019 at 11:59:14AM -0400, Aaron Conole wrote:
> > > Flavio Leitner writes:
> > >
> > > > Signed-off-by: Flavio L
l_64k is available and the packet is beyond the regular
MTU-sized buffer, DPDK selects the mpool_64k mbuf instead.
That avoids allocating huge amounts of 64k buffers to sustain line
rate speeds with small packets.
fbl
>
> Regards,
> Michal Obrembski
>
>
> -Ori
Signed-off-by: Flavio Leitner
---
drivers/net/vhost/rte_eth_vhost.c | 4 +--
examples/tep_termination/main.c | 2 +-
examples/vhost/main.c | 2 +-
lib/librte_vhost/rte_vhost.h | 5 +++-
lib/librte_vhost/virtio_net.c | 47 +--
5 files changed
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index cfbd9a9e5..7965bf57a 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -2294,6 +2294,24
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h | 16
lib/netdev-dpdk.c | 93 ---
2 files changed, 103 insertions(+), 6 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 14f0897fa..2b12604b9 100644
--- a/lib/dp-packet.h
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 44
1 file changed, 44 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 48057835f..7eb294366 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -323,8 +323,11
Hi Michal,
First of all thank you for continuing with the TSO work.
I spent a bit of time reviewing the patchset and my impression is
that the multi-segment support is quite expensive. Even when TSO
is off, we still have a non trivial CPU cost which we can't optimize
further. Also an
On Thu, Sep 05, 2019 at 09:18:22AM +, Frank Wang(王培辉) wrote:
> Hi All
Hi Franck,
Perhaps check the permissions of /var/run/openvswitch ?
If they are correct, you can start ovsdb-server service first and
then start the ovs-vswitchd manually as the service does.
fbl
>
>
>
> I’m
ce_cplusplus_keyword(schema)
File "./ovsdb/ovsdb-idlc.in", line 179, in replace_cplusplus_keyword
for columnName in table.columns:
RuntimeError: dictionary keys changed during iteration
Signed-off-by: Flavio Leitner
---
ovsdb/ovsdb-idlc.in | 2 +-
1 file changed, 1 insertion(+), 1 d
On Tue, Sep 03, 2019 at 03:17:03PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
Also to the set.
Acked-by: Flavio Leitner
thanks Justin
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/li
On Tue, Sep 03, 2019 at 03:13:54PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Sep 03, 2019 at 03:10:17PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Sep 03, 2019 at 03:02:59PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Aug 28, 2019 at 11:29:54AM -0700, Ben Pfaff wrote:
> On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> > When a packet needs to be encapsulated in userspace, the endpoint
> > address needs to be resolved to fill in the headers. If it is not,
> &g
The commit b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
uses the output indentation from newer OvS versions which include the
commit 7be29a47576d ("ofproto-dpif: Remove tabs from output.").
Fixes: b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
On Wed, Aug 28, 2019 at 11:29:54AM -0700, Ben Pfaff wrote:
> On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> > When a packet needs to be encapsulated in userspace, the endpoint
> > address needs to be resolved to fill in the headers. If it is not,
> &g
Hi Ben and Ilya,
This patch has two reviews, so any chance for you to take a look
soon as well?
Thanks in advance!
fbl
On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> When a packet needs to be encapsulated in userspace, the endpoint
> address needs to be re
On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> When a packet needs to be encapsulated in userspace, the endpoint
> address needs to be resolved to fill in the headers. If it is not,
> then currently OvS sends either a Neighbor Solicitation (IPv6)
> or an ARP
of the flow rules would be visible
and so on.
Since the NS/ARP packet is created by OvS and will be injected in
the outgoing bridge, use the corresponding ofproto version instead.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-xlate.c | 4 +--
tests/tunnel.at | 62
RP Request packet to the
datapath only, so it doesn't seem to support endpoint addresses outside
of the OvS. I guess your initial patch covering only interfaces as part
of OvS was good enough then.
Do you agree with that?
Thanks!
fbl
>
> Please let me know what you think of.
> -Vasu
&
Hi Michal,
On Tue, Jul 02, 2019 at 10:06:47PM +0100, Michal Orsák wrote:
> Hello,
>
> On 02/07/2019 19:47, Flavio Leitner wrote:
> > On Tue, Jul 02, 2019 at 10:00:44AM -0700, Ben Pfaff wrote:
> > > Hi Ilya and Ian. Please allow me to introduce Michal Orsak, a grad
On Tue, Jul 02, 2019 at 10:00:44AM -0700, Ben Pfaff wrote:
> Hi Ilya and Ian. Please allow me to introduce Michal Orsak, a grad
> student currently looking at packet classifiers. He's implemented a
> novel classifier that is faster than the one already in OVS in the
> benchmarks that he's run.
On Fri, Jun 28, 2019 at 04:29:36PM +0300, Ilya Maximets wrote:
> On 28.06.2019 16:17, Flavio Leitner wrote:
> > On Fri, Jun 28, 2019 at 03:21:07PM +0300, Ilya Maximets wrote:
> >> On 27.06.2019 14:12, Kevin Traynor wrote:
> >>> vhost tx retries may occur, and it can
x retries are
> > occurring and hence give a hint that guest config should be
> > examined.
> >
> > Signed-off-by: Kevin Traynor
> > Acked-by: Flavio Leitner
> > Acked-by: Eelco Chaudron
> > ---
> > Documentation/topics/dpdk/vhost-user.rst | 5 +
change the max retries, with a value of
> 0 effectively disabling vhost tx retries.
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Flavio Leitner
Thanks Kevin!
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Jun 25, 2019 at 03:57:24PM +0100, Kevin Traynor wrote:
> vhost tx retries can provide some mitigation against
> dropped packets due to a temporarily slow guest/limited queue
> size for an interface, but on the other hand when a system
> is fully loaded those extra cycles retrying could
On Wed, Jun 26, 2019 at 11:05:42AM -0300, Flavio Leitner via dev wrote:
> On Tue, Jun 25, 2019 at 03:57:22PM +0100, Kevin Traynor wrote:
> > Add documentation about vhost tx retries and external
> > configuration that can help reduce/avoid them.
> >
> > Signed-off-b
d be
> examined.
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
define, but since the
max number of retries is exposed to the users in the next patches
as a parameter in the documentation it seems fine to me.
Otherwise the patch looks good to me.
Acked-by: Flavio Leitner
___
dev mailing list
d...@ope
On Tue, Jun 25, 2019 at 03:57:21PM +0100, Kevin Traynor wrote:
> Fix minor issue of one possible additional retry.
>
> Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.")
> Signed-off-by: Kevin Traynor
> Acked-by: Eelco Chaudron
> -
On Tue, Jun 25, 2019 at 03:59:57PM +0300, Ilya Maximets wrote:
> On 25.06.2019 15:41, Flavio Leitner wrote:
> > On Tue, Jun 25, 2019 at 03:37:09PM +0300, Ilya Maximets wrote:
> >> On 25.06.2019 15:20, Flavio Leitner wrote:
> >>> On Tue, Jun 25, 2019 at 01:07:5
Hi William,
On Thu, Jun 20, 2019 at 11:00:56AM -0700, William Tu wrote:
> The patch adds the basic spin lock functions:
> ovs_spin_{lock, try_lock, unlock, init, destroy}.
> I have some use cases using af_xdp, patches will
> come later.
Usually the new API is merged along with an user
ng of vhost-user
> connections) and will help with linux devices clearing with upcoming
> AF_XDP netdev support.
>
> Signed-off-by: Ilya Maximets
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Jun 25, 2019 at 03:37:09PM +0300, Ilya Maximets wrote:
> On 25.06.2019 15:20, Flavio Leitner wrote:
> > On Tue, Jun 25, 2019 at 01:07:53PM +0300, Ilya Maximets wrote:
> >> On 25.06.2019 0:15, Flavio Leitner wrote:
> >>> On Mon, Jun 24, 2019 at 06:28:3
On Tue, Jun 25, 2019 at 01:07:53PM +0300, Ilya Maximets wrote:
> On 25.06.2019 0:15, Flavio Leitner wrote:
> > On Mon, Jun 24, 2019 at 06:28:37PM +0300, Ilya Maximets wrote:
> >> 'netdev' datapath is implemented within ovs-vswitchd process and can
> >> not exi
On Mon, Jun 24, 2019 at 05:43:26PM -0400, Vasu Dasari wrote:
> On Mon, Jun 24, 2019 at 3:58 PM Flavio Leitner wrote:
> > On Wed, Jun 19, 2019 at 11:02:07PM -0400, Vasu Dasari wrote:
> > > +{
> > > +struct tnl_neigh_entry *neigh;
>
On Fri, Jun 21, 2019 at 02:41:57PM +0100, Kevin Traynor wrote:
> vhost tx retries may occur, and it can be a sign that
> the guest is not optimally configured.
>
> Add some stats so a user will know if vhost tx retries are
> occurring and hence give a hint that guest config should be
> examined.
On Fri, Jun 21, 2019 at 02:41:56PM +0100, Kevin Traynor wrote:
> Fix minor issue of one additional retry and add
> documentation about vhost tx retries and ways to
> reduce/remove them.
>
> Signed-off-by: Kevin Traynor
>
> ---
> There is a checkpatch warning that one of the libvirt
> lines in
On Mon, Jun 24, 2019 at 06:28:37PM +0300, Ilya Maximets wrote:
> 'netdev' datapath is implemented within ovs-vswitchd process and can
> not exist without it, so it should be gracefully terminated with a
> full cleanup of resources upon ovs-vswitchd exit.
>
> This change forces dpif cleanup for
On Wed, Jun 19, 2019 at 11:02:07PM -0400, Vasu Dasari wrote:
> Say an ARP entry is learnt on a OVS port and when such a port is deleted,
> learnt entry should be removed from the port. It would have be aged out after
> ARP ageout time. This code will clean up immediately.
>
> Added test
On Fri, May 10, 2019 at 02:31:26PM -0400, Aaron Conole wrote:
> Aaron Conole writes:
>
> > Flavio Leitner writes:
> >
> >> On Thu, Apr 18, 2019 at 01:46:22PM -0600, Alex Williamson wrote:
> >>> On Thu, 18 Apr 2019 15:50:43 -0300
> >>> Flavio
penvswitch: load and reference the NAT helper.")
> Signed-off-by: Geert Uytterhoeven
> ---
Thanks!
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t; ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Apr 18, 2019 at 01:46:22PM -0600, Alex Williamson wrote:
> On Thu, 18 Apr 2019 15:50:43 -0300
> Flavio Leitner wrote:
>
> > On Thu, Apr 18, 2019 at 12:06:57PM -0600, Alex Williamson wrote:
> > > On Thu, 18 Apr 2019 13:56:23 -0300
> > > Flavio Leitner wr
On Thu, Apr 18, 2019 at 12:06:57PM -0600, Alex Williamson wrote:
> On Thu, 18 Apr 2019 13:56:23 -0300
> Flavio Leitner wrote:
>
> > On Thu, Apr 18, 2019 at 10:43:11AM -0600, Alex Williamson wrote:
> > > On Thu, 18 Apr 2019 13:23:54 -0300
> > > Flavio Leitner wr
On Thu, Apr 18, 2019 at 10:43:11AM -0600, Alex Williamson wrote:
> On Thu, 18 Apr 2019 13:23:54 -0300
> Flavio Leitner wrote:
>
> > On Thu, Apr 18, 2019 at 11:05:28AM -0400, Aaron Conole wrote:
> > > On some systems, it's possible that the initialization of the misc
On Thu, Apr 18, 2019 at 11:05:28AM -0400, Aaron Conole wrote:
> On some systems, it's possible that the initialization of the misc chardev
> associated with /dev/vfio/vfio is delayed. This happens on machines with
> large numbers of cores (at least 88+). If this delay exceeds the time
> required
On Wed, Apr 17, 2019 at 04:35:05PM -0700, Ben Pfaff wrote:
> On Wed, Apr 17, 2019 at 05:07:34PM -0300, Flavio Leitner via dev wrote:
> > On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote:
> > > I've once again rolled another OVN/OVS split version. It can be fo
On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote:
> I've once again rolled another OVN/OVS split version. It can be found at
> https://github.com/putnopvut/ovn_mk2.git
>
> The main changes between this and the old split POC are as follows:
>
> * This is based on a much newer build
his change fixes those problems. It will try to load the module
only if it's not present. It grabs a reference to the NAT module
and holds it while the flow is active. Finally, an error message
shows up if either actions above fails.
Fixes: 17c357efe5ec ("openvswitch: load NAT helper")
S
Register amanda, ftp, irc, sip and tftp NAT helpers.
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_amanda.c | 9 -
net/netfilter/nf_nat_ftp.c| 9 -
net/netfilter/nf_nat_irc.c| 9 -
net/netfilter/nf_nat_sip.c| 9 +++--
net/netfilter/nf_nat_tftp.c
The API allows a conntrack helper to indicate its corresponding
NAT helper which then can be loaded and reference counted.
Signed-off-by: Flavio Leitner
---
include/net/netfilter/nf_conntrack_helper.h | 22 +-
net/netfilter/nf_conntrack_amanda.c | 8 +-
net/netfilter
Each NAT helper creates a module alias which follows a pattern.
Use macros for consistency.
Signed-off-by: Flavio Leitner
---
include/net/netfilter/nf_conntrack_helper.h | 4
net/ipv4/netfilter/nf_nat_h323.c| 2 +-
net/ipv4/netfilter/nf_nat_pptp.c| 2 +-
net
an API to point to the NAT helper.
The third patch will register each NAT helper using the
new API.
The last patch fixes openvswitch to use the new API to
load and reference the NAT helper and also report an error
if the operation fails.
Flavio Leitner (4):
netfilter: use macros to create
On Mon, Apr 15, 2019 at 07:50:34AM +0200, Pablo Neira Ayuso wrote:
> On Sat, Apr 13, 2019 at 08:17:10PM -0300, Flavio Leitner wrote:
> [...]
> > +void nf_nat_helper_put(struct nf_conntrack_helper *helper)
> > +{
> > + struct nf_conntrack_nat_helper
On Mon, Apr 15, 2019 at 07:48:20AM +0200, Pablo Neira Ayuso wrote:
> Sorry I didn't see this in the first review.
>
> On Sat, Apr 13, 2019 at 08:17:10PM -0300, Flavio Leitner wrote:
> [...]
> > +int
> > +nf_nat_helper_try_module_get(const char *name, u16 l3num, u8 protonu
his change fixes those problems. It will try to load the module
only if it's not present. It grabs a reference to the NAT module
and holds it while the flow is active. Finally, an error message
shows up if either actions above fails.
Fixes: 17c357efe5ec ("openvswitch: load NAT helper")
S
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_tftp.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
V2
- defined NAT_HELPER_NAME for consistency.
- C99 static change.
- renamed the variables to be nat_helper.*
diff --git a/net/netfilter/nf_nat_tftp.c b/net
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_sip.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
V2
- defined NAT_HELPER_NAME for consistency.
- C99 static change.
- renamed the variables to be nat_helper.*
diff --git a/net/netfilter/nf_nat_sip.c b/net
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_irc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
V2
- defined NAT_HELPER_NAME for consistency.
- C99 static change.
- renamed the variables to be nat_helper.*
diff --git a/net/netfilter/nf_nat_irc.c b/net/netfilter
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_ftp.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
V2
- defined NAT_HELPER_NAME for consistency.
- C99 static change.
- renamed the variables to be nat_helper.*
diff --git a/net/netfilter/nf_nat_ftp.c b/net/netfilter
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_amanda.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
V2
- defined NAT_HELPER_NAME for consistency.
- C99 static change.
- renamed the variables to be nat_helper.*
diff --git a/net/netfilter/nf_nat_amanda.c b/net
The API allows a conntrack helper to indicate its corresponding
NAT helper which then can be loaded and reference counted.
Signed-off-by: Flavio Leitner
---
include/net/netfilter/nf_conntrack_helper.h | 22 -
net/netfilter/nf_conntrack_amanda.c | 8 +-
net/netfilter
Each NAT helper creates a module alias which follows a pattern.
Use macros for consistency.
Signed-off-by: Flavio Leitner
---
include/net/netfilter/nf_conntrack_helper.h | 4
net/ipv4/netfilter/nf_nat_h323.c| 2 +-
net/ipv4/netfilter/nf_nat_pptp.c| 2 +-
net
an API to point to the NAT helper.
The following patches will register each NAT helper using
the new API.
The last patch fixes openvswitch to use the new API to
load and reference the NAT helper and also report an error
if the operation fails.
Flavio Leitner (8):
netfilter: use macros
On Mon, Apr 01, 2019 at 12:10:32AM +0200, Pablo Neira Ayuso wrote:
> On Tue, Mar 26, 2019 at 05:57:09PM -0300, Flavio Leitner wrote:
> > The API allows a conntrack helper to indicate its corresponding
> > NAT helper which then can be loaded and reference counted.
> >
>
501 - 600 of 1013 matches
Mail list logo
