On Fri, 2017-05-19 at 09:22 -0400, Eric Garver wrote:
> On Thu, May 18, 2017 at 07:48:56PM -0700, Greg Rose wrote:
> > On Thu, 2017-05-18 at 15:53 -0700, Joe Stringer wrote:
> > > On 18 May 2017 at 15:35, Greg Rose wrote:
> > > > On Thu, 2017-05-18 at 16:10 -0400, Er
On Fri, 2017-05-19 at 13:27 -0700, Joe Stringer wrote:
> The vport_type_to_kind() call at the top of dpif_netlink_rtnl_verify()
> ensures that these cases can never be hit, so use OVS_NOT_REACHED()
> instead of setting the err to EOPNOTSUPP.
>
> Signed-off-by: Joe Stringer
Acke
ions(+), 57 deletions(-)
>
Acked-by: Greg Rose
> diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c
> index 0ca6529e9d82..76ab0fe3fdec 100644
> --- a/lib/dpif-netlink-rtnl.c
> +++ b/lib/dpif-netlink-rtnl.c
> @@ -160,34 +160,23 @@ rtnl_policy_parse(const char *kind, str
On Fri, 2017-05-19 at 13:27 -0700, Joe Stringer wrote:
> Simplify and refactor a couple of bits of code for improved readability.
>
> Signed-off-by: Joe Stringer
> ---
> lib/dpif-netlink-rtnl.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/lib/d
gt; +does not usually help code generation and it does suppress compiler warnings
> about unused functions. (Functions defined in .h usually should be marked
> inline.)
>
Acked-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, 2017-05-18 at 15:53 -0700, Joe Stringer wrote:
> On 18 May 2017 at 15:35, Greg Rose wrote:
> > On Thu, 2017-05-18 at 16:10 -0400, Eric Garver wrote:
> >> This series adds support for the creation of tunnels using the rtnetlink
> >> interface. This will o
runtime directories")
> Signed-off-by: Joe Stringer
Thanks for fixing this!
Acked-by: Greg Rose
> ---
> rhel/openvswitch.spec.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in
On Thu, 2017-05-18 at 16:10 -0400, Eric Garver wrote:
> This series adds support for the creation of tunnels using the rtnetlink
> interface. This will open the possibility for new features and flags on those
> vports without the need to change vport compatibility code.
>
> Support for STT and LIS
ofputil_port_to_string(port, name, sizeof name);
> xlate_report_error(ctx, "output_trunc does not support "
> "patch port %s", name);
'unpredicable' isn't a word but maybe it should be...
LGTM
Acked-by: Greg R
On Thu, 2017-05-18 at 13:17 -0700, Joe Stringer wrote:
> 3.18 and 3.12 have been EOLed, 4.11 is new, and there are some minor
> revisions to other kernels. Update the list.
>
> Signed-off-by: Joe Stringer
Thanks!
Acked-by: Greg Rose
> ---
> .travis.yml | 15 +++
On Wed, May 17, 2017 at 11:37 AM, Andy Zhou wrote:
> Without the fix, this test currently consistently fail when running
> on Travis CI. Connecting to the controller can take more time than
> running locally. Because the exact connecting time is variable, the
> exact output should not be used for
t.c
> @@ -503,6 +503,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff
> *skb)
> }
>
> skb->dev = vport->dev;
> + skb_sender_cpu_clear(skb);
> vport->ops->send(skb);
> return;
>
LGTM
Acked-by: Greg Rose
__
> +const char *role = ofp12_controller_role_to_str(cinfo->role);
> +ovsrec_controller_set_role(cfg, role);
> ovsrec_controller_set_status(cfg, &cinfo->pairs);
> -} else {
> -ovsrec_controller_set_is_connected(cfg, fa
.. the revert has to be it's own separate patch so
that it can address the commit specified.
I'm not sure about the other implied policy here - are we not able to
revert a patch and then commit another one because in between those two
commits a 'make check' will fail?
- Greg
>
t; tests/tunnel-push-pop.at | 69
>
> 1 file changed, 69 insertions(+)
No signature. Please fix on push. Otherwise...
Acked-by: Greg Rose
>
> diff --git a/tests/tunnel-push-pop.at b/tests/tunnel-push-pop.at
> index 4eeac4154dbc..fe901525ea62 100644
> --- a
openvswitch.org/pipermail/ovs-dev/2017-May/331972.html
> Signed-off-by: Joe Stringer
Acked-by: Greg Rose
> ---
> lib/dpif-netdev.c | 18 ++-
> ofproto/ofproto-dpif-xlate.c | 280
> --
> tests/ofproto-dpif.at | 11 +-
On Mon, 2017-05-08 at 11:49 +0100, Kevin Traynor wrote:
> On 05/06/2017 02:01 AM, Greg Rose wrote:
> > On Fri, May 5, 2017 at 9:34 AM, Kevin Traynor wrote:
> >> Rxqs are scheduled to be handled across available pmds in round robin
> >> order with no weight or priori
On Fri, May 5, 2017 at 9:34 AM, Kevin Traynor wrote:
> Rxqs are scheduled to be handled across available pmds in round robin
> order with no weight or priority.
>
> It can happen that some very busy queues are handled by one pmd which
> does not have enough cycles to prevent packets being dropped
y *key,
> enum nf_nat_manip_type maniptype;
> int err;
>
> +#ifdef HAVE_NF_CT_IS_UNTRACKED
> if (nf_ct_is_untracked(ct)) {
> /* A NAT action may only be performed on tracked packets. */
> return NF_ACCEPT;
> }
> +#endif /* HAVE_NF_CT_I
On Fri, 2017-04-28 at 14:35 -0700, Joe Stringer wrote:
> On 27 April 2017 at 16:13, Greg Rose wrote:
> > Signed-off-by: Greg Rose
> > ---
>
> LGTM, thanks. Will apply to master soon.
I see the patches in master now.
Thanks!
- Greg
__
On Fri, 2017-04-28 at 14:47 -0700, Joe Stringer wrote:
[snip]
>
> I've just started using "git clean" for this purpose, not sure if it's
> more or less reliable than your methods. It will clobber any untracked
> files though, so don't save any handy scripts in the directory :-)
Ah yes, the nucl
On Fri, 2017-04-28 at 14:33 -0700, Joe Stringer wrote:
> On 28 April 2017 at 14:31, Greg Rose wrote:
> > On Fri, 2017-04-28 at 14:21 -0700, Joe Stringer wrote:
> >> On 28 April 2017 at 14:18, Joe Stringer wrote:
> >> > On 28 April 2017 at 14:02, Greg Rose wrote:
&g
On Fri, 2017-04-28 at 14:34 -0700, Joe Stringer wrote:
> On 27 April 2017 at 16:13, Greg Rose wrote:
> > This is an alternative solution patch for the issue reported by
> > Raymond Burkholder and the patch submitted by Guoshuai Li. It uses
> > the acinclude.m4 configuration
On Fri, 2017-04-28 at 14:34 -0700, Joe Stringer wrote:
> On 27 April 2017 at 16:13, Greg Rose wrote:
> > The net parameter was added to nf_defrag_ipv6_enable in linux 4.10
> >
> > Signed-off-by: Greg Rose
>
> Thanks for the patch. Since this macro is only used by the
On Fri, 2017-04-28 at 14:21 -0700, Joe Stringer wrote:
> On 28 April 2017 at 14:18, Joe Stringer wrote:
> > On 28 April 2017 at 14:02, Greg Rose wrote:
> >> On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote:
> >>> On 27 April 2017 at 16:13, Greg Rose wrote:
&
On Fri, 2017-04-28 at 14:18 -0700, Joe Stringer wrote:
> On 28 April 2017 at 14:02, Greg Rose wrote:
> > On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote:
> >> On 27 April 2017 at 16:13, Greg Rose wrote:
> >> > Parenthetical imbalance was causing some checks t
On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote:
> On 27 April 2017 at 16:13, Greg Rose wrote:
> > Parenthetical imbalance was causing some checks to not run
> >
> > Signed-off-by: Greg Rose
> > ---
> > acinclude.m4 | 6 +++---
> > 1 fil
On Thu, 2017-04-27 at 14:47 -0700, William Tu wrote:
> On Thu, Apr 27, 2017 at 11:17 AM, Ben Pfaff wrote:
> > On Thu, Apr 27, 2017 at 10:17:20AM -0700, William Tu wrote:
> >> On Thu, Apr 27, 2017 at 9:57 AM, Ben Pfaff wrote:
> >> > On Thu, Apr 27, 2017 at 04:02:10AM -0700, William Tu wrote:
> >>
Signed-off-by: Greg Rose
---
.travis.yml | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 6f2b065..3a73873 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -30,13 +30,13 @@ env:
- BUILD_ENV="-m32" OPTS="--disable-s
DEFRAG_ENABLE_TAKES_NET should be
set and then checks for that at compile time.
V2 - Incorporate suggestion from Joe Stringer to just return values
of the init functions.
Reported-by: Raymond Burkholder
CC: Guoshuai Li
Signed-off-by: Greg Rose
---
datapath/linux/compat/ip_fragment.c
The net parameter was added to nf_defrag_ipv6_enable in linux 4.10
Signed-off-by: Greg Rose
---
acinclude.m4 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 0d6647e..8653a30 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -703,7 +703,9
Parenthetical imbalance was causing some checks to not run
Signed-off-by: Greg Rose
---
acinclude.m4 | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 9f8e30d..0d6647e 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -681,9 +681,9
values
of the init functions. Compile tested locally on 4.9.24 and 4.10.12
Linux kernels to ensure the inicremental change is valid but
not verified again with Travis.
Verified here:
https://travis-ci.org/gvrose8192/ovs-experimental
Greg Rose (4):
acinclude.m4: Fix parenthetical
On Thu, 2017-04-27 at 14:05 -0700, Andy Zhou wrote:
> On Thu, Apr 27, 2017 at 1:08 PM, Greg Rose wrote:
> > The net parameter was added to nf_defrag_ipv6_enable in linux 4.10
> >
> > Signed-off-by: Greg Rose
>
> Thanks for working on this!
>
> It seems odd that
On Thu, 2017-04-27 at 13:53 -0700, Jarno Rajahalme wrote:
> > On Apr 27, 2017, at 1:08 PM, Greg Rose wrote:
> >
> > This is an alternative solution patch for the issue reported by
> > Raymond Burkholder and the patch submitted by Guoshuai Li. It uses
> > the acin
Signed-off-by: Greg Rose
---
.travis.yml | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 6f2b065..3a73873 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -30,13 +30,13 @@ env:
- BUILD_ENV="-m32" OPTS="--disable-s
DEFRAG_ENABLE_TAKES_NET should be
set and then checks for that at compile time.
Reported-by: Raymond Burkholder
CC: Guoshuai Li
Signed-off-by: Greg Rose
---
datapath/linux/compat/ip_fragment.c| 14 ++
datapath/linux/compat/nf_conntrack_reasm.c | 14 ++
2 files
The net parameter was added to nf_defrag_ipv6_enable in linux 4.10
Signed-off-by: Greg Rose
---
acinclude.m4 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 0d6647e..8653a30 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -703,7 +703,9
Parenthetical imbalance was causing some checks to not run
Signed-off-by: Greg Rose
---
acinclude.m4 | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 9f8e30d..0d6647e 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -681,9 +681,9
-experimental
Greg Rose (4):
acinclude.m4: Fix parenthetical balance
acinclude.m4: Add check for struct net parameter
compat: Fix build error in kernels 4.10+
travis: Update kernels to kernel.org latest
.travis.yml| 14 +++---
acinclude.m4
-if (strchr(br_cfg->name, '/') || strchr(br_cfg->name, '\\')) {
> +if (strchr(br_cfg->name, '/') || strchr(br_cfg->name, '\\')
> +|| !strcmp(br_cfg->name, "default")) {
> /*
On Tue, 2017-04-25 at 17:02 -0700, Andy Zhou wrote:
> vswitchd can gracefully shutdown after receiving the 'appctl exit'
> command. But the datapath resources vswitchd created can
> linger on. This is not a problem, and in fact desireable when the
> shutdown is transient in nature. Since restarted
Burkholder
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331411.html
> Signed-off-by: Guoshuai Li
Compile tested and looks OK to me.
Reviewed-by: Greg Rose
> ---
> datapath/linux/compat/ip_fragment.c| 14 ++
> datapath/linux/compat/nf_con
On Wed, 2017-04-26 at 00:33 +0800, Guoshuai Li wrote:
>
> > Sure, here it is:
> >
> > make -C /lib/modules/4.11.0-rc7+/build
> > M=/home/gvrose/prj/ovs/datapath/linux modules
> > make[4]: Entering directory `/home/gvrose/prj/net-next'
> > CC [M] /home/gvrose/prj/ovs/datapath/linux/actions.o
>
On Tue, 2017-04-25 at 23:56 +0800, Guoshuai Li wrote:
> I did not use 4.11.rc7. My kernel of ubuntu17.04 is 4.10.0 .
> Can you share the build error log?
> >
> > Even with your patch applied I still run into compilation errors on the
> > 4.11.rc7 upstream kernel. Perhaps there is more to do. I'l
Even with your patch applied I still run into compilation errors on the
4.11.rc7 upstream kernel. Perhaps there is more to do. I'll get the
Debian distro as well and look into a fix there.
Thanks,
- Greg
>
> >> boun...@openvswitch.org] On Behalf Of Greg Rose
> >>
On Tue, 2017-04-25 at 11:13 -0300, Raymond Burkholder wrote:
> I am attempting to build openvswitch 2.7.90 on linux 4.10.12 on Debian
> using:
Which version or distribution of Debian? Is it the current 8.7.1 I see
at the Debian site?
Let me know and I'll try to reproduce and investigate.
Thanks
init_conntrack() adds the event cache extension, so we
> only need to set the ctmask value. However, if the system is
> configured without support for events, the setting will be skipped due
> to extension not being found.
>
> Signed-off-by: Jarno Rajahalme
> Reviewed
On Fri, 2017-04-21 at 00:21 -0700, Zhenyu Gao wrote:
> 1. Consume switch/case to judge type of frame instead of using if/else.
> 2. Add parse_ipv4hdr for ipv4 frame header parsing.
>
I think this patch addresses too many issues and should be broken up
into at least two different patches with appr
On Wed, 2017-04-19 at 20:34 -0700, Ben Pfaff wrote:
> On Wed, Apr 19, 2017 at 10:25:11AM -0700, Greg Rose wrote:
> > On Mon, 2017-04-17 at 14:08 -0700, Greg Rose wrote:
> > > Add missing install files to RPM file list to prevent file check error
> > > so t
> } else {
> group = ofproto_group_lookup__(ofproto, group_id, OVS_VERSION_MAX);
Looks good to me.
Acked-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, 2017-04-17 at 14:08 -0700, Greg Rose wrote:
> Add missing install files to RPM file list to prevent file check error
> so that RPM files will be built.
>
> Signed-off-by: Greg Rose
I have not seen this patch committed to the 2.6 branch. Nor did I see
commit 6d02480dc2 cher
On Tue, 2017-04-18 at 11:19 +, Zoltán Balogh wrote:
> From: Jan Scheurich
>
> Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite
> for matching L3 protocols (MPLS, IP, IPv6, ARP etc).
>
> Scan packet_type in odp_flow string.
>
> Added dummy entry for MFF_PACKET_TYPE t
On Mon, 2017-04-17 at 09:38 -0700, Ben Pfaff wrote:
> On Mon, Apr 17, 2017 at 09:18:53AM -0700, Greg Rose wrote:
> > Add missing intall files to RPM file list to prevent file check error so
> > that RPM files will be built.
> >
> > Signed-off-by: Greg Rose
>
>
Add missing install files to RPM file list to prevent file check error
so that RPM files will be built.
Signed-off-by: Greg Rose
---
xenserver/openvswitch-xen.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xenserver/openvswitch-xen.spec.in
b/xenserver/openvswitch-xen.spec.in
On Mon, 2017-04-17 at 09:38 -0700, Ben Pfaff wrote:
> On Mon, Apr 17, 2017 at 09:18:53AM -0700, Greg Rose wrote:
> > Add missing intall files to RPM file list to prevent file check error so
> > that RPM files will be built.
> >
> > Signed-off-by: Greg Rose
>
>
Add missing intall files to RPM file list to prevent file check error so
that RPM files will be built.
Signed-off-by: Greg Rose
---
xenserver/openvswitch-xen.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/xenserver/openvswitch-xen.spec.in
b/xenserver/openvswitch-xen.spec.in
On Sun, 2017-04-16 at 13:19 -0700, Ben Pfaff wrote:
> On Fri, Apr 14, 2017 at 10:41:01AM -0700, Greg Rose wrote:
> > On Fri, 2017-04-14 at 10:03 -0700, Ben Pfaff wrote:
> > > On Fri, Apr 14, 2017 at 09:05:41AM -0700, Greg Rose wrote:
> > > > On Thu, 2017-04-13 a
On Fri, 2017-04-14 at 10:03 -0700, Ben Pfaff wrote:
> On Fri, Apr 14, 2017 at 09:05:41AM -0700, Greg Rose wrote:
> > On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote:
> > > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch
> > > does not ex
On Fri, 2017-04-14 at 09:05 -0700, Greg Rose wrote:
> On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote:
> > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch
> > does not exist") updated the RHEL logrotate configuration. This commit
> > m
On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote:
> Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch
> does not exist") updated the RHEL logrotate configuration. This commit
> makes similar changes for Debian, by synchronizing with the RHEL version.
>
> In particular:
>
901 - 961 of 961 matches
Mail list logo
