[ovs-dev] [PATCH RFC ovn] Generate ICMP Fragmentation Needed for multichassis ports

2022-10-17 Thread Ihar Hrachyshka
o access the original packet as produced by the port inside pinctrl controller action handler? What's the right way to handle it? (I am not yet sure if this problem affects other existing uses of the icmp4_error - routers, for one). Signed-off-by: Ihar Hrachyshka --- controller/physical.c | 1

[ovs-dev] [PATCH v5 ovn 7/7] Document experimental support for co-hosted controllers

2022-10-11 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- NEWS| 2 ++ controller/ovn-controller.8.xml | 12 2 files changed, 14 insertions(+) diff --git a/NEWS b/NEWS index 224a7b83e..63afcea9d 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ Post v22.09.0

[ovs-dev] [PATCH v5 ovn 6/7] Add connectivity test for 2 controllers on the same host

2022-10-11 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 123 +++ 1 file changed, 123 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 3c76ba49c..1d69de96e 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -33170,3 +33170,126 @@ OVS_WAIT_UNTIL

[ovs-dev] [PATCH v5 ovn 5/7] Don't touch tunnel ports from a different br-int

2022-10-11 Thread Ihar Hrachyshka
instance. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c | 42 ++ controller/encaps.h | 1 - controller/ovn-controller.c | 3 +- tests/ovn.at| 70 + 4 files changed, 90 insertions(+), 26 deletions

[ovs-dev] [PATCH v5 ovn 3/7] Allow to override system-id via file

2022-10-11 Thread Ihar Hrachyshka
on controller startup. The file setting overrides configuration stored in ovsdb, if any. This may be useful when running multiple containerized controller instances using the same vswitchd. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 6 + controller/chassis.h

[ovs-dev] [PATCH v5 ovn 2/7] Support ovn-...- specific global ovsdb options

2022-10-11 Thread Ihar Hrachyshka
controller instances using the same vswitchd instance. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 153 +--- controller/chassis.h| 6 +- controller/encaps.c | 19 ++-- controller/ovn-controller.8.xml | 12

[ovs-dev] [PATCH v5 ovn 1/7] Include "chassis index" into tunnel port name

2022-10-11 Thread Ihar Hrachyshka
for itself on startup. The index is then stored in Open_vSwitch:other_config:ovn-chassis-idx- key. An alternative would be including source chassis name into the port name, but the length is limited by IFNAMSIZ defined in kernel, which is 15. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c

[ovs-dev] [PATCH v5 ovn 4/7] Support passing chassis name via CLI

2022-10-11 Thread Ihar Hrachyshka
. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 5 controller/chassis.h| 1 + controller/ovn-controller.8.xml | 8 --- controller/ovn-controller.c | 9 +++ tests/ovn-macros.at | 4 ++-- tests/ovn.at| 42

[ovs-dev] [PATCH v5 ovn 0/7] Support 2+ controllers on the same vswitchd

2022-10-11 Thread Ihar Hrachyshka
emory leak in get_chassis_idx. v5: actually fix the leak... Ihar Hrachyshka (7): Include "chassis index" into tunnel port name Support ovn-...- specific global ovsdb options Allow to override system-id via file Support passing chassis name via CLI Don't touch tunnel ports from a different br-in

[ovs-dev] [PATCH v4 ovn 6/7] Add connectivity test for 2 controllers on the same host

2022-10-07 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 123 +++ 1 file changed, 123 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 3c76ba49c..1d69de96e 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -33170,3 +33170,126 @@ OVS_WAIT_UNTIL

[ovs-dev] [PATCH v4 ovn 5/7] Don't touch tunnel ports from a different br-int

2022-10-07 Thread Ihar Hrachyshka
instance. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c | 42 ++ controller/encaps.h | 1 - controller/ovn-controller.c | 3 +- tests/ovn.at| 70 + 4 files changed, 90 insertions(+), 26 deletions

[ovs-dev] [PATCH v4 ovn 2/7] Support ovn-...- specific global ovsdb options

2022-10-07 Thread Ihar Hrachyshka
controller instances using the same vswitchd instance. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 153 +--- controller/chassis.h| 6 +- controller/encaps.c | 19 ++-- controller/ovn-controller.8.xml | 12

[ovs-dev] [PATCH v4 ovn 4/7] Support passing chassis name via CLI

2022-10-07 Thread Ihar Hrachyshka
. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 5 controller/chassis.h| 1 + controller/ovn-controller.8.xml | 8 --- controller/ovn-controller.c | 9 +++ tests/ovn-macros.at | 4 ++-- tests/ovn.at| 42

[ovs-dev] [PATCH v4 ovn 7/7] Document experimental support for co-hosted controllers

2022-10-07 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- NEWS| 2 ++ controller/ovn-controller.8.xml | 12 2 files changed, 14 insertions(+) diff --git a/NEWS b/NEWS index 224a7b83e..63afcea9d 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ Post v22.09.0

[ovs-dev] [PATCH v4 ovn 1/7] Include "chassis index" into tunnel port name

2022-10-07 Thread Ihar Hrachyshka
for itself on startup. The index is then stored in Open_vSwitch:other_config:ovn-chassis-idx- key. An alternative would be including source chassis name into the port name, but the length is limited by IFNAMSIZ defined in kernel, which is 15. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c

[ovs-dev] [PATCH v4 ovn 3/7] Allow to override system-id via file

2022-10-07 Thread Ihar Hrachyshka
on controller startup. The file setting overrides configuration stored in ovsdb, if any. This may be useful when running multiple containerized controller instances using the same vswitchd. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 6 + controller/chassis.h

[ovs-dev] [PATCH v4 ovn 0/7] Support 2+ controllers on the same vswitchd

2022-10-07 Thread Ihar Hrachyshka
documented the ability to run multiple controllers on the same host, while mentioning that this support is highly experimental. v3: updated NEWS file to include the note about the new experimental issue. v3: rebased. v4: fixed a memory leak in get_chassis_idx. Ihar Hrachyshka (7): Include &quo

[ovs-dev] [PATCH v3 ovn 4/7] Support passing chassis name via CLI

2022-10-04 Thread Ihar Hrachyshka
. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 5 controller/chassis.h| 1 + controller/ovn-controller.8.xml | 8 --- controller/ovn-controller.c | 9 +++ tests/ovn-macros.at | 4 ++-- tests/ovn.at| 42

[ovs-dev] [PATCH v3 ovn 5/7] Don't touch tunnel ports from a different br-int

2022-10-04 Thread Ihar Hrachyshka
instance. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c | 42 ++ controller/encaps.h | 1 - controller/ovn-controller.c | 3 +- tests/ovn.at| 70 + 4 files changed, 90 insertions(+), 26 deletions

[ovs-dev] [PATCH v3 ovn 7/7] Document experimental support for co-hosted controllers

2022-10-04 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- NEWS| 2 ++ controller/ovn-controller.8.xml | 12 2 files changed, 14 insertions(+) diff --git a/NEWS b/NEWS index 224a7b83e..63afcea9d 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ Post v22.09.0

[ovs-dev] [PATCH v3 ovn 6/7] Add connectivity test for 2 controllers on the same host

2022-10-04 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 123 +++ 1 file changed, 123 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 3c76ba49c..1d69de96e 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -33170,3 +33170,126 @@ OVS_WAIT_UNTIL

[ovs-dev] [PATCH v3 ovn 3/7] Allow to override system-id via file

2022-10-04 Thread Ihar Hrachyshka
on controller startup. The file setting overrides configuration stored in ovsdb, if any. This may be useful when running multiple containerized controller instances using the same vswitchd. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 6 + controller/chassis.h

[ovs-dev] [PATCH v3 ovn 2/7] Support ovn-...- specific global ovsdb options

2022-10-04 Thread Ihar Hrachyshka
controller instances using the same vswitchd instance. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 153 +--- controller/chassis.h| 6 +- controller/encaps.c | 19 ++-- controller/ovn-controller.8.xml | 12

[ovs-dev] [PATCH v3 ovn 1/7] Include "chassis index" into tunnel port name

2022-10-04 Thread Ihar Hrachyshka
for itself on startup. The index is then stored in Open_vSwitch:other_config:ovn-chassis-idx- key. An alternative would be including source chassis name into the port name, but the length is limited by IFNAMSIZ defined in kernel, which is 15. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c

[ovs-dev] [PATCH v3 ovn 0/7] Support 2+ controllers on the same vswitchd

2022-10-04 Thread Ihar Hrachyshka
documented the ability to run multiple controllers on the same host, while mentioning that this support is highly experimental. v3: updated NEWS file to include the note about the new experimental issue. v3: rebased. Ihar Hrachyshka (7): Include "chassis index" into tunnel por

Re: [ovs-dev] [OVN v7] OVN - Add Support for Remote Port Mirroring

2022-10-03 Thread Ihar Hrachyshka
R N wrote: > > Hi Ihar, > > Thanks for your review. > Please see below for replies inline. > > On Mon, Oct 3, 2022 at 11:28 PM Ihar Hrachyshka wrote: >> >> NEWS file should be updated. See more comments inline below. > > Sure. Will update the NEWS file in

Re: [ovs-dev] [OVN v7] OVN - Add Support for Remote Port Mirroring

2022-10-03 Thread Ihar Hrachyshka
NEWS file should be updated. See more comments inline below. On Wed, Sep 28, 2022 at 9:08 AM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create Mirror

Re: [ovs-dev] [PATCH ovn 1/6] Rename tunnel ports to include source chassis name

2022-09-27 Thread Ihar Hrachyshka
> On Tue, Sep 20, 2022 at 2:05 AM Ihar Hrachyshka > wrote: > >> This is in preparation to support multiple separate controller instances >> with distinct chassis names operating on the same vswitchd instance. >> >> Signed-off-by: Ihar Hrachyshka >>

[ovs-dev] [PATCH v2 ovn 3/6] Allow to override system-id via file

2022-09-27 Thread Ihar Hrachyshka
on controller startup. The file setting overrides configuration stored in ovsdb, if any. This may be useful when running multiple containerized controller instances using the same vswitchd. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 6 ++ controller/chassis.h| 2

[ovs-dev] [PATCH v2 ovn 6/6] Add connectivity test for 2 controllers on the same host

2022-09-27 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 123 +++ 1 file changed, 123 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index c2f014d78..0f95679ef 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -33084,3 +33084,126 @@ OVS_WAIT_UNTIL

[ovs-dev] [PATCH v2 ovn 5/6] Don't touch tunnel ports from a different br-int

2022-09-27 Thread Ihar Hrachyshka
instance. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c | 42 ++ controller/encaps.h | 1 - controller/ovn-controller.c | 3 +- tests/ovn.at| 70 + 4 files changed, 90 insertions(+), 26 deletions

[ovs-dev] [PATCH v2 ovn 1/6] Include "chassis index" into tunnel port name

2022-09-27 Thread Ihar Hrachyshka
for itself on startup. The index is then stored in Open_vSwitch:other_config:ovn-chassis-idx- key. An alternative would be including source chassis name into the port name, but the length is limited by IFNAMSIZ defined in kernel, which is 15. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c

[ovs-dev] [PATCH v2 ovn 2/6] Support ovn-...- specific global ovsdb options

2022-09-27 Thread Ihar Hrachyshka
controller instances using the same vswitchd instance. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 153 +++- controller/chassis.h| 6 +- controller/encaps.c | 19 +++-- controller/ovn-controller.c | 123

[ovs-dev] [PATCH v2 ovn 4/6] Support passing chassis name via CLI

2022-09-27 Thread Ihar Hrachyshka
. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 5 + controller/chassis.h| 1 + controller/ovn-controller.c | 9 tests/ovn-macros.at | 4 ++-- tests/ovn.at| 42 + 5 files changed, 59 insertions(+), 2

[ovs-dev] [PATCH v2 ovn 0/6] Support 2+ controllers on the same vswitchd

2022-09-27 Thread Ihar Hrachyshka
scheme: include "chassis index" instead of its name for source chassis. v2: formatting adjustments. Ihar Hrachyshka (6): Include "chassis index" into tunnel port name Support ovn-...- specific global ovsdb options Allow to override system-id via file Support passing

Re: [ovs-dev] [PATCH ovn 1/6] Rename tunnel ports to include source chassis name

2022-09-20 Thread Ihar Hrachyshka
On Tue, Sep 20, 2022 at 1:27 AM Ales Musil wrote: > Hi, > please see the comment below. > > > On Tue, Sep 20, 2022 at 2:05 AM Ihar Hrachyshka > wrote: > >> This is in preparation to support multiple separate controller instances >> with distinct chassis nam

Re: [ovs-dev] [PATCH ovn 4/6] Support passing chassis name via CLI

2022-09-19 Thread Ihar Hrachyshka
On Mon, Sep 19, 2022 at 8:05 PM Ihar Hrachyshka wrote: > > This patch adds support for the desired system-id (chassis name) to be > passed via CLI: > > $ ovn-controller -n > > If passed, CLI overrides any settings stored in ovsdb or in > system-id-override file. >

[ovs-dev] [PATCH ovn 6/6] Add connectivity test for 2 controllers on the same host

2022-09-19 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 124 +++ 1 file changed, 124 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index cd4561069..564a5c149 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -33084,3 +33084,127 @@ OVS_WAIT_UNTIL

[ovs-dev] [PATCH ovn 5/6] Don't touch tunnel ports from a different br-int

2022-09-19 Thread Ihar Hrachyshka
instance. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c | 42 ++ controller/encaps.h | 1 - controller/ovn-controller.c | 3 +- tests/ovn.at| 70 + 4 files changed, 90 insertions(+), 26 deletions

[ovs-dev] [PATCH ovn 2/6] Support ovn-...- specific global ovsdb options

2022-09-19 Thread Ihar Hrachyshka
controller instances using the same vswitchd instance. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 151 +++- controller/chassis.h| 6 +- controller/encaps.c | 13 ++-- controller/ovn-controller.c | 121

[ovs-dev] [PATCH ovn 4/6] Support passing chassis name via CLI

2022-09-19 Thread Ihar Hrachyshka
. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 5 + controller/chassis.h| 1 + controller/ovn-controller.c | 9 tests/ovn-macros.at | 4 ++-- tests/ovn.at| 42 + 5 files changed, 59 insertions(+), 2

[ovs-dev] [PATCH ovn 1/6] Rename tunnel ports to include source chassis name

2022-09-19 Thread Ihar Hrachyshka
This is in preparation to support multiple separate controller instances with distinct chassis names operating on the same vswitchd instance. Signed-off-by: Ihar Hrachyshka --- controller/encaps.c | 3 +- tests/ovn-controller.at | 22 +++--- tests/ovn-ipsec.at | 16 ++--- tests

[ovs-dev] [PATCH ovn 0/6] Support 2+ controllers on the same vswitchd

2022-09-19 Thread Ihar Hrachyshka
may, in some instances, simplify administration of the system, since the admin no longer needs to maintain separate vswitchd installations (e.g. in separate containers). This is also helpful when running different datapath types for the mixed setup. Ihar Hrachyshka (6): Rename tunnel ports

[ovs-dev] [PATCH ovn 3/6] Allow to override system-id via file

2022-09-19 Thread Ihar Hrachyshka
on controller startup. The file setting overrides configuration stored in ovsdb, if any. This may be useful when running multiple containerized controller instances using the same vswitchd. Signed-off-by: Ihar Hrachyshka --- controller/chassis.c| 6 ++ controller/chassis.h| 2

Re: [ovs-dev] [OVN v4] OVN - Add Support for Remote Port Mirroring

2022-08-25 Thread Ihar Hrachyshka
> > Other than those regarding the ovn-controller.c and ovn-nb.ovsschema I have > replied inline below. > Kindly take a look and let me know your comments. > > On Thu, Aug 25, 2022 at 5:21 AM Ihar Hrachyshka wrote: >> >> Hi, >> >> I've reviewed everything excep

Re: [ovs-dev] [OVN v4] OVN - Add Support for Remote Port Mirroring

2022-08-24 Thread Ihar Hrachyshka
Hi, I've reviewed everything except mirror.[ch] files. See below. On Mon, Aug 22, 2022 at 4:41 PM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create

Re: [ovs-dev] [PATCH ovn v3 1/5] binding.c: Avoid checking OVSDB tracking status in handle_updated_port.

2022-08-22 Thread Ihar Hrachyshka
Acked-by: Ihar Hrachyshka On Thu, Aug 18, 2022 at 8:21 PM Han Zhou wrote: > > xxx_is_deleted() is an interface that is expected to be used for OVSDB > tracked changes only, but handle_updated_port() function handles both > tracked and untracked rows. It may happen to behave

Re: [ovs-dev] [PATCH v6 ovn 2/2] controller: throttle port claim attempts

2022-08-17 Thread Ihar Hrachyshka
Thanks for bringing this up to Mark and Han. I just posted 22.06 and 22.03 branch backport series in case they are ok'ed to go. Ihar On Sun, Aug 14, 2022 at 8:53 PM Numan Siddique wrote: > > On Thu, Aug 11, 2022 at 4:07 AM Ihar Hrachyshka wrote: > > > > Numan, thank you! >

[ovs-dev] [PATCH branch-22.03 ovn 2/2] controller: throttle port claim attempts

2022-08-17 Thread Ihar Hrachyshka
://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson Signed-off-by: Numan Siddique (cherry picked from commit 4dc4bc7fdb848bcc626becbd2c80ffef8a39ff9a) (cherry picked from commit 887a8df4f4aa08a4a87b42f7aa684ed7e9aff9a1) --- controller/binding.c| 121

[ovs-dev] [PATCH branch-22.03 ovn 1/2] Split out code to handle port binding db updates

2022-08-17 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Conflicts: controller/binding.c Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson Signed-off-by: Numan Siddique (cherry picked from commit 3103487e087b27b1b3577afba016403fd1ac3093

[ovs-dev] [PATCH branch-22.06 ovn 2/2] controller: throttle port claim attempts

2022-08-17 Thread Ihar Hrachyshka
notification consumers trying to keep up with the barrage. This patch throttles port claim attempts so that they don't happen more frequently than once per 0.5 seconds. Reported: https://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson Signed-off

[ovs-dev] [PATCH branch-22.06 ovn 1/2] Split out code to handle port binding db updates

2022-08-17 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson Signed-off-by: Numan Siddique (cherry picked from commit 3103487e087b27b1b3577afba016403fd1ac3093) --- controller/binding.c | 246

Re: [ovs-dev] [PATCH v6 ovn 2/2] controller: throttle port claim attempts

2022-08-10 Thread Ihar Hrachyshka
Numan, thank you! Is it backport material? I know there may be some conflicts and am happy to handle them if we agree this fix can be backported. Thanks again. Ihar On Tue, Aug 9, 2022 at 8:50 PM Numan Siddique wrote: > > On Wed, Aug 10, 2022 at 4:25 AM Ihar Hrachyshka wrote: > &

[ovs-dev] [PATCH v6 ovn 2/2] controller: throttle port claim attempts

2022-08-09 Thread Ihar Hrachyshka
notification consumers trying to keep up with the barrage. This patch throttles port claim attempts so that they don't happen more frequently than once per 0.5 seconds. Reported: https://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson --- v1

[ovs-dev] [PATCH v6 ovn 1/2] Split out code to handle port binding db updates

2022-08-09 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson --- v6: rebased, added Mark's ack --- controller/binding.c | 246 ++- 1 file changed, 128

Re: [ovs-dev] [PATCH ovn] controller: physical: fix regression for container ports

2022-07-28 Thread Ihar Hrachyshka
Oops, sorry about that. This should be backported to 22.06. Acked-By: Ihar Hrachyshka wrote: > > After commit 'd07e5f99d ("Introduce match_outport_dp_and_port_keys > in physical.c")' it is not longer possible to ping a parent port from > container one.

[ovs-dev] [PATCH branch-22.03 ovn 2/2] qos: add support for port minimum bandwidth guarantee

2022-07-27 Thread Ihar Hrachyshka
Reported-At: https://bugzilla.redhat.com/show_bug.cgi?id=2060310 Signed-off-by: Ihar Hrachyshka Acked-by: Ales Musil Signed-off-by: Mark Michelson (cherry picked from commit dbf12e5fe1f7ab2acef4152854c239b999b70188) --- NEWS | 2 ++ controller/binding.c | 13 ++--- ovn

[ovs-dev] [PATCH branch-22.03 ovn 1/2] tests: check qos_max_rate and qos_burst are set

2022-07-27 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka Acked-by: Ales Musil Signed-off-by: Mark Michelson (cherry picked from commit 8f4beb7ce310e4bcac0aff636fa948aa3ca438ac) --- tests/system-ovn.at | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/system-ovn.at b/tests/system-ovn.at

[ovs-dev] [PATCH ovn] tests: enable and fix vif-provider test scenario

2022-07-27 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- controller/test-vif-plug.c | 2 +- tests/ovn-vif-plug.at | 2 +- tests/testsuite.at | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/controller/test-vif-plug.c b/controller/test-vif-plug.c index 01ff37d8f..d7094199a 100644

Re: [ovs-dev] [PATCH ovn v3 6/6] northd: Limit bulk removal of MAC binding aging

2022-07-26 Thread Ihar Hrachyshka
Acked-By: Ihar Hrachyshka On Wed, Jul 20, 2022 at 4:56 AM Ales Musil wrote: > > Because the transaction is limited, in terms of how > many operations it can do, we should not allow > more than 15 MAC bindings to be removed at once every > 10 ms. This has a downside that in

Re: [ovs-dev] [PATCH ovn v3 4/6] northd: Add MAC binding aging mechanism

2022-07-26 Thread Ihar Hrachyshka
Acked-By: Ihar Hrachyshka On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote: > > Add MAC binding aging mechanism, that utilizes > the timestamp column of MAC_Binding table. > When the MAC binding exceeds the threshold it is > removed from SB DB, this is postponed only in case >

Re: [ovs-dev] [PATCH ovn v3 3/6] northd: Move struct ovn_datapath and related structs to northd.h

2022-07-26 Thread Ihar Hrachyshka
Acked-By: Ihar Hrachyshka On Wed, Jul 20, 2022 at 4:53 AM Ales Musil wrote: > > The struct ovn_datapath could not be used outside the northd.c > move it to northd.h that it can be used by other .c files later on. > > Reported-at: https://bugzilla.redhat.com/2084668 > Signed-

Re: [ovs-dev] [PATCH ovn v3 2/6] controller: Add mac-binding-index.c/.h files

2022-07-26 Thread Ihar Hrachyshka
Acked-By: Ihar Hrachyshka On Wed, Jul 20, 2022 at 4:55 AM Ales Musil wrote: > > Add helper source file for creating index > over MAC binding table. > > Reported-at: https://bugzilla.redhat.com/2084668 > Signed-off-by: Ales Musil > --- > v3: Rebase on top of current main

Re: [ovs-dev] [PATCH ovn v3 1/6] northd, controller: Add timestamp column to MAC_Binding table

2022-07-26 Thread Ihar Hrachyshka
Acked-By: Ihar Hrachyshka On Wed, Jul 20, 2022 at 4:51 AM Ales Musil wrote: > > The new timestamp column in MAC_Binding is > populated with current time whenever the row is > created or the MAC address is updated. > This can be utilized by MAC binding aging mechanism, >

Re: [ovs-dev] [PATCH ovn v3 4/6] northd: Add MAC binding aging mechanism

2022-07-26 Thread Ihar Hrachyshka
On Tue, Jul 26, 2022 at 1:37 AM Ales Musil wrote: > > > > On Mon, Jul 25, 2022 at 5:53 PM Ihar Hrachyshka > wrote: > >> On Mon, Jul 25, 2022 at 1:23 AM Ales Musil wrote: >> >>> Hi Ihar, >>> >>> >>> On Fri, Jul 22, 2022 at 8:38

Re: [ovs-dev] [PATCH ovn v3 5/6] ovn.at: Add test case covering the MAC binding aging

2022-07-25 Thread Ihar Hrachyshka
On Mon, Jul 25, 2022 at 1:25 AM Ales Musil wrote: > > Hi Ihar, > > > On Fri, Jul 22, 2022 at 8:37 PM Ihar Hrachyshka wrote: >> >> On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote: >> > >> > Reported-at: https://bugzilla.redhat.com/2084668 >> &g

Re: [ovs-dev] [PATCH ovn v3 4/6] northd: Add MAC binding aging mechanism

2022-07-25 Thread Ihar Hrachyshka
On Mon, Jul 25, 2022 at 1:23 AM Ales Musil wrote: > Hi Ihar, > > > On Fri, Jul 22, 2022 at 8:38 PM Ihar Hrachyshka > wrote: > >> On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote: >> > >> > Add MAC binding aging mechanism, that utilizes >> > t

Re: [ovs-dev] [PATCH ovn v3 4/6] northd: Add MAC binding aging mechanism

2022-07-22 Thread Ihar Hrachyshka
On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote: > > Add MAC binding aging mechanism, that utilizes > the timestamp column of MAC_Binding table. > When the MAC binding exceeds the threshold it is > removed from SB DB, this is postponed only in case > we receive update ARP with update to MAC

Re: [ovs-dev] [PATCH ovn v3 5/6] ovn.at: Add test case covering the MAC binding aging

2022-07-22 Thread Ihar Hrachyshka
On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote: > > Reported-at: https://bugzilla.redhat.com/2084668 > Signed-off-by: Ales Musil > --- > v3: Rebase on top of current main. > Update according to the final conclusion. > --- > tests/ovn.at | 109

Re: [ovs-dev] [RFC ovn] Multi-chassis port + MTU behavior

2022-07-21 Thread Ihar Hrachyshka
On Wed, Jul 20, 2022 at 3:45 PM Numan Siddique wrote: > > On Mon, Jul 18, 2022 at 7:44 PM Ihar Hrachyshka wrote: > > > > Hi folks, > > > > looking for some advices on MTU / IP behavior for multi-chassis ports. > > > > 22.06 got the new multichassis port

[ovs-dev] [RFC ovn] Multi-chassis port + MTU behavior

2022-07-18 Thread Ihar Hrachyshka
Hi folks, looking for some advices on MTU / IP behavior for multi-chassis ports. 22.06 got the new multichassis port concept introduced where the same port may be present on multiple chassis, which can be used as a performance optimization for VM live migration, among other things. Migration

[ovs-dev] [PATCH v5 ovn 2/2] controller: throttle port claim attempts

2022-07-12 Thread Ihar Hrachyshka
notification consumers trying to keep up with the barrage. This patch throttles port claim attempts so that they don't happen more frequently than once per 0.5 seconds. Reported: https://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka --- v1: initial version v2: don't

[ovs-dev] [PATCH v5 ovn 1/2] Split out code to handle port binding db updates

2022-07-12 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 250 ++- 1 file changed, 130 insertions(+), 120 deletions(-) diff --git a/controller/binding.c b

Re: [ovs-dev] [PATCH v4 ovn 2/2] controller: throttle port claim attempts

2022-07-12 Thread Ihar Hrachyshka
FYI there's a memory leak in the patch (I don't free shash_node->data on cleanup), please hold off merging. On Tue, Jul 12, 2022 at 2:37 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > > On 7/12/22 12:51, Ihar Hrachyshka wrote: > > When multiple chassis are fight

[ovs-dev] [PATCH ovn] tests: fixed '1 LR with distributed router gateway port' fluke

2022-07-12 Thread Ihar Hrachyshka
The test sometimes failed because of duplicate periodic bcast ARPs captured. Use _UNIQ version of packet check procedure to pass. Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index d65a0ac39

[ovs-dev] [PATCH v4 ovn 2/2] controller: throttle port claim attempts

2022-07-12 Thread Ihar Hrachyshka
notification consumers trying to keep up with the barrage. This patch throttles port claim attempts so that they don't happen more frequently than once per 0.5 seconds. Reported: https://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka --- v1: initial version v2: don't

[ovs-dev] [PATCH v4 ovn 1/2] Split out code to handle port binding db updates

2022-07-12 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 250 ++- 1 file changed, 130 insertions(+), 120 deletions(-) diff --git a/controller/binding.c b

Re: [ovs-dev] [PATCH ovn 2/2] controller: throttle port claim attempts

2022-07-12 Thread Ihar Hrachyshka
On Tue, Jul 12, 2022 at 11:55 AM Mark Michelson wrote: > > Hi Ihar, I have a few comments below. > > On 7/9/22 01:33, Ihar Hrachyshka wrote: > > When multiple chassis are fighting for the same port (requested-chassis > > is not set, e.g. for gateway ports), they may

[ovs-dev] [PATCH v3 ovn 2/2] controller: throttle port claim attempts

2022-07-11 Thread Ihar Hrachyshka
notification consumers trying to keep up with the barrage. This patch throttles port claim attempts so that they don't happen more frequently than once per 0.5 seconds. Reported: https://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka --- v1: initial version v2: don't

[ovs-dev] [PATCH v3 ovn 1/2] Split out code to handle port binding db updates

2022-07-11 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 250 ++- 1 file changed, 130 insertions(+), 120 deletions(-) diff --git a/controller/binding.c b

[ovs-dev] [PATCH v2 ovn 2/2] controller: throttle port claim attempts

2022-07-11 Thread Ihar Hrachyshka
notification consumers trying to keep up with the barrage. This patch throttles port claim attempts so that they don't happen more frequently than once per 0.5 seconds. Reported: https://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka --- v1: initial version v2: don't

[ovs-dev] [PATCH v2 ovn 1/2] Split out code to handle port binding db updates

2022-07-11 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 248 ++- 1 file changed, 129 insertions(+), 119 deletions(-) diff --git a/controller/binding.c b

[ovs-dev] [PATCH ovn 2/2] controller: throttle port claim attempts

2022-07-08 Thread Ihar Hrachyshka
notification consumers trying to keep up with the barrage. This patch throttles port claim attempts so that they don't happen more frequently than once per 0.5 seconds. Reported: https://bugzilla.redhat.com/show_bug.cgi?id=1974898 Signed-off-by: Ihar Hrachyshka --- controller/binding.c| 119

[ovs-dev] [PATCH ovn 1/2] Split out code to handle port binding db updates

2022-07-08 Thread Ihar Hrachyshka
This function will later be used to handle port binding updates for postponed (throttled) bindings. Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 248 ++- 1 file changed, 129 insertions(+), 119 deletions(-) diff --git a/controller/binding.c b

Re: [ovs-dev] [PATCH v2 ovn] Always funnel multichassis port traffic through tunnels

2022-07-08 Thread Ihar Hrachyshka
On Thu, Jul 7, 2022 at 4:39 PM Numan Siddique wrote: > > On Fri, Jul 1, 2022 at 1:52 PM Mark Michelson wrote: > > > > Looks good to me. Thanks, Ihar. > > > > Acked-by: Mark Michelson > > > > On 6/24/22 18:35, Ihar Hrachyshka wrote: > > >

[ovs-dev] Fwd: |fail| pw1650288 [PATCH ovn] Use _[add, del]value to manage additional_[chassis, encap]

2022-06-29 Thread Ihar Hrachyshka
Hi, [sorry if this is the wrong venue.] I've noticed this failure in my local environment and thought that's some issue with my environment, but now I see it in the gate too. You can find a link to the failure below, but in general it goes as: something in a test calls a ovs/ovn CLI command

Re: [ovs-dev] [PATCH ovn] tests: fixed flaky test localnet connectivity with multiple requested-chassis

2022-06-29 Thread Ihar Hrachyshka
Thank you. Acked-by: Ihar Hrachyshka On Wed, Jun 22, 2022 at 12:21 PM Xavier Simonart wrote: > > The test was failing randomly (on highly loaded systems) mainly because > the MAC address of the migrator port in the main switch was migrating at > unexpected times. > In addition,

[ovs-dev] [PATCH ovn] Use _[add, del]value to manage additional_[chassis, encap]

2022-06-29 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- controller/binding.c | 63 +--- 1 file changed, 6 insertions(+), 57 deletions(-) diff --git a/controller/binding.c b/controller/binding.c index 2279570f9..3beafdb0d 100644 --- a/controller/binding.c +++ b/controller

[ovs-dev] [PATCH ovn 2/2] tests: ovn-nbctl dump-flows -> ovn-sbctl dump-flows

2022-06-24 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index bfaa41962..a4a696d51 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -7432,7 +7432,7 @@ ovs-vsctl -- add-port br-int vif2 -- \ # Allow some

[ovs-dev] [PATCH ovn 1/2] Fix memleak in ovn-nbctl when args can't be parsed

2022-06-24 Thread Ihar Hrachyshka
The leak is reported for asan runs. Signed-off-by: Ihar Hrachyshka --- utilities/ovn-dbctl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/utilities/ovn-dbctl.c b/utilities/ovn-dbctl.c index a292e589d..c4cc8c9b2 100644 --- a/utilities/ovn-dbctl.c +++ b/utilities/ovn-dbctl.c

[ovs-dev] [PATCH v2 ovn] Always funnel multichassis port traffic through tunnels

2022-06-24 Thread Ihar Hrachyshka
, this patch reduces network downtime during OpenStack VM live migration from 1.0s+ to 0.05-0.10s, on par with geneve networks. Fixes: 10398c1f51d5 ("Clone packets to all port chassis") Signed-off-by: Ihar Hrachyshka --- v2: fixed a memory leak caught by asan job. v1: initial commit. ---

[ovs-dev] [PATCH ovn] tests: add multi-chassis keyword to relevant test cases

2022-06-23 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index bfaa41962..e2d1d993e 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -14012,6 +14012,7 @@ AT_CLEANUP OVN_FOR_EACH_NORTHD([ AT_SETUP([options:multiple

[ovs-dev] [PATCH ovn] Always funnel multichassis port traffic through tunnels

2022-06-23 Thread Ihar Hrachyshka
, this patch reduces network downtime during OpenStack VM live migration from 1.0s+ to 0.05-0.10s, on par with geneve networks. Fixes: 10398c1f51d5 ("Clone packets to all port chassis") Signed-off-by: Ihar Hrachyshka --- controller/binding.c| 38 ++ controller/lo

[ovs-dev] [PATCH ovn v19] Implement RARP activation strategy for ports

2022-06-17 Thread Ihar Hrachyshka
s options:additional-chassis-activated in southbound db. This feature is useful in live migration scenarios where it's not advisable to unlock the destination port location prematurily to avoid duplicate packets originating from the port. Signed-off-by: Ihar Hrachyshka --- v19: for now, don't hand

Re: [ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-15 Thread Ihar Hrachyshka
, Jun 15, 2022 at 9:39 PM Ihar Hrachyshka wrote: > > When options:activation-strategy is set to "rarp" for LSP, when used in > combination with multiple chassis names listed in > options:requested-chassis, additional chassis will install special flows > that would blo

[ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-15 Thread Ihar Hrachyshka
s options:additional-chassis-activated in southbound db. This feature is useful in live migration scenarios where it's not advisable to unlock the destination port location prematurily to avoid duplicate packets originating from the port. Signed-off-by: Ihar Hrachyshka --- v18: also ha

Re: [ovs-dev] [PATCH ovn v15] Implement RARP activation strategy for ports

2022-06-15 Thread Ihar Hrachyshka
On Wed, Jun 15, 2022 at 12:18 AM Han Zhou wrote: > > > > On Tue, Jun 14, 2022 at 6:19 PM Ihar Hrachyshka wrote: >> >> On Tue, Jun 14, 2022 at 4:19 PM Numan Siddique wrote: >> > > > > > > If I understand correctly, the major benefit of this f

[ovs-dev] [PATCH ovn v17] Implement RARP activation strategy for ports

2022-06-14 Thread Ihar Hrachyshka
s options:additional-chassis-activated in southbound db. This feature is useful in live migration scenarios where it's not advisable to unlock the destination port location prematurily to avoid duplicate packets originating from the port. Acked-by: Han Zhou Signed-off-by: Ihar Hrachyshka --- v17: mak

Re: [ovs-dev] [PATCH ovn v15] Implement RARP activation strategy for ports

2022-06-14 Thread Ihar Hrachyshka
On Tue, Jun 14, 2022 at 4:19 PM Numan Siddique wrote: > > > > > > If I understand correctly, the major benefit of this feature is to > > > > activate the port immediately when ready, without waiting for the > > > > control > > > > plane to converge though SB DB. So I think here it shouldn't

Re: [ovs-dev] [PATCH ovn v15] Implement RARP activation strategy for ports

2022-06-14 Thread Ihar Hrachyshka
On Tue, Jun 14, 2022 at 1:02 PM Numan Siddique wrote: > > On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote: > > > > On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka wrote: > > > > > > On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote: > > > > > >

<    1   2   3   4   5   6   7   8   >