On 3/12/24 13:16, Eelco Chaudron wrote:
>
>
> On 12 Mar 2024, at 12:47, Ilya Maximets wrote:
>
>> Starting with image version 20240310.1.0, GitHub runners are using
>> 32-bit entropy for ASLR:
>>
>> $ sudo sysctl -a | grep vm.mmap.rnd
>> vm.mmap_
On 3/12/24 14:28, Dumitru Ceara wrote:
> On 3/12/24 13:16, Eelco Chaudron wrote:
>>
>>
>> On 12 Mar 2024, at 12:47, Ilya Maximets wrote:
>>
>>> Starting with image version 20240310.1.0, GitHub runners are using
>>> 32-bit entropy for ASLR:
are available
reducing ASLR entropy manually to 28 bits to make builds work.
Reported-at: https://github.com/actions/runner-images/issues/9491
Signed-off-by: Ilya Maximets
---
.github/workflows/build-and-test.yml | 8
1 file changed, 8 insertions(+)
diff --git a/.github/workflows/build
On 3/11/24 21:00, Ilya Maximets wrote:
> On 3/11/24 20:47, Ilya Maximets wrote:
>> Something strange is happening. Every single test fails if
>> clang with asan+ubsan tests are running on 20240310.1.0 image.
>>
>> Example: https://github.com/ovsrobot/ovs/actions/runs/8
On 3/11/24 20:47, Ilya Maximets wrote:
> Something strange is happening. Every single test fails if
> clang with asan+ubsan tests are running on 20240310.1.0 image.
>
> Example: https://github.com/ovsrobot/ovs/actions/runs/8237626849
>
> Every built binary appears to be cra
ng works fine.
FYI.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ues/issues/321
Signed-off-by: Ilya Maximets
---
lib/netdev-dpdk.c | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 9444c53b1..8c52accff 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -607,6 +60
On 3/11/24 06:17, Han Zhou wrote:
>
>
> On Fri, Mar 8, 2024 at 12:17 AM Tao Liu <mailto:taoliu...@163.com>> wrote:
>>
>>
>> On 3/7/24 5:39 AM, Ilya Maximets wrote:
>> > On 2/27/24 20:14, Han Zhou wrote:
>> >> For kernel datapath, when a
ion.h | 6 +
> tests/ovsdb-execution.at | 51
> tests/ovsdb-rbac.at | 23 ++
> 4 files changed, 102 insertions(+), 1 deletion(-)
Thanks, Mike! Applied.
Best regards, Ilya Maximets.
_
On 3/8/24 12:21, Kevin Traynor wrote:
> On 07/03/2024 19:39, Ilya Maximets wrote:
>> It's hard to debug situations where driver rejects packets for some
>> reason. Dumping out the mbuf should help with that.
>>
>> Sample output looks like this:
>>
>> |netd
ssion
>> Down")
>>
>> Reported-by: Alex Stupnikov
>> Reported-at: https://bugzilla.redhat.com/2258496
>> Signed-off-by: Timothy Redaelli
>
> Thanks for following up, the change looks good to me!
>
> Acked-by: Eelco Chaudron
>
Thanks, Timothy a
> Signed-off-by: Timothy Redaelli
>> ---
>
> Other than the small grammer correction this patch look good to me. So
> assuming the change is applied on commit;
>
> Acked-by: Eelco Chaudron
Thanks, Timothy and Eelco!
I fixed the issues and applied the patc
On 3/7/24 22:29, Ilya Maximets wrote:
> On 3/7/24 21:59, Adrian Moreno wrote:
>>
>>
>> On 3/7/24 17:54, Ilya Maximets wrote:
>>> On 3/7/24 16:18, Adrian Moreno wrote:
>>>> ** Background ** Currently, OVS supports several packet
>>>> sampli
ne zone should leave the others intact
Nit: Capital letter and a period at the end.
> +AT_CHECK([ovs-appctl dpctl/flush-conntrack zone=2])
> +AT_CHECK([ovs-appctl dpctl/dump-conntrack zone=1 | FORMAT_CT(10.1.1.2)],
> [0], [dnl
> +tcp,orig=(src=10.1.1.1,dst=10.1.1.2,sport=,dport=),reply
On 3/8/24 11:02, Adrian Moreno wrote:
>
>
> On 2/20/24 07:29, Adrian Moreno wrote:
>>
>>
>> On 2/19/24 23:53, Ilya Maximets wrote:
>>> On 2/19/24 09:14, Adrian Moreno wrote:
>>>> Add a page for flow visualization with a few key concepts and
On 3/7/24 21:59, Adrian Moreno wrote:
>
>
> On 3/7/24 17:54, Ilya Maximets wrote:
>> On 3/7/24 16:18, Adrian Moreno wrote:
>>> ** Background **
>>> Currently, OVS supports several packet sampling mechanisms (sFlow,
>>> per-bridge IPFIX, per-
| ...$
0020: 00 00 00 00 00 00 FF 02 00 00 00 00 00 00 00 00 |
0030: 00 00 00 00 00 16 3A 00 05 02 00 00 01 00 8F 00 | ..:.
Signed-off-by: Ilya Maximets
---
Version 2:
* Only dumping the first invalid packet as we don't actually
know
On 3/7/24 20:09, Ilya Maximets wrote:
> On 3/7/24 18:08, Eric Garver wrote:
>> v10:
>> - fix a sparse error in show_dp_feature_atomic_bool()
>> v9:
>> - new patch make get_datapath_cap() access support by pointer
>> - fix a clang warning in copy_support()
&
On 3/7/24 18:08, Eric Garver wrote:
> Kernel support has been added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
> ---
> include/linux/openvswitch.h | 2 +-
> lib/dpif.c | 6 ---
> lib/dpif.h | 1 -
>
On 3/7/24 20:18, Ilya Maximets wrote:
> On 3/7/24 18:08, Eric Garver wrote:
>> The next commit will convert a dp feature from bool to atomic_bool. As
>> such we have to add support to the macros and functions. We must pass by
>> reference instead of pass by value because all
On 3/7/24 18:08, Eric Garver wrote:
> The next commit will convert a dp feature from bool to atomic_bool. As
> such we have to add support to the macros and functions. We must pass by
> reference instead of pass by value because all the atomic operations
> require a reference.
>
> Signed-off-by:
d patch and some issue with clang-analyzer in the next one.
In general, it might be easier if you can debug the tests by pushing
to you local fork on github first before sending patches to the list.
Just to save a few iterations.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
en a separate
socket and configure sampling to redirect all packets there while
normal MISS upcalls would still arrive to per-cpu sockets. This
should cover the performance concern.
For the case without per-cpu dispatch, the feature comes for free
if userspace application
On 3/7/24 14:22, Kevin Traynor wrote:
> On 05/03/2024 17:31, Ilya Maximets wrote:
>> On 3/5/24 18:13, Kevin Traynor wrote:
>>> On 05/03/2024 15:22, Ilya Maximets wrote:
>>>> It's hard to debug situations where driver rejects packets for some
>>>>
n general. We should likely
just destroy the tnl_port structure right away, similarly to how we clean
up stp, lldp and bundles in ofproto_port_unregister(). Maybe we can add
a new callback similar to bundle_remove() and call tnl_port_del() from it?
(I didn't try, so I'm not 100% sure this wi
On 3/5/24 18:13, Kevin Traynor wrote:
> On 05/03/2024 15:22, Ilya Maximets wrote:
>> It's hard to debug situations where driver rejects packets for some
>> reason. Dumping out the mbuf should help with debugging.
>>
>> Sample output looks like this:
>>
>>
| ...$
0020: 00 00 00 00 00 00 FF 02 00 00 00 00 00 00 00 00 |
0030: 00 00 00 00 00 16 3A 00 05 02 00 00 01 00 8F 00 | ..:.
Signed-off-by: Ilya Maximets
---
lib/netdev-dpdk.c | 33 +
1 file changed, 33 insertions
t further, but
I'm a little hesitant to do so since we don't have CI for stable branches
and no-one complained so far. Let me know if you think we should backport
further, I can do that.
Best regards, Ilya Maximets.
>
>>
>> On 1 Mar 2024, at 22:10, Ilya Maximets wrote:
>>
>>
h/patch/20240209161718.1149494-1-i.maxim...@ovn.org/
>
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/319
> Co-authored-by: Ilya Maximets
> Signed-off-by: Ilya Maximets
> Signed-off-by: Adrian Moreno
> ---
Thanks! Applied and backported down t
On 2/26/24 14:10, Simon Horman wrote:
> On Thu, Feb 22, 2024 at 04:06:32PM +0100, Ilya Maximets wrote:
>> Trace attempts to process all the recirculations. However, if there
>> is a recirculation loop, i.e. if every recirculation generates another
>> recirculation, this pr
On 2/20/24 23:52, Ilya Maximets wrote:
> On 2/20/24 23:33, Alin Serdean wrote:
>> Thank you so much for the patches and dealing with this, Ilya!
>>
>> Regarding the MD / MT linking for a given binary, this can work, usually,
>> without any issues, although it wi
, and we
can also move 'windows-prepare.sh' to the install phase.
Cache is also invalidated whenever appveyor.yml changes.
Acked-by: Simon Horman
Signed-off-by: Ilya Maximets
---
appveyor.yml | 52 ++--
1 file changed, 42 insertions(+), 10
.
While at it, fixing documentation examples to point to Win64 default
installation folder.
Signed-off-by: Ilya Maximets
---
Documentation/intro/install/windows.rst | 6 +++---
m4/ax_check_openssl.m4 | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation
inherited ACEs
from a containing folder.
Acked-by: Simon Horman
Signed-off-by: Ilya Maximets
---
utilities/ovs-pki.in | 87 ++--
1 file changed, 84 insertions(+), 3 deletions(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
index b0c538903
We need to know exact linking / compilation errors in order
to fix issues. We could have uploaded it as an artifact,
but it seems easier to just print it out for now.
Acked-by: Simon Horman
Signed-off-by: Ilya Maximets
---
.ci/windows-build.sh | 2 +-
1 file changed, 1 insertion(+), 1
builting everything with MT by default. [Alin]
* Fixed OpenSSL-Win32 references in the installation doc. [Alin]
* Added Acks from Simon to patches 1, 2 and 4.
Ilya Maximets (4):
appveyor: Print out config.log on configuration failure.
ovs-pki: Fix file permissions on Windows.
m4: Fix
On 2/26/24 22:16, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply
mirror_mask_t *dup_mirrors, struct ofbundle **out,
> -int *snaplen, int *out_vlan);
> +bool mirror_get(struct mbridge *mbridge, int index,
> +struct mirror_config *mc);
Not a full review, but don't add names for obviously typed arg
om Mike I have a couple nits for the test.
See below. Otherwise, the change looks good.
Best regards, Ilya Maximets.
> ---
> lib/conntrack.c | 14
> lib/conntrack.h | 1 +
> tests/system-traffic.at | 47 +
>
On 3/1/24 16:18, Paolo Valerio wrote:
> Ilya Maximets writes:
>
>> With a new runner update, GitHub Actions had a kernel update.
>> And it seems like something changed between kernels 6.2 and 6.5
>> so this test now fails very frequently.
>>
>> I can repro
On 3/1/24 12:37, Ilya Maximets wrote:
> With a new runner update, GitHub Actions had a kernel update.
> And it seems like something changed between kernels 6.2 and 6.5
> so this test now fails very frequently.
>
> I can reproduce the same issue on RHEL 9, and I can't reproduce
, but the behavior
is unexpected and the test fails.
Disable the test in CI until we figure out how to fix the
kernel (if it is a kernel bug) or the test.
Signed-off-by: Ilya Maximets
---
tests/system-traffic.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
s
mean innermost header, except for cases where they do not,
doesn't make a lot of sense to me and we'll keep hitting issues
like this one because of that.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 2/29/24 01:56, Chris Mi wrote:
> On 2/28/2024 8:51 PM, Ilya Maximets wrote:
>> On 2/28/24 13:26, Chris Mi wrote:
>>> Hi Ilya,
>>>
>>> On 2/28/2024 7:56 PM, Ilya Maximets wrote:
>>>> On 2/28/24 11:03, Eelco Chaudron wrote:
>>&
.h | 6 +
> tests/ovsdb-execution.at | 51
> tests/ovsdb-rbac.at | 23 ++
> 4 files changed, 105 insertions(+), 1 deletion(-)
Hi, Mike. Thanks for v2! I didn't test, but it looks good in general.
See one comment inline.
Best regards, Ilya Maximets.
be the case, but I don't know.
>
> There is a lot of online info on this, for example
> https://nexb.com/do-you-really-need-to-update-the-copyright-each-new-year/.
> But maybe you can ask the legal team.
This one copyright notice is a little different from the ones
in the files with
On 2/28/24 13:26, Chris Mi wrote:
> Hi Ilya,
>
> On 2/28/2024 7:56 PM, Ilya Maximets wrote:
>> On 2/28/24 11:03, Eelco Chaudron wrote:
>>>
>>>
>>> On 28 Feb 2024, at 8:06, Chris Mi wrote:
>>>
>>>> Hi Eelco,
>>>>
slow ping:
https://patchwork.ozlabs.org/project/openvswitch/patch/20230619050557.310690-9-...@nvidia.com/#3136718
It should be reproducible locally under ASAN.
Ping is not a reliable tool when we're trying to send a particular number
of packets, especially with intervals under 10
On 1/29/24 20:24, Ilya Maximets wrote:
> On 1/26/24 17:00, Eelco Chaudron wrote:
>>
>>
>> On 26 Jan 2024, at 15:38, Ilya Maximets wrote:
>>
>>> checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16
>>> which is now deprecated i
On 2/27/24 17:05, Ilya Maximets wrote:
> If the ACL.log is false for a fair meter, but ACL.meter is set in the
> Northbound database, northd will create a unique meter for this ACL in
> a Southbound database, even though it will never be used.
>
> Normal ovn-nbctl acl-add comma
be fixed
anyway.
Fixes: 880dca99eaf7 ("northd: Enhance the implementation of ACL log meters
(pre-ddlog merge).")
Reported-at: https://issues.redhat.com/browse/FDP-401
Signed-off-by: Ilya Maximets
---
northd/en-meters.c | 8 ++--
tests/ovn-northd.at | 18 ++
2 files c
On 2/27/24 07:51, Han Zhou wrote:
>
>
> On Mon, Feb 26, 2024 at 9:44 AM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>>
>> Currently, ovn-controller attempts to sync all the meters on each
>> ofctrl_put() call. And the complexity of this logic is q
On 2/26/24 18:44, Ilya Maximets wrote:
> Currently, ovn-controller attempts to sync all the meters on each
> ofctrl_put() call. And the complexity of this logic is quadratic
> because for each desired meter we perform a full scan of all the
> rows in the Southbound Meter table in ord
instead. But using an index
is a simpler fix for now.
Fixes: 885655e16e63 ("controller: reconfigure ovs meters for ovn meters")
Fixes: 999e1adfb572 ("ovn: Support configuring meters through SB Meter table.")
Reported-at: https://issues.redhat.com/browse/FDP-399
Signed-o
On 2/22/24 14:12, Daniel Ding wrote:
>
>
>
>> 2024年2月22日 下午7:20，Ilya Maximets > <mailto:i.maxim...@ovn.org>> 写道：
>>
>> On 2/22/24 11:53, Ilya Maximets wrote:
>>> On 2/22/24 11:02, Daniel Ding wrote:
>>>>
>>>>
>>>&g
; ./resubmits.txt
ovs-ofclt add-flows br0 ./resubmits.txt
ovs-appctl ofproto/trace br0 'in_port=1' > ./trace.txt
Depending on compiler flags it manages to get to 4096 resubmit limit
in anywhere from 5 to 16 recirculations.
Thoughts?
Signed-off-by: Ilya Maximets
---
include/openvswitch/comp
ackets and it is a side effect
of a kernel conntrack implementation. But I see how it can be
useful for the real world tracing since the Linux kernel does behave
this way and it's not going to change any time soon.
So, yeah, I think, it's reasonable to add such a trace modifier in
the future
Caamaño Ruiz
Signed-off-by: Ilya Maximets
---
ofproto/ofproto-dpif-trace.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/ofproto/ofproto-dpif-trace.c b/ofproto/ofproto-dpif-trace.c
index b86e7fe07..87506aa78 100644
--- a/ofproto/ofproto-dpif-trace.c
+++ b/ofproto/
On 2/22/24 11:53, Ilya Maximets wrote:
> On 2/22/24 11:02, Daniel Ding wrote:
>>
>>
>>> 2024年2月22日 上午1:55，Ilya Maximets >> <mailto:i.maxim...@ovn.org>> 写道：
>>>
>>> On 2/21/24 15:27, Aaron Conole wrote:
>>>> Daniel Ding mailt
On 2/22/24 11:02, Daniel Ding wrote:
>
>
>> 2024年2月22日 上午1:55，Ilya Maximets > <mailto:i.maxim...@ovn.org>> 写道：
>>
>> On 2/21/24 15:27, Aaron Conole wrote:
>>> Daniel Ding mailto:danieldin...@gmail.com>> writes:
>>>
>>&g
On 2/20/24 23:35, Ilya Maximets wrote:
> The whole patch set is needed for a two-line fix in the third patch,
> more precisely, for the ability to test these two lines.
>
> First patch in the set is not necessary, but it makes a second patch
> a little cleaner.
>
> The seco
On 2/21/24 15:34, Eelco Chaudron wrote:
>
>
> On 15 Feb 2024, at 13:00, Ilya Maximets wrote:
>
>> Currently, failures of pthread_* functions are printed to stderr
>> only and then OVS aborts. These error messages are hard to find
>> and may be even just lost.
h 35: 9007199254740940 kB load
+ hash 41: 9007199254740940 kB load
...
Could you, please, take a look?
Also, we should probably add a test like that to the patch.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
of recursion
check and blocking it while executing the hooks. The signal number
will need to be stored in the signal handler and the signal will need
to be re-raised in the call_hooks() instead of signal handler.
We can use mutex.acquire(blocking=False) as a way to prevent recursion.
Does that make se
we need to change the instructions at the top from MinGW to
MSYS, but I actually have no idea how to install them. I've only been
using what AppVeyor provides. :)
So, if you can take this one that would be great. It can definitely
be a separate change.
Best regards, Ilya Maximets.
>
> I wil
ase for now.
Fixes: 8e4e45887ec3 ("ofproto-dpif-xlate: makes OVS native tunneling honor
tunnel-specified source addresses")
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-February/052938.html
Reported-by: Derrick Lim
Signed-off-by: Ilya Maximets
---
rface,
there will be a route to each locally hosted IP in the local routing
table. This is a normal side effect of bringing up an IP address on
an interface under linux."
Signed-off-by: Ihar Hrachyshka
Co-authored-by: Ilya Maximets
Signed-off-by: Ilya Maximets
---
lib/netdev-dummy.c| 17 +++
-by: Ilya Maximets
---
tests/system-layer3-tunnels.at | 55 ---
tests/tunnel-push-pop.at | 79 ++
2 files changed, 79 insertions(+), 55 deletions(-)
diff --git a/tests/system-layer3-tunnels.at b/tests/system-layer3-tunnels.at
index 6fbdedb64
Hrachyshka (1):
netdev-dummy: Add local route entries for IP addresses.
Ilya Maximets (2):
tests: Move the non-local port as tunnel endpoint test.
ofproto-dpif-xlate: Fix ignoring IPv6 local_ip for native tunnels.
AUTHORS.rst| 1 +
lib/netdev-dummy.c | 17 ++-
lib
do you think?
I didn't fully read the doc, but see some typos and minor issues that
caught my eye below.
Best regards, Ilya Maximets.
> Documentation/topics/index.rst | 1 +
> 3 files changed, 472 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/to
${command}
> +unset command
> +])
Hi, Xavier. Not an issue of this particular patch as this thing was
introduced long ago, but...
The shell command 'command' is a way to call a different command ignoring
the defined aliases. Overloading the 'command' itself in that sense do
On 2/8/24 16:53, Eelco Chaudron wrote:
>
>
> On 8 Feb 2024, at 15:00, Ilya Maximets wrote:
>
>> On 2/8/24 13:44, Eelco Chaudron wrote:
>>>
>>>
>>> On 6 Feb 2024, at 16:01, Ilya Maximets wrote:
>>>
>>>> On 2/6/24 15:07, Eel
p dump;
> struct ofpbuf buf, reply, delete;
> +int err;
> +
> +if (netlink_flush_supports_zone()) {
> +ofpbuf_init(, NL_DUMP_BUFSIZE);
> +
> +nl_msg_put_nfgenmsg(, 0, AF_UNSPEC, NFNL_SUBSYS_CTNETLINK,
> +IPCTNL_MSG_CT_DELETE
On 2/16/24 16:55, Simon Horman wrote:
> On Fri, Feb 16, 2024 at 12:46:33PM +0100, Ilya Maximets wrote:
>> Signed-off-by: Ilya Maximets
>
> Acked-by: Simon Horman
>
Thanks, Simon!
I applied the patches (first one to master and branch-3.3 and
the second one to branch-3.
On 2/16/24 21:40, Mike Pattrick wrote:
> On Fri, Feb 16, 2024 at 3:23 PM Ilya Maximets wrote:
>>
>> On 2/15/24 23:53, Mike Pattrick wrote:
>>> Previously a gap existed in the tunnel system tests where only ICMP and
>>> TCP traffic was tested. However, the
ya/ovs/commit/f544d397250714b7ba8c1a3f81eada29ffd59142
I did several iterations of GHA runs with these changes and they
work fine in CI.
If you agree, I can fold those in while applying the set.
Please, let me know as soon as possible as we need to proceed with
the release.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
CC: Aaron, Simon. :)
On 2/16/24 12:46, Ilya Maximets wrote:
> It's time for an OVS 3.3 release!
>
> The plan is to accept a couple more fixes before the actual release,
> namely checksum offloading fixes, but sending this set now to get
> it reviewed.
>
> Ilya Maximets (2):
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index fb3ec..4bfb341cf 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.3.1 - xx xxx
Beside the date update, moving the mdb NEWS entry to a more
appropriate place - ovs-appctl section.
Signed-off-by: Ilya Maximets
---
NEWS | 6 +++---
debian/changelog | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index e4eedb5b4..fb3ec 100644
It's time for an OVS 3.3 release!
The plan is to accept a couple more fixes before the actual release,
namely checksum offloading fixes, but sending this set now to get
it reviewed.
Ilya Maximets (2):
Set release date for 3.3.0.
Prepare for 3.3.1.
NEWS | 9
oving forward with this simple change at this time?
I think, it's fine for now. The extra 2 recirculations are very unlikely
to blow up the stack, especially since the default config is to have 2 MB
of pre-allocated and mlocked stack.
So, applied for now. Also applied to 3.3 as I don't think this change
carries any risk at this time and it will make life of OVN developers/users
much easier.
But we still need to think of a better way of solving this issue for the
future.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 2/15/24 14:36, Simon Horman wrote:
> On Thu, Feb 15, 2024 at 12:55:59PM +0100, Ilya Maximets wrote:
>> The cited commit removed direct call to RSTP module from a callback,
>> but we can still enter the module after going through a patch port
>> to a different bridge via ofp
On 2/15/24 14:18, Simon Horman wrote:
> On Tue, Feb 13, 2024 at 08:44:41PM +0100, Ilya Maximets wrote:
>> The output file of this openssl command is a certificate signed with
>> pre-existing private key. It doesn't create a private key. The
>> restricted permissions are ex
On 2/15/24 14:15, Simon Horman wrote:
> On Tue, Feb 13, 2024 at 08:42:36PM +0100, Ilya Maximets wrote:
>> It's not an executable file.
>>
>> Signed-off-by: Ilya Maximets
>
> Acked-by: Simon Horman
Thanks, Mike and Simon! Applied.
On 2/14/24 13:43, Xavier Simonart wrote:
> When a ct element was cleaned, the cmap could be shrinked, potentially
> causing some elements to be skipped in the flush iteration.
>
> Signed-off-by: Xavier Simonart
> ---
> lib/conntrack.c | 14 -
> lib/conntrack.h | 1 +
On 2/15/24 13:42, Simon Horman wrote:
> On Tue, Feb 13, 2024 at 11:08:54AM +0100, Ilya Maximets wrote:
>> On 2/13/24 09:37, Adrian Moreno wrote:
>>>
>>>
>>> On 2/13/24 09:32, Adrian Moreno wrote:
>>>>
>>>>
>>>> On 2/9
'.
Signed-off-by: Ilya Maximets
---
Another thing we can do to improve debugability is to also dump
the stack trace on ovs_abort. It will also help with debugging
assertions on systems where coredumps are disabled for some reason.
But it's a separate topic.
lib/ovs-thread.c | 42
lock recursion.")
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-February/052925.html
Reported-by: Huangzhidong
Signed-off-by: Ilya Maximets
---
lib/rstp.c| 6 -
tests/rstp.at | 57 +
tests/stp.at
,14 @@ avx512_dp_packet_resize_l2(struct dp_packet *b, int
> resize_by_bytes)
> /* Set the v_u16_max register to all one's. */
> const __m128i v_u16_max = _mm_cmpeq_epi16(v_zeros, v_zeros);
>
> -/* Each lane represents 16 bits in a 12-bit register. In this case the
> - * first three 16-bit values, which will map to the l2_5_ofs, l3_ofs and
> - * l4_ofs fields. */
> -const uint8_t k_lanes = 0b1110;
> +/* Each lane represents 16 bits in a 12-bit register. Here the bitmask
Not an issue of this patch, but there should be 128-bit register, not 12.
I fixed that before applying the set since we're touching this line anyway.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
TSO.")
>> Signed-off-by: Mike Pattrick
>
> Reviewed-by: David Marchand
>
>
Thanks, Mike and David!
I applied the set and backported down to 3.3.
Patches 2 and 4 also backported down to 2.17.
Best regards, Ilya Maximets.
__
om
> tc operations.
>
> Also expand the unit test to cover queues where ceil is determined by
> the maximum link speed.
>
> Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
> Reported-by: Daryl Wang
> Suggested-by: Ilya Maximets
> Si
permissions in the first place.
Fixes: 99e5e05db37a ("ovs-pki: Create private keys with restricted
permissions.")
Signed-off-by: Ilya Maximets
---
utilities/ovs-pki.in | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pk
It's not an executable file.
Signed-off-by: Ilya Maximets
---
utilities/ovs-pki.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
index e0ba910f9..37913cb6b 100755
--- a/utilities/ovs-pki.in
+++ b/utilities/ovs-pki.in
@@ -318,7
, and we
can also move 'windows-prepare.sh' to the install phase.
Cache is also invalidated whenever appveyor.yml changes.
Signed-off-by: Ilya Maximets
---
appveyor.yml | 52 ++--
1 file changed, 42 insertions(+), 10 deletions(-)
diff --git
inherited ACEs
from a containing folder.
Signed-off-by: Ilya Maximets
---
utilities/ovs-pki.in | 87 ++--
1 file changed, 84 insertions(+), 3 deletions(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
index e0ba910f9..285018e41 100755
We need to know exact linking / compilation errors in order
to fix issues. We could have uploaded it as an artifact,
but it seems easier to just print it out for now.
Signed-off-by: Ilya Maximets
---
.ci/windows-build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci
/20230531192341.2006171-2-i.maxim...@ovn.org/
Fixing permissions for keys and certs generated by ovs-pki,
adding support for building with OpenSSL 3+ and fixing CI
to actually download and build with desired versions of
OpenSSL.
Ilya Maximets (4):
appveyor: Print out config.log on configuration failure
in different folders
based on the linkage type. So, we have to provide an exact path in
order to find the library.
'lib/VC/x64/MD' was chosen in this patch and it seems to work fine.
MD stands for dynamic linking, MT is static, 'd' stands for debug
versions of the libraries.
Signed-off-by: Ilya Maximets
On 2/13/24 09:28, Adrian Moreno wrote:
>
>
> On 2/12/24 18:49, Ilya Maximets wrote:
>> On 2/12/24 09:43, Adrian Moreno wrote:
>>>
>>>
>>> On 2/9/24 17:15, Ilya Maximets wrote:
>>>> On 2/9/24 08:06, Adrian Moreno wrote:
>>>>>
On 2/13/24 09:37, Adrian Moreno wrote:
>
>
> On 2/13/24 09:32, Adrian Moreno wrote:
>>
>>
>> On 2/9/24 17:17, Ilya Maximets wrote:
>>> For some reason annotation is made for a read-lock, while all the
>>> callers are correctly holding a write-lock.
&g
401 - 500 of 6950 matches
Mail list logo
