On 2/9/24 21:47, Ilya Maximets wrote:
> AppVeyor is planning to remove support for MinGW 32bit soon. And we
> had a couple of incidents where it wasn't available already, so we
> moved to a 'Previous' image.
>
> Move to msys64 instead.
>
> While at it making the CI s
is treated as fatal failure by powershell.
Scripts are running with 'set -e', so a failure of individual
commands will fail the script.
The OpenSSL download is still failing, but it is out of scope for
this change.
Signed-off-by: Ilya Maximets
---
.ci/windows-build.sh | 17
.ci
For some reason annotation is made for a read-lock, while all the
callers are correctly holding a write-lock.
Fixes: 05df16238d43 ("ofproto/bond: Fix bond post recirc rule leak.")
Signed-off-by: Ilya Maximets
---
ofproto/bond.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 2/9/24 08:06, Adrian Moreno wrote:
> In order to properly balance bond traffic, ofproto/bond periodically
> reads usage statistics of the post-recirculation rules (which are added
> to a hidden internal table).
>
> To do that, each "struct bond_entry" (which represents a hash within a
> bond)
On 2/8/24 18:06, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> Bug Fix + Security release.
>>
>> Ilya Maximets (2):
>> Set release date for 3.2.2.
>> Prepare for 3.2.3.
>>
>> NEWS | 8 +++-
>> configure.ac | 2 +-
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 3.2.2.
Prepare for 3.2.3.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 0387b66d5..47be5e065 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v3.2.2 - xx xxx
+v3.2.2 - 08 Feb 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 47be5e065..baeecae04 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.2.3 - xx xxx
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 3.1.4.
Prepare for 3.1.5.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 8fff14652..aaddb77e8 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.1.5 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index a88724e1e..0bb28638c 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.0.7 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 77cf4bbac..8fff14652 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v3.1.4 - xx xxx
+v3.1.4 - 08 Feb 2024
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 2a9a99a8f..a88724e1e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v3.0.6 - xx xxx
+v3.0.6 - 08 Feb 2024
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 3.0.6.
Prepare for 3.0.7.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 4c3cdd651..ca111ae3a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v2.17.10 - xx xxx
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 2.17.9.
Prepare for 2.17.10.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 7ef97cfa8..4c3cdd651 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v2.17.9 - xx xxx
+v2.17.9 - 08 Feb 2024
is not sent to flower.
It also includes a system-traffic test for geneve packets with corrupted
metadata.
Fixes: a468645c6d33 ("lib/tc: add geneve with option match offload")
Reported-by: Haresh Khandelwal
Signed-off-by: Timothy Redaelli
Signed-off-by: Ilya Maximets
---
The patch is alrea
than both
'icmp_type=..,icmp_code=0' when matching on neighbor discovery.
Signed-off-by: Aaron Conole
Signed-off-by: Ilya Maximets
---
The patch is already applied. Posting for completeness.
lib/odp-util.c | 31 +++--
tests/ofproto-macros.at | 15
On 2/8/24 13:44, Eelco Chaudron wrote:
>
>
> On 6 Feb 2024, at 16:01, Ilya Maximets wrote:
>
>> On 2/6/24 15:07, Eelco Chaudron wrote:
>>>
>>>
>>> On 6 Feb 2024, at 14:46, Ilya Maximets wrote:
>>>
>>>> On 2/6/24 14:30, Eelco Ch
On 2/7/24 22:07, Adrian Moreno wrote:
>
>
> On 2/7/24 19:05, Ilya Maximets wrote:
>> On 2/5/24 13:02, Adrian Moreno wrote:
>>> netdev_linux_get_speed needs to lock netdev_linux->mutex, and so do the
>>> internal tc operations. Therefore, the former
om
> tc operations.
>
> Also expand the unit test to cover queues where ceil is determined by
> the maximum link speed.
>
> Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
> Reported-by: Daryl Wang
> Suggested-by: Ilya Maximets
> Signed-off-b
On 2/6/24 22:22, Ilya Maximets wrote:
>>>
>>> I did some testing with my patch and these are the findings
>>>
>>> | Avg. Poll Intervals | Total
>>> test time | northd RSS
>>> ---
umber of very small objects.
Numan also gets rid of all the space allocated for hash maps that hold
all these refcounts, and these were taking ~25% of all allocations.
Getting rid of these allocations likely saves a lot of CPU cycles as
well, since they are very heavy.
P.S.
Almost all of these 12M refco
On 2/6/24 15:07, Eelco Chaudron wrote:
>
>
> On 6 Feb 2024, at 14:46, Ilya Maximets wrote:
>
>> On 2/6/24 14:30, Eelco Chaudron wrote:
>>> Previously, the ability to override the system default for the number
>>> of handler threads was broken since to the in
n changed completely.
And those setups may suffer if we suddenly decide to respect the configuration
that is ignored on modern kernels for all currently supported versions of OVS.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.
ilar to selection), this introduces
an unclear difference between empty mutations with and without condition.
One performs RBAC check and the other does not. We should be consistent.
Would be also nice to have a non-RBAC test that checks the number of rows
mid-transaction, i.e. adds a row, runs
On 2/6/24 13:50, Eelco Chaudron wrote:
>
>
> On 6 Feb 2024, at 13:46, Ilya Maximets wrote:
>
>> On 2/4/24 15:40, Timothy Redaelli wrote:
>>> A log message like this one:
>>>
>>> 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD
et_inner_l4(b)
> - dp_packet_l2_pad_size(b)
Hi, Mike. Thanks for v2!
I don't have any particular comments beside the ones David already made.
Could you, please, address them and post a new version?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
need to split lines, I did that only for ease of reading)
Since at least one part will change, the arrow should not be confusing anymore.
Spelling out bfd.Xx names as in the RFC is probably not necessary since we're
printing out simple words (state, dia
22.11.4
> 3.3.x23.11
>
Hi, Kevin. Thanks for the patches!
I didn't test them, but LGTM. For all DPDK update patches:
Acked-by: Ilya Maximets
P.S.: the 'master/branch-3.3' tag is likely confusing for bots,
it's better to send separate
On 2/5/24 15:45, Ilya Maximets wrote:
> On 2/5/24 11:34, Ilya Maximets wrote:
>> On 2/5/24 09:23, Dumitru Ceara wrote:
>>> On 2/5/24 08:13, Han Zhou wrote:
>>>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>>>
>>>>> On Sun,
On 2/5/24 11:34, Ilya Maximets wrote:
> On 2/5/24 09:23, Dumitru Ceara wrote:
>> On 2/5/24 08:13, Han Zhou wrote:
>>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>>
>>>> On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote:
>>>>>
On 2/5/24 11:58, Dumitru Ceara wrote:
> On 2/5/24 11:34, Ilya Maximets wrote:
>> On 2/5/24 09:23, Dumitru Ceara wrote:
>>> On 2/5/24 08:13, Han Zhou wrote:
>>>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>>>
>>>>> On Sun,
On 2/5/24 09:23, Dumitru Ceara wrote:
> On 2/5/24 08:13, Han Zhou wrote:
>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>
>>> On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote:
>>>>
>>>> On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrot
concerning. Unfortunately it is not tied to the
cluster-density test. The same 4-5x RSS jump is also seen in other test
like density-heavy. Last week RSS of ovn-northd in cluster-density 500 node
was between 1.5 and 2.5 GB, this week we have a range between 5.5 and 8.5 GB.
I would consider th
t;,
\"statistics\",\"status\",\"tag\",\"trunks\",\"vlan_mode\"]"
},"id":52,"result":null}
The column have to stay, similarly to other public interfaces.
What we can probably do is to add a new column and use/store values
from/into both, while removing the old one from the documentation.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
one zone should leave the others intact
Hi, Felix. Not a full review, but I'm a little concerned if that part
actually works for zone 0, i.e. that zone 0 remains intact when we flush
other zones.
I sent a question to the netdev list:
https://lore.kernel.org/netdev/2032238f-31ac-4106-8f22-522e76df5..
"columns": {
> @@ -293,10 +293,9 @@
> "enum": ["set", ["from-lport",
> "to-lport"]]}}},
> "match": {"type": "string"},
>
On 1/30/24 10:55, Simon Horman wrote:
> On Mon, Jan 29, 2024 at 11:33:56PM +0100, Ilya Maximets wrote:
>> Fedora 37 reached EOL in November. Switch to the most recent version
>> to avoid potential CI failures in the future.
>>
>> Signed-off-by: Ilya Maximets
On 1/31/24 14:27, Ilya Maximets wrote:
> On 1/31/24 13:13, Ilya Maximets wrote:
>> On 1/30/24 15:18, Ilya Maximets wrote:
>>> On 1/30/24 13:07, Ilya Maximets wrote:
>>>> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
>>>> outdated Node.js
On 1/31/24 13:13, Ilya Maximets wrote:
> On 1/30/24 15:18, Ilya Maximets wrote:
>> On 1/30/24 13:07, Ilya Maximets wrote:
>>> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
>>> outdated Node.js 16 which is now deprecated in GHA [1], so these
>&g
On 1/30/24 15:18, Ilya Maximets wrote:
> On 1/30/24 13:07, Ilya Maximets wrote:
>> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
>> outdated Node.js 16 which is now deprecated in GHA [1], so these
>> actions may stop working soon.
>>
>> Updat
On 1/30/24 13:07, Ilya Maximets wrote:
> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
> outdated Node.js 16 which is now deprecated in GHA [1], so these
> actions may stop working soon.
>
> Updating to most recent major versions with Node.js 20. This stops
>
pattern: go.sum
Specify a path to all .sum files we have in the repository to make
the setup-go happy. This should in theory make the builds a touch
faster. This change is in line with recent changes in ovn-kubernetes
itself.
Signed-off-by: Ilya Maximets
---
.github/workflows/containers.yml
On 1/30/24 09:54, Jakob Meng wrote:
> On 29.01.24 23:33, Ilya Maximets wrote:
>> Fedora 37 reached EOL in November. Switch to the most recent version
>> to avoid potential CI failures in the future.
>>
>> Signed-off-by: Ilya Maximets
>> ---
>> .github/wo
On 1/25/24 21:55, Aaron Conole wrote:
> All supported versions of Fedora do package libbpf, so it
> makes sense to enable USDT support.
>
> Signed-off-by: Aaron Conole
> ---
> v8: Include the correct devel package as a dependency
>
> rhel/openvswitch-fedora.spec.in | 8
> 1 file
Fedora 37 reached EOL in November. Switch to the most recent version
to avoid potential CI failures in the future.
Signed-off-by: Ilya Maximets
---
.github/workflows/build-and-test.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/build-and-test.yml
b
On 1/26/24 17:00, Eelco Chaudron wrote:
>
>
> On 26 Jan 2024, at 15:38, Ilya Maximets wrote:
>
>> checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16
>> which is now deprecated in GHA [1], so these actions will stop working
>> soon.
>&
On 1/23/24 14:53, Mohammad Heib wrote:
> Hi Dumitru,
>
> Thank you for the review,
> yes sure will bump the submodule to the last stable once they fix the issue.
I applied the BFD fix and also applied the typedef fix for the mcast_group_proto
enum. So, make sure to include both for the update.
On 1/28/24 11:20, Mohammad Heib wrote:
> Thanks, Ilya,
> Looks good to me.
>
> Acked-by: Mohammad Heib mailto:mh...@redhat.com>>
>
Thanks! I applied the change and backported to branch-3.3.
Best regards, Ilya Maximets.
> Thanks,
>
>
>
> On Fri, J
ckported to 3.3.
I left some comments for the other patches in the set.
FWIW, Dumitru, you may want to wait for the following change to land
before upgrading submodule in OVN:
https://patchwork.ozlabs.org/project/openvswitch/patch/20240126170758.11430
that there is a variable definition in
one of the cases and braces should be used. Strangely some versions
of compilers do not require braces in this case, so OVN change works
locally, but not in CI.
Fixes: 077d0bad0436 ("mcast-snooping: Store IGMP/MLD protocol version.")
Signed-of
-off-by: Ilya Maximets
---
Version 2:
* Updated cache/resote and cache/save sub-actions as well.
.github/workflows/build-and-test.yml | 42 ++--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/.github/workflows/build-and-test.yml
b/.github/workflows/build
On 1/25/24 22:46, Mike Pattrick wrote:
> Include inner offsets in functions where l3 and l4 offsets are either
> modified or checked.
>
> Signed-off-by: Mike Pattrick
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> ---
> lib/dp-packet.c | 6 +-
> 1 file changed, 5
On 1/25/24 22:46, Mike Pattrick wrote:
> Previously the BFD packet creation code did not appropriately set
> offsets or flags. This contributed to issues involving encapsulation and
> the TSO code.
>
> Signed-off-by: Mike Pattrick
> Fixes: ccc096898c46 ("bfd: Implement Bidirectional Forwarding
On 1/25/24 22:46, Mike Pattrick wrote:
> This patch fixes the correctness of dp_packet_inner_l4_size() when
> checking for the existence of an inner L4 header. Previously it checked
> for the outer L4 header.
>
> This function is currently only used when a packet is already flagged
> for
On 1/26/24 14:59, Ilya Maximets wrote:
> checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16
> which is now deprecated in GHA [1], so these actions will stop working
> soon.
>
> Updating to most recent major versions with Node.js 20. This stops GHA
> from
-off-by: Ilya Maximets
---
.github/workflows/build-and-test.yml | 38 ++--
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/.github/workflows/build-and-test.yml
b/.github/workflows/build-and-test.yml
index 3807e5f13..8d90f9798 100644
--- a/.github/workflows
On 1/25/24 22:46, Mike Pattrick wrote:
> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
> a BFD packet flagged as double encapsulated would trigger a seg fault.
> The problem surfaced because bfd_put_packet was reusing a packet
> allocated on the stack that wasn't having
On 1/24/24 17:39, Aaron Conole wrote:
> Dumitru Ceara writes:
>
>> On 1/23/24 00:11, Mike Pattrick wrote:
>>> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
>>> a BFD packet flagged as double encapsulated would trigger a seg fault.
>>> The problem surfaced because
On 1/23/24 14:31, Mike Pattrick wrote:
> On Tue, Jan 23, 2024 at 7:41 AM Ilya Maximets wrote:
>>
>> On 1/22/24 23:24, Mike Pattrick wrote:
>>> On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote:
>>>>
>>>> On 1/22/24 21:33, Mike Pattrick wrote:
>
On 1/22/24 23:24, Mike Pattrick wrote:
> On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote:
>>
>> On 1/22/24 21:33, Mike Pattrick wrote:
>>> On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote:
>>>>
>>>> On 1/22/24 18:51, Mike Pattrick
On 1/22/24 21:33, Mike Pattrick wrote:
> On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote:
>>
>> On 1/22/24 18:51, Mike Pattrick wrote:
>>> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
>>> a double encapsulated BFD packet would trigg
On 1/19/24 14:01, Eelco Chaudron wrote:
>
>
> On 19 Jan 2024, at 13:53, David Marchand wrote:
>
>> On Fri, Jan 19, 2024 at 1:49 PM Ilya Maximets wrote:
>>>
>>> On 1/18/24 14:00, David Marchand wrote:
>>>> Seen in GHA recently.
>>>>
> Acked-by: Simon Horman
>
Thanks, Frode and Simon!
Ideally we would add a new argument for the sed strings to the macro
and have a particular replacement logic in the test itself. But since
the replacement is actually only needed for one test, seems fine as-is.
Applied. Backported to 3.3 a
/browse/FDP-300
> Signed-off-by: Mike Pattrick
> ---
> lib/dp-packet.h | 10 --
> lib/packets.c | 6 +++---
> 2 files changed, 11 insertions(+), 5 deletions(-)
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
to work,
but lo interface is down by default in new namespaces. So, bringing
it up. These tests are skipped in Ubuntu 22.04, because it doesn't
have bareudp support, but it's better to have the change anyway, so it
doesn't bite us in the future while upgrading the base image.
Signed-off-by: Ilya
accesses on netdev_dpdk_pending_reset[],
>
> ---
> NEWS | 7 -
> lib/netdev-dpdk.c | 76 +--
> 2 files changed, 61 insertions(+), 22 deletions(-)
Thanks, David!
Applied and backported to branch-3.3.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1/18/24 19:34, Mike Pattrick wrote:
> On Thu, Jan 18, 2024 at 11:40 AM Ilya Maximets wrote:
>>
>> Currently, dp_packet_ol_send_prepare() performs multiple checks for
>> each offloading flag separately. That takes a noticeable amount of
>> extra cycles for p
On 1/19/24 10:18, Simon Horman wrote:
> On Thu, Jan 18, 2024 at 08:25:23PM +0100, Ilya Maximets wrote:
>> Otherwise, it randomly fails due to age not being zero under load:
>>
>> tests/mcast-snooping.at:645: ovs-appctl mdb/show br0
>> --- -
>> +++ /at-gro
On 1/19/24 13:05, Simon Horman wrote:
> On Thu, Jan 18, 2024 at 04:30:06PM +, Simon Horman wrote:
>> On Thu, Jan 18, 2024 at 03:59:05PM +0100, Ilya Maximets wrote:
>>> GCC 14 started to advertise c_atomic extension, older versions didn't
>>> do that. Add check fo
We wanted to be able
to match on "subnets" by supplying only part of the address.
There was at least one test that used this functionality.
Eelco removed it though here:
https://github.com/openvswitch/ovs/commit/a80883f7682158c7a6955360ee852e8279f748e9
Did you check if have any more
IGMPv1224.1.1.1 1
1 0 IGMPv2224.1.1.2 0
1 0 IGMPv3233.54.12.230 0
Fixes: b222593bc69b ("mcast-snooping: Add group protocol to mdb/show output.")
Signed-off-by: Ilya Maximets
---
tests/mcast-snooping.at | 2 ++
1 file
.
Signed-off-by: Ilya Maximets
---
Would be great to have performance numbers confirmed independently
on this one. Better if with some physical ports as well.
I didn't list 'Fixes' tags since it's a little bit of a boiled frog
situation. But I think this should be backported to branch-3.3
On 1/18/24 15:59, Ilya Maximets wrote:
> GCC 14 started to advertise c_atomic extension, older versions didn't
> do that. Add check for __clang__, so GCC doesn't include headers
> designed for Clang.
>
> Another option would be to prefer stdatomic implementation instead,
&
On 1/18/24 15:41, David Marchand wrote:
> When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> mutex lock.
> As part of this configure operation, the net/iavf driver (used with i40e
> VF devices) triggers a queue count change. The PF entity (serviced by a
> kernel PF driver
by GCC as described in commit:
07ece367fb5f ("ovs-atomic: Prefer Clang intrinsics over .")
This change fixes OVS build with GCC on Fedora Rawhide (40).
Reported-by: Jakob Meng
Signed-off-by: Ilya Maximets
---
lib/ovs-atomic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 1/18/24 14:30, David Marchand wrote:
> On Thu, Jan 18, 2024 at 2:23 PM Ilya Maximets wrote:
>>
>> On 1/18/24 14:16, David Marchand wrote:
>>> When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
>>> mutex lock.
>>> As part of thi
On 1/18/24 14:16, David Marchand wrote:
> When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> mutex lock.
> As part of this configure operation, the net/iavf driver (used with i40e
> VF devices) triggers a queue count change. The PF entity (serviced by a
> kernel PF driver
Hi, everyone.
branch-3.3 was just created. Please, test it and report issues!
Official release date, according to our release process, should be
on Friday, February 16th (1 month from now).
Best regards, Ilya Maximets.
___
dev mailing list
d
le. But I think I know how to improve
that. I'll post a small patch tomorrow.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ke and Simon! I applied the set now.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ooperative multitasking.
> json: Add yielding json create/destroy functions.
> ovsdb-server: Make use of cooperative multitasking.
Thanks! I did another round of scale testing and didn't notice any
issues with this change.
Applied.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1/17/24 10:07, Dexia Li wrote:
> For userspace vxlan and geneve tunnel tso, this commit
> fix one packet leak and modify style issues.
>
> Signed-off-by: Dexia Li
> ---
> lib/dp-packet.c | 6 +++---
> lib/dp-packet.h | 46 +
>
On 1/17/24 11:09, Dexia Li wrote:
>
>
> On 1/14/24 00:34, Ilya Maximets wrote:
>> On 12/27/23 19:55, Mike Pattrick wrote:
>>> From: Dexia Li
>>>
>>> For userspace datapath, this patch provides vxlan and geneve tunnel tso.
>>> Only support
On 1/17/24 13:14, Eelco Chaudron wrote:
>
>
> On 17 Jan 2024, at 12:16, Ilya Maximets wrote:
>
>> On 1/16/24 15:26, Eelco Chaudron wrote:
>>>
>>>
>>> On 16 Jan 2024, at 15:20, Ilya Maximets wrote:
>>>
>>>> On 12/27/23
Signed-off-by: Ilya Maximets
---
NEWS | 4
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index b27d4a2ed..0588d41d1 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+Post-v3.3.0
Also fixed the Conntrack Helper Persistence version.
Signed-off-by: Ilya Maximets
---
Documentation/faq/releases.rst | 3 ++-
NEWS | 2 +-
configure.ac | 2 +-
debian/changelog | 4 ++--
debian/rules | 4 ++--
5 files
The plan is to branch today by the EOD. There is still a couple of
patch sets on the list that can/will be applied before that.
Ilya Maximets (2):
Prepare for 3.3.0.
Prepare for post-3.3.0 (3.3.90).
Documentation/faq/releases.rst | 3 ++-
NEWS | 6
On 1/16/24 15:26, Eelco Chaudron wrote:
>
>
> On 16 Jan 2024, at 15:20, Ilya Maximets wrote:
>
>> On 12/27/23 12:15, Mohammad Heib wrote:
>>> Store igmp/mld protocol version into the
>>> mcast_group internally, the multicast snooping feature
>>> is u
.openvswitch.org/pipermail/ovs-dev/2023-June/406049.html
>>> v9: address warnings by 0-robot regarding the summary line
Thanks, Ivan and Kevin!
Applied.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
;ofproto-dpif-upcall: Change flow dump duration message
> to WARN level.")
> Signed-off-by: Eelco Chaudron
> ---
>
> v2: Move exclusion to check_logs()
>
> tests/ofproto-macros.at | 4
> 1 file changed, 4 insertions(+)
Thanks! I applied this one myself to s
On 1/16/24 21:52, Mike Pattrick wrote:
> Correct the length field in IPv6 packets when applying software fallback
> GSO. Previosuly the field retained an IPv4 header size, which was
> incorrect.
>
> Signed-off-by: Mike Pattrick
> ---
> lib/dp-packet-gso.c | 2 +-
> 1 file changed, 1
could incorporate them
myself before branching. Most of them are minor, but I'm proposing
to bring back the json_serialized_object_with_yield(), since it turned
out to be important at higher scale.
Let me know what you think.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
hmap_node, >table->rows) {
> struct json *row_json;
>
> +cooperative_multitasking_yield();
> +
> row_json = ovsdb_monitor_compose_row_update2(mt, condition,
> OVSDB_ROW, row,
>
er scale, but I guess 1 second
is just really not enough there. My guess is that we spend significant
amount of time in socket I/O... But that's a story for another time
and likely much more debugging to actually understand what is going on.
For now, I'd suggest to get the changes above.
What do y
On 1/13/24 00:00, Frode Nordahl wrote:
> The OVSDB server is mostly synchronous and single threaded. The
> OVSDB RAFT storage engine operate under strict deadlines with
> operational impact should the deadline be overrun.
>
> Register for cooperative multitasking so that long running
>
essing in the
> OVSDB server does not interfere with stable maintenance of the
> RAFT cluster in subsequent patches.
>
> Suggested-by: Ilya Maximets
> Signed-off-by: Frode Nordahl
> ---
> lib/automake.mk| 3 +
> lib/cooperative-multitasking-private.h
On 1/13/24 00:00, Frode Nordahl wrote:
> It may be desirable to make use of time warp functionality in unit
> tests.
>
> Separate logic from time/stop unixctl into timeval_stop() and add
> a new timeval_warp() interface for directing monotonic clock into
> slow path and advancing the current
601 - 700 of 7046 matches
Mail list logo
