+++
> lib/ovs-rcu.c | 1 +
> 2 files changed, 12 insertions(+)
Thank you, Mike! This solves most issues I had when running OVS tests on Fedora
Rawhide with Clang 18 and "-fsanitize=undefined".
Acked-by: Jakob Meng
___
On 13.04.24 00:55, Ilya Maximets wrote:
> On 4/12/24 09:26, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> The 'dpif/show' command now supports machine-readable JSON output in
>> addition to the plain-text output for humans. An example would be:
>>
>&g
;>>>>
>>>>> On 19 Mar 2024, at 15:00, Ilya Maximets wrote:
>>>>>
>>>>>> On 3/19/24 14:41, Jakob Meng wrote:
>>>>>>>
>>>>>>> On 19.03.24 13:22, Ilya Maximets wrote:
>>>>>
On 19.03.24 13:22, Ilya Maximets wrote:
> On 3/19/24 13:21, Ilya Maximets wrote:
>> On 3/19/24 13:17, Eelco Chaudron wrote:
>>>
>>> On 19 Mar 2024, at 13:11, Jakob Meng wrote:
>>>
>>>> Hi!
>>>>
>>>> On 15.03.24 11:19, Eelc
Hi!
On 15.03.24 11:19, Eelco Chaudron wrote:
> On 18 Jan 2024, at 16:26, jm...@redhat.com wrote:
>
>> ...
> Thank for the patch! What a beast to go trough ;)
Thank you for doing it anyway ☺️
> I believe the current approach is acceptable. However, we could also
> incorporate union callbacks: if
On 15.03.24 11:16, Eelco Chaudron wrote:
> Hi Jakob,
>
> See some comments below.
>
> //Eelco
Thanks and comments below again
Cheers,
Jakob
>> ...
>> --- a/tests/appctl.py
>> +++ b/tests/appctl.py
>> @@ -49,13 +49,30 @@ def main():
>> help="Arguments to the
On 15.03.24 11:15, Eelco Chaudron wrote:
> [...]
> Hi Jakob,
>
>
> Thank you for submitting this series; I believe it's a valuable addition to
> OVS! Apologies for the delayed response. I've reviewed the entire series, and
> most of the comments are minor change requests. I'll hold off on
On 16.02.24 00:03, Ilya Maximets wrote:
> On 2/15/24 14:23, Simon Horman wrote:
>> On Thu, Feb 15, 2024 at 09:16:38AM +0100, Jakob Meng wrote:
>>> On 30.01.24 10:44, Simon Horman wrote:
>>>> On Fri, Jan 26, 2024 at 02:24:51PM +0100, jm...@redhat.com
On 30.01.24 10:44, Simon Horman wrote:
> On Fri, Jan 26, 2024 at 02:24:51PM +0100, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> In a scenario where OVN does load balancing and then SNAT with a OVS
>> userspace datapath [0], the recirc_depth may be greater t
On 29.01.24 23:33, Ilya Maximets wrote:
> Fedora 37 reached EOL in November. Switch to the most recent version
> to avoid potential CI failures in the future.
>
> Signed-off-by: Ilya Maximets
> ---
> .github/workflows/build-and-test.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
gt; but some older versions of Clang are not able to use stdatomic.h
> supplied by GCC as described in commit:
> 07ece367fb5f ("ovs-atomic: Prefer Clang intrinsics over .")
>
> This change fixes OVS build with GCC on Fedora Rawhide (40).
>
> Reported-by: Jakob Meng
> Signed
On 18.01.24 11:17, 0-day Robot wrote:
> Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> error: Failed to m
On 17.01.24 20:50, Simon Horman wrote:
> On Wed, Jan 17, 2024 at 06:56:31PM +, Simon Horman wrote:
>> On Wed, Jan 17, 2024 at 01:55:36PM +0100, jm...@redhat.com wrote:
>>> From: Jakob Meng
>>>
>>> Previous commits introduced support different output
On 03.01.24 00:57, Ilya Maximets wrote:
> On 11/16/23 11:41, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> A previous patch had changed the JSON-RPC API in lib/unixctl.* (and
>> its Python counterpart) in order to allow transporting the requested
>> output
list covers more terms, though the
Inclusive Naming Word Lists has better rationale. Most other sources simply
compile lists without giving any rationale.
[0] https://issues.redhat.com/browse/FDP-146
[1] https://github.com/IBM/IBMInclusiveITLanguage
[2] https://inclusivenaming.org/word-
Thank you again for all your input! Your comments have been incorporated into a
new patch series v4:
https://patchwork.ozlabs.org/project/openvswitch/list/?series=382459=both=*
On 25.10.23 11:37, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Add global option to output JSON from o
On 14.11.23 12:17, Kevin Traynor wrote:
> On 13/11/2023 08:53, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> This patch series incorporates Ilya's comments for v7 and has been rebased
>> to master:
>> * fixed afxdp status descriptions in vswitchd/vswitch.xml
On 03.11.23 22:44, Ilya Maximets wrote:
> On 10/30/23 10:49, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> For better usability, the function pairs get_config() and
>> set_config() for netdevs should be symmetric: Options which are
>> accepted by set_config()
On 31.10.23 16:22, Simon Horman wrote:
> On Mon, Oct 30, 2023 at 10:02:59AM +0100, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> The unixctl implementation in Python has been split into three parts in
>> the past. During this process the UnixctlClient was duplicate
Hi Ilya,
thanks for sharing your thoughts, always appreciated! ☺️ Please find comments
below.
On 28.10.23 00:05, Ilya Maximets wrote:
> On 10/27/23 23:51, Ilya Maximets wrote:
>> On 10/26/23 13:44, Jakob Meng wrote:
>>> On 25.10.23 11:37, jm...@redhat.com wrote:
>
On 30.10.23 14:07, Ilya Maximets wrote:
> On 10/30/23 10:54, Jakob Meng wrote:
>> On 27.10.23 17:25, Kevin Traynor wrote:
>>> On 27/10/2023 14:38, Ilya Maximets wrote:
>>>> On 10/26/23 11:29, Jakob Meng wrote:
>>>>> On 25.10.23 19:10, Ilya Maximets w
On 30.10.23 11:19, Eelco Chaudron wrote:
> On 30 Oct 2023, at 11:07, Jakob Meng wrote:
>
>> On 27.10.23 16:27, Eelco Chaudron wrote:
>>> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
>>>> From: Jakob Meng
>>>>
>>>> Add global option
On 27.10.23 15:52, Eelco Chaudron wrote:
> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> This patch introduces support for different output formats to the
>> Python code, as did the previous commit for ovs-xxx tools like
>> 'o
On 27.10.23 16:27, Eelco Chaudron wrote:
> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> Add global option to output JSON from ovs-appctl cmds.
>>
>> This patch is an update of [0] with the following major changes:
>> *
On 27.10.23 17:25, Kevin Traynor wrote:
> On 27/10/2023 14:38, Ilya Maximets wrote:
>> On 10/26/23 11:29, Jakob Meng wrote:
>>> On 25.10.23 19:10, Ilya Maximets wrote:
>>>> ...
>>>> Maybe something along these lines:
>>>>
>>>> -
On 28.10.23 00:08, Ilya Maximets wrote:
> On 10/26/23 14:10, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> The unixctl implementation in Python has been split into three parts in
>> the past. During this process the UnixctlClient was duplicated, in
>> python
in the commit message. I know
> that it is an editor config property, so not much to do about
> trim_trailing_whitespaces in the message.
>
> Additionally, for things like "contain trailing whitespaces" maybe we
> can use "contain trailing blank characters?"
>
&g
On 27.10.23 12:29, Eelco Chaudron wrote:
>
> On 26 Oct 2023, at 14:34, Jakob Meng wrote:
>
>> On 26.10.23 14:21, Robin Jarry wrote:
>>> Jakob Meng, Oct 26, 2023 at 14:17:
>>>> On 26.10.23 13:52, Robin Jarry wrote:
>>>>> , Oct 26, 2023 at 13:
On 26.10.23 14:21, Robin Jarry wrote:
> Jakob Meng, Oct 26, 2023 at 14:17:
>> On 26.10.23 13:52, Robin Jarry wrote:
>> > , Oct 26, 2023 at 13:07:
>> >> From: Jakob Meng
>> >>
>> >> Wildcard sections [*] and [**] are unsafe because pro
On 26.10.23 13:52, Robin Jarry wrote:
> , Oct 26, 2023 at 13:07:
>> From: Jakob Meng
>>
>> Wildcard sections [*] and [**] are unsafe because properties cannot be
>> applied safely to any filetype in general. For example, IDEs like
>> Visual Studio Code and K
On 25.10.23 11:37, jm...@redhat.com wrote:
> From: Jakob Meng
>
> For monitoring systems such as Prometheus it would be beneficial if
> OVS and OVS-DPDK would expose statistics in a machine-readable format.
>
> This patch introduces support for different output formats
On 25.10.23 20:50, Jakob Meng wrote:
> On 25.10.23 15:48, Mike Pattrick wrote:
>> On Wed, Oct 25, 2023 at 9:02 AM Robin Jarry wrote:
>>> Eelco Chaudron, Oct 25, 2023 at 14:56:
>>>> On 25 Oct 2023, at 13:52, jm...@redhat.com wrote:
>>>>
>>>>>
On 25.10.23 19:10, Ilya Maximets wrote:
> On 10/24/23 11:21, Kevin Traynor wrote:
>> Using correct email for Simon this time
>>
>> On 24/10/2023 10:19, Kevin Traynor wrote:
>>> On 23/10/2023 10:11, Jakob Meng wrote:
>>>> On 20.10.23 12:02, Kevin Tr
On 25.10.23 15:48, Mike Pattrick wrote:
> On Wed, Oct 25, 2023 at 9:02 AM Robin Jarry wrote:
>> Eelco Chaudron, Oct 25, 2023 at 14:56:
>>> On 25 Oct 2023, at 13:52, jm...@redhat.com wrote:
>>>
>>>> From: Jakob Meng
>>>>
>>>> A pa
On 25.10.23 13:52, jm...@redhat.com wrote:
> From: Jakob Meng
>
> A patch created with 'git format-patch' can contain trailing spaces.
> When editing a patch, e.g. to fix a typo in the title, the trailing
> spaces should not be removed. This becomes tricky when editors like
On 25.10.23 11:59, 0-day Robot wrote:
> Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> WARNING: L
On 20.10.23 13:48, Eelco Chaudron wrote:
>
> On 20 Oct 2023, at 12:43, jm...@redhat.com wrote:
>
>> From: Jakob Meng
>>
>> This patch follows an alternative approach to RFC [0].
>>
>> For monitoring systems such as Prometheus it would be beneficial if OVS
On 23.10.23 20:52, Jakob Meng wrote:
> On 23.10.23 15:31, Ilya Maximets wrote:
>> Since last month ReadTheDocs only supports building with a new
>> configuration file provided in the repository itself:
>> https://blog.readthedocs.com/migrate-configuration-v2/
>>
&
On 23.10.23 15:31, Ilya Maximets wrote:
> Since last month ReadTheDocs only supports building with a new
> configuration file provided in the repository itself:
> https://blog.readthedocs.com/migrate-configuration-v2/
>
> So, all our documentation buids are failing for quite some time.
>
> Add
On 20.10.23 12:02, Kevin Traynor wrote:
> On 13/10/2023 10:07, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> For better usability, the function pairs get_config() and
>> set_config() for netdevs should be symmetric: Options which are
>> accepted b
On 20.10.23 12:03, Kevin Traynor wrote:
> On 13/10/2023 10:07, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> For better usability, the function pairs get_config() and
>> set_config() for netdevs should be symmetric: Options which are
>> accepted b
Thanks for your feedback, Kevin! Added some notes inline.
On 20.10.23 12:03, Kevin Traynor wrote:
> On 13/10/2023 10:07, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> For better usability, the function pairs get_config() and
>> set_config() for netdevs should
Superseeded by:
https://patchwork.ozlabs.org/project/openvswitch/patch/20231020104320.1417664-2-jm...@redhat.com/
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Superseeded by:
https://patchwork.ozlabs.org/project/openvswitch/patch/20231020092205.710399-2-jm...@redhat.com/
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 12.10.23 17:39, Robin Jarry wrote:
> Kevin Traynor, Oct 12, 2023 at 17:34:
>> ok, 'rss' is documented as default, so maybe we don't need to display if it
>> is in use by default, selected by user or as fallback.
>>
>> That would make things a bit easier as 'rx-steering:' is free to use to
>>
r0 p0 -- set Interface p0
> type=patch options:peer=p1 \
> Size of vring n.
>
> +
> +Status of userspace-tso.
> +
>
>
LGTM
Acked-by: Jakob Meng
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt; +
> +Vhost numa association.
> +
> +
> +Vhost socket path.
> +
> +
> + Status of connection.
> +
> +
> +Size of vring n.
> +
> +
>
>
LGTM
Acked-by: Jakob Meng
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 11.10.23 18:48, Kevin Traynor wrote:
> On 11/10/2023 11:11, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> For better usability, the function pairs get_config() and
>> set_config() for each netdev should be symmetric: Options which are
>> accepted b
On 09.10.23 15:27, Ilya Maximets wrote:
> On 10/8/23 10:00, Jakob Meng wrote:
>>
>> On 06.10.23 20:00, Ilya Maximets wrote:
>>> On 10/6/23 09:49, Jakob Meng wrote:
>>>> On 05.10.23 21:08, Ilya Maximets wrote:
>>>>> On 10/4/23 14:21, jm...@redhat.
On 06.10.23 20:00, Ilya Maximets wrote:
> On 10/6/23 09:49, Jakob Meng wrote:
>> On 05.10.23 21:08, Ilya Maximets wrote:
>>> On 10/4/23 14:21, jm...@redhat.com wrote:
>>>> diff --git a/tests/pmd.at b/tests/pmd.at
>>>> index 7bdaca9e7..fb838286b 10064
On 06.10.23 11:29, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.")
> Signed-off-by: Jakob Meng
> ---
> vswitchd/vswitch.xml | 14 ++
> 1 file changed, 14 insertions(+)
>
>
On 06.10.23 11:29, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ")
> Signed-off-by: Jakob Meng
> ---
> vswitchd/vswitch.xml | 4
> 1 file changed, 4 insertions(+)
>
> diff --
On 06.10.23 11:17, Eelco Chaudron wrote:
>
> On 6 Oct 2023, at 11:10, Jakob Meng wrote:
>
> On 06.10.23 10:55, Eelco Chaudron wrote:
>> On 6 Oct 2023, at 9:21, Jakob Meng wrote:
>>
>>> On 05.10.23 17:53, Kevin Traynor wrote:
>>>>
On 06.10.23 10:55, Eelco Chaudron wrote:
> On 6 Oct 2023, at 9:21, Jakob Meng wrote:
>
>> On 05.10.23 17:53, Kevin Traynor wrote:
>>> On 05/10/2023 13:52, Eelco Chaudron wrote:
>>>> On 4 Oct 2023, at 10:31, jm...@redhat.com wrote:
>>>>
>>>&
On 05.10.23 21:08, Ilya Maximets wrote:
> On 10/4/23 14:21, jm...@redhat.com wrote:
>> diff --git a/tests/pmd.at b/tests/pmd.at
>> index 7bdaca9e7..fb838286b 100644
>> --- a/tests/pmd.at
>> +++ b/tests/pmd.at
>> @@ -93,11 +93,11 @@ pmd thread numa_id core_id :
>>overhead: NOT AVAIL
>> ])
>>
On 05.10.23 17:53, Kevin Traynor wrote:
> On 05/10/2023 13:52, Eelco Chaudron wrote:
>> On 4 Oct 2023, at 10:31, jm...@redhat.com wrote:
>>
>>> From: Jakob Meng
>>>
>>> The status options pci-vendor_id and pci-device_id for dpdk netdevs
>>>
On 05.10.23 09:42, Simon Horman wrote:
> On Wed, Oct 04, 2023 at 02:27:17PM +0200, Jakob Meng wrote:
>> On 04.10.23 12:18, Ilya Maximets wrote:
>>> On 10/2/23 16:44, David Marchand wrote:
>>>> On Mon, Oct 2, 2023 at 1:52 PM Simon Horman wrote:
>>>>>
On 04.10.23 12:18, Ilya Maximets wrote:
> On 10/2/23 16:44, David Marchand wrote:
>> On Mon, Oct 2, 2023 at 1:52 PM Simon Horman wrote:
>>> On Wed, Sep 27, 2023 at 03:24:07PM +0200, jm...@redhat.com wrote:
>>>> From: Jakob Meng
>>>>
>>>&g
On 04.10.23 10:32, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.")
> ---
> vswitchd/vswitch.xml | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/vswitchd/vswitch.
On 04.10.23 10:31, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The status options pci-vendor_id and pci-device_id for dpdk netdevs
> have been replaced by bus_info. This patch updates the documentation
> in vswitchd/vswitch.xml accordingly.
>
> Fixes: a77c7796f23a
On 04.10.23 10:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ")
> ---
> vswitchd/vswitch.xml | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/vswitchd/vswitch.xml b/vswi
On 29.09.23 17:05, Kevin Traynor wrote:
> On 28/09/2023 08:50, Simon Horman wrote:
>> On Wed, Sep 27, 2023 at 01:46:19PM +0200, jm...@redhat.com wrote:
>>> From: Jakob Meng
>>>
>>> The documentation in vswitchd/vswitch.xml for status columns has been
>
CI discovered some code locations I had missed previously, so I had to upload a
new patch v3:
https://patchwork.ozlabs.org/project/openvswitch/patch/20230927132406.2076833-1-jm...@redhat.com/
___
dev mailing list
d...@openvswitch.org
On 27.09.23 13:16, David Marchand wrote:
> On Wed, Sep 27, 2023 at 12:11 PM Jakob Meng wrote:
>> The documentation in vswitchd/vswitch.xml for status columns has been
>> updated accordingly. Status columns pci-vendor_id and pci-device_id
>> have been replaced with bus_
On 27.09.23 13:16, David Marchand wrote:
> On Wed, Sep 27, 2023 at 12:11 PM Jakob Meng wrote:
>> The documentation in vswitchd/vswitch.xml for status columns has been
>> updated accordingly. Status columns pci-vendor_id and pci-device_id
>> have been replaced with bus_
been replaced with bus_info in order to sync changes from [0].
[0]
https://github.com/openvswitch/ovs/commit/a77c7796f23a76190b61e2109a009df980253b0f
Reported-at: https://bugzilla.redhat.com/1949855
Signed-off-by: Jakob Meng
---
Documentation/intro/install/afxdp.rst | 12 ++---
Documentation
66 matches
Mail list logo
