Re: [ovs-dev] [PATCH v2 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-07-03 Thread Roi Dayan via dev
On 03/07/2024 13:16, Eelco Chaudron wrote: > > > On 3 Jul 2024, at 9:33, Roi Dayan wrote: > >> It is observed in some environments that there are much more ukeys than >> actual DP flows. For example: >> >> $ ovs-appctl upcall/show >> system@ovs-syste

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-07-03 Thread Roi Dayan via dev
On 03/07/2024 13:01, Eelco Chaudron wrote: > > > On 3 Jul 2024, at 9:31, Roi Dayan wrote: > >> On 18/06/2024 11:53, Eelco Chaudron wrote: >>> >>> >>> On 18 Jun 2024, at 8:05, Roi Dayan wrote: >>> >>>> On 03/06/2024 16:29, Ee

[ovs-dev] [PATCH v2 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-07-03 Thread Roi Dayan via dev
Signed-off-by: Roi Dayan --- ofproto/ofproto-dpif-upcall.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 83609ec62b63..08b3c70411aa 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-07-03 Thread Roi Dayan via dev
On 18/06/2024 11:53, Eelco Chaudron wrote: > > > On 18 Jun 2024, at 8:05, Roi Dayan wrote: > >> On 03/06/2024 16:29, Eelco Chaudron wrote: >>> >>> >>> On 3 Jun 2024, at 10:07, Roi Dayan wrote: >>> >>>> On 03/06/2024 10

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-06-18 Thread Roi Dayan via dev
On 03/06/2024 16:29, Eelco Chaudron wrote: > > > On 3 Jun 2024, at 10:07, Roi Dayan wrote: > >> On 03/06/2024 10:18, Roi Dayan wrote: >>> >>> >>> On 30/05/2024 18:48, Eelco Chaudron wrote: >>>> >>>> >>>> On

[ovs-dev] [PATCH] dpif-netdev: Disable XPS (Transmit Packet Steering) for non-pmd ports.

2024-06-09 Thread Roi Dayan via dev
TX queue ID 0 for port 'v1_r'. Fix it. Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) implementation.") Signed-off-by: Eli Britstein Acked-by: Roi Dayan --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c

Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype.

2024-06-06 Thread Roi Dayan via dev
11:56 To: Roi Dayan Cc: Ilya Maximets; d...@openvswitch.org; Maor Dickman Subject: Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype. On Thu, May 30, 2024 at 09:31:06AM +0300, Roi Dayan via dev wrote: > > > On 28/05/2024 20:12, Ilya Maximets wrote: &g

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-06-03 Thread Roi Dayan via dev
On 03/06/2024 10:18, Roi Dayan wrote: > > > On 30/05/2024 18:48, Eelco Chaudron wrote: >> >> >> On 23 May 2024, at 12:46, Roi Dayan via dev wrote: >> >>> It is observed in some environments that there are much more ukeys than >>> actual DP f

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-06-03 Thread Roi Dayan via dev
On 30/05/2024 18:48, Eelco Chaudron wrote: > > > On 23 May 2024, at 12:46, Roi Dayan via dev wrote: > >> It is observed in some environments that there are much more ukeys than >> actual DP flows. For example: >> >> $ ovs-appctl upcall/show >> system

Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype.

2024-05-30 Thread Roi Dayan via dev
On 28/05/2024 20:12, Ilya Maximets wrote: > On 5/26/24 10:31, Roi Dayan via dev wrote: >> From: Maor Dickman >> >> The cited commit reserved lower tc priorities for IP ethertypes in order >> to give IP traffic higher priority than other management traffic. >>

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-05-30 Thread Roi Dayan via dev
On 29/05/2024 17:35, Mike Pattrick wrote: > On Thu, May 23, 2024 at 6:47 AM Roi Dayan via dev > wrote: >> >> It is observed in some environments that there are much more ukeys than >> actual DP flows. For example: >> >> $ ovs-appctl upcall/show >> syst

[ovs-dev] [PATCH 1/1] debian: Fix tabs vs spaces.

2024-05-28 Thread Roi Dayan via dev
Getting the following message while trying to build a debian package. debian/openvswitch-switch.init debian/openvswitch-switch.postinst See above for files that use tabs for indentation. Please use spaces instead. Fix it. Signed-off-by: Roi Dayan --- debian/openvswitch-switch.init | 22

Re: [ovs-dev] [PATCH 1/2] netdev-linux: Fix using uninitialized current_speed.

2024-05-27 Thread Roi Dayan via dev
On 27/05/2024 15:44, Ilya Maximets wrote: > On 5/27/24 13:00, Roi Dayan via dev wrote: >> Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0 >> lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized >> in this function [-Werror=maybe-unini

[ovs-dev] [PATCH 1/2] netdev-linux: Fix using uninitialized current_speed.

2024-05-27 Thread Roi Dayan via dev
Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0 lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized in this function [-Werror=maybe-uninitialized] Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.") Signed-off-by: Roi Dayan ---

[ovs-dev] [PATCH 2/2] netdev-linux: Fix ethtool_cmd is partly outside array bounds.

2024-05-27 Thread Roi Dayan via dev
cmd; | ~~^ lib/netdev-linux.c:2411:7: note: while referencing ‘sset_info’ 2411 | } sset_info; | ^ Fixes: 6c59c195266c ("netdev-linux: Use ethtool to detect offload support.") Signed-off-by: Roi Dayan --- lib/netdev-linux.c | 1 + 1 file changed, 1 inser

[ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype.

2024-05-26 Thread Roi Dayan via dev
. Fixes: c230c7579c14 ("netdev-offload-tc: Reserve lower tc prios for ip ethertypes") Signed-off-by: Maor Dickman Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 2 ++ lib/tc.h| 1 + 2 files changed, 3 insertions(+) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-of

[ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-05-23 Thread Roi Dayan via dev
off-by: Han Zhou Signed-off-by: Roi Dayan --- ofproto/ofproto-dpif-upcall.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 83609ec62b63..e9520ebdf910 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofpr

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Drop invalid parsed packets

2024-05-06 Thread Roi Dayan via dev
On 06/05/2024 14:05, Ilya Maximets wrote: > On 5/5/24 08:42, Roi Dayan via dev wrote: >> From: Eli Britstein >> >> In case of a malformed packet, its parsing fails. Instead of continuing >> and possible form a wrong flow, drop the packet. > > Hi, Eli and Roi.

[ovs-dev] [PATCH 1/2] flow: Return value from miniflow_extract()

2024-05-05 Thread Roi Dayan via dev
From: Eli Britstein Parsing of the packet has some validity checks. Return it as a return value. Signed-off-by: Eli Britstein Acked-by: Roi Dayan --- lib/flow.c | 6 +- lib/flow.h | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index

[ovs-dev] [PATCH 2/2] dpif-netdev: Drop invalid parsed packets

2024-05-05 Thread Roi Dayan via dev
From: Eli Britstein In case of a malformed packet, its parsing fails. Instead of continuing and possible form a wrong flow, drop the packet. Relevant tests changed to send valid packets. Signed-off-by: Eli Britstein Acked-by: Roi Dayan --- lib/dpif-netdev.c| 7 ++- tests/mpls

[ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-17 Thread Roi Dayan via dev
When failing to get flow control parameters use VLOG_WARN_BUF() to expose the error string in ovs-vsctl show. Signed-off-by: Roi Dayan Suggested-by: Simon Horman Acked-by: Eli Britstein --- lib/netdev-dpdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-17 Thread Roi Dayan via dev
On 16/04/2024 18:48, Simon Horman wrote: > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: >> VLOG_WARN_BUF() is allocating memory for the error string and should >> e used if the configuration cannot continue and error is being returned >> so the

[ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-16 Thread Roi Dayan via dev
("netdev-dpdk: Add option to configure VF MAC address.") Signed-off-by: Roi Dayan Acked-by: Gaetan Rivet Acked-by: Eli Britstein --- lib/netdev-dpdk.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 21

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-01-09 Thread Roi Dayan via dev
s Mi wrote: >>>> >>>>> Add three sFlow offload test cases: >>>>> >>>>>3: offloads - sflow with sampling=1 - offloads enabled ok >>>>>4: offloads - sflow with sampling=2 - offloads enabled ok >>>>>5:

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2024-01-09 Thread Roi Dayan via dev
On 18/12/2023 9:45, Roi Dayan wrote: > > > On 14/12/2023 15:25, Aaron Conole wrote: >> Eelco Chaudron writes: >> >>> On 15 Nov 2023, at 3:33, Aaron Conole wrote: >>> >>>> Eelco Chaudron writes: >>>> >>>>> On

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-12-17 Thread Roi Dayan via dev
On 14/12/2023 15:25, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 15 Nov 2023, at 3:33, Aaron Conole wrote: >> >>> Eelco Chaudron writes: >>> >>>> On 14 Nov 2023, at 8:49, Roi Dayan wrote: >>>> >>>

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread Roi Dayan via dev
On 13/11/2023 19:08, Aaron Conole wrote: > Roi Dayan writes: > >> codespell dictionary contains a list of widely used words >> which enchant alone could fail on. for an example: >> refcount, pthread, enqueuing, etc. >> Load that dictionary, if exists, into encha

Re: [ovs-dev] [PATCH v2 0/1] improve checkpatch spell checker

2023-11-13 Thread Roi Dayan via dev
On 13/11/2023 12:52, Roi Dayan wrote: > Him > > The first patch is for using enchant add_to_session() to add > words to current session only. > The second patch is for improving the spell checker by adding > the codespell dictionary of words. > > v2 > - Load cod

[ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread Roi Dayan via dev
codespell dictionary contains a list of widely used words which enchant alone could fail on. for an example: refcount, pthread, enqueuing, etc. Load that dictionary, if exists, into enchant spell checker. Signed-off-by: Roi Dayan --- utilities/checkpatch.py | 19 +++ 1 file

[ovs-dev] [PATCH v3 1/2] checkpatch: Fix personal word list storage.

2023-11-13 Thread Roi Dayan via dev
From: Gaetan Rivet The enchant dictionary synchronizes additions to the source file. Keep the two word source separate by adding the extra words only to the current session. Signed-off-by: Gaetan Rivet Acked-by: Roi Dayan --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1

[ovs-dev] [PATCH v3 0/2] improve checkpatch spell checker

2023-11-13 Thread Roi Dayan via dev
session instead of adding the entire dictionary.txt into the repo. Gaetan Rivet (1): checkpatch: Fix personal word list storage. Roi Dayan (1): checkpatch.py: Load codespell dictionary. utilities/checkpatch.py | 21 - 1 file changed, 20 insertions(+), 1 deletion

[ovs-dev] [PATCH v2 1/1] checkpatch.py: Load codespell dictionary.

2023-11-13 Thread Roi Dayan via dev
codespell dictionary contains a list of widely used words which enchant alone could fail on. for an example: refcount, pthread, enqueuing, etc. Load that dictionary, if exists, into enchant spell checker. Signed-off-by: Roi Dayan --- utilities/checkpatch.py | 19 +++ 1 file

[ovs-dev] [PATCH v2 0/1] improve checkpatch spell checker

2023-11-13 Thread Roi Dayan via dev
dictionary.txt into the repo. Roi Dayan (1): checkpatch.py: Load codespell dictionary. utilities/checkpatch.py | 19 +++ 1 file changed, 19 insertions(+) -- 2.38.0 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org

Re: [ovs-dev] [PATCH 1/2] checkpatch.py: Load personal words list.

2023-11-13 Thread Roi Dayan via dev
On 13/11/2023 11:46, Eelco Chaudron wrote: > > > On 12 Nov 2023, at 8:22, Roi Dayan wrote: > >> On 10/11/2023 16:23, Aaron Conole wrote: >>> Roi Dayan writes: >>> >>>> On 08/11/2023 21:04, Aaron Conole wrote: >>>>> Roi Dayan vi

Re: [ovs-dev] [PATCH 1/2] checkpatch.py: Load personal words list.

2023-11-11 Thread Roi Dayan via dev
On 10/11/2023 16:23, Aaron Conole wrote: > Roi Dayan writes: > >> On 08/11/2023 21:04, Aaron Conole wrote: >>> Roi Dayan via dev writes: >>> >>>> On 02/11/2023 16:11, Eelco Chaudron wrote: >>>>> >>>>> On 2 Nov 2023,

Re: [ovs-dev] [PATCH 1/2] checkpatch.py: Load personal words list.

2023-11-09 Thread Roi Dayan via dev
On 08/11/2023 21:04, Aaron Conole wrote: > Roi Dayan via dev writes: > >> On 02/11/2023 16:11, Eelco Chaudron wrote: >>> >>> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote: >>> >>>> Add personal words list as spellcheck.txt and load it >

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-08 Thread Roi Dayan via dev
On 08/11/2023 20:50, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote: >> >>> From: Gaetan Rivet >>> >>> The enchant dictionary synchronizes additions to the source file. >>> Keep the t

[ovs-dev] [PATCH v2 1/2] checkpatch: Add argument to skip committer signoff check.

2023-11-05 Thread Roi Dayan via dev
From: Salem Sol Introduce --skip-committer-signoff arg that can be used internally by groups using gerrit for code reviews and gerrit maintainers could do the rebase instead of the author or push upstream commits to be merged through gerrit. Signed-off-by: Salem Sol Acked-by: Roi Dayan

[ovs-dev] [PATCH v2 2/2] checkpatch.at: Add cases to verify skip committer check.

2023-11-05 Thread Roi Dayan via dev
First case without the skip flag should fail. Second case uses the skip flag and should pass. Signed-off-by: Roi Dayan --- tests/checkpatch.at | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/tests/checkpatch.at b/tests/checkpatch.at index

[ovs-dev] [PATCH v2 0/2] Add argument to skip committer signoff check

2023-11-05 Thread Roi Dayan via dev
Hi, This v2 is just adding checkpatch.at case to verify the flag. Thanks, Roi Roi Dayan (1): checkpatch.at: Add cases to verify skip committer check. Salem Sol (1): checkpatch: Add argument to skip committer signoff check. tests/checkpatch.at | 26

Re: [ovs-dev] [PATCH 1/1] checkpatch: Add argument to skip committer signoff check.

2023-11-05 Thread Roi Dayan via dev
On 02/11/2023 15:22, Eelco Chaudron wrote: > > > On 2 Nov 2023, at 13:37, Roi Dayan via dev wrote: > >> From: Salem Sol >> >> Introduce --skip-committer-signoff arg that can be used internally >> by groups using gerrit for code reviews and gerrit mainta

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-05 Thread Roi Dayan via dev
On 02/11/2023 16:07, Eelco Chaudron wrote: > > > On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote: > >> From: Gaetan Rivet >> >> The enchant dictionary synchronizes additions to the source file. >> Keep the two word source separate by adding the extra

Re: [ovs-dev] [PATCH 1/2] checkpatch.py: Load personal words list.

2023-11-05 Thread Roi Dayan via dev
On 02/11/2023 16:11, Eelco Chaudron wrote: > > On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote: > >> Add personal words list as spellcheck.txt and load it >> into enchant spell checker. This file is generated from >> codespell dictionary.txt and contains words use

Re: [ovs-dev] [PATCH 1/1] checkpatch: Don't spell check Fixes tag

2023-11-05 Thread Roi Dayan via dev
On 02/11/2023 15:56, Eelco Chaudron wrote: > > > On 2 Nov 2023, at 13:59, Roi Dayan via dev wrote: > >> From: Eli Britstein >> >> Fixes tag quotes another commit that might fail in a spell check. Don't >> fail it. >> >> Sign

[ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-02 Thread Roi Dayan via dev
From: Gaetan Rivet The enchant dictionary synchronizes additions to the source file. Keep the two word source separate by adding the extra words only to the current session. Signed-off-by: Gaetan Rivet Acked-by: Roi Dayan --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH 1/1] checkpatch: Don't spell check Fixes tag

2023-11-02 Thread Roi Dayan via dev
On 02/11/2023 14:59, Roi Dayan wrote: > From: Eli Britstein > > Fixes tag quotes another commit that might fail in a spell check. Don't > fail it. > > Signed-off-by: Eli Britstein > Acked-by: Roi Dayan > --- > utilities/checkpatch.py | 3 +++ > 1 file chan

[ovs-dev] [PATCH 1/1] checkpatch: Don't spell check Fixes tag

2023-11-02 Thread Roi Dayan via dev
From: Eli Britstein Fixes tag quotes another commit that might fail in a spell check. Don't fail it. Signed-off-by: Eli Britstein Acked-by: Roi Dayan --- utilities/checkpatch.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index

[ovs-dev] [PATCH 1/1] checkpatch: Add argument to skip committer signoff check.

2023-11-02 Thread Roi Dayan via dev
From: Salem Sol Introduce --skip-committer-signoff arg that can be used internally by groups using gerrit for code reviews and gerrit maintainers could do the rebase instead of the author or push upstream commits to be merged through gerrit. Signed-off-by: Salem Sol Acked-by: Roi Dayan

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-17 Thread Roi Dayan via dev
On 16/10/2023 19:27, Mike Pattrick wrote: > On Mon, Oct 16, 2023 at 4:08 AM Roi Dayan via dev > wrote: >> >> >> On 16/10/2023 11:00, Roi Dayan wrote: >>> >>> On 16/10/2023 10:42, Eelco Chaudron wrote: >>>> >>>> >>>>

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 14:02, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 12:52, Roi Dayan wrote: > >> On 16/10/2023 11:31, Eelco Chaudron wrote: >>> >>> >>> On 16 Oct 2023, at 10:07, Roi Dayan wrote: >>> >>>> On 16/10/2023 11:00

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 11:31, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 10:07, Roi Dayan wrote: > >> On 16/10/2023 11:00, Roi Dayan wrote: >>> >>> On 16/10/2023 10:42, Eelco Chaudron wrote: >>>> >>>> >>>> On 16 Oct 2023, a

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 11:00, Roi Dayan wrote: > > On 16/10/2023 10:42, Eelco Chaudron wrote: >> >> >> On 16 Oct 2023, at 9:09, Roi Dayan wrote: >> >>> On 09/10/2023 15:05, Roi Dayan wrote: >>>> The cited commit fixed missing mirror packets by rese

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 10:42, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 9:09, Roi Dayan wrote: > >> On 09/10/2023 15:05, Roi Dayan wrote: >>> The cited commit fixed missing mirror packets by reset mirror when >>> packets are modified but setting geneve option

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 09/10/2023 15:05, Roi Dayan wrote: > The cited commit fixed missing mirror packets by reset mirror when > packets are modified but setting geneve options was also treated as > a modified packet but should be treated as a part of set_tunnel > which doesn't reset mirror

Re: [ovs-dev] [PATCH v3 2/3] tests/tunnel.at: Add geneve options mirror test.

2023-10-09 Thread Roi Dayan via dev
On 09/10/2023 15:05, Roi Dayan wrote: > Test geneve options mirror flow doesn't add redundant mirror. > > Signed-off-by: Roi Dayan > --- > > Notes: > v3: > - use AT_CHECK for configuring the mirror port. > > v2: > - add dot in

[ovs-dev] [PATCH v3 3/3] tests: Update some tests title prefix print.

2023-10-09 Thread Roi Dayan via dev
Use test title prefix according to filename the test is in for tunnel.at and ofproto-dpif.at. Signed-off-by: Roi Dayan Acked-by: Simon Horman Acked-by: Eelco Chaudron --- Notes: v2: - add prefix to bond cases. tests/ofproto-dpif.at | 10 +- tests/tunnel.at | 2 +- 2

[ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-09 Thread Roi Dayan via dev
ckets that are modified.") Signed-off-by: Roi Dayan Acked-by: Simon Horman Acked-by: Eelco Chaudron --- Notes: v2: - user correct sha in fixes line. ofproto/ofproto-dpif-xlate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/of

[ovs-dev] [PATCH v3 2/3] tests/tunnel.at: Add geneve options mirror test.

2023-10-09 Thread Roi Dayan via dev
Test geneve options mirror flow doesn't add redundant mirror. Signed-off-by: Roi Dayan --- Notes: v3: - use AT_CHECK for configuring the mirror port. v2: - add dot in title. tests/tunnel.at | 29 + 1 file changed, 29 insertions(+) diff --git

[ovs-dev] [PATCH v3 0/3] Fix redundant mirror with tunnel options.

2023-10-09 Thread Roi Dayan via dev
Hi, The first commit removing the redundant mirror when using tunnel options. The second is a test to verify it stays like this and doesn't break again. The third commit is just updating prefixes of tests to match the file their in. Thanks, Roi Roi Dayan (3): ofproto-dpif-upcall: Fix

Re: [ovs-dev] [PATCH v2 2/3] tests/tunnel.at: Add geneve options mirror test.

2023-10-09 Thread Roi Dayan via dev
On 09/10/2023 12:56, Eelco Chaudron wrote: > > > On 8 Oct 2023, at 9:08, Roi Dayan wrote: > >> On 05/10/2023 15:36, Eelco Chaudron wrote: >>> >>> >>> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote: >>> >>>> Test geneve opti

Re: [ovs-dev] [PATCH v2 2/3] tests/tunnel.at: Add geneve options mirror test.

2023-10-08 Thread Roi Dayan via dev
On 05/10/2023 15:36, Eelco Chaudron wrote: > > > On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote: > >> Test geneve options mirror flow doesn't add redundant mirror. >> >> Signed-off-by: Roi Dayan > > In general this patch looks good, some small nit below

[ovs-dev] [PATCH v2 3/3] tests: Update some tests title prefix print.

2023-10-04 Thread Roi Dayan via dev
Use test title prefix according to filename the test is in for tunnel.at and ofproto-dpif.at. Signed-off-by: Roi Dayan --- Notes: v2: - add prefix to bond cases. tests/ofproto-dpif.at | 10 +- tests/tunnel.at | 2 +- 2 files changed, 6 insertions(+), 6 deletions

[ovs-dev] [PATCH v2 2/3] tests/tunnel.at: Add geneve options mirror test.

2023-10-04 Thread Roi Dayan via dev
Test geneve options mirror flow doesn't add redundant mirror. Signed-off-by: Roi Dayan --- Notes: v2: - add dot in title. tests/tunnel.at | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/tunnel.at b/tests/tunnel.at index ddeb66bc9fb7

[ovs-dev] [PATCH v2 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-04 Thread Roi Dayan via dev
ckets that are modified.") Signed-off-by: Roi Dayan Acked-by: Simon Horman --- Notes: v2: - user correct sha in fixes line. ofproto/ofproto-dpif-xlate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index be

[ovs-dev] [PATCH v2 0/3] Fix redundant mirror with tunnel options.

2023-10-04 Thread Roi Dayan via dev
Hi, The first commit removing the redundant mirror when using tunnel options. The second is a test to verify it stays like this and doesn't break again. The third commit is just updating prefixes of tests to match the file their in. Thanks, Roi Roi Dayan (3): ofproto-dpif-upcall: Fix

Re: [ovs-dev] [PATCH 1/1] tests: Update some tests title prefix print.

2023-10-04 Thread Roi Dayan via dev
On 04/10/2023 12:46, Simon Horman wrote: > On Tue, Oct 03, 2023 at 05:03:20PM +0300, Roi Dayan via dev wrote: >> Use test title prefix according to filename the test is in >> for tunnel.at and ofproto-dpif.at. >> >> Signed-off-by: Roi Dayan >> --- >> tes

[ovs-dev] [PATCH 1/1] tests: Update some tests title prefix print.

2023-10-03 Thread Roi Dayan via dev
Use test title prefix according to filename the test is in for tunnel.at and ofproto-dpif.at. Signed-off-by: Roi Dayan --- tests/ofproto-dpif.at | 6 +++--- tests/tunnel.at | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at

Re: [ovs-dev] [PATCH 1/1] tests/tunnel.at: Add geneve options mirror test

2023-10-03 Thread Roi Dayan via dev
On 03/10/2023 16:54, Roi Dayan wrote: > Test geneve options mirror flow doesn't add redundant mirror. > > Signed-off-by: Roi Dayan > --- > tests/tunnel.at | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/tests/tunnel.at b

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Roi Dayan via dev
On 03/10/2023 15:22, Ilya Maximets wrote: > On 10/3/23 10:33, Roi Dayan wrote: >> The cited commit fixed missing mirror packets by reset mirror when >> packets are modified but setting geneve options was also treated as >> a modified packet but should be treated as a part o

[ovs-dev] [PATCH 1/1] tests/tunnel.at: Add geneve options mirror test

2023-10-03 Thread Roi Dayan via dev
Test geneve options mirror flow doesn't add redundant mirror. Signed-off-by: Roi Dayan --- tests/tunnel.at | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/tunnel.at b/tests/tunnel.at index ddeb66bc9fb7..c0b932110446 100644 --- a/tests/tunnel.at +++ b

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Roi Dayan via dev
On 03/10/2023 13:36, Simon Horman wrote: > On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: >> The cited commit fixed missing mirror packets by reset mirror when >> packets are modified but setting geneve options was also treated as >> a modified packet

[ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Roi Dayan via dev
ckets that are modified.") Signed-off-by: Roi Dayan --- ofproto/ofproto-dpif-xlate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index be4bd6657688..e243773307b7 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/of

Re: [ovs-dev] [PATCH v2] checkpatch: Increase recommended line length to 100

2023-09-27 Thread Roi Dayan via dev
On 27/09/2023 16:36, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 27 Sep 2023, at 15:05, Ilya Maximets wrote: >> >>> On 9/27/23 14:34, Roi Dayan wrote: >>>> >>>> On 18/06/2020 21:17, Roi Dayan wrote: >>>>> This is to

Re: [ovs-dev] [PATCH v2] checkpatch: Increase recommended line length to 100

2023-09-27 Thread Roi Dayan via dev
On 18/06/2020 21:17, Roi Dayan wrote: > This is to match a recent kernel checkpatch change that > also increased it to 100 line length. > > Signed-off-by: Roi Dayan > Reviewed-by: Simon Horman > Acked-by: Aaron Conole > --- > > Notes: > v2 > - updat

Re: [ovs-dev] discussing memory leak in netdev_tc_init_flow_api() and ovs-system behavior

2023-08-10 Thread Roi Dayan via dev
On 10/08/2023 15:26, Ilya Maximets wrote: > On 8/10/23 09:59, Roi Dayan wrote: >> Hi, >> >> We noticed a possible memory leak in netdev_tc_init_flow_api() >> as we allocate memory for meter_police_ids with id_pool_create() >> but we never destroy it. &g

[ovs-dev] discussing memory leak in netdev_tc_init_flow_api() and ovs-system behavior

2023-08-10 Thread Roi Dayan via dev
Hi, We noticed a possible memory leak in netdev_tc_init_flow_api() as we allocate memory for meter_police_ids with id_pool_create() but we never destroy it. I added a code to refcount netdev_tc_init_flow_api and so in netdev_tc_uninit_flow_api() to destroy it and noticed some behavior about

Re: [ovs-dev] [PATCH v6 9/9] system-offloads-traffic.at: Add vxlan gbp offload test

2023-07-04 Thread Roi Dayan via dev
On 29/06/2023 11:50, Eelco Chaudron wrote: > > > On 27 Jun 2023, at 12:48, Roi Dayan wrote: > >> From: Gavin Li >> >> Add a vxlan gbp offload test case: >> >> vxlan offloads with gbp extention - ping between two ports - offloads >> enabl

Re: [ovs-dev] [PATCH v6 7/9] tc: Add vxlan encap action with gbp option offload

2023-07-04 Thread Roi Dayan via dev
On 29/06/2023 11:50, Eelco Chaudron wrote: > > > On 27 Jun 2023, at 12:48, Roi Dayan wrote: > >> From: Gavin Li >> >> Add TC offload support for vxlan encap with gbp option >> >> Signed-off-by: Gavin Li >> Reviewed-by: Gavi Teitz >>

Re: [ovs-dev] [PATCH v5 9/9] system-offloads-traffic.at: Add vxlan gbp offload test

2023-06-27 Thread Roi Dayan via dev
:57, Simon Horman wrote: >>> >>>> On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote: >>>>> >>>>> On 19 Jun 2023, at 13:56, Roi Dayan wrote: >>>>> >>>>>> From: Gavin Li >>>>>&

[ovs-dev] [PATCH v6 9/9] system-offloads-traffic.at: Add vxlan gbp offload test

2023-06-27 Thread Roi Dayan via dev
From: Gavin Li Add a vxlan gbp offload test case: vxlan offloads with gbp extention - ping between two ports - offloads enabled ok Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- tests/system-offloads-traffic.at | 50 1 file

[ovs-dev] [PATCH v6 8/9] netdev-tc-offloads: Probe for allowing vxlan gbp support

2023-06-27 Thread Roi Dayan via dev
gbp action/match if kernel does not support it. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- lib/netdev-offload-tc.c | 64 +++-- 1 file changed, 61 insertions(+), 3 deletions(-) diff --git a/lib

[ovs-dev] [PATCH v6 7/9] tc: Add vxlan encap action with gbp option offload

2023-06-27 Thread Roi Dayan via dev
From: Gavin Li Add TC offload support for vxlan encap with gbp option Signed-off-by: Gavin Li Reviewed-by: Gavi Teitz Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- acinclude.m4 | 7 include/linux/tc_act/tc_tunnel_key.h | 17

[ovs-dev] [PATCH v6 6/9] tc: Pass encap entirely to nl_msg_put_act_tunnel_key_set

2023-06-27 Thread Roi Dayan via dev
-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- lib/tc.c | 57 +++- lib/tc.h | 38 +++-- 2 files changed, 43 insertions(+), 52 deletions(-) diff --git a/lib/tc.c b/lib/tc.c index

[ovs-dev] [PATCH v6 5/9] tc: Add vxlan gbp option flower match offload

2023-06-27 Thread Roi Dayan via dev
From: Gavin Li Add TC offload support for filtering vxlan tunnels with gbp option Signed-off-by: Gavin Li Reviewed-by: Gavi Teitz Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- include/linux/pkt_cls.h | 13 ++ lib/netdev-offload-tc.c | 17 lib

[ovs-dev] [PATCH v6 2/9] odp-util: Extract vxlan gbp option decoding to a function

2023-06-27 Thread Roi Dayan via dev
From: Gavin Li Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in following commits. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- lib/odp-util.c | 9 +++-- lib/odp-util.h | 8 2 files changed, 11

[ovs-dev] [PATCH v6 4/9] netlink: Add new function to add NLA_F_NESTED to nested netlink messages

2023-06-27 Thread Roi Dayan via dev
nested netlink messages with a new function nl_msg_start_nested_with_flag(). Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- lib/netlink.c | 9 + lib/netlink.h | 1 + 2 files changed, 10 insertions(+) diff --git a/lib/netlink.c b

[ovs-dev] [PATCH v6 1/9] tc: Pass tunnel entirely to tunnel option parse and put functions

2023-06-27 Thread Roi Dayan via dev
tunnel entirely to it instead of keep adding new arguments. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- lib/tc.c | 15 --- lib/tc.h | 34 ++ 2 files changed, 26 insertions(+), 23 deletions

[ovs-dev] [PATCH v6 3/9] odp-util: Extract vxlan gbp option encoding to a function

2023-06-27 Thread Roi Dayan via dev
From: Gavin Li Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in following commits. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Eelco Chaudron --- lib/odp-util.c | 5 +++-- lib/odp-util.h | 5 + 2 files changed, 8 insertions

[ovs-dev] [PATCH v6 0/9] Add vxlan gbp offload with TC

2023-06-27 Thread Roi Dayan via dev
Hi, This series adds TC offload support for filtering vxlan tunnels with gbp option. First 4 patches do some refactoring and the later patches adds the feature. Thanks, Roi changelog v6: - fix nits in patch #7. - fix test in patch #9 to run test on supported kernel. v5: - Fix byte order issue

[ovs-dev] [PATCH v5 9/9] system-offloads-traffic.at: Add vxlan gbp offload test

2023-06-19 Thread Roi Dayan via dev
From: Gavin Li Add a vxlan gbp offload test case: vxlan offloads with gbp extention - ping between two ports - offloads enabled ok Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- tests/system-offloads-traffic.at | 49 1 file

[ovs-dev] [PATCH v5 8/9] netdev-tc-offloads: Probe for allowing vxlan gbp support

2023-06-19 Thread Roi Dayan via dev
gbp action/match if kernel does not support it. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-offload-tc.c | 64 +++-- 1 file changed, 61 insertions(+), 3 deletions(-) diff --git a/lib/netdev-offload-tc.c b/lib

[ovs-dev] [PATCH v5 6/9] tc: Pass encap entirely to nl_msg_put_act_tunnel_key_set

2023-06-19 Thread Roi Dayan via dev
-by: Roi Dayan Reviewed-by: Simon Horman --- lib/tc.c | 57 +++- lib/tc.h | 38 +++-- 2 files changed, 43 insertions(+), 52 deletions(-) diff --git a/lib/tc.c b/lib/tc.c index ae1ca57c9d2a..7434b0150f74 100644

[ovs-dev] [PATCH v5 7/9] tc: Add vxlan encap action with gbp option offload

2023-06-19 Thread Roi Dayan via dev
From: Gavin Li Add TC offload support for vxlan encap with gbp option Signed-off-by: Gavin Li Reviewed-by: Gavi Teitz Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- acinclude.m4 | 7 include/linux/tc_act/tc_tunnel_key.h | 17 +++- lib/netdev-offload

[ovs-dev] [PATCH v5 2/9] odp-util: Extract vxlan gbp option decoding to a function

2023-06-19 Thread Roi Dayan via dev
From: Gavin Li Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in following commits. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/odp-util.c | 9 +++-- lib/odp-util.h | 8 2 files changed, 11 insertions(+), 6 deletions

[ovs-dev] [PATCH v5 5/9] tc: Add vxlan gbp option flower match offload

2023-06-19 Thread Roi Dayan via dev
From: Gavin Li Add TC offload support for filtering vxlan tunnels with gbp option Signed-off-by: Gavin Li Reviewed-by: Gavi Teitz Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- include/linux/pkt_cls.h | 13 ++ lib/netdev-offload-tc.c | 17 lib/tc.c| 92

[ovs-dev] [PATCH v5 4/9] netlink: Add new function to add NLA_F_NESTED to nested netlink messages

2023-06-19 Thread Roi Dayan via dev
nested netlink messages with a new function nl_msg_start_nested_with_flag(). Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netlink.c | 9 + lib/netlink.h | 1 + 2 files changed, 10 insertions(+) diff --git a/lib/netlink.c b/lib/netlink.c index

[ovs-dev] [PATCH v5 1/9] tc: Pass tunnel entirely to tunnel option parse and put functions

2023-06-19 Thread Roi Dayan via dev
tunnel entirely to it instead of keep adding new arguments. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/tc.c | 15 --- lib/tc.h | 34 ++ 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/lib/tc.c b/lib

[ovs-dev] [PATCH v5 3/9] odp-util: Extract vxlan gbp option encoding to a function

2023-06-19 Thread Roi Dayan via dev
From: Gavin Li Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in following commits. Signed-off-by: Gavin Li Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/odp-util.c | 5 +++-- lib/odp-util.h | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff

[ovs-dev] [PATCH v5 0/9] Add vxlan gbp offload with TC

2023-06-19 Thread Roi Dayan via dev
Hi, This series adds TC offload support for filtering vxlan tunnels with gbp option. First 4 patches do some refactoring and the later patches adds the feature. Thanks, Roi changelog v5: - Fix byte order issue in probe. v4: - probe TC kernel for vxlan gbp support. - add test. - style fix in

[ovs-dev] [PATCH v4 9/9] system-offloads-traffic.at: Add vxlan gbp offload test

2023-06-14 Thread Roi Dayan via dev
From: Gavin Li Add a vxlan gbp offload test case: vxlan offloads with gbp extention - ping between two ports - offloads enabled ok Signed-off-by: Gavin Li --- tests/system-offloads-traffic.at | 49 1 file changed, 49 insertions(+) diff --git

  1   2   3   4   5   6   7   8   9   10   >