On 10/07/2024 18:35, Eelco Chaudron wrote:
>
>
> On 9 Jul 2024, at 23:38, Ilya Maximets wrote:
>
>> On 7/3/24 12:28, Roi Dayan via dev wrote:
>>>
>>>
>>> On 03/07/2024 13:16, Eelco Chaudron wrote:
>>>>
>>>>
>>&g
4 13:01, Eelco Chaudron wrote:
>
>
> On 3 Jul 2024, at 9:31, Roi Dayan wrote:
>
> On 18/06/2024 11:53, Eelco Chaudron wrote:
>
>
> On 18 Jun 2024, at 8:05, Roi Dayan wrote:
>
> On 03/06/2024 16:29, Eelco Chaudron wrote:
>
>
> On 3 Jun 2024, at 10:07, Roi Day
On 03/07/2024 13:16, Eelco Chaudron wrote:
>
>
> On 3 Jul 2024, at 9:33, Roi Dayan wrote:
>
>> It is observed in some environments that there are much more ukeys than
>> actual DP flows. For example:
>>
>> $ ovs-appctl upcall/show
>> system@ovs-system:
>> flows : (current 7) (avg 6) (max 117)
lco Chaudron wrote:
>>>>>
>>>>>
>>>>> On 3 Jun 2024, at 10:07, Roi Dayan wrote:
>>>>>
>>>>>> On 03/06/2024 10:18, Roi Dayan wrote:
>>>>>>>
>>>>>>>
>>>>>>>
It is observed in some environments that there are much more ukeys than
actual DP flows. For example:
$ ovs-appctl upcall/show
system@ovs-system:
flows : (current 7) (avg 6) (max 117) (limit 2125)
offloaded flows : 525
dump duration : 1063ms
ufid enabled : true
23: (keys 3612)
24: (keys 3625)
:18, Roi Dayan wrote:
>>>>>
>>>>>
>>>>> On 30/05/2024 18:48, Eelco Chaudron wrote:
>>>>>>
>>>>>>
>>>>>> On 23 May 2024, at 12:46, Roi Dayan via dev wrote:
>>>>>>
>>>>>>>
On 03/06/2024 16:29, Eelco Chaudron wrote:
>
>
> On 3 Jun 2024, at 10:07, Roi Dayan wrote:
>
>> On 03/06/2024 10:18, Roi Dayan wrote:
>>>
>>>
>>> On 30/05/2024 18:48, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On
From: Eli Britstein
In the cited commit, XPS was introduced. It is NA for non-pmd ports.
Upon port creation it is indeed disabled, but at port reconfigure, the
condition of netdev_is_pmd() is missing.
As a result, XPS is configured, and such messages are repeating in the log:
DBG|Core 2: New
11:56
To: Roi Dayan
Cc: Ilya Maximets; d...@openvswitch.org; Maor Dickman
Subject: Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for
vlan ethertype.
On Thu, May 30, 2024 at 09:31:06AM +0300, Roi Dayan via dev wrote:
>
>
> On 28/05/2024 20:12, Ilya Maximets wrote:
&g
On 03/06/2024 10:18, Roi Dayan wrote:
>
>
> On 30/05/2024 18:48, Eelco Chaudron wrote:
>>
>>
>> On 23 May 2024, at 12:46, Roi Dayan via dev wrote:
>>
>>> It is observed in some environments that there are much more ukeys than
>>> actual DP f
On 30/05/2024 18:48, Eelco Chaudron wrote:
>
>
> On 23 May 2024, at 12:46, Roi Dayan via dev wrote:
>
>> It is observed in some environments that there are much more ukeys than
>> actual DP flows. For example:
>>
>> $ ovs-appctl upcall/show
>> system
On 28/05/2024 20:12, Ilya Maximets wrote:
> On 5/26/24 10:31, Roi Dayan via dev wrote:
>> From: Maor Dickman
>>
>> The cited commit reserved lower tc priorities for IP ethertypes in order
>> to give IP traffic higher priority than other management traffic.
>>
On 29/05/2024 17:35, Mike Pattrick wrote:
> On Thu, May 23, 2024 at 6:47 AM Roi Dayan via dev
> wrote:
>>
>> It is observed in some environments that there are much more ukeys than
>> actual DP flows. For example:
>>
>> $ ovs-appctl upcall/show
>> syst
Getting the following message while trying to build a debian package.
debian/openvswitch-switch.init
debian/openvswitch-switch.postinst
See above for files that use tabs for indentation.
Please use spaces instead.
Fix it.
Signed-off-by: Roi Dayan
---
debian/openvswitch-switch.init | 22
On 27/05/2024 15:44, Ilya Maximets wrote:
> On 5/27/24 13:00, Roi Dayan via dev wrote:
>> Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
>> lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized
>> in this function [-Werror=maybe-unini
Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
Signed-off-by: Roi Dayan
---
Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
lib/netdev-linux.c: In function ‘netdev_linux_construct’:
lib/netdev-linux.c:7003:15: error: array subscript ‘struct ethtool_cmd[0]’ is
partly outside array bounds of ‘union [1]’ [-Werror=array-bounds]
7003 | ecmd->cmd = cmd;
|
From: Maor Dickman
The cited commit reserved lower tc priorities for IP ethertypes in order
to give IP traffic higher priority than other management traffic.
In case of of vlan encap traffic, IP traffic will still get lower
priority.
Fix it by also reserving low priority tc prio for vlan.
It is observed in some environments that there are much more ukeys than
actual DP flows. For example:
$ ovs-appctl upcall/show
system@ovs-system:
flows : (current 7) (avg 6) (max 117) (limit 2125)
offloaded flows : 525
dump duration : 1063ms
ufid enabled : true
23: (keys 3612)
24: (keys 3625)
On 06/05/2024 14:05, Ilya Maximets wrote:
> On 5/5/24 08:42, Roi Dayan via dev wrote:
>> From: Eli Britstein
>>
>> In case of a malformed packet, its parsing fails. Instead of continuing
>> and possible form a wrong flow, drop the packet.
>
> Hi, Eli and Roi.
From: Eli Britstein
Parsing of the packet has some validity checks. Return it as a return
value.
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
---
lib/flow.c | 6 +-
lib/flow.h | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index
From: Eli Britstein
In case of a malformed packet, its parsing fails. Instead of continuing
and possible form a wrong flow, drop the packet.
Relevant tests changed to send valid packets.
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
---
lib/dpif-netdev.c| 7 ++-
When failing to get flow control parameters use VLOG_WARN_BUF()
to expose the error string in ovs-vsctl show.
Signed-off-by: Roi Dayan
Suggested-by: Simon Horman
Acked-by: Eli Britstein
---
lib/netdev-dpdk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On 16/04/2024 18:48, Simon Horman wrote:
> On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote:
>> VLOG_WARN_BUF() is allocating memory for the error string and should
>> e used if the configuration cannot continue and error is being returned
>> so the
VLOG_WARN_BUF() is allocating memory for the error string and should
e used if the configuration cannot continue and error is being returned
so the caller has indication of releasing the pointer.
Change to VLOG_WARN() to keep the logic that error is not being
returned.
Fixes: f4336f504b17
On 02/11/2023 15:24, Eelco Chaudron wrote:
>
>
> On 3 Oct 2023, at 17:03, Eelco Chaudron wrote:
>
>> On 19 Jun 2023, at 12:18, Chris Mi wrote:
>>
>>> On 6/19/2023 6:04 PM, Eelco Chaudron wrote:
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> Add three sFlow offload test cases:
On 18/12/2023 9:45, Roi Dayan wrote:
>
>
> On 14/12/2023 15:25, Aaron Conole wrote:
>> Eelco Chaudron writes:
>>
>>> On 15 Nov 2023, at 3:33, Aaron Conole wrote:
>>>
Eelco Chaudron writes:
> On 14 Nov 2023, at 8:49, Roi Dayan wrote:
>
>> On 13/11/2023 19:08, Aaron
On 14/12/2023 15:25, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 15 Nov 2023, at 3:33, Aaron Conole wrote:
>>
>>> Eelco Chaudron writes:
>>>
On 14 Nov 2023, at 8:49, Roi Dayan wrote:
> On 13/11/2023 19:08, Aaron Conole wrote:
>> Roi Dayan writes:
>>
>>>
On 13/11/2023 19:08, Aaron Conole wrote:
> Roi Dayan writes:
>
>> codespell dictionary contains a list of widely used words
>> which enchant alone could fail on. for an example:
>> refcount, pthread, enqueuing, etc.
>> Load that dictionary, if exists, into enchant spell checker.
>>
>>
On 13/11/2023 12:52, Roi Dayan wrote:
> Him
>
> The first patch is for using enchant add_to_session() to add
> words to current session only.
> The second patch is for improving the spell checker by adding
> the codespell dictionary of words.
>
> v2
> - Load codespell dictionary if exists
codespell dictionary contains a list of widely used words
which enchant alone could fail on. for an example:
refcount, pthread, enqueuing, etc.
Load that dictionary, if exists, into enchant spell checker.
Signed-off-by: Roi Dayan
---
utilities/checkpatch.py | 19 +++
1 file
From: Gaetan Rivet
The enchant dictionary synchronizes additions to the source file.
Keep the two word source separate by adding the extra words only
to the current session.
Signed-off-by: Gaetan Rivet
Acked-by: Roi Dayan
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1
Hi,
The first patch is for using enchant add_to_session() to add
words to current session only.
The second patch is for improving the spell checker by adding
the codespell dictionary of words.
v3
- sent in v2 only one patch by mistake.
v2
- Load codespell dictionary if exists into enchant
codespell dictionary contains a list of widely used words
which enchant alone could fail on. for an example:
refcount, pthread, enqueuing, etc.
Load that dictionary, if exists, into enchant spell checker.
Signed-off-by: Roi Dayan
---
utilities/checkpatch.py | 19 +++
1 file
Him
The first patch is for using enchant add_to_session() to add
words to current session only.
The second patch is for improving the spell checker by adding
the codespell dictionary of words.
v2
- Load codespell dictionary if exists into enchant session
instead of adding the entire
On 13/11/2023 11:46, Eelco Chaudron wrote:
>
>
> On 12 Nov 2023, at 8:22, Roi Dayan wrote:
>
>> On 10/11/2023 16:23, Aaron Conole wrote:
>>> Roi Dayan writes:
>>>
>>>> On 08/11/2023 21:04, Aaron Conole wrote:
>>>>> Roi Dayan vi
On 10/11/2023 16:23, Aaron Conole wrote:
> Roi Dayan writes:
>
>> On 08/11/2023 21:04, Aaron Conole wrote:
>>> Roi Dayan via dev writes:
>>>
>>>> On 02/11/2023 16:11, Eelco Chaudron wrote:
>>>>>
>>>>> On 2 Nov 2023,
On 08/11/2023 21:04, Aaron Conole wrote:
> Roi Dayan via dev writes:
>
>> On 02/11/2023 16:11, Eelco Chaudron wrote:
>>>
>>> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>>>
>>>> Add personal words list as spellcheck.txt and load it
>
On 08/11/2023 20:50, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>>
>>> From: Gaetan Rivet
>>>
>>> The enchant dictionary synchronizes additions to the source file.
>>> Keep the t
From: Salem Sol
Introduce --skip-committer-signoff arg that can be used internally
by groups using gerrit for code reviews and gerrit maintainers could
do the rebase instead of the author or push upstream commits to be
merged through gerrit.
Signed-off-by: Salem Sol
Acked-by: Roi Dayan
---
First case without the skip flag should fail.
Second case uses the skip flag and should pass.
Signed-off-by: Roi Dayan
---
tests/checkpatch.at | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/tests/checkpatch.at b/tests/checkpatch.at
index
Hi,
This v2 is just adding checkpatch.at case to verify the flag.
Thanks,
Roi
Roi Dayan (1):
checkpatch.at: Add cases to verify skip committer check.
Salem Sol (1):
checkpatch: Add argument to skip committer signoff check.
tests/checkpatch.at | 26 +++---
On 02/11/2023 15:22, Eelco Chaudron wrote:
>
>
> On 2 Nov 2023, at 13:37, Roi Dayan via dev wrote:
>
>> From: Salem Sol
>>
>> Introduce --skip-committer-signoff arg that can be used internally
>> by groups using gerrit for code reviews and gerrit mainta
On 02/11/2023 16:07, Eelco Chaudron wrote:
>
>
> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>
>> From: Gaetan Rivet
>>
>> The enchant dictionary synchronizes additions to the source file.
>> Keep the two word source separate by adding the extra
On 02/11/2023 16:11, Eelco Chaudron wrote:
>
> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>
>> Add personal words list as spellcheck.txt and load it
>> into enchant spell checker. This file is generated from
>> codespell dictionary.txt and contains words use
On 02/11/2023 15:56, Eelco Chaudron wrote:
>
>
> On 2 Nov 2023, at 13:59, Roi Dayan via dev wrote:
>
>> From: Eli Britstein
>>
>> Fixes tag quotes another commit that might fail in a spell check. Don't
>> fail it.
>>
>> Sign
From: Gaetan Rivet
The enchant dictionary synchronizes additions to the source file.
Keep the two word source separate by adding the extra words only
to the current session.
Signed-off-by: Gaetan Rivet
Acked-by: Roi Dayan
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1
On 02/11/2023 14:59, Roi Dayan wrote:
> From: Eli Britstein
>
> Fixes tag quotes another commit that might fail in a spell check. Don't
> fail it.
>
> Signed-off-by: Eli Britstein
> Acked-by: Roi Dayan
> ---
> utilities/checkpatch.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff
From: Eli Britstein
Fixes tag quotes another commit that might fail in a spell check. Don't
fail it.
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
---
utilities/checkpatch.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index
From: Salem Sol
Introduce --skip-committer-signoff arg that can be used internally
by groups using gerrit for code reviews and gerrit maintainers could
do the rebase instead of the author or push upstream commits to be
merged through gerrit.
Signed-off-by: Salem Sol
Acked-by: Roi Dayan
---
On 16/10/2023 19:27, Mike Pattrick wrote:
> On Mon, Oct 16, 2023 at 4:08 AM Roi Dayan via dev
> wrote:
>>
>>
>> On 16/10/2023 11:00, Roi Dayan wrote:
>>>
>>> On 16/10/2023 10:42, Eelco Chaudron wrote:
>>>>
>>>>
>>>>
On 16/10/2023 14:02, Eelco Chaudron wrote:
>
>
> On 16 Oct 2023, at 12:52, Roi Dayan wrote:
>
>> On 16/10/2023 11:31, Eelco Chaudron wrote:
>>>
>>>
>>> On 16 Oct 2023, at 10:07, Roi Dayan wrote:
>>>
On 16/10/2023 11:00, Roi Dayan wrote:
>
> On 16/10/2023 10:42, Eelco Chaudron
On 16/10/2023 11:31, Eelco Chaudron wrote:
>
>
> On 16 Oct 2023, at 10:07, Roi Dayan wrote:
>
>> On 16/10/2023 11:00, Roi Dayan wrote:
>>>
>>> On 16/10/2023 10:42, Eelco Chaudron wrote:
On 16 Oct 2023, at 9:09, Roi Dayan wrote:
> On 09/10/2023 15:05, Roi Dayan wrote:
On 16/10/2023 11:00, Roi Dayan wrote:
>
> On 16/10/2023 10:42, Eelco Chaudron wrote:
>>
>>
>> On 16 Oct 2023, at 9:09, Roi Dayan wrote:
>>
>>> On 09/10/2023 15:05, Roi Dayan wrote:
The cited commit fixed missing mirror packets by reset mirror when
packets are modified but setting
On 16/10/2023 10:42, Eelco Chaudron wrote:
>
>
> On 16 Oct 2023, at 9:09, Roi Dayan wrote:
>
>> On 09/10/2023 15:05, Roi Dayan wrote:
>>> The cited commit fixed missing mirror packets by reset mirror when
>>> packets are modified but setting geneve options was also treated as
>>> a modified
On 09/10/2023 15:05, Roi Dayan wrote:
> The cited commit fixed missing mirror packets by reset mirror when
> packets are modified but setting geneve options was also treated as
> a modified packet but should be treated as a part of set_tunnel
> which doesn't reset mirror.
>
> Fixes:
On 09/10/2023 15:05, Roi Dayan wrote:
> Test geneve options mirror flow doesn't add redundant mirror.
>
> Signed-off-by: Roi Dayan
> ---
>
> Notes:
> v3:
> - use AT_CHECK for configuring the mirror port.
>
> v2:
> - add dot in title.
>
> tests/tunnel.at | 29
Use test title prefix according to filename the test is in
for tunnel.at and ofproto-dpif.at.
Signed-off-by: Roi Dayan
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
---
Notes:
v2:
- add prefix to bond cases.
tests/ofproto-dpif.at | 10 +-
tests/tunnel.at | 2 +-
2
The cited commit fixed missing mirror packets by reset mirror when
packets are modified but setting geneve options was also treated as
a modified packet but should be treated as a part of set_tunnel
which doesn't reset mirror.
Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are
Test geneve options mirror flow doesn't add redundant mirror.
Signed-off-by: Roi Dayan
---
Notes:
v3:
- use AT_CHECK for configuring the mirror port.
v2:
- add dot in title.
tests/tunnel.at | 29 +
1 file changed, 29 insertions(+)
diff --git
Hi,
The first commit removing the redundant mirror when using tunnel options.
The second is a test to verify it stays like this and doesn't break again.
The third commit is just updating prefixes of tests to match the file their in.
Thanks,
Roi
Roi Dayan (3):
ofproto-dpif-upcall: Fix
On 09/10/2023 12:56, Eelco Chaudron wrote:
>
>
> On 8 Oct 2023, at 9:08, Roi Dayan wrote:
>
>> On 05/10/2023 15:36, Eelco Chaudron wrote:
>>>
>>>
>>> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote:
>>>
>>>> Test geneve opti
On 05/10/2023 15:36, Eelco Chaudron wrote:
>
>
> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote:
>
>> Test geneve options mirror flow doesn't add redundant mirror.
>>
>> Signed-off-by: Roi Dayan
>
> In general this patch looks good, some small nit below
Use test title prefix according to filename the test is in
for tunnel.at and ofproto-dpif.at.
Signed-off-by: Roi Dayan
---
Notes:
v2:
- add prefix to bond cases.
tests/ofproto-dpif.at | 10 +-
tests/tunnel.at | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
Test geneve options mirror flow doesn't add redundant mirror.
Signed-off-by: Roi Dayan
---
Notes:
v2:
- add dot in title.
tests/tunnel.at | 29 +
1 file changed, 29 insertions(+)
diff --git a/tests/tunnel.at b/tests/tunnel.at
index
The cited commit fixed missing mirror packets by reset mirror when
packets are modified but setting geneve options was also treated as
a modified packet but should be treated as a part of set_tunnel
which doesn't reset mirror.
Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are
Hi,
The first commit removing the redundant mirror when using tunnel options.
The second is a test to verify it stays like this and doesn't break again.
The third commit is just updating prefixes of tests to match the file their in.
Thanks,
Roi
Roi Dayan (3):
ofproto-dpif-upcall: Fix
On 04/10/2023 12:46, Simon Horman wrote:
> On Tue, Oct 03, 2023 at 05:03:20PM +0300, Roi Dayan via dev wrote:
>> Use test title prefix according to filename the test is in
>> for tunnel.at and ofproto-dpif.at.
>>
>> Signed-off-by: Roi Dayan
>> ---
>> tes
Use test title prefix according to filename the test is in
for tunnel.at and ofproto-dpif.at.
Signed-off-by: Roi Dayan
---
tests/ofproto-dpif.at | 6 +++---
tests/tunnel.at | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
On 03/10/2023 16:54, Roi Dayan wrote:
> Test geneve options mirror flow doesn't add redundant mirror.
>
> Signed-off-by: Roi Dayan
> ---
> tests/tunnel.at | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/tests/tunnel.at b/tests/tunnel.at
> index
On 03/10/2023 15:22, Ilya Maximets wrote:
> On 10/3/23 10:33, Roi Dayan wrote:
>> The cited commit fixed missing mirror packets by reset mirror when
>> packets are modified but setting geneve options was also treated as
>> a modified packet but should be treated as a part of set_tunnel
>> which
Test geneve options mirror flow doesn't add redundant mirror.
Signed-off-by: Roi Dayan
---
tests/tunnel.at | 29 +
1 file changed, 29 insertions(+)
diff --git a/tests/tunnel.at b/tests/tunnel.at
index ddeb66bc9fb7..c0b932110446 100644
--- a/tests/tunnel.at
+++
On 03/10/2023 13:36, Simon Horman wrote:
> On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote:
>> The cited commit fixed missing mirror packets by reset mirror when
>> packets are modified but setting geneve options was also treated as
>> a modified packet
The cited commit fixed missing mirror packets by reset mirror when
packets are modified but setting geneve options was also treated as
a modified packet but should be treated as a part of set_tunnel
which doesn't reset mirror.
Fixes: 1437f51fea92 ("ofproto-dpif-upcall: Mirror packets that are
On 27/09/2023 16:36, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 27 Sep 2023, at 15:05, Ilya Maximets wrote:
>>
>>> On 9/27/23 14:34, Roi Dayan wrote:
On 18/06/2020 21:17, Roi Dayan wrote:
> This is to match a recent kernel checkpatch change that
> also increased it
On 18/06/2020 21:17, Roi Dayan wrote:
> This is to match a recent kernel checkpatch change that
> also increased it to 100 line length.
>
> Signed-off-by: Roi Dayan
> Reviewed-by: Simon Horman
> Acked-by: Aaron Conole
> ---
>
> Notes:
> v2
> - update docs
> - add ack from Simon
On 10/08/2023 15:26, Ilya Maximets wrote:
> On 8/10/23 09:59, Roi Dayan wrote:
>> Hi,
>>
>> We noticed a possible memory leak in netdev_tc_init_flow_api()
>> as we allocate memory for meter_police_ids with id_pool_create()
>> but we never destroy it.
>
> Hi, Roi.
>
> I'd not consider this as
Hi,
We noticed a possible memory leak in netdev_tc_init_flow_api()
as we allocate memory for meter_police_ids with id_pool_create()
but we never destroy it.
I added a code to refcount netdev_tc_init_flow_api and so in
netdev_tc_uninit_flow_api() to destroy it and noticed some behavior
about
On 29/06/2023 11:50, Eelco Chaudron wrote:
>
>
> On 27 Jun 2023, at 12:48, Roi Dayan wrote:
>
>> From: Gavin Li
>>
>> Add a vxlan gbp offload test case:
>>
>> vxlan offloads with gbp extention - ping between two ports - offloads
>> enabled ok
>>
>> Signed-off-by: Gavin Li
>> Reviewed-by:
On 29/06/2023 11:50, Eelco Chaudron wrote:
>
>
> On 27 Jun 2023, at 12:48, Roi Dayan wrote:
>
>> From: Gavin Li
>>
>> Add TC offload support for vxlan encap with gbp option
>>
>> Signed-off-by: Gavin Li
>> Reviewed-by: Gavi Teitz
>> Reviewed-by: Roi Dayan
>> Reviewed-by: Simon Horman
>>
On 25/06/2023 7:04, Gavin Li wrote:
>
> On 6/23/2023 7:06 PM, Simon Horman wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On Fri, Jun 23, 2023 at 01:01:38PM +0200, Eelco Chaudron wrote:
>>>
>>> On 23 Jun 2023, at 12:57, Simon Horman wrote:
>>>
On Fri, Jun 23,
From: Gavin Li
Add a vxlan gbp offload test case:
vxlan offloads with gbp extention - ping between two ports - offloads
enabled ok
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
tests/system-offloads-traffic.at | 50
1 file
From: Gavin Li
Kernels that do not support vxlan gbp would treat the rule that has vxlan
gbp encap action or vxlan gbp id match differently, either reject it or
just skip the action/match and continue processing the knowing ones.
To solve the issue, probe and disallow inserting rules with vxlan
From: Gavin Li
Add TC offload support for vxlan encap with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
Acked-by: Eelco Chaudron
---
acinclude.m4 | 7
include/linux/tc_act/tc_tunnel_key.h | 17
From: Gavin Li
Most of the data members of struct tc_action{ } are defined as anonymous
struct in place. Instead of passing all members of an anonymous struct,
which is not flexible to new members being added, expose encap as named
struct and pass it entirely.
Signed-off-by: Gavin Li
From: Gavin Li
Add TC offload support for filtering vxlan tunnels with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
Acked-by: Eelco Chaudron
---
include/linux/pkt_cls.h | 13 ++
lib/netdev-offload-tc.c | 17
From: Gavin Li
Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
Acked-by: Eelco Chaudron
---
lib/odp-util.c | 9 +++--
lib/odp-util.h | 8
2 files changed, 11
From: Gavin Li
Linux kernel netlink module added NLA_F_NESTED flag checking for nested
netlink messages in 5.2. A nested message without the flag set will be
treated as malformated one. The check is optional and is controlled by
message policy. To avoid this, add NLA_F_NESTED explicitly for all
From: Gavin Li
Tc flower tunnel key options were encoded in nl_msg_put_flower_tunnel_opts
and decoded in nl_parse_flower_tunnel_opts. Only geneve was supported.
To avoid adding more arguments to the function to support more vxlan
options in the future, change the function arguments to pass
From: Gavin Li
Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
Acked-by: Eelco Chaudron
---
lib/odp-util.c | 5 +++--
lib/odp-util.h | 5 +
2 files changed, 8
Hi,
This series adds TC offload support for filtering vxlan tunnels with gbp option.
First 4 patches do some refactoring and the later patches adds the feature.
Thanks,
Roi
changelog
v6:
- fix nits in patch #7.
- fix test in patch #9 to run test on supported kernel.
v5:
- Fix byte order issue
From: Gavin Li
Add a vxlan gbp offload test case:
vxlan offloads with gbp extention - ping between two ports - offloads
enabled ok
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
tests/system-offloads-traffic.at | 49
1 file
From: Gavin Li
Kernels that do not support vxlan gbp would treat the rule that has vxlan
gbp encap action or vxlan gbp id match differently, either reject it or
just skip the action/match and continue processing the knowing ones.
To solve the issue, probe and disallow inserting rules with vxlan
From: Gavin Li
Most of the data members of struct tc_action{ } are defined as anonymous
struct in place. Instead of passing all members of an anonymous struct,
which is not flexible to new members being added, expose encap as named
struct and pass it entirely.
Signed-off-by: Gavin Li
From: Gavin Li
Add TC offload support for vxlan encap with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
acinclude.m4 | 7
include/linux/tc_act/tc_tunnel_key.h | 17 +++-
From: Gavin Li
Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
lib/odp-util.c | 9 +++--
lib/odp-util.h | 8
2 files changed, 11 insertions(+), 6 deletions(-)
From: Gavin Li
Add TC offload support for filtering vxlan tunnels with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
include/linux/pkt_cls.h | 13 ++
lib/netdev-offload-tc.c | 17
lib/tc.c| 92
From: Gavin Li
Linux kernel netlink module added NLA_F_NESTED flag checking for nested
netlink messages in 5.2. A nested message without the flag set will be
treated as malformated one. The check is optional and is controlled by
message policy. To avoid this, add NLA_F_NESTED explicitly for all
From: Gavin Li
Tc flower tunnel key options were encoded in nl_msg_put_flower_tunnel_opts
and decoded in nl_parse_flower_tunnel_opts. Only geneve was supported.
To avoid adding more arguments to the function to support more vxlan
options in the future, change the function arguments to pass
From: Gavin Li
Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
lib/odp-util.c | 5 +++--
lib/odp-util.h | 5 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff
1 - 100 of 351 matches
Mail list logo
