Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

2024-06-07 Thread Simon Horman
On Fri, Jun 07, 2024 at 12:03:15PM +0100, Simon Horman wrote: > On Fri, Jun 07, 2024 at 07:06:21AM +, Adrián Moreno wrote: > > On Fri, Jun 07, 2024 at 08:57:11AM GMT, Eelco Chaudron wrote: > > > > > > > > > On 5 Jun 2024, at 15:51, Adrian Moreno wrot

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

2024-06-07 Thread Simon Horman
On Fri, Jun 07, 2024 at 07:06:21AM +, Adrián Moreno wrote: > On Fri, Jun 07, 2024 at 08:57:11AM GMT, Eelco Chaudron wrote: > > > > > > On 5 Jun 2024, at 15:51, Adrian Moreno wrote: > > > > > Current regexp used to check whitespaces around operators does not > > > consider that there can be

Re: [ovs-dev] [Patch v2] ovsdb-client: Add "COLUMN" arg to help for 'dump'.

2024-06-07 Thread Simon Horman
Kalcok Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-06 Thread Simon Horman
On Wed, Jun 05, 2024 at 09:26:02PM +0800, Wilson Peng wrote: > Hi, Simon, > In this case, for tftp packet processing, it does have a child-parent > processing logic just like ftp in tcp. > Tftp packet1 from port1 to 69 and it will create one new conntrack entry > and create one related

Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype.

2024-06-06 Thread Simon Horman
On Thu, Jun 06, 2024 at 10:54:45AM +, Roi Dayan wrote: > Hi Simon, > > I appreciate the review, Yes we will look in some of the other ether > types and see if it's something we think is needed to prioritize as well. Thanks Roi, Much appreciated. I've gone ahead and applied this patch to

Re: [ovs-dev] [PATCH v2] checkpatch: Extend and move extra_keywords list to file.

2024-06-06 Thread Simon Horman
> patches and selecting any words that appeared multiple times. > > The rational for using a separate file is to make management of this > list simpler by decoupling the code from the keywords. > > Signed-off-by: Mike Pattrick > --- > v2: Included new file in

Re: [ovs-dev] [PATCH] checkpatch: Extend and move extra_keywords list to file.

2024-06-06 Thread Simon Horman
> patches and selecting any words that appeared multiple times. > > The rational for using a separate file is to make management of this > list simpler by decoupling the code from the keywords. > > Signed-off-by: Mike Pattrick Acked-by: Simon Horman

Re: [ovs-dev] [PATCH v2] system-dpdk: Tolerate new warnings 23.11.1/24.03.

2024-06-06 Thread Simon Horman
s://github.com/DPDK/dpdk-stable/commit/cbd1c165 > > Signed-off-by: Christian Ehrhardt > --- > Changes since v1: > - adapt to grammar rules for the subject Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

2024-06-06 Thread Simon Horman
e raised when the > patch contains a simple list of pointers, e.g: "char **errrp"). > > Fix the regexp to allow more than one consecutive "+" characters. > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH 1/1] debian: Fix tabs vs spaces.

2024-06-06 Thread Simon Horman
On Tue, May 28, 2024 at 11:34:17AM +0300, Roi Dayan via dev wrote: > Getting the following message while trying to build a debian package. > debian/openvswitch-switch.init > debian/openvswitch-switch.postinst > See above for files that use tabs for indentation. > Please use spaces instead. > Fix

Re: [ovs-dev] [PATCH v2] netdev-offload-dpdk: Support offload of set dscp action.

2024-06-06 Thread Simon Horman
On Wed, May 29, 2024 at 09:14:03AM +0800, Sunyang Wu via dev wrote: Hi Sunyang, It would be nice to include a patch description here. > Signed-off-by: Sunyang Wu ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

2024-06-05 Thread Simon Horman
On Wed, Jun 05, 2024 at 07:31:55PM +, Adrián Moreno wrote: > On Wed, Jun 05, 2024 at 08:29:22AM GMT, kernel test robot wrote: > > Hi Adrian, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on net-next/main] > > > > url: > >

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

2024-06-05 Thread Simon Horman
On Mon, Jun 03, 2024 at 08:56:39PM +0200, Adrian Moreno wrote: > Add support for a new action: emit_sample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the

Re: [ovs-dev] [PATCH net-next v2 9/9] selftests: openvswitch: add emit_sample test

2024-06-05 Thread Simon Horman
On Mon, Jun 03, 2024 at 08:56:43PM +0200, Adrian Moreno wrote: > Add a test to verify sampling packets via psample works. > > In order to do that, create a subcommand in ovs-dpctl.py to listen to > on the psample multicast group and print samples. > > In order to also test simultaneous sFlow and

Re: [ovs-dev] [PATCH 1/1] debian: Fix tabs vs spaces.

2024-06-05 Thread Simon Horman
instead. > Fix it. > > Signed-off-by: Roi Dayan Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: support offload of set dscp action.

2024-06-05 Thread Simon Horman
On Sun, May 26, 2024 at 04:43:16PM +0800, Sunyang Wu via dev wrote: > Signed-off-by: Sunyang Wu Recheck-request: github-robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-05 Thread Simon Horman
On Wed, Jun 05, 2024 at 01:35:52PM +0800, Wilson Peng via dev wrote: > From: Wilson Peng > > It is found the TFTP reply packet with source port 69 will trigger host hang > And the possible coredump. > > According to part 4 in TFTP RFC https://datatracker.ietf.org/doc/html/rfc1350, > The TFTP

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Add sanity check in OvsInitConntrack.

2024-06-05 Thread Simon Horman
On Sun, May 26, 2024 at 04:08:18PM +0800, Wilson Peng via dev wrote: > From: Wilson Peng > > While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, > Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not > started > After the Windows node is

Re: [ovs-dev] [PATCH 0/2] ovs-ctl: Fix typo.

2024-06-04 Thread Simon Horman
On Mon, May 20, 2024 at 04:39:49PM +0100, 'Simon Horman' wrote: > -- > v1 [Simon] > - Added punctuation to subject > - Added commit message > - Extracted ptach from GitHub PR workflow > + https://github.com/openvswitch/ovs/pull/406 > > --- > Jun Gu (1): >

Re: [ovs-dev] [PATCH 0/2] docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling.

2024-06-04 Thread Simon Horman
On Mon, May 20, 2024 at 07:13:43PM +0100, 'Simon Horman' wrote: > This short patch set: > > * Corrects the spelling of CONFIG_HAVE_EBPF_JIT in AFXDP documentation > - This patch extracted from GitHub PR > https://github.com/openvswitch/ovs/pull/393 > * Adds Ville Skyttä t

Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 128 everywhere.

2024-06-04 Thread Simon Horman
+ Ihar On Fri, May 31, 2024 at 03:40:08PM -0400, Brian Haley wrote: > An earlier patch [1] increased the size of the listen > backlog to 64. While that was a huge improvement over > 10, further testing in large deployments showed 128 > was even better. nit: I would slightly prefer if a commit

Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype.

2024-06-04 Thread Simon Horman
On Thu, May 30, 2024 at 09:31:06AM +0300, Roi Dayan via dev wrote: > > > On 28/05/2024 20:12, Ilya Maximets wrote: > > On 5/26/24 10:31, Roi Dayan via dev wrote: > >> From: Maor Dickman > >> > >> The cited commit reserved lower tc priorities for IP ethertypes in order > >> to give IP traffic

Re: [ovs-dev] [PATCH 3/3] nsh: Add support to compose-packet and use it in system tests.

2024-06-03 Thread Simon Horman
on't feel strongly about it. > M4 macros are better than shell variables, because we can see the > substitution result in the test log. So, using m4_define and m4_join > extensively. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___

Re: [ovs-dev] [PATCH 2/3] tests: Convert ND, MPLS and CT sendpkt tests to compose-packet.

2024-06-03 Thread Simon Horman
ell variables, because we can see the > substitution result in the test log. So, using m4_define and m4_join > extensively. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] tests: sendpkt: Allow different input formats.

2024-06-03 Thread Simon Horman
ytes as well as pure hex strings provided by ovs-ofctl compose-packet > and ovs-pcap. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/2] ipf: Handle common case of ipf defragmentation.

2024-06-03 Thread Simon Horman
st of the > time. > > Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") > Reported-at: https://issues.redhat.com/browse/FDP-560 > Signed-off-by: Mike Pattrick Acked-by: Simon Horman ___ dev mailing list d..

Re: [ovs-dev] [PATCH v2 1/2] ipf: Only add fragments to batch of same dl_type.

2024-06-03 Thread Simon Horman
datapath: Add fragmentation handling.") > Reported-at: https://issues.redhat.com/browse/FDP-560 > Signed-off-by: Mike Pattrick Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

2024-06-03 Thread Simon Horman
On Mon, Jun 03, 2024 at 12:20:36AM -0400, Mike Pattrick wrote: > Currently all OVSDB database queries except for UUID lookups all result > in linear lookups over the entire table, even if an index is present. > > This patch modifies ovsdb_query() to attempt an index lookup first, if > possible.

Re: [ovs-dev] [PATCH 1/2] docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling.

2024-05-21 Thread Simon Horman
On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote: > > > On 20 May 2024, at 20:13, Simon Horman wrote: > > > From: Ville Skyttä > > > > Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). > > > > Signed-

[ovs-dev] [PATCH 0/2] docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling.

2024-05-20 Thread 'Simon Horman'
This short patch set: * Corrects the spelling of CONFIG_HAVE_EBPF_JIT in AFXDP documentation - This patch extracted from GitHub PR https://github.com/openvswitch/ovs/pull/393 * Adds Ville Skyttä to the authors file --- Simon Horman (1): AUTHORS: Add Ville Skyttä. Ville Skyttä (1

[ovs-dev] [PATCH 1/2] docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling.

2024-05-20 Thread 'Simon Horman'
From: Ville Skyttä Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). Signed-off-by: Ville Skyttä [simon: added commit meesage] Signed-off-by: Simon Horman --- Documentation/intro/install/afxdp.rst | 2 +- 1 file changed, 1 insertion(+), 1 del

[ovs-dev] [PATCH 2/2] AUTHORS: Add Ville Skyttä.

2024-05-20 Thread Simon Horman
Add Ville Skyttä to AUTHORS file. Signed-off-by: Simon Horman --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index bb44ef142513..0a6de17a7acc 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -474,6 +474,7 @@ Valient Gough vgo

[ovs-dev] [PATCH 0/2] ovs-ctl: Fix typo.

2024-05-20 Thread 'Simon Horman'
-- v1 [Simon] - Added punctuation to subject - Added commit message - Extracted ptach from GitHub PR workflow + https://github.com/openvswitch/ovs/pull/406 --- Jun Gu (1): ovs-ctl: Fix typo. Simon Horman (1): AUTHORS: Add Jun Gu. AUTHORS.rst | 1 + utilities/ovs-ctl.in

[ovs-dev] [PATCH 1/2] ovs-ctl: Fix typo.

2024-05-20 Thread 'Simon Horman'
From: Jun Gu Correct spelling of destination in ovs-ctl.in. Signed-off-by: Jun Gu Signed-off-by: Simon Horman --- utilities/ovs-ctl.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 0b2820c3611e..57abd3a5b45b 100644

[ovs-dev] [PATCH 2/2] AUTHORS: Add Jun Gu.

2024-05-20 Thread Simon Horman
Add Jun Gu to AUTHORS file. Signed-off-by: Simon Horman --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index bb44ef142513..b8cb2aef418d 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -246,6 +246,7 @@ Joe Stringer j...@ovn.org

Re: [ovs-dev] [PATCH] ipf: Only add fragments to batch of same dl_type.

2024-05-16 Thread Simon Horman
Hi Mike, On Wed, May 15, 2024 at 12:24:33PM -0400, Mike Pattrick wrote: > When conntrack is reassembling packet fragments, the same reassembly > context can be shared across multiple threads handling different packets > simultaneously. Once a full packet is assembled, it is added to a packet >

Re: [ovs-dev] vlog: Destroy async_append first then close log_fd.

2024-05-15 Thread Simon Horman
On Wed, May 15, 2024 at 11:28:21AM +0800, hepeng via dev wrote: > From: Peng He > > async_append stores log_fd, it should be destructed before log_fd > is closed. > > Signed-off-by: Peng He Acked-by: Simon Horman ___

Re: [ovs-dev] [PATCH v2] table: Fix freeing global variable.

2024-05-15 Thread Simon Horman
ibc.so.6+0x2b038) > #10 0xaeb50110 in __libc_start_main (/usr/lib64/libc.so.6+ > 0x2b110) > #11 0x40906c in _start (/usr/local/bin/ovsdb-client+0x40906c) > > Fixes: cb139fa8b3a1 ("table: New function table_format() for f

Re: [ovs-dev] [PATCH v2] conntrack: Fully initialize conn struct before insertion.

2024-05-13 Thread Simon Horman
ar NAT or all-zero SNAT. > > Fix it by initializing early the connections fields. > > Fixes: 1116459b3ba8 ("conntrack: Remove nat_conn introducing key > directionality.") > Reported-at: https://issues.redhat.com/browse/FDP-616 > Signed-off-by: Mike Pattrick > Co-authored-

Re: [ovs-dev] [PATCH] Subject: conntrack: Fully initialize conn struct before insertion.

2024-05-13 Thread Simon Horman
ar NAT or all-zero SNAT. > > Fix it by initializing early the connections fields. > > Fixes: 1116459b3ba8 ("conntrack: Remove nat_conn introducing key > directionality.") > Reported-at: https://issues.redhat.com/browse/FDP-616 > Signed-off-by: Mike Pattrick > Co-authored-

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-13 Thread Simon Horman
On Fri, May 10, 2024 at 01:31:10PM +0200, martin.kal...@canonical.com wrote: > Thanks for the merge and backports Simon. > > On Tue, 2024-05-07 at 17:26 +0100, Simon Horman wrote: > > On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > > > On Fri, May 03,

Re: [ovs-dev] [PATCH v2] utilities: Correct deletion reason in flow_reval_monitor.py.

2024-05-09 Thread Simon Horman
fproto-dpif-upcall.c > @@ -1,3 +1,4 @@ > + > /* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc. > * > * Licensed under the Apache License, Version 2.0 (the "License"); Nit: this hunk seems unrelated to the rest of the patch. Otherwise, this

Re: [ovs-dev] [PATCH] ci: Set platform parameter when building DPDK.

2024-05-09 Thread Simon Horman
On Tue, May 07, 2024 at 05:04:34PM +0200, David Marchand wrote: > This change has no impact, since -Dmachine=default gets converted by > DPDK into -Dplatform=generic (since v21.08, see the link to DPDK commit > below). Yet, switch to explicitly setting -Dplatform and avoid the > following warning:

Re: [ovs-dev] [PATCH] ci: Set platform parameter when building DPDK.

2024-05-07 Thread Simon Horman
2024-04-18T14:50:17.0770596Z WARNING: Running the setup command as > `meson [options]` instead of `meson setup [options]` is ambiguous > and deprecated. > > Link: https://git.dpdk.org/dpdk/commit/?id=bf66003b51ec > Signed-off-by: David Marchand Acked-by: Simon Horm

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-07 Thread Simon Horman
On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > On Fri, May 03, 2024 at 02:22:27PM +0200, martin.kal...@canonical.com wrote: ... > Thanks, > > Sorry for the confusion on my part. > Now that I can see it again I have applied it to main. > > - ovsdb-cl

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-07 Thread Simon Horman
Martin. > > [0] > https://patchwork.ozlabs.org/project/openvswitch/patch/2024050043.357669-1-martin.kal...@canonical.com/ > > On Fri, 2024-05-03 at 13:16 +0100, Simon Horman wrote: > > On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > > > On Wed,

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-03 Thread Simon Horman
On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > > Help text for 'ovsdb-client dump' does not mention that it's capable > > of dumping specific table's contents if user supplies table's name > >

Re: [ovs-dev] [PATCH v2 1/2] test-conntrack: Add per zone benchmark tool.

2024-05-03 Thread Simon Horman
On Wed, Apr 24, 2024 at 02:44:47PM +0200, Felix Huettner via dev wrote: > The current test-conntrack benchmark command runs with multiple threads > against a single conntrack zone. We now add a new benchmark-zones > command that allows us to check the performance between multiple zones. > > We in

Re: [ovs-dev] [PATCH v3] hash, jhash: Fix unaligned access to the hash remainder.

2024-05-03 Thread Simon Horman
oject/issues/90848 > Fixes: db5a101931c5 ("clang: Fix the alignment warning.") > Signed-off-by: Ales Musil > --- > v3: Do partial revert of db5a101931c5 instead of simple cast. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] sparse: Add additional define for sparse on GCC >= 14.

2024-05-03 Thread Simon Horman
-mirror/gcc/commit/aea8e4105553cd16799f2134d15420ccf182d732 > Tested-by: Dumitru Ceara > Signed-off-by: Ales Musil Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Documentation: Update Pacemaker main page link.

2024-05-03 Thread Simon Horman
On Wed, May 01, 2024 at 01:39:58PM +0200, Eelco Chaudron wrote: > > > On 1 May 2024, at 12:54, Simon Horman wrote: > > > Update link to pacemaker main page as the existing link is broken. > > Also, use HTTPS. > > > > Broken link flagged by make check-docs

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > Help text for 'ovsdb-client dump' does not mention that it's capable > of dumping specific table's contents if user supplies table's name > as a third positional argument. > > Signed-off-by: Martin Kalcok Acked-b

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 11:59:02AM +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 11:57:46AM +0100, Simon Horman wrote: > > On Fri, Apr 26, 2024 at 10:16:31PM -0700, William Tu via dev wrote: > > > Add route-table that support ipv4 dst via ipv6. BGP unnumbered i

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Simon Horman
IP fragments. > > Since TC already applies fragmentation bit masking, this patch simply > needs to prevent these packets from being processed through TC. > > Signed-off-by: Eelco Chaudron Acked-by: Simon Horman ___ dev mailing list

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Simon Horman
On Tue, Apr 30, 2024 at 02:42:45PM +0200, Eelco Chaudron wrote: > Greetings, Intel team! > > The self-test conducted as part of this patch has revealed an issue with the > AVX512 checksumming code. Since it was agreed upon that your team would > maintain this code upon its inclusion, could you

Re: [ovs-dev] [PATCH v2] ofproto-dpif-rid: Fix duplicate entries.

2024-05-01 Thread Simon Horman
On Tue, Apr 30, 2024 at 05:36:09PM +0800, wushao...@chinatelecom.cn wrote: > From: Shaohua Wu > > In scenarios with multiple PMDs, there may be > simultaneous requests for recirc_id from multiple > PMD threads.In recirc_alloc_id_ctx, we first check > if there is a duplicate entry in the

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Key connections by zone.

2024-05-01 Thread Simon Horman
thout commiting of around 6% to 23% > * a significant performance improvement for flushing a full zone of > around 75% to 99% > * an even more significant improvement for flushing empty zones since we > no longer need to check any unrelated connections Very nice numbers indeed. > [1] 9ec849e8aa869b646c372fac552ae2609a4b5f66 > > Signed-off-by: Felix Huettner Acked-by: Simon Horman ... ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/2] test-conntrack: Add per zone benchmark tool.

2024-05-01 Thread Simon Horman
t the entries of a >single zone > > Signed-off-by: Felix Huettner > --- > v1->v2: fix formatting Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 11:57:46AM +0100, Simon Horman wrote: > On Fri, Apr 26, 2024 at 10:16:31PM -0700, William Tu via dev wrote: > > Add route-table that support ipv4 dst via ipv6. BGP unnumbered is mechanism > > that allows BGP to establish peering sessions without the nee

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
v br-phy src 100.87.18.6 > > Currently OVS can only support either all-ipv4 or all-ipv6, the patch > adds support for such use case. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html > Signe

[ovs-dev] [PATCH] Documentation: Update Pacemaker main page link.

2024-05-01 Thread Simon Horman
Update link to pacemaker main page as the existing link is broken. Also, use HTTPS. Broken link flagged by make check-docs Signed-off-by: Simon Horman --- Documentation/topics/integration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/topics

Re: [ovs-dev] [PATCH] socket: Don't fail when AF_UNIX connect() returns EAGAIN.

2024-05-01 Thread Simon Horman
andled the same way - by returning the `fd` and > letting the caller to complete connection asynchronously. > > [1]: > https://pubs.opengroup.org/onlinepubs/9699919799.2016edition/functions/connect.html > [2]: see `connect(2)` on Linux for details > > Signed-off-by: Ihar

Re: [ovs-dev] [PATCH v3] docs: Document manual cluster recovery procedure.

2024-05-01 Thread Simon Horman
Ihar Hrachyshka > > --- > > v1: initial version. > v2: remove --force mentioned in ovsdb-server(1). > v3: multiple language and markup changes suggested by Ilya. Thanks for the updates Ihar, this version looks good to me. Acked-by: Simon Horman ... __

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Fri, Apr 26, 2024 at 09:59:50AM +0100, Simon Horman wrote: > On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > > On 22/04/2024 13:37, Paolo Valerio wrote: > > > When no parameters other than the datapath are specified a segfault > > > occurs. >

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-26 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote: > When failing to get flow control parameters use VLOG_WARN_BUF() > to expose the error string in ovs-vsctl show. > > Signed-off-by: Roi Dayan > Suggested-by: Simon Horman > Acked-by: Eli Britstein Thanks Roi

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > On 22/04/2024 13:37, Paolo Valerio wrote: > > When no parameters other than the datapath are specified a segfault > > occurs. > > > > Fix it by checking the argument access is inside the bounds. > > > > Signed-off-by: Paolo Valerio

Re: [ovs-dev] [PATCH] GitHub: Add Coverity scan as a daily GitHub action.

2024-04-26 Thread Simon Horman
add the following two actions secrets > to the GitHub openvswitch project: > > - COVERITY_SCAN_TOKEN; The secret token from the project page > - COVERITY_SCAN_EMAIL; The maintainer's email alias > > Signed-off-by: Eelco Chaudron Hi Eelco, I'm fine with this patch in it's c

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-26 Thread Simon Horman
On Thu, Apr 25, 2024 at 12:21:51PM -0700, Jakub Kicinski wrote: > On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote: > > openvswitch.sh does not appear to have any dependencies on Open vSwitch > > user-space. My understanding is that, rather, it makes use of > > tools/

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
+ Aaron On Thu, Apr 25, 2024 at 09:26:37AM +0100, Simon Horman wrote: > On Wed, Apr 24, 2024 at 05:30:00PM -0700, Jakub Kicinski wrote: > > On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote: > > > I have recently been exercising the Open vSwitch kernel selftest

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
On Wed, Apr 24, 2024 at 05:30:00PM -0700, Jakub Kicinski wrote: > On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote: > > I have recently been exercising the Open vSwitch kernel selftests, > > using vng, > > Speaking of ovs tests, we currently don't run them in CI (and s

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
On Wed, Apr 24, 2024 at 02:14:09PM -0400, Aaron Conole wrote: > Simon Horman writes: > > > Hi Aaron, Jakub, all, > > > > I have recently been exercising the Open vSwitch kernel selftests, > > using vng, something like this: > > > > TESTDI

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
On Wed, Apr 24, 2024 at 01:59:29PM -0400, Benjamin Poirier wrote: > On 2024-04-24 18:37 +0100, Simon Horman wrote: > > On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote: > > > Hi Aaron, Jakub, all, > > > > > > I have recently been exercisi

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-24 Thread Simon Horman
On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote: > Hi Aaron, Jakub, all, > > I have recently been exercising the Open vSwitch kernel selftests, > using vng, something like this: > > TESTDIR="tools/testing/selftests/net/openvswitch" > >

[ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-24 Thread Simon Horman
Hi Aaron, Jakub, all, I have recently been exercising the Open vSwitch kernel selftests, using vng, something like this: TESTDIR="tools/testing/selftests/net/openvswitch" vng -v --run . --user root --cpus 2 \ --overlay-rwdir "$PWD" -- \ "modprobe

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-24 Thread Simon Horman
On Tue, Apr 23, 2024 at 11:33:15AM +0100, Simon Horman wrote: > On Wed, Apr 17, 2024 at 10:43:11AM +0300, Roi Dayan wrote: > > > > > > On 16/04/2024 18:48, Simon Horman wrote: > > > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: > > >

Re: [ovs-dev] [PATCH net-next] net: openvswitch: Release reference to netdev

2024-04-23 Thread Simon Horman
ner.pl my.patch I'd wait for feedback from Jakub on if a repost is needed (because for one thing it's not good to repost within 24h.) The above notwithstanding, Reviewed-by: Simon Horman > --- > net/openvswitch/vport-netdev.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >

Re: [ovs-dev] [PATCH 1/3] ovsdb-idl: Add python keyword to persistent UUID test.

2024-04-23 Thread Simon Horman
On Thu, Apr 11, 2024 at 11:46:01AM +0100, Simon Horman wrote: > On Wed, Apr 10, 2024 at 04:38:24PM -0500, Terry Wilson wrote: > > The Python persistent UUID tests should have the keyword "python" > > added so that TESTSUITEFLAGS="-k python" will not mi

Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 64 everywhere.

2024-04-23 Thread Simon Horman
On Fri, Apr 12, 2024 at 10:33:18AM +0100, Simon Horman wrote: > On Fri, Apr 12, 2024 at 02:45:17AM +, Ihar Hrachyshka wrote: > > Before the patch, the size of the backlog depended on the type of socket > > (UNIX vs INET) as well as on the language (C vs Python), specifically: &g

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-23 Thread Simon Horman
On Mon, Apr 22, 2024 at 02:37:41PM +0200, Paolo Valerio wrote: > When no parameters other than the datapath are specified a segfault > occurs. > > Fix it by checking the argument access is inside the bounds. > > Signed-off-by: Paolo Valerio Acke

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-23 Thread Simon Horman
tever reason it takes too long is problematic. Addressing > > the root cause (compaction, too many calls, some other bug(s) etc) is > > good, but extending the timeout seems like an easy backstop. > > I agree with Jon's assessment - regardless of any action taken on compaction > or preventing growth in the first place, we should consider the proposed > timeout increase as a backstop against getting stuck in an infinite loop. > > Ilya (or another maintainer) - can I get an opinion on this? Yes, I agree that the timeout increase is a good idea. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-23 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:43:11AM +0300, Roi Dayan wrote: > > > On 16/04/2024 18:48, Simon Horman wrote: > > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: > >> VLOG_WARN_BUF() is allocating memory for the error string and should > >> e

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-23 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote: > When failing to get flow control parameters use VLOG_WARN_BUF() > to expose the error string in ovs-vsctl show. > > Signed-off-by: Roi Dayan > Suggested-by: Simon Horman > Acked-by: Eli Britstein Acke

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-16 Thread Simon Horman
'%s'.", netdev_get_name(netdev), vf_mac); > } else if (!eth_addr_equals(dev->requested_hwaddr, mac)) { > dev->requested_hwaddr = mac; > netdev_request_reconfigure(netdev); Thanks Roi, I agree that this change makes sense as the allocated value

Re: [ovs-dev] [PATCH] checkpatch: Allow rST manpages to be added.

2024-04-12 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:45:55PM +0200, Eelco Chaudron wrote: > > > On 9 Apr 2024, at 9:19, Adrian Moreno wrote: > > > The current __check_doc_is_listed() verifies that the new .rst file is > > listed in Documentation/automake.mk with the full path (i.e: > > "{directory}/{filename}"). > > > >

Re: [ovs-dev] [PATCH] docs: Document manual cluster recovery procedure.

2024-04-12 Thread Simon Horman
Ihar Hrachyshka Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 64 everywhere.

2024-04-12 Thread Simon Horman
://mail.openvswitch.org/pipermail/ovs-discuss/2024-April/053049.html > > Signed-off-by: Ihar Hrachyshka > Acked-by: Eelco Chaudron Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] appveyor: Fix too wide OpenSSL version regexp.

2024-04-12 Thread Simon Horman
penSSL 3.0.") > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/2] ci: Remove reference to master branch.

2024-04-11 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:09:19PM +0100, Simon Horman wrote: > The OvS primary development branch has been renamed main > so there is no longer any need for CI configuration to > refer to master. > > Signed-off-by: Simon Horman > > --- > Simon Horman (2): >

Re: [ovs-dev] [PATCH 1/3] ovsdb-idl: Add python keyword to persistent UUID test.

2024-04-11 Thread Simon Horman
rt to specify the uuid for row > insert.") > Signed-off-by: Terry Wilson Acked-by: Simon Horman Tested-by: Simon Horman ... ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/3] github: Update python to 3.12.

2024-04-11 Thread Simon Horman
ecomes > a race against older python versions reaching end of their life and > packages dropping support of these versions. This may cause unexpected > CI failures. So, not doing that for now. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___

Re: [ovs-dev] [PATCH 2/3] ovsdb-dot: Fix flake8 issues.

2024-04-11 Thread Simon Horman
gt; > Files added to flake8-check to avoid future issues. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] ovsdb-doc: Fix syntax warning with Python 3.12 and flake8 issues.

2024-04-11 Thread Simon Horman
the future. This means also fixing all the other issues with the > script like unused imports and variables, long lines, missing empty > lines, wildcarded imports. Also cleaning up one place that handles > compatibility with Python 2 types, since we do not support Python 2 > for a long

Re: [ovs-dev] [PATCH] python: Remove hacking dependency and use recent flake8.

2024-04-10 Thread Simon Horman
OVN a while ago: > https://github.com/ovn-org/ovn/commit/271186fa7d76 > > Signed-off-by: Dumitru Ceara Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Simon Horman
> > If this change is accepted, I'd also suggest backporting it to 3.3. > It is a debug-only change that touches only the code executed under > fatal failure conditions, so should be safe enough. Backporting > will allow us easier debugging in to-be-LTS release. And a

Re: [ovs-dev] [PATCH branch-2.17] xenserver: Fix tests with Python 3.12.

2024-04-10 Thread Simon Horman
: VLAN on bondok 2352: non-VLAN, non-bond ok Acked-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v2] treewide: Rename references from OvS master to main.

2024-04-10 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:45:53PM +0200, Ales Musil wrote: > There was recent switch in OvS from master to main branch. > Use main in all the references across OVN code base. > > Signed-off-by: Ales Musil > --- > v2: Add the missing two references. Acke

[ovs-dev] [PATCH 1/2] appveyor: Remove reference to master branch.

2024-04-10 Thread Simon Horman
The OvS primary development branch has been renamed main so there is no longer any need for this CI configuration to refer to master. Signed-off-by: Simon Horman --- appveyor.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 050c7dead786..baa844753962

[ovs-dev] [PATCH 2/2] github: Remove reference to master branch.

2024-04-10 Thread Simon Horman
The OvS primary development branch has been renamed main so there is no longer any need for this CI configuration to refer to master. Signed-off-by: Simon Horman --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build

[ovs-dev] [PATCH 0/2] ci: Remove reference to master branch.

2024-04-10 Thread Simon Horman
The OvS primary development branch has been renamed main so there is no longer any need for CI configuration to refer to master. Signed-off-by: Simon Horman --- Simon Horman (2): appveyor: Remove reference to master branch. github: Remove reference to master branch. .github

[ovs-dev] [ANN] Primary OVS branch renamed as main development branch as main.

2024-04-10 Thread Simon Horman
Hi, I would like to announce that the primary development branch for OvS has been renamed main. The rename occurred a little earlier today. OVS is currently hosted on GitHub. We can expect the following behaviour after the rename: * GitHub pull requests against master should have been

  1   2   3   4   5   6   7   8   9   10   >