Hi Ilya,
thanks for your review!
The patch passes my githug-ci
https://github.com/williamtu/ovs/actions/runs/9293675528/job/25577358954
I don't know why it fails/skipped at
https://github.com/ovsrobot/ovs/actions/runs/9294537471
On 5/30/24 11:17 AM, Ilya Maximets wrote:
diff --git a/tests/t
packet header, but only used for lookup the out dev br-phy.
Currently OVS can only support either all-ipv4 or all-ipv6, the patch
adds support for such use case.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html
Acked-by: Simon Horman
Signed-off-by: William Tu
packet header, but only used for lookup the out dev br-phy.
Currently OVS can only support either all-ipv4 or all-ipv6, the patch
adds support for such use case.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html
Acked-by: Simon Horman
Signed-off-by: William Tu
On 5/16/24 1:48 PM, Ilya Maximets wrote:
I didn't look at the code changes too closely, but in case you
wan't to re-spin the patch, I added a few comments for the
test cases below.
thanks for taking a look at this patch
diff --git a/tests/ovs-router.at b/tests/ovs-router.at
index b3314b3df
packet header, but only used for lookup the out dev br-phy.
Currently OVS can only support either all-ipv4 or all-ipv6, the patch
adds support for such use case.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html
Acked-by: Simon Horman
Signed-off-by: William Tu
support for such use case.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html
Signed-off-by: William Tu
---
v2: fix CI errors
RFC: wait for Derrick to verify vxlan use case
---
lib/ovs-router.c | 34 --
lib/route-table.c
use case.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html
Signed-off-by: William Tu
---
Need Derrick to verify it's working on tunnel
---
lib/ovs-router.c | 34 --
lib/route-table.c
use case.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html
Signed-off-by: William Tu
---
Need Derrick to verify it's working on tunnel
---
lib/ovs-router.c | 34 --
lib/route-table.c
On Mon, Jun 26, 2023 at 7:53 AM Simon Horman wrote:
>
> On Wed, Jul 08, 2020 at 09:10:36AM -0700, William Tu wrote:
> > The patch adds VxLAN encap tc-offload support. The userspace datapath,
> > dpif-netdev,
> > flow format differs than the kernel datapath in case of tu
> > CC: Ian Stokes
> > CC: Ilya Maximets
> > CC: Jarno Rajahalme
> > CC: Jesse Gross
> > CC: Justin Pettit
> > CC: Pravin B Shelar
> > CC: Simon Horman
> > CC: Thomas Graf
> > CC: William Tu
> > CC: YAMAMOTO Takashi
> > ---
On Tue, May 31, 2022 at 12:09 PM Ilya Maximets wrote:
>
> On 5/31/22 20:29, William Tu wrote:
> > CT timeout is not supported in Windows datapath, but
> > currently it incorrectly reports to ovs-vswitchd as supported blow
> > "system@ovs-system: Datapath support
On Tue, May 31, 2022 at 12:06 PM Ilya Maximets wrote:
>
> On 5/31/22 20:27, William Tu wrote:
> > Truncate action is not supported in Windows datapath, but
> > currently it incorrectly reports to ovs-vswitchd as supported blow
> > "system@ovs-system: Datapath suppo
Signed-off-by: William Tu
---
datapath-windows/ovsext/Conntrack.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/datapath-windows/ovsext/Conntrack.c
b/datapath-windows/ovsext/Conntrack.c
index 471bf961b..b33676cc1 100644
--- a/datapath-windows/ovsext/Conntrack.c
+++ b/datapath-wind
Truncate action is not supported in Windows datapath, but
currently it incorrectly reports to ovs-vswitchd as supported blow
"system@ovs-system: Datapath supports truncate action".
The patches detects it and returns not support.
Cc: Alin-Gabriel Serdean
Cc: Wilson Peng
Signed-off-by:
th ERSPAN tunnel type.
1. https://cloudbase.it/open-vswitch-2-5-hyper-v-gre-part-3/
A short demo using One Linux server and one Windows server:
https://youtu.be/_01lWBRnrd4
Cc: Alin-Gabriel Serdean
Signed-off-by: William Tu
---
v2: fix tab and replaced with space
Tested-at:
https://g
Windows")
Cc: Alin-Gabriel Serdean
Signed-off-by: William Tu
---
v2: talked to Wilson and add fixes to Vxlan.c and Stt.c
---
datapath-windows/ovsext/Gre.c | 5 -
datapath-windows/ovsext/Stt.c | 6 --
datapath-windows/ovsext/Vxlan.c | 5 -
3 files changed, 16 deletions(-)
diff -
th ERSPAN tunnel type.
1. https://cloudbase.it/open-vswitch-2-5-hyper-v-gre-part-3/
A short demo using One Linux server and one Windows server:
https://youtu.be/_01lWBRnrd4
Cc: Alin-Gabriel Serdean
Signed-off-by: William Tu
---
Documentation/faq/releases.rst | 2
quot;)
Cc: Alin-Gabriel Serdean
Signed-off-by: William Tu
---
datapath-windows/ovsext/Gre.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/Gre.c
index d87864029303..54725dd176c1 100644
--- a/datapath-windows/ovsext/Gre.c
+++ b/datapa
On Sat, Jan 29, 2022 at 11:38 AM Ben Pfaff wrote:
>
> Until now, the monitor process held its log file open while it waited for
> the child to exit, and then it reopened it after the child exited. Holding
> the log file open this way prevented log rotation from freeing disk space.
> This commit a
ml
The patch detects vpopcntdq and disables AVX512 when not found.
Reported-by: Greg Rose
Signed-off-by: William Tu
---
acinclude.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 5c971e98ce91..0c360fd1ef73 100644
--- a/acinclude.m4
+++ b/a
On Wed, Jan 26, 2022 at 8:56 AM Ben Pfaff wrote:
>
> Until now, the monitor process held its log file open while it waited for
> the child to exit, and then it reopened it after the child exited. Holding
> the log file open this way prevented log rotation from freeing disk space.
> This commit av
472914
[2]
http://patchwork.ozlabs.org/project/openvswitch/cover/20210808014931.320242-1-sergey.madami...@gmail.com/
[3] https://doc.dpdk.org/guides/windows_gsg/
[4] Porting OvS-DPDK to Windows with Meson
https://github.com/smadaminov/ovs-dpdk-meson-issues
[5] ebpf-for-windows: https://github.com/microsoft/ebpf-for
On Thu, Nov 4, 2021 at 4:35 AM Thomas Monjalon wrote:
>
> 06/10/2021 19:00, William Tu:
> > The patch adds OVS-DPDK supports on Windows.
> [...]
> > Implementation on Windows
> > -
> > It's harder than I thought due to my Linux only b
14
[2]
http://patchwork.ozlabs.org/project/openvswitch/cover/20210808014931.320242-1-sergey.madami...@gmail.com/
[3] https://doc.dpdk.org/guides/windows_gsg/
[4] Porting OvS-DPDK to Windows with Meson
https://github.com/smadaminov/ovs-dpdk-meson-issues
Signed-off-by: William Tu
---
ovs/config.h
On Tue, Oct 5, 2021 at 8:05 PM William Tu wrote:
>
> On Tue, Oct 5, 2021 at 11:33 AM Numan Siddique wrote:
> >
> > On Tue, Oct 5, 2021 at 1:46 PM Han Zhou wrote:
> > >
> > > On Tue, Oct 5, 2021 at 9:39 AM Ben Pfaff wrote:
> > > >
> > >
On Tue, Oct 5, 2021 at 11:33 AM Numan Siddique wrote:
>
> On Tue, Oct 5, 2021 at 1:46 PM Han Zhou wrote:
> >
> > On Tue, Oct 5, 2021 at 9:39 AM Ben Pfaff wrote:
> > >
> > > I have not been actively maintaining OVN for some time now. I don't
> > expect
> > > that to change. I think that the res
On Wed, Aug 25, 2021 at 3:08 PM Gregory Rose wrote:
>
>
>
> On 8/25/2021 11:42 AM, Yifeng Sun wrote:
> > LGTM, thanks Greg.
> >
> > Reviewed-by: Yifeng Sun
>
Thanks, I pushed to master.
William
___
dev mailing list
d...@openvswitch.org
https://mail.open
> >>> Meson is a nice system in many aspects, but its support for tests is very
> >>> limited. IIUC, it can only run a single binary and check the error codes.
> >>> Most of our tests starts several daemons and performs several fairly
> >>> complex
> >>> operations and checks. I'm afraid that we
Hi Ilya,
Thanks for your feedback!
> Hi, Sergey and William. Thanks for working on this.
>
> I think that it might be a good idea to move to a different build system
> that will not be that painful to run on Windows. I'm not working on
> Windows parts, but it would be great to have a fast CI th
On Tue, Jun 15, 2021 at 11:43 AM Ansis wrote:
>
> On Mon, Jun 14, 2021 at 10:22 PM Ansis wrote:
> >
> > On Mon, Jun 7, 2021 at 1:31 PM Toms Atteka wrote:
> > >
> > > This optimization caused FLOW_TNL_F_UDPIF flag not to be used in
> > > hash calculation for geneve tunnel when revalidating flows
b64/libpthread-2.28.so)
> by 0x69ECF72: clone (in /usr/lib64/libc-2.28.so)
> Uninitialised value was created by a stack allocation
> at 0x4B1CE0: tun_key_to_attr (odp-util.c:3129)
>
> CC: William Tu
> Fixes: 98514eea21f4 ("erspan: add kernel datapath su
Thanks Björn and Jesper for feedbacks.
On Fri, Mar 5, 2021 at 7:34 AM Björn Töpel wrote:
>
> On 2021-03-05 16:07, Jesper Dangaard Brouer wrote:
> > On Fri, 5 Mar 2021 14:56:02 +0100
> > Björn Töpel wrote:
> >
> >> On 2021-03-05 11:13, Jesper Dangaard Brouer wrote:
>
>
> [...]
> >>
> >> You'd lik
% pmd-c07/id:8 ovs-vswitchd[.] pmd_perf_start_iteration
Signed-off-by: William Tu
---
lib/netdev-afxdp.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/lib/netdev-afxdp.c b/lib/netdev-afxdp.c
index 482400d8d135..49881a8cc0cb 100644
--- a/lib/netdev-afxdp.c
+++ b/lib/net
On Mon, Mar 1, 2021 at 3:47 AM Ilya Maximets wrote:
>
> On 1/10/21 3:16 AM, Hongzhi Guo wrote:
> > From: hongzhi guo
> >
> > I found the basic vxlan topology cannot work when upgrade ovs 2.12 version.
> > Through debugging, I found that when the native tunnel forward,
> > the inner vlan was used
Hi Hepeng,
Thanks, now I understand.
On Sat, Feb 27, 2021 at 12:54 AM 贺鹏 wrote:
>
> Hi,
>
> Thanks William and Ilya for a detailed revisiting of the origin of the
> problem. I learned a lot.
>
> I now understand that the mix using of RCU and refcounts is not
> intended in the first place.
> But m
On Thu, Feb 25, 2021 at 7:26 AM Toshiaki Makita
wrote:
>
> On 2021/02/24 3:37, William Tu wrote:
> >>>>> I don't know if this is too much to ask for.
> >>>>> I wonder if you, or we can work together, to add at least a tunnel
> >>>&
On Thu, Feb 25, 2021 at 4:54 AM Ilya Maximets wrote:
>
> On 2/25/21 4:32 AM, Guohongzhi (Russell Lab) wrote:
> > Refcount and RCU are not mutually exclusive.
> > IMO, the main reason for this problem is that the rule uses both refcount
> > and rcu, while the ofproto uses only rcu, and the rule re
On Tue, Feb 23, 2021 at 6:03 PM Yi Yang (杨燚)-云服务集团 wrote:
>
> Out of curious, I remember OVN doesn't support OVS DPDK, I believe OVN also
> does IPv6 ND by openflow, is it acceptable to use slow path to handle IPv6 ND
> for OVS kernel datapath?
>
Maybe OVN uses IPv6 ND, but not setting/matching
On Tue, Feb 23, 2021 at 4:35 PM Gaëtan Rivet wrote:
>
> On Tue, Feb 23, 2021, at 22:56, William Tu wrote:
> > On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote:
> > >
> > > When ct_sweep() is far behind on its work, the 'next_wake' returned can
> &
On Tue, Feb 23, 2021 at 4:34 PM Gaëtan Rivet wrote:
>
>
>
> On Tue, Feb 23, 2021, at 22:55, William Tu wrote:
> > Hi Gaetan,
> >
> > Thanks for the patch, looks very useful.
> > I haven't tested it yet.
> > Minor question/comments i
ng an atomic will ensure the same write consistency while
> keeping the same (lack of) guarantee for reads. Reading the atomic will
> however be less costly than taking and releasing the lock.
>
> Signed-off-by: Gaetan Rivet
> Reviewed-by: Eli Br
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote:
>
> When ct_sweep() is far behind on its work, the 'next_wake' returned can
> be before the moment it started. When it happens, the thread schedules a
> zero ms timer that is logged as an error.
>
> Instead, mark the thread for immediate wake in
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote:
>
> The current rate limit is set to allow other threads to update the
> connections when applicable. This was valid when taking the 'ct_lock'
> was needed with a global critical section.
>
> Now that the size of the critical section for 'ct_lock
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote:
>
> Do not add noise to the DBG log for empty sweeps.
> Only log time taken when some connections were cleaned.
>
> Signed-off-by: Gaetan Rivet
> Reviewed-by: Eli Britstein
> ---
LGTM
Acked-by: William Tu
> lib/con
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote:
>
> The lock priority order is for the global 'ct_lock' to be taken first
> and then 'conn->lock'. This is an issue, as multiple operations on
> connections are thus blocked between threads contending on the
> global 'ct_lock'.
>
> This was previ
t; at most). Using a CMAP reduces multiple lock taking and releasing in
> the connection insertion path.
>
> Signed-off-by: Gaetan Rivet
> Reviewed-by: Eli Britstein
> ---
Read through the patch and everything looks good to me
Acked-by: William Tu
__
Thanks, I have one question inline.
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote:
>
> Change the data structure from hmap to cmap for zone limits.
> As they are shared amongst multiple conntrack users, multiple
> readers want to check the current zone limit state before progressing in
> the
policies module is affected, making the default policy being
> referenced using an incorrect hash value.
>
> Fixes: 2078901a4c14 ("userspace: Add conntrack timeout policy support.")
> Signed-off-by: Gaetan Rivet
> Reviewed-by: Eli Britstein
> ---
LGTM, thanks for the fix.
Ac
Hi Gaetan,
Thanks for the patch, looks very useful.
I haven't tested it yet.
Minor question/comments inline.
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote:
>
> Change the connection expiration lists from ovs_list to rculist.
> This is a pre-step towards reducing the granularity of 'ct_lock'
> >>> +
> >>> +return 0;
> >>> +}
> >>> +#endif
> >>> +
> >>> static int
> >>> xsk_load_prog(struct netdev *netdev, const char *path,
> >>> struct bpf_object **pobj, int *prog_fd)
> >>> {
> >>> +struct netdev_linux *dev OVS_UNUSED = netdev_linux_cast(netdev);
> >>>
> >>> I don't know if this is too much to ask for.
> >>> I wonder if you, or we can work together, to add at least a tunnel
> >>> support, ex: vxlan?
> >>> The current version is a good prototype for people to test an L2/L3
> >>> XDP offload switch,
> >>> but without a good use case, it's hard to a
On Sun, Feb 21, 2021 at 9:39 PM Yi Yang (杨燚)-云服务集团 wrote:
>
> Thanks William, it is my ovs-ofctl issue, my ovs-vswitchd is new, but
> ovs-ofctl is old, but after I used ovs-ofctl, I still saw issues:
>
> OFPT_ERROR (OF1.3) (xid=0x6): OFPBAC_BAD_SET_ARGUMENT
> OFPT_FLOW_MOD (OF1.3) (xid=0x6): ADD
On Sat, Feb 20, 2021 at 2:11 AM Yi Yang (杨燚)-云服务集团 wrote:
>
> Hi, folks
>
>
>
> I need to set nd_options_type to 2 for NS message to respond IPv6 NS, my flow
> is below, why nd_options_type can’t be set? Per commit
> 9b2b84973db76e1138d9234ff1b84bb6bb156011, it should work, what’s wrong?
> Appr
On Fri, Feb 19, 2021 at 6:29 PM 贺鹏 wrote:
>
> Hi, Ilya
>
> Ilya Maximets 于2021年2月19日周五 下午7:19写道:
> >
> > On 2/19/21 3:12 AM, 贺鹏 wrote:
> > > Hi,
> > >
> > > Looks like this bug is caused by violating the fact that if a rule is
> > > referenced, the related ofproto should not be destroyed.
> > >
>
involved ofproto was already deallocated:
>
> (gdb) print *ofproto
> $1 = ..., name = 0x55d907602820 "nsx-managed", ..., ports = {...,
> one = 0x0, mask = 63, n = 0}, ..., connmgr = 0x0, ...
>
> This patch fixes it.
>
> VMware-BZ: #2700626
> Signed-off-by: Yi
6,000
Fixes: e61bdffc2a98 ("netdev-dpdk: Add new DPDK RFC 4115 egress policer")
Signed-off-by: William Tu
---
Documentation/topics/dpdk/qos.rst | 14 --
vswitchd/vswitch.xml | 6 --
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/Documentat
On Thu, Feb 18, 2021 at 6:55 AM Eelco Chaudron wrote:
>
>
>
> On 18 Feb 2021, at 15:40, William Tu wrote:
>
> > On Thu, Feb 18, 2021 at 1:23 AM Eelco Chaudron
> > wrote:
> >>
> >>
> >>
> >> On 17 Feb 2021, at 18:41, William Tu wrote:
On Thu, Feb 18, 2021 at 1:23 AM Eelco Chaudron wrote:
>
>
>
> On 17 Feb 2021, at 18:41, William Tu wrote:
>
> >>
> >>>> Information Rate). High priority traffic is routed to queue 10,
> >>>> which marks
> >>>> all traf
ws on exit by
> > default.")
> > Reported-by: Dumitru Ceara
> > Signed-off-by: Ilya Maximets
> > ---
LGTM. LeakSanitizer is pretty useful.
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> >> Information Rate). High priority traffic is routed to queue 10,
> >> which marks
> >> all traffic as CIR, i.e. Green. All low priority traffic, queue 20,
> >> is
> >> marked as EIR, i.e. Yellow::
> >>
> >> $ ovs-vsctl --timeout=5 set port dpdk1 qos=@myqos -- \
> >> --id=@myq
On Wed, Feb 17, 2021 at 8:21 AM Eelco Chaudron wrote:
>
>
>
> On 17 Feb 2021, at 9:23, Eelco Chaudron wrote:
>
> > On 17 Feb 2021, at 4:39, William Tu wrote:
> >
> >> RFC4115 says "The CIR and EIR are both measured in bits/s."
> >> Fix the
On Tue, Feb 16, 2021 at 1:40 PM Yi-Hung Wei wrote:
>
> On Tue, Feb 16, 2021 at 1:06 PM Yifeng Sun wrote:
> >
> > ovs-vswitchd could crash under these circumstances:
> > 1. When one bridge is being destroyed, ofproto_destroy() is called and
> > connmgr pointer of its ofproto struct is nullified. T
RFC4115 says "The CIR and EIR are both measured in bits/s."
Fix the example use case based on the decription.
64-Byte packet * 8 * 1000 pps = 512000
Fixes: e61bdffc2a98 ("netdev-dpdk: Add new DPDK RFC 4115 egress policer")
Signed-off-by: William Tu
---
Documentation/topi
l fail only with AddressSanitizer enabled.
>
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27851
> Fixes: f839892a206a ("OF support and translation of generic encap and decap")
> Signed-off-by: Ilya Maximets
LGTM.
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Aaron,
Should we also consider the case where udp checksum is 0x?
I saw in netdev_tnl_calc_udp_csum, we set to 0x when a packet has
udp checksum = 0.
Thanks
William
On Wed, Feb 10, 2021 at 12:15 PM Flavio Leitner wrote:
>
> On Wed, Feb 10, 2021 at 02:45:06PM -0500, Aaron Conole wrote
Remove one extra space. No actual code logic changed.
Fixes: 2109841b79845 ("Use batch process recv for tap and raw socket in netdev
datapath")
Signed-off-by: William Tu
---
lib/netdev-linux.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
di
I see, thanks.
On Tue, Feb 16, 2021 at 12:52 PM Ben Pfaff wrote:
>
> On Fri, Feb 12, 2021 at 11:15:46AM -0800, William Tu wrote:
> > I'm confused with what l2_pad_size is.
> > I thought it's between L2 and L3 header, there is a 2-byte padding to
> > make it 16-b
On Tue, Feb 9, 2021 at 1:39 AM Toshiaki Makita
wrote:
>
> On 2021/02/05 2:36, William Tu wrote:
> > Hi Toshiaki,
> >
> > Thanks for the patch. I've been testing it for a couple days.
> > I liked it a lot! The compile and build process all work without any issu
On Tue, Feb 2, 2021 at 10:00 AM Ben Pfaff wrote:
>
> On Tue, Feb 02, 2021 at 05:11:09PM +0100, Ilya Maximets wrote:
> > On 1/21/21 11:33 PM, Ben Pfaff wrote:
> > > The calculation in tcp_reader_run() failed to account for L2 padding.
> > > This fixes the problem, by moving the existing function
>
-c 3 -i .2 10.1.1.2
ip netns exec at_ns1 ethtool -K p1 tx off
ip netns exec at_ns1 iperf -s
ip netns exec at_ns0 iperf -c 10.1.1.2 -t1
Tested-at: https://github.com/williamtu/ovs-travis/actions/runs/553156643
Signed-off-by: William Tu
---
lib/automake.mk
On Mon, Feb 8, 2021 at 4:58 AM Ilya Maximets wrote:
>
> On 2/7/21 5:05 PM, Toshiaki Makita wrote:
> > On 2021/02/07 2:00, William Tu wrote:
> >> On Fri, Feb 5, 2021 at 1:08 PM Gregory Rose wrote:
> >>> On 2/4/2021 7:08 PM, William Tu wrote:
> >>>
t; case to trigger that issue.
> >
> > -邮件原件-
> > 发件人: William Tu [mailto:u9012...@gmail.com]
> > 发送时间: 2021年2月7日 23:46
> > 收件人: Yi Yang (杨燚)-云服务集团
> > 抄送: i.maxim...@ovn.org; yang_y...@163.com; ovs-dev@openvswitch.org;
> > f...@sysclose.org
>
On Mon, Feb 8, 2021 at 8:57 AM Ilya Maximets wrote:
>
> On 2/6/21 5:15 PM, William Tu wrote:
> > On Mon, Feb 1, 2021 at 5:48 PM Yi Yang (杨燚)-云服务集团
> > wrote:
> >>
> >> Thanks Ilya, net_tap PMD is handling tap device on host side, so it can
> >> leve
On Tue, Oct 27, 2020 at 6:02 PM Yi Yang (杨燚)-云服务集团 wrote:
>
> -邮件原件-
> 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 Ilya Maximets
> 发送时间: 2020年10月27日 21:03
> 收件人: yang_y...@163.com; ovs-dev@openvswitch.org
> 抄送: f...@sysclose.org; i.maxim...@ovn.org
> 主题: Re: [ovs-dev] [PATCH V3 2/
On Fri, Feb 5, 2021 at 1:08 PM Gregory Rose wrote:
>
>
>
> On 2/4/2021 7:08 PM, William Tu wrote:
> > On Thu, Feb 4, 2021 at 3:17 PM Gregory Rose wrote:
> >>
> >>
> >>
> >> On 2/3/2021 1:21 PM, William Tu wrote:
> >>> M
On Mon, Feb 1, 2021 at 5:48 PM Yi Yang (杨燚)-云服务集团 wrote:
>
> Thanks Ilya, net_tap PMD is handling tap device on host side, so it can
> leverage vnet header to do TSO/GSO, maybe net_pmd authors don't know how to
> do this, from source code, tap fd isn't enabled vnet header and TSO.
>
thanks, lear
On Tue, Oct 27, 2020 at 5:50 PM Yi Yang (杨燚)-云服务集团 wrote:
>
> -邮件原件-
> 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 Ilya Maximets
> 发送时间: 2020年10月27日 21:12
> 收件人: yang_y...@163.com; ovs-dev@openvswitch.org
> 抄送: f...@sysclose.org; i.maxim...@ovn.org
> 主题: Re: [ovs-dev] [PATCH V3 3/
On Thu, Feb 4, 2021 at 3:17 PM Gregory Rose wrote:
>
>
>
> On 2/3/2021 1:21 PM, William Tu wrote:
> > Mellanox card has different XSK design. It requires users to create
> > dedicated queues for XSK. Unlike Intel's NIC which loads XDP program
> > to all queues,
On Thu, Feb 4, 2021 at 5:15 PM William Tu wrote:
>
> Hi Toshiaki,
>
> Thanks for the patch. I have some questions inline.
>
> On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita
> wrote:
> >
> > This provider offloads classifier to software XDP.
> >
> &
Hi Toshiaki,
Thanks for the patch. I have some questions inline.
On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita
wrote:
>
> This provider offloads classifier to software XDP.
>
> It works only when a custom XDP object is loaded by afxdp netdev.
> The BPF program needs to implement classifier wit
On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita
wrote:
>
> The following commit will introduce another offload driver using XDP.
> When using afxdp netdev, both of TC and XDP will be supported, so let's
> add an other_config to specify which offload driver is preferable.
> When not specified and m
On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita
wrote:
>
> From: William Tu
>
> Now netdev-afxdp always forwards all packets to userspace because
> it is using libbpf's default XDP program, see 'xsk_load_xdp_prog'.
> There are some cases when users want to ke
On Thu, Feb 4, 2021 at 10:08 AM Cpp Code wrote:
>
> The patch is ready, I am writing a test for this. Maybe it was worth checking
> this in and adding test later!?
>
I'd suggest having a test case together with the patch, since this
isn't a trivial issue.
William
_
Hi Toshiaki,
Thanks for the patch. I've been testing it for a couple days.
I liked it a lot! The compile and build process all work without any issues.
On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita
wrote:
>
> This patch adds an XDP-based flow cache using the OVS netdev-offload
> flow API provi
On Wed, Feb 3, 2021 at 4:33 PM Yi-Hung Wei wrote:
>
> This patch adds an RPMBUILD_OPT so that user can enable
> AF_XDP support in the rpm package by:
>
> $ make rpm-fedora RPMBUILD_OPT="--with afxdp"
>
> Signed-off-by: Yi-Hung Wei
&
pe udp4 action 1
note: we need additionally add flow-redirect rule to queue 1
Tested-at: https://github.com/williamtu/ovs-travis/actions/runs/535141041
Signed-off-by: William Tu
---
Documentation/intro/install/afxdp.rst | 2 ++
lib/netdev-afxdp.c| 23 ++---
works over tunnel, the TCP sender sending huge
packet size will fail. I have to segment the inner TCP
packet before pushing the outer tunnel header.
Signed-off-by: William Tu
---
lib/netdev-linux.c | 2 +-
lib/netdev-native-tnl.c | 11 ++-
lib/netdev.c
/lib/netdev-native-tnl.c
> index b89dfdd52a86..09cff3a1fc7d 100644
> --- a/lib/netdev-native-tnl.c
> +++ b/lib/netdev-native-tnl.c
> @@ -1015,9 +1015,11 @@ netdev_geneve_pop_header(struct dp_packet *packet)
> tnl->tun_id = htonll(ntohl(get_16alig
On Thu, Nov 5, 2020 at 4:48 AM Ilya Maximets wrote:
>
> On 4/10/20 12:03 AM, William Tu wrote:
> > On Wed, Mar 25, 2020 at 05:33:51PM -0700, William Tu wrote:
> >> On Thu, Mar 19, 2020 at 12:20:19PM -0700, William Tu wrote:
> >>> On Thu, Mar 19, 2020 at 12:05
n data.items():
RuntimeError: dictionary changed size during iteration
The patch fixes it by making a copy of the key and value.
VMware-BZ: #2663359
Signed-off-by: William Tu
---
utilities/bugtool/ovs-bugtool.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utilities/bugtoo
On Wed, Oct 21, 2020 at 8:47 AM Stokes, Ian wrote:
>
> > On 6/8/20 5:36 PM, William Tu wrote:
> > > On Mon, Jun 8, 2020 at 7:01 AM Ilya Maximets wrote:
> > >>
> > >> On 5/14/20 4:11 PM, William Tu wrote:
> > >>> The 'dpctl/dump-flows
On Tue, Aug 4, 2020 at 7:24 AM Ilya Maximets wrote:
>
> On 8/4/20 3:19 PM, William Tu wrote:
> > On Mon, Aug 3, 2020 at 2:23 PM Ilya Maximets wrote:
> >>
> >> On 7/30/20 12:44 AM, Ilya Maximets wrote:
> >>>
> >>> Ilya Maximets (2):
> >
On Mon, Aug 3, 2020 at 2:23 PM Ilya Maximets wrote:
>
> On 7/30/20 12:44 AM, Ilya Maximets wrote:
> >
> > Ilya Maximets (2):
> > Set release date for 2.13.1.
> > Prepare for 2.13.2.
> >
> > NEWS | 14 +-
> > configure.ac | 2 +-
> > debian/changelog | 8 +++-
On Wed, Jul 29, 2020 at 3:42 PM Ilya Maximets wrote:
>
> Signed-off-by: Ilya Maximets
> ---
LGTM,
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jul 29, 2020 at 3:42 PM Ilya Maximets wrote:
>
> Signed-off-by: Ilya Maximets
> ---
LGTM,
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote:
>
> Signed-off-by: Ilya Maximets
> ---
LGTM,
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote:
>
> Signed-off-by: Ilya Maximets
> ---
LGTM,
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote:
>
> Signed-off-by: Ilya Maximets
> ---
LGTM,
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote:
>
> Signed-off-by: Ilya Maximets
> ---
LGTM,
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jul 29, 2020 at 3:44 PM Ilya Maximets wrote:
>
> Signed-off-by: Ilya Maximets
> ---
LGTM,
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
1 - 100 of 1254 matches
Mail list logo