[ovs-dev] [PATCH v2 1/1] datapath-windows: Merge split dis-continuous net-buf.

2024-08-05 Thread Wilson Peng via dev
From: Wilson Peng NdisGetDataBuffer() is called without providing a buffer to copy packet data in case it is not contiguous. So, it fails in some scenarios where the packet is handled by the general network stack before OVS and headers become split in multiple buffers. In the fix it will supply

Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: Merge split dis-continuous net-buf.

2024-07-17 Thread Wilson Peng via dev
OvsGetTcp or OvsGetPacketBytes in other patches after The needed testing is done. Not sure if this kind of strategy is accepted? Regards Wilson On Wed, Jul 17, 2024 at 8:10 PM Ilya Maximets wrote: > On 7/17/24 13:42, Wilson Peng via dev wrote: > > From: Wilson Peng > > > &

[ovs-dev] [PATCH v1 1/1] datapath-windows: Merge split dis-continuous net-buf.

2024-07-17 Thread Wilson Peng via dev
From: Wilson Peng NdisGetDataBuffer() is called without providing a buffer to copy packet data in case it is not contiguous. So, it fails in some scenarios where the packet is handled by the general network stack before OVS and headers become split in multiple buffers. In the fix it will supply

[ovs-dev] [ovs-dev v1 1/1] datapath-windows: Merge split dis-continuous net-buf.

2024-07-15 Thread Wilson Peng via dev
From: Wilson Peng NdisGetDataBuffer() is called without providing a buffer to copy packet data in case it is not contiguous. So, it fails in some scenarios where the packet is handled by the general network stack before OVS and headers become split in multiple buffers. In the fix it will supply

[ovs-dev] [PATCH v3 1/1] datapath-windows : Correct the failure handling in OvsInitConntrack.

2024-06-18 Thread Wilson Peng via dev
From: Wilson Peng v2-v3 change: Remove the unneeded sanity check and just correct 3 failure for function ObReferenceObjectByHandle, zoneInfo allocated failed and OvsNatInit is failed on OvsInitConntrack. While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, Sometimes it i

[ovs-dev] [PATCH v3 1/1] datapath-windows : Correct the failure handling in OvsInitConntrack.

2024-06-16 Thread Wilson Peng via dev
From: Wilson Peng v2-v3 change: Remove the unneeded sanity check and just correct the failure when OvsNatInit is called failed. While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not Started after

[ovs-dev] [PATCH v3 1/1] datapath-windows : Correct the failure handling in OvsInitConntrack.

2024-06-16 Thread Wilson Peng via dev
From: Wilson Peng v2-v3 change: Remove the unneeded sanity check and just correct the failure when OvsNatInit is called failed. While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not Started after

[ovs-dev] [PATCH v3 1/1] datapath-windows : Correct the failure handling in OvsInitConntrack.

2024-06-15 Thread Wilson Peng via dev
From: Wilson Peng v2-v3 change: Remove the unneeded sanity check and just correct the failure when OvsNatInit is called failed. While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not Started after

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-06 Thread Wilson Peng via dev
Hi, Simon, Below list why it would go into deadlock, 1). 1st place OvsCtExecute_()->OvsProcessConntrackEntry(). entry->parent = parentEntry;(here parentEntry == entry) 2). After it return back from OvsProcessConntrackEntry(), it goes to the lines below,(Still on function OvsCtExecute_())

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-05 Thread Wilson Peng via dev
iginal conntrack entry (port1-->69) and lead to conntrack_entry parent be equal to itself. Only ftp/tftp traffic processing will have parent-child logic. Regards Wilson On Wed, Jun 5, 2024 at 8:32 PM Simon Horman wrote: > On Wed, Jun 05, 2024 at 01:35:52PM +0800, Wilson Peng v

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-05 Thread Wilson Peng via dev
iginal conntrack entry (port1-->69) and lead to conntrack_entry parent be equal to itself. Only ftp/tftp traffic processing will have parent-child logic. Regards Wilson On Wed, Jun 5, 2024 at 8:32 PM Simon Horman wrote: > On Wed, Jun 05, 2024 at 01:35:52PM +0800, Wilson Peng v

[ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-04 Thread Wilson Peng via dev
From: Wilson Peng It is found the TFTP reply packet with source port 69 will trigger host hang And the possible coredump. According to part 4 in TFTP RFC https://datatracker.ietf.org/doc/html/rfc1350, The TFTP reply packet should use a new source-port(not 69) to connect to Client. Upon this TFT

[ovs-dev] [PATCH v1 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-04 Thread Wilson Peng via dev
From: Wilson Peng It is found the TFTP reply packet with source port 69 will trigger host hang And the possible coredump. According to part 4 in TFTP RFC https://datatracker.ietf.org/doc/html/rfc1350, The TFTP reply packet should use a new source-port(not 69) to connect to Client. Upon this TFT

[ovs-dev] [PATCH v1 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-04 Thread Wilson Peng via dev
From: Wilson Peng It is found the TFTP reply packet with source port 69 will trigger host hang And the possible coredump. According to part 4 in TFTP RFC https://datatracker.ietf.org/doc/html/rfc1350, The TFTP reply packet should use a new source-port(not 69) to connect to Client. Upon this TFT

[ovs-dev] [PATCH v1 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

2024-06-04 Thread Wilson Peng via dev
From: Wilson Peng It is found the TFTP reply packet with source port 69 will trigger host hang And the possible coredump. According to part 4 in TFTP RFC https://datatracker.ietf.org/doc/html/rfc1350, The TFTP reply packet should use a new source-port(not 69) to connect to Client. Upon this TFT

[ovs-dev] [PATCH v1 1/1] datapath-windows : TFTP rep Avoid a deadlock when processing TFTP conntrack.

2024-06-04 Thread Wilson Peng via dev
From: Wilson Peng It is found the TFTP reply packet with source port 69 will trigger host hang And the possible coredump. According to part 4 in TFTP RFC https://datatracker.ietf.org/doc/html/rfc1350, The TFTP reply packet should use a new source-port(not 69) to connect to Client. Upon this TFT

[ovs-dev] [PATCH v2 1/1] datapath-windows : Add sanity check in OvsInitConntrack.

2024-05-26 Thread Wilson Peng via dev
From: Wilson Peng While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not started After the Windows node is rebooted on unexpected condition. It could be also observed a similar issue in local Ant

[ovs-dev] [PATCH v2 1/1] datapath-windows : Add sanity check in OvsInitConntrack.

2024-05-26 Thread Wilson Peng via dev
From: Wilson Peng While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not started After the Windows node is rebooted on unexpected condition. It could be also observed a similar issue in local Ant

[ovs-dev] [PATCH v1 1/1] datapath-windows : Add sanity check when starting OvsConntrackEntryCleaner thread

2024-05-25 Thread Wilson Peng via dev
From: Wilson Peng While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not started After the Windows node is rebooted on unexpected condition. It could be also observed a similar issue in loca

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread Wilson Peng via dev
Hi Simon, Thanks for the comments and I have uploaded new patch with the Updated notations in the patch. And also, I have updated the error log Combined with the debug diff in the related reported issue https://github.com/openvswitch/ovs-issues/issues/262 Regards Wilson From: dev on behalf of

Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: Check the condition to reset pseudo header checksum on Rx side

2022-11-08 Thread Wilson Peng via dev
Hi Alin, Thanks for the comments. V2 version is sent out and it corrects the name Off issue and rename the added variables. As this is bug fix, please help apply It back to branch 3.0-2.14 also. Regards Wilson From: dev on behalf of alinserd...@gmail.com Date: Wednesday, November 9, 2022 at 02

Re: [ovs-dev] [PATCH v2 1/1] lib: Correct the stats of packet_count and byte_count on Windows

2022-10-25 Thread Wilson Peng via dev
Hi, Ilya, Really thanks for the guidance and solution. New code diff could work on my testing. New v3 patch according to your comments is also submitted and the test result is also pasted in the v3 patch. Regards Wilson From: dev on behalf of Ilya Maximets Date: Tuesday, October 25, 2022 at

Re: [ovs-dev] [PATCH v1 1/1] lib: Correct the stats of packet_count and byte_count on Windows

2022-10-21 Thread Wilson Peng via dev
Hi, Ilya, Thanks for the comments. V2 patch is sent out for review. And It is also verified on Windows with the v2 patch. Regards Wilson From: Ilya Maximets Date: Thursday, October 20, 2022 at 19:31 To: Wilson Peng , d...@openvswitch.org Cc: i.maxim...@ovn.org , Wilson Peng Subject: Re: [o

Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: Add IPv6 conntrack ip fragment support on windows

2022-08-26 Thread Wilson Peng via dev
Alin, And help check the new fix patch below, it could be applied to Mater and branch-3.0. It could make Geneve V6 tunnel could be Working for checksum offload enabled case. [ovs-dev,ovs-dev,v1,1/1] datapath-windows: Correct Geneve IPV6 header checksum parameter https://patchwork.ozlabs.org/proj

[ovs-dev] [PATCH v1 1/1] datapath-windows: Update layers for multiple tunnels processing

2022-06-01 Thread Wilson Peng via dev
From: Wilson Peng While testing OVS-windows for multiple IPV6 Geneve tunnels on Windows2019VM, for the broadcast/mutlicast packets, it needs to flood out via configured multiple Geneve tunnels. Then in some flow pipeline processing, it may have at least two tunnel processing in OVS_ACTION_ATTR_S