/browse/FDP-608
Signed-off-by: Xavier Simonart
---
v2: updated based on nit from Paolo.
---
lib/conntrack.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 16e1c8bb5..655b87ba9 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
gt; Acked-by: Paolo Valerio
>
> Xavier Simonart writes:
>
> > In the following case:
> > union ct_addr {
> > unsigned int ipv4;
> > struct in6_addr ipv6;
> > };
> > union ct_addr zero_ip = {0};
> >
> > The ipv6 field m
/browse/FDP-608
Signed-off-by: Xavier Simonart
---
lib/conntrack.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 16e1c8bb5..ff4a17abc 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -2302,7 +2302,8 @@ find_addr(const struct
ing a non-existing check_debug function.
Fixes: 5b1476709d7c ("controller: only sample flow if Collector Set exists")
Signed-off-by: Xavier Simonart
---
controller/ovn-controller.c | 13 +
tests/ovn.at| 58 -
2 files changed
is already properly handling the resume.
This caused the following tests to fail sporadically:
- ovn-ic -- sync ISB status to INB
- propagate Port_Binding.up to NB and OVS.
Signed-off-by: Xavier Simonart
---
ic/ovn-ic.c | 2 +-
northd/ovn-northd.c | 1 +
2 files changed, 2 insertions
Flows were not properly removed when parent port of a container port
was deleted.
Signed-off-by: Xavier Simonart
---
controller/binding.c | 1 +
controller/physical.c | 3 ++-
tests/ovn.at | 34 ++
3 files changed, 37 insertions(+), 1 deletion
avoid using same name for a port and
for a switch).
Signed-off-by: Xavier Simonart
---
controller/binding.c | 12
tests/ovn.at | 12
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index c9658cb2a
If iface-id-ver was wrong and modified to a correct value,
the port was correctly claimed, but the flows were not installed
by I+P.
Signed-off-by: Xavier Simonart
---
controller/binding.c | 14 ++
tests/ovn.at | 2 ++
2 files changed, 16 insertions(+)
diff --git
while parent was postponed.
Signed-off-by: Xavier Simonart
---
controller/binding.c | 29 +++--
tests/ovn.at | 10 ++
2 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index 1499ceae1..0bef5dc42 100644
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2023-May/405107.html
Suggested-by: Priyankar Jain
Signed-off-by: Xavier Simonart
---
controller/binding.c | 12 +-
tests/ovn.at | 57
2 files changed, 68 insertions(+), 1
Comparing I+P flows versus flows after recompute highlighted a few
issues.
Xavier Simonart (5):
controller: Fix iface-id-ver handling.
controller: Nonvif related lports handling.
controller: Fix deletion of container parent port.
controller: Handle postponed ports claims.
controller
Hi Mark
Thanks for the review.
On Thu, Apr 4, 2024 at 10:25 PM Mark Michelson wrote:
> Hi Xavier, the patch looks good, but I have one question down below.
>
> On 3/26/24 07:56, Xavier Simonart wrote:
> > The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then
when the last logical port of
a datapath is deleted.
Signed-off-by: Xavier Simonart
---
tests/ovn-macros.at | 44
1 file changed, 44 insertions(+)
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
index ed93764d3..11377f616 100644
--- a/tests/ovn
So system testsuite will be recompiled when ovn-macro is changed.
Signed-off-by: Xavier Simonart
---
tests/automake.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/automake.mk b/tests/automake.mk
index f6f0f0e33..1fdc89835 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
Such macros can then be used for instance to create condition where
sb is seen as read-only by ovn-controller.
Signed-off-by: Xavier Simonart
---
tests/ovn-macros.at | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/tests/ovn-macros.at b/tests/ovn
Pinctrl is responsible of creating MAC_Bindings on peer router datapaths.
However, when sb was read-only, this did not happen.
This caused the test "neighbor update on same HV" to fail in a flaky way.
Signed-off-by: Xavier Simonart
---
v2: - Fix userspace tests
- Replac
This issue is happening for instance when running test
"ovn-controller - Chassis other_config".
Signed-off-by: Xavier Simonart
---
v2: Amend subject summary.
Rebase on origin/main.
---
controller/pinctrl.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
Hi
Thanks Ales for the feedback.
There is also a small change needed to make userspace tests to work as well
(as pointed out by ovs_robot).
I'll send a v2.
Thanks
Xavier
On Wed, Mar 20, 2024 at 12:11 PM Ales Musil wrote:
>
>
> On Wed, Mar 20, 2024 at 8:12 AM Xavier Simonart
Pinctrl is responsible of creating MAC_Bindings on peer router datapaths.
However, when sb was read-only, this did not happen.
This caused the test "neighbor update on same HV" to fail in a flaky way.
Signed-off-by: Xavier Simonart
---
controller/pinctrl.c | 2 +-
tests/ovn-macros
This issue is happening for instance when running test
"ovn-controller - Chassis other_config".
Signed-off-by: Xavier Simonart
---
controller/pinctrl.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index
Fixes: 65f9f010b426 ("tests: Check unit tests logs for errors.")
Signed-off-by: Xavier Simonart
---
tests/ovn-macros.at | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
index 3410afb74..5c69facd2 100644
--- a/tests/ovn-macros.at
+++ b
This patch uses the recently introduced macros defining openflow table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Handled Ales' comments (i.e. fix few remaining hard-coded numbers)
- Rebase on origin/main
v3: - Rebase on origin/main
---
tests/ovn-macros.at | 4 +
tests/ovn.at
There are only two changes:
- The AT_DATA content is not double quoted between square brackets.
- All '[' have been replaced by '[[' and all ']' by ']]'
This patch will be used in subsequent patch to remove hard-coded
table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Rebase on origin/main
Hi Mark
Sorry, drop this patch - missing the 1/2.
Will resend.
Thanks
Xavier
On Fri, Mar 15, 2024 at 7:03 PM Xavier Simonart wrote:
> This patch uses the recently introduced macros defining openflow table
> numbers.
>
> Signed-off-by: Xavier Simonart
>
> ---
> v2: - H
This patch uses the recently introduced macros defining openflow table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Handled Ales' comments (i.e. fix few remaining hard-coded numbers)
- Rebase on origin/main
v3: - Rebase on origin/main
---
tests/ovn-macros.at | 4 +
tests/ovn.at
On netdev datapath, when a ct element was cleaned, the cmap
could be shrinked, potentially causing some elements to be skipped
in the flush iteration.
Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Xavier Simonart
---
v2: - Updated commit message.
- Use comp
Thanks Mike and Ilya.
Sending v3 to handle comments from Mike and Ilya.
Thanks
Xavier
On Fri, Mar 1, 2024 at 7:48 PM Ilya Maximets wrote:
> On 2/26/24 11:49, Xavier Simonart wrote:
> > On netdev datapath, when a ct element was cleaned, the cmap
> > could be shrinked, potential
On netdev datapath, when a ct element was cleaned, the cmap
could be shrinked, potentially causing some elements to be skipped
in the flush iteration.
Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Xavier Simonart
---
v2: - Updated commit message.
- Use comp
Hi Numan
Thanks for the quick review.
On Wed, Feb 14, 2024 at 10:57 PM Numan Siddique wrote:
> On Wed, Feb 14, 2024 at 1:26 PM Xavier Simonart
> wrote:
> >
> > When (re)starting ovn-northd with an existing big nbdb,
> > the first iteration of northd was very slow a
When (re)starting ovn-northd with an existing big nbdb,
the first iteration of northd was very slow as trying to
push all flows in a single bucket.
Fixes: a623606052ea ("northd: Refactor lflow management into a separate
module.")
Signed-off-by: Xavier Simonart
---
northd/lflow
When a ct element was cleaned, the cmap could be shrinked, potentially
causing some elements to be skipped in the flush iteration.
Signed-off-by: Xavier Simonart
---
lib/conntrack.c | 14 -
lib/conntrack.h | 1 +
tests/system-traffic.at | 45
).
Signed-off-by: Xavier Simonart
---
tests/ovn-controller.at | 66 +--
tests/ovn-ic.at | 4 +-
tests/ovn-macros.at | 50 ++--
tests/ovn.at| 250 +---
4 files changed, 309 insertions(+), 61 deletions(-)
diff --git a/tests
- The test was sometimes failing if ofctrl was too slow to reconnect.
- Also, the test was not really verifying that flows were not installed
before expiry of wait-before-clear.
- Finally, use grep -F to avoid catching unexpected flows.
Signed-off-by: Xavier Simonart
---
tests/ovn-controller.at
Signed-off-by: Xavier Simonart
---
tests/ovn-controller.at | 14 --
tests/ovn-macros.at | 11 +++
tests/ovn.at| 8 +---
3 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at
index 3089aea9d
Signed-off-by: Xavier Simonart
---
tests/ovn-northd.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index 591ad5aad..33f71d673 100644
--- a/tests/ovn-northd.at
+++ b/tests/ovn-northd.at
@@ -10762,6 +10762,8 @@ ovn_start
# Test I-P for load
Signed-off-by: Xavier Simonart
---
tests/ovn-controller.at | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at
index 8dda85f53..3089aea9d 100644
--- a/tests/ovn-controller.at
+++ b/tests/ovn-controller.at
@@ -213,6 +213,13 @@ if test X
Flow parsing was failing and causing some lex errors
...eth.dst == 00:00:00:00:00:1 ...: Invalid numeric constant
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 6ed764ace..dd3cb4c66
Signed-off-by: Xavier Simonart
---
tests/ovn-controller-vtep.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at
index 462e858f1..d35dbbd05 100644
--- a/tests/ovn-controller-vtep.at
+++ b/tests/ovn-controller-vtep.at
.
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 291c6bca5..6ed764ace 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -16246,15 +16246,13 @@ sim_add hv1
as hv1
ovs
Test was using ovs-sbctl instead of ovn-sbctl for some
debugging purposes.
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 902dd3793..291c6bca5 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
Check unit tests logs for errors.
Fix multiple unit tests issues highlighted when checking logs for errors.
Xavier Simonart (10):
tests: Have tests fail when adding veth peer fails.
tests: Fix typos in tests.
tests: Fix flaky "options:requested-chassis ...".
tests: Fix
Before this patch, the test was seen as "skipped" if ip link
was failing.
Signed-off-by: Xavier Simonart
---
tests/system-common-macros.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 4bfc74582.
The test was confused as 192.168.0.1 was configured for DR-S3 port
(configured as a gateway-chassis hv4) as well as the encap_ip for hv1.
Hence packets which were supposed to be sent towards hv1 got sent
to hv4.
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 2 +-
1 file changed, 1
This issue was highlighted by frequent failures of "IPv6 prefix
delegation" test in Build_and_Test ovsrobot.
Signed-off-by: Xavier Simonart
---
controller/pinctrl.c | 38 +--
tests/system-common-macros.at | 38 ++-
There are only two changes:
- The AT_DATA content is not double quoted between square brackets.
- All '[' have been replaced by '[[' and all ']' by ']]'
This patch will be used in subsequent patch to remove hard-coded
table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Rebase on origin/main
This patch uses the recently introduced macros defining openflow table numbers.
Signed-off-by: Xavier Simonart
---
v2: - Handled Ales' comments (i.e. fix few remaining hard-coded numbers)
- Rebase on origin/main
---
tests/ovn-macros.at | 4 +
tests/ovn.at| 245
The macro had two issues:
- It never used the third (optional) argument (command such as trim_zeros).
- The default command was wrong, causing the test to always succeed.
Fixes: 9857ef8f61a0 ("tests: fixed multiple tests not properly waiting for
packets to be received")
Signed-off-
be able to change (most ?) table
numbers without impacting tests...
Thanks
Xavier
On Tue, Feb 6, 2024 at 5:42 PM Ales Musil wrote:
>
>
> On Tue, Feb 6, 2024 at 3:45 PM Xavier Simonart
> wrote:
>
>> This patch uses the recently introduced macros defining openflow table
>>
/ replace them by table=?? in the comments ?
- The test "action parsing" still has quite a few table numbers. I sent a
patch for (trying to) fix it.
For patches 1-26:
Acked-by: Xavier Simonart
Thanks
Xavier
On Tue, Feb 6, 2024 at 10:44 AM Ales Musil wrote:
> Add macro for OFTABLE_MA
There are only two changes:
- The AT_DATA content is not double quoted between square brackets.
- All '[' have been replaced by '[[' and all ']' by ']]'
This patch will be used in subsequent patch to remove hard-code table numbers
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 590
This patch uses the recently introduced macros defining openflow table numbers.
Signed-off-by: Xavier Simonart
---
tests/ovn-macros.at | 4 +
tests/ovn.at| 230 +++-
2 files changed, 122 insertions(+), 112 deletions(-)
diff --git a/tests/ovn
Xavier Simonart (2):
tests: Make test "action parsing" support expansion.
tests: Remove table numbers from test action parsing.
tests/ovn-macros.at | 4 +
tests/ovn.at| 662 ++--
2 files changed, 338 insertions(+), 328
436,7 +1436,7 @@ ct_snat(fd11::2);
> > has prereqs ip
> > ct_snat(192.168.1.2, 1-3000);
> > formats as ct_snat(192.168.1.2,1-3000);
> > -encodes as
> ct(commit,table=19,zone=NXM_NX_REG12[0..15],nat(src=192.168.1.2:1-3000))
> > +encodes as
> ct(
Hi Ales
The patch looks good to me, Thanks!
Acked-by: Xavier Simonart
Thanks
Xavier
On Thu, Jan 18, 2024 at 3:54 PM Ales Musil wrote:
> We are intentionally skipping ND NA with LLA as source.
> However, this doesn't work when the ND NA has LLA source,
> but the target address is g
_node (recompute_allowed=true, node=0x7ffd19ba5b70) at
lib/inc-proc-eng.c:503
13 engine_run (recompute_allowed=recompute_allowed@entry=true) at
lib/inc-proc-eng.c:528
14 0x0040ade2 in main (argc=, argv=) at
controller/ovn-controller.c:5709
Signed-off-by: Xavier Simonart
---
v2
Hi Dumitru
Thanks for the review and sorry for the delay.
On Fri, Nov 10, 2023 at 4:30 PM Dumitru Ceara wrote:
> On 11/3/23 10:38, Ales Musil wrote:
> > On Mon, Oct 30, 2023 at 9:46 AM Xavier Simonart
> wrote:
> >
> >> When a tunnel_key for a datapath was change
Hi Numan
Thanks for the review and the comments
On Thu, Dec 7, 2023 at 12:48 AM Numan Siddique wrote:
> On Mon, Nov 20, 2023 at 7:09 AM Ales Musil wrote:
> >
> > On Thu, Nov 2, 2023 at 3:58 PM Xavier Simonart
> wrote:
> >
> > > When a logical switch port w
-server.pid)])
> + on_exit "kill -CONT $(cat $1/ovsdb-server.pid)"
> }
> wake_up_ovsdb() {
>echo OVSDB $1 waking up
> --
> 2.39.3
>
> Except for the missing "Fixes" in the commit message, it looks good to me.
Acked-by: Xavier Simonart
Thanks
Xavier
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Dumitru
Thanks for the detailed review.
All comments make sense to me.
Thanks
Xavier
On Thu, Nov 30, 2023 at 9:13 PM Dumitru Ceara wrote:
> On 11/30/23 17:53, Xavier Simonart wrote:
> > The group_table and meter_table are initialized in ovn-controller, with
> n_ids = 0.
> >
artificially limit group and meter IDs
to 16bit.")
Signed-off-by: Xavier Simonart
---
v2: - Updated based on Dumitru's feedback i.e. call ovn_extend_table_clear
within ovn_extend_table_reinit
and do not call ovn_extend_table_reinit anymore from ofctrl
- Modified existing test case (ofc
Hi Dumitru
Thanks for the review.
On Wed, Nov 29, 2023 at 11:23 PM Dumitru Ceara wrote:
> On 11/29/23 16:45, Xavier Simonart wrote:
> > The group_table and meter_table are initialized in ovn-controller, with
> n_ids = 0.
> > Then they are re-initialized in ofctrl, with prop
artificially limit group and meter IDs
to 16bit.")
Signed-off-by: Xavier Simonart
---
controller/ovn-controller.c | 8
1 file changed, 8 insertions(+)
diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
index 44605eb4e..98d95b1f3 100644
--- a/controller/ovn-con
Hi Dumitru
Looks good to me, thanks.
Acked-by: Xavier Simonart
Thanks
Xavier
On Thu, Nov 16, 2023 at 2:54 PM Dumitru Ceara wrote:
>
> The test incorrectly assumed that "ovn-nbctl --wait=hv sync" will always
> send an OpenFlow barrier to ovs-vswitchd. That do
Hi Dumitru
Thanks for the patch. It clearly decreases the failure count.
I am afraid however it does not fix all potential issues.
My understanding is the following:
The test goal was to ensure ovs does not disconnect the connections on
inactivity probe.There are 4 connections with inactivity
Those extra flows are added when 1st localnet_learn_fdb is enabled.
They are however not removed if/when last localnet_learn_fdb got disabled.
Signed-off-by: Xavier Simonart
---
controller/binding.c| 12
controller/binding.h| 3 +++
controller/lflow.c | 28
if localnet_learn_fdb is
not
enabled.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2242830
Signed-off-by: Xavier Simonart
---
v2: ovn.at update: check PACKET_IN2 count from ovs-vswitchd.log
---
controller/lflow.c | 37 -
controller/lflow.h | 1 +
controller/lport.c
*** BLURB HERE ***
Xavier Simonart (2):
controller: FDB entries for localnet should not overwrite entries for
vifs
controller: avoid extra flows if localnet_learn_fdb is disabled
controller/binding.c | 12 ++
controller/binding.h | 3 +
controller/lflow.c
As otherwise ports might be down before the recompute and up after,
causing the test to fail. This error happened with
"LSP incremental processing" tests.
Signed-off-by: Xavier Simonart
---
tests/ovn-northd.at | 40
1 file changed, 24 inserti
The following tests:
- ipam
- ipam connectivity
- ipam to non-ipam
set the mac_prefix using nbctl.
However, it can happen that both northd and nbctl sets the mac_prefix
at the same time, which might result in the mac_prefix from nbctl to
be dropped.
Signed-off-by: Xavier Simonart
---
tests
Xavier Simonart (5):
tests: fixed "interconnection - static multicast" and "- IGMP/MLD
multicast"
tests: fixed system test "LR with SNAT fragmentation needed for
external server".
tests: fixed "ovn-nbctl - daemon retry connection"
tes
The test was sometimes failing if IPv6 packets were received.
Signed-off-by: Xavier Simonart
---
tests/system-ovn-kmod.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn-kmod.at b/tests/system-ovn-kmod.at
index 2492b9412..fb95ba881 100644
--- a/tests
"kill pid" does not wait for process to be terminated.
Wait for ovsdb-server termination before restarting it.
Signed-off-by: Xavier Simonart
---
tests/ovn-nbctl.at | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index 637d92bed..a855392fc 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -26366,10 +26366,13 @@ check ovn-nbctl lsp-add ts ts-lr3 \
wait_for_ports_up
ovn_as
We might get less recomputes than expected: e.g. Port_Binding->chassis and
Port_Binding->up might be received by northd within the same idl transaction.
Signed-off-by: Xavier Simonart
---
v2: check number of recomputes within bounds (min/max) instead of just a max.
v3: lflow and sync
Move the submodule to the tip of OVS branch3.2. This picks up:
- 0d0e95cd2ae6 ("ovsdb: Fix potential leak when making diff of conditions.")
fixing multiple memory leaks in OVN unit tests.
Signed-off-by: Xavier Simonart
---
ovs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
When a logical switch port was deleted and added back quickly, it could
happen that the lsp was never reported up
Signed-off-by: Xavier Simonart
---
northd/northd.c | 17 +++--
tests/ovn.at| 45 +
2 files changed, 56 insertions(+), 6
Those extra flows are added when 1st localnet_learn_fdb is enabled.
They are however not removed if/when last localnet_learn_fdb got disabled.
Signed-off-by: Xavier Simonart
---
controller/binding.c| 12
controller/binding.h| 3 +++
controller/lflow.c | 28
Xavier Simonart (2):
controller: FDB entries for localnet should not overwrite entries for
vifs
controller: avoid extra flows if localnet_learn_fdb is disabled
controller/binding.c | 12 ++
controller/binding.h | 3 +
controller/lflow.c | 51
if localnet_learn_fdb is
not
enabled.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2242830
Signed-off-by: Xavier Simonart
---
controller/lflow.c | 37 -
controller/lflow.h | 1 +
controller/lport.c | 22 ++-
controller/lport.h | 4
module to recompute.
This patch fixed issues two and three by moving the work of setting pb->chassis
and pb->up to the if-status module.
Signed-off-by: Xavier Simonart
---
v2: Avoid clearing iface if already deleted
v3: - handled Mark's feedback i.e.
- clear comment in claimed_lpo
Xavier Simonart (3):
binding: slight refactor if no local binding in consider_iface_release
binding: handle pb->chassis and pb->up from if-status module
Fix flows not removed in ha migration
controller/binding.c| 221 ++--
controller/bin
Signed-off-by: Xavier Simonart
---
controller/binding.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index bd48db621..cc316f390 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -1841,7 +1841,9
Signed-off-by: Xavier Simonart
---
controller/binding.c | 74 +---
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index 8020d052f..9a09b2074 100644
--- a/controller/binding.c
+++ b/controller
_node (recompute_allowed=true, node=0x7ffd19ba5b70) at
lib/inc-proc-eng.c:503
13 engine_run (recompute_allowed=recompute_allowed@entry=true) at
lib/inc-proc-eng.c:528
14 0x0040ade2 in main (argc=, argv=) at
controller/ovn-controller.c:5709
Signed-off-by: Xavier Simonart
---
v2: Fixed p
succeeded).
Test case has been adapted so that ct_zone recompute usually happens
before adding the sw0-lr0 port.
Signed-off-by: Xavier Simonart
---
v2: - updated comment as suggested by Dumitru
- rebased on origin/main
---
controller/ovn-controller.c | 5 +++--
tests/ovn.at
Hi Mark
Thanks for the review and the comments.
On Mon, Sep 25, 2023 at 9:48 PM Mark Michelson wrote:
>
> Hi Xavier,
>
> Functionality-wise, this looks good. I have a couple of small comments
> though.
>
> On 9/20/23 11:45, Xavier Simonart wrote:
> > Before this patc
This patch fixes the segfault but might cause a memory leak. I'll send a v2
There is also an (unrelated) flaky test ("Check default openflow
flows") which will be fixed later in a different patch
Thanks
Xavier
On Mon, Oct 23, 2023 at 12:04 PM Xavier Simonart wrote:
>
> W
_node (recompute_allowed=true, node=0x7ffd19ba5b70) at
lib/inc-proc-eng.c:503
13 engine_run (recompute_allowed=recompute_allowed@entry=true) at
lib/inc-proc-eng.c:528
14 0x0040ade2 in main (argc=, argv=) at
controller/ovn-controller.c:5709
Signed-off-by: Xavier Simonart
---
contr
-by: Xavier Simonart
---
ic/ovn-ic.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c
index e2023c2ba..bb91bad11 100644
--- a/ic/ovn-ic.c
+++ b/ic/ovn-ic.c
@@ -2216,10 +2216,19 @@ main(int argc, char *argv[])
ovn_db_run
be immediately
visible in different az.
- Expecting routes updates between az to happen immediately.
Reported-at: https://issues.redhat.com/browse/FDP-98
Signed-off-by: Xavier Simonart
---
tests/ovn-ic.at | 44 ++--
1 file changed, 26 insertions(+), 18
Signed-off-by: Xavier Simonart
---
ic/ovn-ic.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c
index e2023c2ba..eec466ec4 100644
--- a/ic/ovn-ic.c
+++ b/ic/ovn-ic.c
@@ -1630,13 +1630,18 @@ collect_lr_routes(struct ic_context *ctx,
const
Xavier Simonart (5):
tests: fixed multiple tests not properly waiting for packets to be
received
tests: do not start backup-northd by default
tests: fixed "LSP incremental processing"
tests: fixed "ipsec -- basic configuration"
tests: wait for all flows to be inst
We might get less recomputes than expected: e.g. Port_Binding->chassis and
Port_Binding->up might be received by northd within the same idl transaction.
Signed-off-by: Xavier Simonart
---
v2: check number of recomputes within bounds (min/max) instead of just a max
---
tests/ovn-northd.a
re failing
if more garp were received, and were slower than expected as always waiting for
a few additional packets).
Signed-off-by: Xavier Simonart
---
v2: rebased on origin/main
---
tests/ovn.at | 268 ---
1 file changed, 81 insertions(+), 187 deletion
Signed-off-by: Xavier Simonart
---
v2: rebased on origin/main
---
tests/ovn-ipsec.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn-ipsec.at b/tests/ovn-ipsec.at
index 10ef97878..f8df8d60e 100644
--- a/tests/ovn-ipsec.at
+++ b/tests/ovn-ipsec.at
@@ -48,11
-northd might hide a northd crash.
- Some tests expects northd.log (and not northd-backup.log) to contain some
specific strings. Having northd-backup running makes such tests to fail
flakily.
Signed-off-by: Xavier Simonart
---
v2: do not start northd-backup instead of fixing test cases 1 by 1
Remote output flows are setup when binding of remote port is received.
Hence those flows can be setup after ports have been reported up.
- 3 HVs, 1 VIFs/HV, 1 software GW, 1 LS
- 3 HVs, 3 LS, 3 lports/LS, 1 LR
- 2 HVs, 2 LRs connected via LS, gateway router
Signed-off-by: Xavier Simonart
Hi Mark, Dumitru
Thanks for the feedback
On Fri, Oct 6, 2023 at 12:57 PM Dumitru Ceara wrote:
>
> On 10/6/23 09:08, Dumitru Ceara wrote:
> > Hi Xavier, Mark,
> >
> > On 9/21/23 15:27, Xavier Simonart wrote:
> >> Hi Mark
> >>
> >> Tha
-server.c:417:9
11 0x517550 in main_loop ovsdb/ovsdb-server.c:224:9
12 0x512e80 in main ovsdb/ovsdb-server.c:507:5
13 0x7f9ecf675b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
Fixes: ef1da757f016 ("ovsdb: condition: Process condition changes
incrementally.")
Signed-off-
Hi
Thanks Ilya for the review.
Comments below. I'll send a v2
Xavier
On Wed, Sep 20, 2023 at 9:05 PM Ilya Maximets wrote:
> On 9/20/23 19:28, Xavier Simonart wrote:
> > OVN unit tests highlight this:
> >
> > ERROR: LeakSanitizer: detected memory leaks
> > Direc
1 - 100 of 335 matches
Mail list logo
