Re: [ovs-dev] 答复: 答复: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev stats

2020-04-30 Thread William Tu
On Wed, Apr 29, 2020 at 10:42:41PM -0700, Pravin Shelar wrote: > On Wed, Apr 29, 2020 at 11:07 AM William Tu wrote: > > > > On Tue, Apr 28, 2020 at 03:29:10AM +, 姜立东 wrote: > > > Hi William, > > > > > > > -/* Use kernel netdev's packet and byte counts since vport's > > > > counters >

Re: [ovs-dev] 答复: 答复: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev stats

2020-04-29 Thread Pravin Shelar
On Wed, Apr 29, 2020 at 11:07 AM William Tu wrote: > > On Tue, Apr 28, 2020 at 03:29:10AM +, 姜立东 wrote: > > Hi William, > > > > > -/* Use kernel netdev's packet and byte counts since vport's > > > counters > > > - * do not reflect packet counts on the wire when GSO, TSO or GRO

Re: [ovs-dev] 答复: 答复: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev stats

2020-04-29 Thread William Tu
On Tue, Apr 28, 2020 at 03:29:10AM +, 姜立东 wrote: > Hi William, > > > -/* Use kernel netdev's packet and byte counts since vport's > > counters > > - * do not reflect packet counts on the wire when GSO, TSO or GRO > > are > > - * enabled. */ > > Actually I think it s

[ovs-dev] 答复: 答复: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev stats

2020-04-27 Thread 姜立东 via dev
Hi William, > -/* Use kernel netdev's packet and byte counts since vport's counters > - * do not reflect packet counts on the wire when GSO, TSO or GRO are > - * enabled. */ Actually I think it should be moved to netdev_stats_from_ovs_vport_stats :), that explains what n