Re: [ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-15 Thread Eelco Chaudron
On 15 Apr 2021, at 15:25, David Marchand wrote: On Thu, Apr 15, 2021 at 1:45 PM Flavio Leitner wrote: +COVERAGE_DEFINE(ipv4_check_too_short); +COVERAGE_DEFINE(ipv4_check_length_error); +COVERAGE_DEFINE(ipv6_check_too_short); +COVERAGE_DEFINE(ipv6_check_length_error); The check keyword is

Re: [ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-15 Thread David Marchand
On Thu, Apr 15, 2021 at 1:12 PM Flavio Leitner wrote: > > > +static void > > > +dump_invalid_packet(struct dp_packet *packet, const char *reason) > > > +{ > > > +static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); > > > +struct ds ds = DS_EMPTY_INITIALIZER; > > > +size_t

Re: [ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-15 Thread David Marchand
On Thu, Apr 15, 2021 at 1:45 PM Flavio Leitner wrote: > > > > > +COVERAGE_DEFINE(ipv4_check_too_short); > > > > > +COVERAGE_DEFINE(ipv4_check_length_error); > > > > > +COVERAGE_DEFINE(ipv6_check_too_short); > > > > > +COVERAGE_DEFINE(ipv6_check_length_error); > > > > > > > > The check keyword is

Re: [ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-15 Thread Flavio Leitner
On Thu, Apr 15, 2021 at 01:32:06PM +0200, Eelco Chaudron wrote: > > > On 15 Apr 2021, at 13:12, Flavio Leitner wrote: > > > Hi Eelco, > > > > On Thu, Apr 15, 2021 at 10:07:24AM +0200, Eelco Chaudron wrote: > > > > > > > > > On 14 Apr 2021, at 17:50, David Marchand wrote: > > > > > > >

Re: [ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-15 Thread Eelco Chaudron
On 15 Apr 2021, at 13:12, Flavio Leitner wrote: Hi Eelco, On Thu, Apr 15, 2021 at 10:07:24AM +0200, Eelco Chaudron wrote: On 14 Apr 2021, at 17:50, David Marchand wrote: Skipping further processing of invalid IP packets helps avoid crashes but it does not help to figure out if the

Re: [ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-15 Thread Flavio Leitner
Hi Eelco, On Thu, Apr 15, 2021 at 10:07:24AM +0200, Eelco Chaudron wrote: > > > On 14 Apr 2021, at 17:50, David Marchand wrote: > > > Skipping further processing of invalid IP packets helps avoid crashes > > but it does not help to figure out if the malformed packets are still > > present on

Re: [ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-15 Thread Eelco Chaudron
On 14 Apr 2021, at 17:50, David Marchand wrote: Skipping further processing of invalid IP packets helps avoid crashes but it does not help to figure out if the malformed packets are still present on the network. Add coverage counters for IPv4 and IPv6 sanity checks so that we know there are

[ovs-dev] [PATCH] flow: Count and dump invalid IP packets.

2021-04-14 Thread David Marchand
Skipping further processing of invalid IP packets helps avoid crashes but it does not help to figure out if the malformed packets are still present on the network. Add coverage counters for IPv4 and IPv6 sanity checks so that we know there are some invalid packets. Dump such whole packets in