Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread Ilya Maximets
On 2/6/20 1:28 PM, David Marchand wrote: > On Thu, Feb 6, 2020 at 12:50 PM Flavio Leitner wrote: >> >> On Thu, Feb 06, 2020 at 11:48:58AM +0100, Ilya Maximets wrote: >>> On 2/5/20 7:01 PM, David Marchand wrote: On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: > > On Tue, Feb 04,

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread David Marchand
On Thu, Feb 6, 2020 at 12:50 PM Flavio Leitner wrote: > > On Thu, Feb 06, 2020 at 11:48:58AM +0100, Ilya Maximets wrote: > > On 2/5/20 7:01 PM, David Marchand wrote: > > > On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: > > >> > > >> On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 11:48:58AM +0100, Ilya Maximets wrote: > On 2/5/20 7:01 PM, David Marchand wrote: > > On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: > >> > >> On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand wrote: > >>> The check on TSO capability did not ensure ip checksum

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread Ilya Maximets
On 2/5/20 7:01 PM, David Marchand wrote: > On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: >> >> On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand wrote: >>> The check on TSO capability did not ensure ip checksum, tcp checksum and >>> TSO tx offloads were available which resulted in a

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: > > On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand wrote: > > The check on TSO capability did not ensure ip checksum, tcp checksum and > > TSO tx offloads were available which resulted in a port init failure > > (example below with a

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-05 Thread Flavio Leitner
On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand wrote: > The check on TSO capability did not ensure ip checksum, tcp checksum and > TSO tx offloads were available which resulted in a port init failure > (example below with a ena device): > > *2020-02-04T17:42:52.976Z|00084|dpdk|ERR|Ethdev

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-05 Thread Kevin Traynor
On 04/02/2020 21:28, David Marchand wrote: > The check on TSO capability did not ensure ip checksum, tcp checksum and > TSO tx offloads were available which resulted in a port init failure > (example below with a ena device): > > *2020-02-04T17:42:52.976Z|00084|dpdk|ERR|Ethdev port_id=0 requested

[ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-04 Thread David Marchand
The check on TSO capability did not ensure ip checksum, tcp checksum and TSO tx offloads were available which resulted in a port init failure (example below with a ena device): *2020-02-04T17:42:52.976Z|00084|dpdk|ERR|Ethdev port_id=0 requested Tx offloads 0x2a doesn't match Tx offloads capabiliti