Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

> > > > OK. > > > > I am going to sit on this for a few days and see whether anyone reports > > unusual issues. If nothing arises, I'll backport as far as reasonable. > > I backported to branch-2.9 and branch-2.8. Thanks, Ben. ___ dev mailing list

Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

On Fri, Apr 06, 2018 at 10:44:13AM -0700, Ben Pfaff wrote: > [also CCing Joe on the chance that he wants to comment] > > On Fri, Apr 06, 2018 at 09:34:38AM +, Jan Scheurich wrote: > > > -Original Message- > > > From: Ben Pfaff [mailto:b...@ovn.org] > > > Sent: Wednesday, 04 April,

Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

On 6 April 2018 at 10:44, Ben Pfaff wrote: > [also CCing Joe on the chance that he wants to comment] > > On Fri, Apr 06, 2018 at 09:34:38AM +, Jan Scheurich wrote: >> > -Original Message- >> > From: Ben Pfaff [mailto:b...@ovn.org] >> > Sent: Wednesday, 04 April, 2018

Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

[also CCing Joe on the chance that he wants to comment] On Fri, Apr 06, 2018 at 09:34:38AM +, Jan Scheurich wrote: > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Wednesday, 04 April, 2018 22:28 > > > > Oh, that's weird. It's as if I didn't read the patch.

Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, 04 April, 2018 22:28 > > Oh, that's weird. It's as if I didn't read the patch. Maybe I just > read some preliminary version in another thread. > > Anyway, you're totally right. I applied this to master.

Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

Oh, that's weird. It's as if I didn't read the patch. Maybe I just read some preliminary version in another thread. Anyway, you're totally right. I applied this to master. If you're seeing problems in another branch, let me know and I will backport. On Wed, Apr 04, 2018 at 07:03:43PM +,

Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

Thanks Ben, I hope what my patch does is precisely what you suggest. I had the same thoughts when I had a closer look at the code. Regards, Jan > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, 04 April, 2018 19:20 > To: Jan Scheurich

Re: [ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

On Wed, Apr 04, 2018 at 01:26:02PM +0200, Jan Scheurich wrote: > In the current implementation the dump_seq of a new datapath flow ukey > is set to seq_read(udpif->dump_seq). This implies that any revalidation > during the current dump_seq period (up to 500 ms) is skipped. > > This can trigger

[ovs-dev] [PATCH] ofproto-dpif: Init ukey->dump_seq to zero

In the current implementation the dump_seq of a new datapath flow ukey is set to seq_read(udpif->dump_seq). This implies that any revalidation during the current dump_seq period (up to 500 ms) is skipped. This can trigger incorrect behavior, for example when the the creation of datapath flow