Re: [ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-02-16 Thread William Tu
I see, thanks. On Tue, Feb 16, 2021 at 12:52 PM Ben Pfaff wrote: > > On Fri, Feb 12, 2021 at 11:15:46AM -0800, William Tu wrote: > > I'm confused with what l2_pad_size is. > > I thought it's between L2 and L3 header, there is a 2-byte padding to > > make it 16-byte alignment. But it doesn't look

Re: [ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-02-16 Thread Ben Pfaff
On Fri, Feb 12, 2021 at 11:15:46AM -0800, William Tu wrote: > I'm confused with what l2_pad_size is. > I thought it's between L2 and L3 header, there is a 2-byte padding to > make it 16-byte alignment. But it doesn't look like that. Ethernet has a 64-byte minimum packet length. l2_pad_size is the

Re: [ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-02-12 Thread William Tu
On Tue, Feb 2, 2021 at 10:00 AM Ben Pfaff wrote: > > On Tue, Feb 02, 2021 at 05:11:09PM +0100, Ilya Maximets wrote: > > On 1/21/21 11:33 PM, Ben Pfaff wrote: > > > The calculation in tcp_reader_run() failed to account for L2 padding. > > > This fixes the problem, by moving the existing function >

Re: [ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-02-02 Thread Ben Pfaff
On Tue, Feb 02, 2021 at 05:11:09PM +0100, Ilya Maximets wrote: > On 1/21/21 11:33 PM, Ben Pfaff wrote: > > The calculation in tcp_reader_run() failed to account for L2 padding. > > This fixes the problem, by moving the existing function > > tcp_payload_length() from a conntrack private header file

Re: [ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-02-02 Thread Ilya Maximets
On 1/21/21 11:33 PM, Ben Pfaff wrote: > The calculation in tcp_reader_run() failed to account for L2 padding. > This fixes the problem, by moving the existing function > tcp_payload_length() from a conntrack private header file into > dp-packet.h and renaming it to suit the dp_packet style. > > Si

[ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-01-21 Thread Ben Pfaff
The calculation in tcp_reader_run() failed to account for L2 padding. This fixes the problem, by moving the existing function tcp_payload_length() from a conntrack private header file into dp-packet.h and renaming it to suit the dp_packet style. Signed-off-by: Ben Pfaff --- lib/conntrack-private