Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-31 Thread Ilya Maximets
On 5/30/23 22:05, Simon Horman wrote: > On Fri, May 26, 2023 at 03:11:01PM +0200, Ilya Maximets wrote: >> On 5/25/23 15:20, Simon Horman wrote: >>> On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: Many OVSDB tests are not checking the server log for warnings or errors. Some

Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-30 Thread Simon Horman
On Fri, May 26, 2023 at 03:11:01PM +0200, Ilya Maximets wrote: > On 5/25/23 15:20, Simon Horman wrote: > > On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: > >> Many OVSDB tests are not checking the server log for warnings or > >> errors. Some are not even using the log file. It's m

Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-26 Thread Ilya Maximets
On 5/25/23 15:20, Simon Horman wrote: > On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: >> Many OVSDB tests are not checking the server log for warnings or >> errors. Some are not even using the log file. It's mostly OK as we're >> usually checking the user-visible behavior. But i

Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-25 Thread Simon Horman
On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: > Many OVSDB tests are not checking the server log for warnings or > errors. Some are not even using the log file. It's mostly OK as we're > usually checking the user-visible behavior. But it would also be nice > to detect some inter

[ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-17 Thread Ilya Maximets
Many OVSDB tests are not checking the server log for warnings or errors. Some are not even using the log file. It's mostly OK as we're usually checking the user-visible behavior. But it would also be nice to detect some internal warnings if there are some. Moving the OVSDB_SERVER_SHUTDOWN macro