[ovs-dev] [PATCH ovn] controller: split mg action in table=39 and 40 to fit kernel netlink buffer size

2023-09-21 Thread Lorenzo Bianconi
Introduce the capability to split multicast group openflow actions created in consider_mc_group routine in multiple buffers if the single buffer size is over netlink buffer size limits. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2232152 Signed-off-by: Lorenzo Bianconi --- controlle

Re: [ovs-dev] [PATCH ovn] controller: split mg action in table=39 and 40 to fit kernel netlink buffer size

2023-09-26 Thread Mark Michelson
Hi Lorenzo, Overall, I think this has the beginnings of a good solution. There are a few high-level problems. 1) I think MC_OFPACTS_MAX_MSG_SIZE is too low. The maximum size for an OpenFlow message is 65535, and the netlink MAX_ACTIONS_BUFSIZE is 32768. Even if we wanted to be conservative, I

Re: [ovs-dev] [PATCH ovn] controller: split mg action in table=39 and 40 to fit kernel netlink buffer size

2023-09-27 Thread Dumitru Ceara
On 9/26/23 19:26, Mark Michelson wrote: > > 2) I don't think a controller action is necessary. The controller action > sets some registers and then resubmits to table 40 or 41. I think this > could be done directly in OpenFlow instead. Hi Mark, I didn't review the patch at all yet so I'll just c

Re: [ovs-dev] [PATCH ovn] controller: split mg action in table=39 and 40 to fit kernel netlink buffer size

2023-09-27 Thread Ihar Hrachyshka
On Wed, Sep 27, 2023 at 7:16 AM Dumitru Ceara wrote: > On 9/26/23 19:26, Mark Michelson wrote: > > > > 2) I don't think a controller action is necessary. The controller action > > sets some registers and then resubmits to table 40 or 41. I think this > > could be done directly in OpenFlow instead

Re: [ovs-dev] [PATCH ovn] controller: split mg action in table=39 and 40 to fit kernel netlink buffer size

2023-09-27 Thread Mark Michelson
On 9/27/23 07:15, Dumitru Ceara wrote: On 9/26/23 19:26, Mark Michelson wrote: 2) I don't think a controller action is necessary. The controller action sets some registers and then resubmits to table 40 or 41. I think this could be done directly in OpenFlow instead. Hi Mark, I didn't review

Re: [ovs-dev] [PATCH ovn] controller: split mg action in table=39 and 40 to fit kernel netlink buffer size

2023-09-27 Thread Dumitru Ceara
On 9/27/23 17:33, Mark Michelson wrote: > On 9/27/23 07:15, Dumitru Ceara wrote: >> On 9/26/23 19:26, Mark Michelson wrote: >>> >>> 2) I don't think a controller action is necessary. The controller action >>> sets some registers and then resubmits to table 40 or 41. I think this >>> could be done d