Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-30 Thread Dumitru Ceara
On 6/28/21 8:05 AM, Han Zhou wrote: > On Fri, Jun 25, 2021 at 2:38 PM Numan Siddique wrote: >> >> On Fri, Jun 25, 2021 at 2:53 PM Han Zhou wrote: >>> >>> On Fri, Jun 25, 2021 at 4:50 AM Dumitru Ceara wrote: It's valid that port_groups contain non-vif ports, they can actually

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-28 Thread Han Zhou
On Fri, Jun 25, 2021 at 2:38 PM Numan Siddique wrote: > > On Fri, Jun 25, 2021 at 2:53 PM Han Zhou wrote: > > > > On Fri, Jun 25, 2021 at 4:50 AM Dumitru Ceara wrote: > > > > > > It's valid that port_groups contain non-vif ports, they can actually > > > contain any type of logical_switch_port.

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Numan Siddique
On Fri, Jun 25, 2021 at 2:53 PM Han Zhou wrote: > > On Fri, Jun 25, 2021 at 4:50 AM Dumitru Ceara wrote: > > > > It's valid that port_groups contain non-vif ports, they can actually > > contain any type of logical_switch_port. > > > > Also, there's no need to allocate a new sset containing the

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Han Zhou
On Fri, Jun 25, 2021 at 4:50 AM Dumitru Ceara wrote: > > It's valid that port_groups contain non-vif ports, they can actually > contain any type of logical_switch_port. > > Also, there's no need to allocate a new sset containing the local ports' > names every time the I-P engine processes a

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Dumitru Ceara
On 6/25/21 4:36 PM, Numan Siddique wrote: > On Fri, Jun 25, 2021 at 7:51 AM Dumitru Ceara wrote: >> >> It's valid that port_groups contain non-vif ports, they can actually >> contain any type of logical_switch_port. >> >> Also, there's no need to allocate a new sset containing the local ports' >>

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Numan Siddique
On Fri, Jun 25, 2021 at 7:51 AM Dumitru Ceara wrote: > > It's valid that port_groups contain non-vif ports, they can actually > contain any type of logical_switch_port. > > Also, there's no need to allocate a new sset containing the local ports' > names every time the I-P engine processes a

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Dumitru Ceara
On 6/25/21 1:50 PM, Dumitru Ceara wrote: > It's valid that port_groups contain non-vif ports, they can actually > contain any type of logical_switch_port. > > Also, there's no need to allocate a new sset containing the local ports' > names every time the I-P engine processes a change, we can

[ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Dumitru Ceara
It's valid that port_groups contain non-vif ports, they can actually contain any type of logical_switch_port. Also, there's no need to allocate a new sset containing the local ports' names every time the I-P engine processes a change, we can maintain a sset and incrementally update it when port