[ovs-dev] [PATCH ovn 1/2] Fix pidfile_is_running when $cmd is not passed

[ -z $string ] needs double quotes to handle zero-length strings properly. Fixes: 09dc4866fd32 ("Handle re-used pids in pidfile_is_running") Signed-off-by: Ihar Hrachyshka --- utilities/ovn-ctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-ctl b/utilities/ovn-

Re: [ovs-dev] [PATCH ovn 1/2] Fix pidfile_is_running when $cmd is not passed

Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 137 characters long (recommended limit is 79) #24 FILE: utilities/ovn-ctl:4

Re: [ovs-dev] [PATCH ovn 1/2] Fix pidfile_is_running when $cmd is not passed

On Mon, Jun 13, 2022 at 3:00 PM Ihar Hrachyshka wrote: > > [ -z $string ] needs double quotes to handle zero-length strings > properly. > > Fixes: 09dc4866fd32 ("Handle re-used pids in pidfile_is_running") > Signed-off-by: Ihar Hrachyshka I still see the same issue with this patch. If I remove