Hi Numan,
Uploaded v5 patch making the column as weak reference and fixing the tests with
—sync=sb.
V4 patch was already ignoring a NAT rule if gateway_port is not set and LR has
multiple DGP.
The behaviour is same in v5.
Will send out a patch to determine gateway port for a NAT rule when it
On Thu, Mar 31, 2022, 8:32 AM Abhiram Sangana
wrote:
> Hi Numan,
>
> Is it ok if we make the “gateway_port” column optional in a subsequent
> patch?
> Will send out a v5 patch that addresses other comments.
>
I'm fine if you can
- make the column as weak reference
- and if gateway_port is not
Hi Numan,
Is it ok if we make the “gateway_port” column optional in a subsequent patch?
Will send out a v5 patch that addresses other comments.
Thanks,
Abhiram Sangana
> On 30 Mar 2022, at 19:32, Numan Siddique wrote:
>
> On Wed, Mar 30, 2022 at 1:41 PM Abhiram Sangana
> wrote:
>>
>> Hi
On Wed, Mar 30, 2022 at 1:41 PM Abhiram Sangana
wrote:
>
> Hi Numan,
>
> Thanks for reviewing the patch
>
> On 30 Mar 2022, at 16:55, Numan Siddique
> mailto:num...@ovn.org>> wrote:
>
> I think the "gateway_port" column can be a weak reference to
> "Logical_Router_Port".
> Otherwise CMS cannot
Hi Numan,
Thanks for reviewing the patch.
> On 30 Mar 2022, at 16:55, Numan Siddique wrote:
>
>
> I think the "gateway_port" column can be a weak reference to
> "Logical_Router_Port".
> Otherwise CMS cannot delete the logical router port unless it clears
> this column or deletes the NAT row.
Hi Numan,
Thanks for reviewing the patch
On 30 Mar 2022, at 16:55, Numan Siddique
mailto:num...@ovn.org>> wrote:
I think the "gateway_port" column can be a weak reference to
"Logical_Router_Port".
Otherwise CMS cannot delete the logical router port unless it clears
this column or deletes the
"
On Thu, Mar 24, 2022 at 12:14 PM Abhiram Sangana
wrote:
>
> Currently, if multiple distributed gateway ports (DGP) are configured
> on a logical router, NAT is disabled as part of commit 15348b7
> (northd: Multiple distributed gateway port support.)
>
> This patch adds a new column called
References: <20220324161239.61857-1-sangana.abhi...@nutanix.com>
Bleep bloop. Greetings Abhiram Sangana, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 275
Currently, if multiple distributed gateway ports (DGP) are configured
on a logical router, NAT is disabled as part of commit 15348b7
(northd: Multiple distributed gateway port support.)
This patch adds a new column called "gateway_port" in NAT table that
references a distributed gateway port in
