Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2023-03-06 Thread Alin Serdean
Applied on master and backported until 2.9 Thank you! > On 9 Nov 2022, at 04:32, Wilson Peng wrote: > > From: Wilson Peng > > In the recent Antrea project testing, some port could not be created > on Windows. > > When doing debug, our team found there is one case happening when multiple >

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread Wilson Peng via dev
of Simon Horman Date: Wednesday, November 9, 2022 at 02:55 To: Wilson Peng Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows !! External Email On Thu, Oct 13, 2022 at 10:50:51PM +0800, Wilson Peng wrote

[ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread Wilson Peng
From: Wilson Peng In the recent Antrea project testing, some port could not be created on Windows. When doing debug, our team found there is one case happening when multiple ports are waiting for be created with correct port number. Some system type port will be created netdev successfully and

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread Simon Horman
On Thu, Oct 13, 2022 at 10:50:51PM +0800, Wilson Peng wrote: ... > @@ -165,8 +166,19 @@ netdev_windows_system_construct(struct netdev *netdev_) > if (strcmp(netdev_get_type(>up), "internal") && ret) { > return ret; > } > + > ofpbuf_delete(buf); > > +/* if ovs-type

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread alinserdean
- From: dev On Behalf Of Wilson Peng Sent: Thursday, October 13, 2022 5:51 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows From: Wilson Peng In the recent Antrea project testing, some port could

[ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-10-13 Thread Wilson Peng
From: Wilson Peng In the recent Antrea project testing, some port could not be created on Windows. When doing debug, our team found there is one case happening when multiple ports are waiting for be created with correct port number. Some system type port will be created netdev successfully and

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-10-13 Thread 0-day Robot
Bleep bloop. Greetings Wilson Peng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate spacing in pointer declaration #46 FILE: lib/netdev-windows.c:173:

[ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-10-13 Thread Wilson Peng
From: Wilson Peng In the recent Antrea project testing, some port could not be created on Windows. When doing debug, our team found there is one case happening when multiple ports are waiting for be created with correct port number. Some system type port will be created netdev successfully and

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-10-13 Thread 0-day Robot
Bleep bloop. Greetings Wilson Peng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 94 characters long (recommended limit is 79) #45 FILE:

[ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-10-13 Thread Wilson Peng
From: Wilson Peng In the recent Antrea project testing, some port could not be created on Windows. When doing debug, our team found there is one case happening when multiple ports are waiting for be created with correct port number. Some system type port will be created netdev successfully and