[ovs-dev] [PATCH v12 5/8] file, monitor: Add null pointer assertions for old and new ovsdb_rows

2023-06-13 Thread James Raphael Tiovalen
This commit adds non-null pointer assertions in some code that performs some decisions based on old and new input ovsdb_rows. Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman --- ovsdb/file.c| 2 ++ ovsdb/monitor.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) di

Re: [ovs-dev] [PATCH v12 5/8] file, monitor: Add null pointer assertions for old and new ovsdb_rows

2023-07-11 Thread Eelco Chaudron
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: > This commit adds non-null pointer assertions in some code that performs > some decisions based on old and new input ovsdb_rows. > > Signed-off-by: James Raphael Tiovalen > Reviewed-by: Simon Horman What about error messages/argument c

Re: [ovs-dev] [PATCH v12 5/8] file, monitor: Add null pointer assertions for old and new ovsdb_rows

2023-07-11 Thread Ilya Maximets
On 7/11/23 12:17, Eelco Chaudron wrote: > > > On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: > >> This commit adds non-null pointer assertions in some code that performs >> some decisions based on old and new input ovsdb_rows. >> >> Signed-off-by: James Raphael Tiovalen >> Reviewed-by:

Re: [ovs-dev] [PATCH v12 5/8] file, monitor: Add null pointer assertions for old and new ovsdb_rows

2023-07-11 Thread Eelco Chaudron
On 11 Jul 2023, at 16:38, Ilya Maximets wrote: > On 7/11/23 12:17, Eelco Chaudron wrote: >> >> >> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: >> >>> This commit adds non-null pointer assertions in some code that performs >>> some decisions based on old and new input ovsdb_rows. >>>

Re: [ovs-dev] [PATCH v12 5/8] file, monitor: Add null pointer assertions for old and new ovsdb_rows

2023-07-11 Thread Ilya Maximets
On 7/11/23 17:08, Eelco Chaudron wrote: > > > On 11 Jul 2023, at 16:38, Ilya Maximets wrote: > >> On 7/11/23 12:17, Eelco Chaudron wrote: >>> >>> >>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: >>> This commit adds non-null pointer assertions in some code that performs some