Re: [ovs-dev] [PATCH v3 09/17] hmap: use short version of safe loops if possible

2022-02-25 Thread Dumitru Ceara
On 2/16/22 15:27, Adrian Moreno wrote: > Using SHORT version of the *_SAFE loops makes the code cleaner and less > error prone. So, use the SHORT version and remove the extra variable > when possible for hmap and all its derived types. > > In order to be able to use both long and short versions

Re: [ovs-dev] [PATCH v3 09/17] hmap: use short version of safe loops if possible

2022-02-16 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #87 FILE: include/openvswitch/hmap.h:185:

[ovs-dev] [PATCH v3 09/17] hmap: use short version of safe loops if possible

2022-02-16 Thread Adrian Moreno
Using SHORT version of the *_SAFE loops makes the code cleaner and less error prone. So, use the SHORT version and remove the extra variable when possible for hmap and all its derived types. In order to be able to use both long and short versions without changing the name of the macro for all the