Re: [ovs-dev] [PATCH v3 1/6] Add a new OVS action check_pkt_larger

2019-04-20 Thread Ben Pfaff
On Fri, Apr 19, 2019 at 11:06:02PM +0530, Numan Siddique wrote: > On Fri, Apr 19, 2019 at 4:58 AM Gregory Rose wrote: > > > > > On 4/18/2019 2:48 PM, Ben Pfaff wrote: > > > On Tue, Apr 16, 2019 at 01:23:37PM +0530, nusid...@redhat.com wrote: > > >> From: Numan Siddique > > >> > > >> This patch

Re: [ovs-dev] [PATCH v3 1/6] Add a new OVS action check_pkt_larger

2019-04-19 Thread Numan Siddique
Thank you Ben and Greg for the reviews. Please see few comments inline below Thanks Numan On Fri, Apr 19, 2019 at 4:58 AM Gregory Rose wrote: > > On 4/18/2019 2:48 PM, Ben Pfaff wrote: > > On Tue, Apr 16, 2019 at 01:23:37PM +0530, nusid...@redhat.com wrote: > >> From: Numan Siddique > >> >

Re: [ovs-dev] [PATCH v3 1/6] Add a new OVS action check_pkt_larger

2019-04-18 Thread Gregory Rose
On 4/18/2019 2:48 PM, Ben Pfaff wrote: On Tue, Apr 16, 2019 at 01:23:37PM +0530, nusid...@redhat.com wrote: From: Numan Siddique This patch adds a new action 'check_pkt_larger' which checks if the packet is larger than the given size and stores the result in the destination register. Thanks

Re: [ovs-dev] [PATCH v3 1/6] Add a new OVS action check_pkt_larger

2019-04-18 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 01:23:37PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new action 'check_pkt_larger' which checks if the > packet is larger than the given size and stores the result in the > destination register. Thanks for the revision! I'm taking a

[ovs-dev] [PATCH v3 1/6] Add a new OVS action check_pkt_larger

2019-04-16 Thread nusiddiq
From: Numan Siddique This patch adds a new action 'check_pkt_larger' which checks if the packet is larger than the given size and stores the result in the destination register. Usage: check_pkt_larger(len)->REGISTER Eg. match=...,actions=check_pkt_larger(1442)->NXM_NX_REG0[0],next; This patch