Re: [ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 04:01:12PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote: > >> Developers wishing to add checks to checkpatch sift through an adhoc mess, > >> currently. The process goes something like: > >> 1. Figure ou

Re: [ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Aaron Conole
Ben Pfaff writes: > On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote: >> Developers wishing to add checks to checkpatch sift through an adhoc mess, >> currently. The process goes something like: >> 1. Figure out what to test in the patch >> 2. Write some code, quickly, that checks fo

Re: [ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote: > Developers wishing to add checks to checkpatch sift through an adhoc mess, > currently. The process goes something like: > 1. Figure out what to test in the patch > 2. Write some code, quickly, that checks for that condition > 3. Look

[ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Aaron Conole
Developers wishing to add checks to checkpatch sift through an adhoc mess, currently. The process goes something like: 1. Figure out what to test in the patch 2. Write some code, quickly, that checks for that condition 3. Look through the statemachine to find where the check should go 4. ignore pa