Re: [ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-28 Thread Dumitru Ceara
On 9/21/20 9:01 AM, Han Zhou wrote: > > > On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara > wrote: >> >> Avoid reparsing the *_force_snat_ip addresses for every logical router > port. >> These addresses are defined once for the whole router. >> > > The commit message is

Re: [ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-28 Thread Dumitru Ceara
On 9/22/20 8:11 AM, Numan Siddique wrote: > > > On Mon, Sep 21, 2020 at 12:32 PM Han Zhou > wrote: > > On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara > wrote: > > > > Avoid reparsing the *_force_snat_ip addresses for every logical

Re: [ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-21 Thread Numan Siddique
On Mon, Sep 21, 2020 at 12:32 PM Han Zhou wrote: > On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara wrote: > > > > Avoid reparsing the *_force_snat_ip addresses for every logical router > port. > > These addresses are defined once for the whole router. > > > > The commit message is a little mislead

Re: [ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-21 Thread Han Zhou
On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara wrote: > > Avoid reparsing the *_force_snat_ip addresses for every logical router port. > These addresses are defined once for the whole router. > The commit message is a little misleading. Originally it wasn't reparsing for every logical router port.

[ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-17 Thread Dumitru Ceara
Avoid reparsing the *_force_snat_ip addresses for every logical router port. These addresses are defined once for the whole router. Signed-off-by: Dumitru Ceara --- lib/ovn-util.c |6 lib/ovn-util.h |2 + northd/ovn-northd.c | 69 -