Re: [ovs-dev] [PATCH v5] tests/mfex: Improve pcap script for mfex tests.

2022-05-25 Thread Amber, Kumar
Hi Cian, Eelco Thanks for the suggestions. Replies inline. > -Original Message- > From: Ferriter, Cian > Sent: Wednesday, May 25, 2022 9:09 PM > To: Eelco Chaudron ; Amber, Kumar > > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian > ; Van Haaren, Harry > Subject: RE: [PATC

Re: [ovs-dev] [PATCH v5] tests/mfex: Improve pcap script for mfex tests.

2022-05-25 Thread Ferriter, Cian
> >>> diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index > >>> 7d2715c4a..ac83e5a57 100644 > >>> --- a/tests/system-dpdk.at > >>> +++ b/tests/system-dpdk.at > >>> @@ -226,17 +226,19 @@ dnl > >>> -- > >>> > >>> d

Re: [ovs-dev] [PATCH v5] tests/mfex: Improve pcap script for mfex tests.

2022-05-25 Thread Eelco Chaudron
On 25 May 2022, at 12:59, Amber, Kumar wrote: > Hi Eelco, > > Please find replies inline. > >>> +# Relative path for the pcap file location. >>> path = str(sys.argv[1]) + "/pcap/fuzzy.pcap" >> >> Would it be better to supply the full file name, rather than a fixed file >> name >> and directory

Re: [ovs-dev] [PATCH v5] tests/mfex: Improve pcap script for mfex tests.

2022-05-25 Thread Amber, Kumar
Hi Eelco, Please find replies inline. > > +# Relative path for the pcap file location. > > path = str(sys.argv[1]) + "/pcap/fuzzy.pcap" > > Would it be better to supply the full file name, rather than a fixed file name > and directory being concatenated? > Sure, would make the script usable t

Re: [ovs-dev] [PATCH v5] tests/mfex: Improve pcap script for mfex tests.

2022-05-25 Thread Eelco Chaudron
On 24 May 2022, at 14:10, Kumar Amber wrote: > The mfex pcap generation script is improved for varied length > traffic and also removes the hard coded mfex_pcap and instead uses > the script itself to generate complex traffic patterns for testing. > > Signed-off-by: Kumar Amber > Acked-by: Cian

[ovs-dev] [PATCH v5] tests/mfex: Improve pcap script for mfex tests.

2022-05-24 Thread Kumar Amber
The mfex pcap generation script is improved for varied length traffic and also removes the hard coded mfex_pcap and instead uses the script itself to generate complex traffic patterns for testing. Signed-off-by: Kumar Amber Acked-by: Cian Ferriter --- v5: - fix mac and ip address generation. v4