> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, June 30, 2021 11:07 AM
> To: Van Haaren, Harry
> Cc: Flavio Leitner ; Amber, Kumar ;
> d...@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to sele
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, June 30, 2021 10:52 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; d...@openvswitch.org;
> i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select
>
Eelco Chaudron
>>>> Sent: Tuesday, June 29, 2021 1:38 PM
>>>> To: Amber, Kumar
>>>> Cc: d...@openvswitch.org; i.maxim...@ovn.org
>>>> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to
>>>> select the
>> best
>>
dron
>>>> Sent: Tuesday, June 29, 2021 1:38 PM
>>>> To: Amber, Kumar
>>>> Cc: d...@openvswitch.org; i.maxim...@ovn.org
>>>> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to
>>>> select the
>> best
>>
> -Original Message-
> From: Flavio Leitner
> Sent: Tuesday, June 29, 2021 7:11 PM
> To: Van Haaren, Harry
> Cc: Eelco Chaudron ; Amber, Kumar
> ; d...@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to sele
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, June 30, 2021 10:18 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; d...@openvswitch.org;
> i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select
>
On 29 Jun 2021, at 18:32, Van Haaren, Harry wrote:
>> -Original Message-
>> From: dev On Behalf Of Eelco Chaudron
>> Sent: Tuesday, June 29, 2021 1:38 PM
>> To: Amber, Kumar
>> Cc: d...@openvswitch.org; i.maxim...@ovn.org
>> Subject: Re: [ovs-de
bject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select
> > the best
> > mfex function
> >
> > More comments below. FYI I’m only reviewing right now, no testing.
>
> Sure, thanks for reviews.
>
> > On 17 Jun 2021, at 18:27, Kumar Amber wrot
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Thursday, June 24, 2021 2:20 PM
> > To: Amber, Kumar ; d...@openvswitch.org; Van
> > Haaren, Harry
> > Cc: Amber, Kumar ; i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v4 03/12]
> -Original Message-
> From: dev On Behalf Of Eelco Chaudron
> Sent: Tuesday, June 29, 2021 1:38 PM
> To: Amber, Kumar
> Cc: d...@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select
> the best
>
More comments below. FYI I’m only reviewing right now, no testing.
//Eelco
On 17 Jun 2021, at 18:27, Kumar Amber wrote:
> The study function runs all the available implementations
> of miniflow_extract and makes a choice whose hitmask has
> maximum hits and sets the mfex to that function.
>
>
Hi Flavio,
Thanks again and my replies are inline.
> -Original Message-
> From: Flavio Leitner
> Sent: Monday, June 28, 2021 8:22 AM
> To: Amber, Kumar
> Cc: d...@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study
Hi,
On Thu, Jun 17, 2021 at 09:57:45PM +0530, Kumar Amber wrote:
> The study function runs all the available implementations
> of miniflow_extract and makes a choice whose hitmask has
> maximum hits and sets the mfex to that function.
>
> Study can be run at runtime using the following
Hi Ian ,
Thanks Again, replies are inline.
> > @@ -114,6 +114,7 @@ lib_libopenvswitch_la_SOURCES = \
> > lib/dpif-netdev.c \ lib/dpif-netdev.h \
> > lib/dpif-netdev-private-dfc.c \
> > +lib/dpif-netdev-extract-study.c \
> Headers should be added alphabetically.
>
Fixed in v5.
> >
> -Original Message-
> From: Stokes, Ian
> Sent: Thursday, June 24, 2021 2:20 PM
> To: Amber, Kumar ; d...@openvswitch.org; Van
> Haaren, Harry
> Cc: Amber, Kumar ; i.maxim...@ovn.org
> Subject: RE: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to sele
> The study function runs all the available implementations
> of miniflow_extract and makes a choice whose hitmask has
> maximum hits and sets the mfex to that function.
Hi Amber/Harry,
Thanks for the patch, a few comments inline below.
>
> Study can be run at runtime using the following
The study function runs all the available implementations
of miniflow_extract and makes a choice whose hitmask has
maximum hits and sets the mfex to that function.
Study can be run at runtime using the following command:
$ ovs-appctl dpif-netdev/miniflow-parser-set study
Signed-off-by: Kumar
17 matches
Mail list logo
