Hi Eelco,
Thanks for reviews good find I missed it will be fixed in v7.
< Snip>
>
> >>> + * for that packet.
> >>> + */
> >>> +uint32_t mfex_hit = (mf_mask & (1 << i));
> >>
> >> This was supposed to become a bool?
> >>
> >
> > This cannot be a bool as this is used like
On 7 Jul 2021, at 6:34, Amber, Kumar wrote:
> Hi Eelco,
>
> MFEX v7 will be available shorty EOD today.
> Some comments are inline.
Thanks, looks like one item is still not clear, and I think why (see below).
>
>>> + * for that packet.
>>> + */
>>> +uint32_t mfex_hit
On 7 Jul 2021, at 9:21, Amber, Kumar wrote:
> Hi Eelco
>
> Pls find my comments inline.
>
See comments inline...
>>>
>>>
>>>
> +return;
> +}
Argument handling is not as it should be, see my previous comment. I
think the packets count should only be a
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 7, 2021 7:45 AM
> To: Van Haaren, Harry
> Cc: Ferriter, Cian ; ovs-dev@openvswitch.org;
> f...@sysclose.org; i.maxim...@ovn.org; Amber, Kumar ;
> Stokes, Ian
> Subject: Re: [v5 01/11] dpif-netdev: Add command line and fu
Hi Eelco
Pls find my comments inline.
> >> See comments inline...
> >
> >
> >
> >>> +return;
> >>> +}
> >>
> >>
> >> Argument handling is not as it should be, see my previous comment. I
> >> think the packets count should only be available for the study option
> >> (this might not b
On 6 Jul 2021, at 17:32, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Tuesday, July 6, 2021 3:19 PM
>> To: Ferriter, Cian
>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
>> Haaren,
>> Harry ; Amber, Kumar ;
>> Stokes, Ian
Hi Eelco,
MFEX v7 will be available shorty EOD today.
Some comments are inline.
> > + * for that packet.
> > + */
> > +uint32_t mfex_hit = (mf_mask & (1 << i));
>
> This was supposed to become a bool?
>
This cannot be a bool as this is used like a bit-mask and set bit
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 6, 2021 3:19 PM
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren,
> Harry ; Amber, Kumar ;
> Stokes, Ian
> Subject: Re: [v5 01/11] dpif-netdev: Add command line and f
See comments inline...
On 2 Jul 2021, at 14:56, Cian Ferriter wrote:
> From: Kumar Amber
>
> This patch introduces the mfex function pointers which allows
> the user to switch between different miniflow extract implementations
> which are provided by the OVS based on optimized ISA CPU.
>
> The u
Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless (lib/dpif-netdev.c).
error: could not build fake anc
From: Kumar Amber
This patch introduces the mfex function pointers which allows
the user to switch between different miniflow extract implementations
which are provided by the OVS based on optimized ISA CPU.
The user can query for the available minflow extract variants available
for that CPU by
Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless (lib/dpif-netdev.c).
error: could not build fake ances
Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless (lib/dpif-netdev.c).
error: could not build fake ances
This patch introduces the mfex function pointers which allows
the user to switch between different miniflow extract implementations
which are provided by the OVS based on optimized ISA CPU.
The user can query for the available minflow extract variants available
for that CPU by following commands:
This patch introduces the mfex function pointers which allows
the user to switch between different miniflow extract implementations
which are provided by the OVS based on optimized ISA CPU.
The user can query for the available minflow extract variants available
for that CPU by following commands:
This patch introduces the mfex function pointers which allows
the user to switch between different miniflow extract implementations
which are provided by the OVS based on optimized ISA CPU.
The user can query for the available minflow extract variants available
for that CPU by following commands:
16 matches
Mail list logo
